Jenkins build is back to normal : Knox-master-patch-scan #80558

[Apache Jenkins Server]

See 

[jira] [Commented] (KNOX-1160) Bug fixes to make spark history UI work

[Marco Gaido (JIRA)]

[ 
https://issues.apache.org/jira/browse/KNOX-1160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509391#comment-16509391
 ] 

Marco Gaido commented on KNOX-1160:
---

Thanks for your answer [~weihan]. Yes, sure. Let's say you are accessing SHS 
through Knox proxy and the URL you are using is 
{{https://knoxgateway:8443/gateway/default/sparkhistory/}}. I this case you 
have to add in your env variable {{SPARK_HISTORY_OPTS}} the value 
{{-Dspark.ui.proxyBase=/gateway/default/sparkhistory}}. So, you have to add 
something like {{export SPARK_HISTORY_OPTS="$SPARK_HISTORY_OPTS 
-Dspark.ui.proxyBase=/gateway/default/sparkhistory" in your spark-env. Please, 
as I am pretty sure by your patch that you are using a Spark version affected 
by SPARK-23644, do always put the end "/" at the URL when accessing it.

As a side note, with this patch there may also be problems when accessing the 
individual applications UIs, as they are all based on the value of 
{{spark.ui.proxyBase}} and I saw no rewrite rule for those other paths. Maybe 
it is not needed anything more, but it should be checked very carefully, as we 
may have broken other links there.

[~weihan] [~lmccay] [~smore] if we all agree, I'd propose to revert this as of 
now for the many problems described. After that, if [~weihan] is interested in 
this work, maybe he can propose a new patch using versioning which introduces 
the rewrite rules only for versions <= 2.3.0, after fixing the issue introduced 
(like the logs link broken and checking also all the possible tabs in the 
single application UIs). Let me know what you think about this. Thanks.

> Bug fixes to make spark history UI work
> ---
>
> Key: KNOX-1160
> URL: https://issues.apache.org/jira/browse/KNOX-1160
> Project: Apache Knox
>  Issue Type: Bug
>Reporter: Wei Han
>Priority: Minor
> Fix For: 1.1.0
>
> Attachments: sparkhistoryui.patch
>
>
> During my test of the spark history UI I found a couple of issues. The 
> attached patch fixes all of the issues I have seen



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Build failed in Jenkins: Knox-master-patch-scan #80557

[Apache Jenkins Server]

See 


--
Started by timer
[EnvInject] - Loading node environment variables.
Building remotely on H16 (Hadoop xenial) in workspace 

 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url https://github.com/apache/knox.git # timeout=10
Fetching upstream changes from https://github.com/apache/knox.git
 > git --version # timeout=10
 > git fetch --tags --progress https://github.com/apache/knox.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/master^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/origin/master^{commit} # timeout=10
Checking out Revision db50800726efc6005f1eaea5547d3a9e8bdf514c 
(refs/remotes/origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f db50800726efc6005f1eaea5547d3a9e8bdf514c
Commit message: "KNOX-1352 - Service Discovery is not honoring the enabled 
attribute of HA Provider configuration"
 > git rev-list --no-walk db50800726efc6005f1eaea5547d3a9e8bdf514c # timeout=10
[Knox-master-patch-scan] $ /bin/bash /tmp/jenkins8773729544801937808.sh
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0  
0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0100 
736560 736560 0  65579  0 --:--:--  0:00:01 --:--:-- 65588
curl: (56) GnuTLS recv error (-110): The TLS connection was non-properly 
terminated.
Could not retrieve available patches from JIRA
Build step 'Execute shell' marked build as failure

[jira] [Updated] (KNOX-1354) Revert KNOX-1160 in favor of using spark.ui.proxyBase to solve spark UI issues

[Wei Han (JIRA)]

 [ 
https://issues.apache.org/jira/browse/KNOX-1354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Wei Han updated KNOX-1354:
--
Attachment: revert.patch

> Revert KNOX-1160 in favor of using spark.ui.proxyBase to solve spark UI issues
> --
>
> Key: KNOX-1354
> URL: https://issues.apache.org/jira/browse/KNOX-1354
> Project: Apache Knox
>  Issue Type: Bug
>Affects Versions: 1.1.0
>Reporter: Wei Han
>Priority: Minor
> Attachments: revert.patch
>
>
> As discussed in https://issues.apache.org/jira/browse/KNOX-1160, the original 
> fix is not the right way to fix the UI issues, rather we should use 
> spark.ui.proxyBase. So opening an new issue to revert 
> https://issues.apache.org/jira/browse/KNOX-1160.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (KNOX-1354) Revert KNOX-1160 in favor of using spark.ui.proxyBase to solve spark UI issues

[Wei Han (JIRA)]

Wei Han created KNOX-1354:
-

 Summary: Revert KNOX-1160 in favor of using spark.ui.proxyBase to 
solve spark UI issues
 Key: KNOX-1354
 URL: https://issues.apache.org/jira/browse/KNOX-1354
 Project: Apache Knox
  Issue Type: Bug
Affects Versions: 1.1.0
Reporter: Wei Han


As discussed in https://issues.apache.org/jira/browse/KNOX-1160, the original 
fix is not the right way to fix the UI issues, rather we should use 
spark.ui.proxyBase. So opening an new issue to revert 
https://issues.apache.org/jira/browse/KNOX-1160.

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KNOX-1354) Revert KNOX-1160 in favor of using spark.ui.proxyBase to solve spark UI issues

[Wei Han (JIRA)]

[ 
https://issues.apache.org/jira/browse/KNOX-1354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509740#comment-16509740
 ] 

Wei Han commented on KNOX-1354:
---

[~mgaido] This is the issue to revert KNOX-1160, could you review it? If you 
can test the patch on your env, that'll be even better.

cc [~smore]

> Revert KNOX-1160 in favor of using spark.ui.proxyBase to solve spark UI issues
> --
>
> Key: KNOX-1354
> URL: https://issues.apache.org/jira/browse/KNOX-1354
> Project: Apache Knox
>  Issue Type: Bug
>Affects Versions: 1.1.0
>Reporter: Wei Han
>Priority: Minor
> Attachments: revert.patch
>
>
> As discussed in https://issues.apache.org/jira/browse/KNOX-1160, the original 
> fix is not the right way to fix the UI issues, rather we should use 
> spark.ui.proxyBase. So opening an new issue to revert 
> https://issues.apache.org/jira/browse/KNOX-1160.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (KNOX-1354) Revert KNOX-1160 in favor of using spark.ui.proxyBase to solve spark UI issues

[Wei Han (JIRA)]

 [ 
https://issues.apache.org/jira/browse/KNOX-1354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Wei Han updated KNOX-1354:
--
Description: 
As discussed in KNOX-1160, the original fix is not the right way to fix the UI 
issues, rather we should use spark.ui.proxyBase. So opening an new issue to 
revert KNOX-1160.

 

  was:
As discussed in https://issues.apache.org/jira/browse/KNOX-1160, the original 
fix is not the right way to fix the UI issues, rather we should use 
spark.ui.proxyBase. So opening an new issue to revert 
https://issues.apache.org/jira/browse/KNOX-1160.

 


> Revert KNOX-1160 in favor of using spark.ui.proxyBase to solve spark UI issues
> --
>
> Key: KNOX-1354
> URL: https://issues.apache.org/jira/browse/KNOX-1354
> Project: Apache Knox
>  Issue Type: Bug
>Affects Versions: 1.1.0
>Reporter: Wei Han
>Priority: Minor
> Attachments: revert.patch
>
>
> As discussed in KNOX-1160, the original fix is not the right way to fix the 
> UI issues, rather we should use spark.ui.proxyBase. So opening an new issue 
> to revert KNOX-1160.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (KNOX-1160) Bug fixes to make spark history UI work

[Sandeep More (JIRA)]

[ 
https://issues.apache.org/jira/browse/KNOX-1160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509605#comment-16509605
 ] 

Sandeep More commented on KNOX-1160:


Thanks [~weihan] and [~mgaido] for the inputs !
I think it would be safe to revert the patch, but I would let both of you 
decide on how to go about it. 
Let me know what you decide either reverting or handling this with a new patch. 

Thanks again !

> Bug fixes to make spark history UI work
> ---
>
> Key: KNOX-1160
> URL: https://issues.apache.org/jira/browse/KNOX-1160
> Project: Apache Knox
>  Issue Type: Bug
>Reporter: Wei Han
>Priority: Minor
> Fix For: 1.1.0
>
> Attachments: sparkhistoryui.patch
>
>
> During my test of the spark history UI I found a couple of issues. The 
> attached patch fixes all of the issues I have seen



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)