Re: Review Request 39221: LENS-533 : Update critical metrics on monitoring doc

2015-10-12 Thread Rajat Khandelwal 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39221/#review102216
---

Ship it!


Ship It!

- Rajat Khandelwal


On Oct. 12, 2015, 12:21 p.m., Amareshwari Sriramadasu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39221/
> ---
> 
> (Updated Oct. 12, 2015, 12:21 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-533
> https://issues.apache.org/jira/browse/LENS-533
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Added critical metrics section
> 
> 
> Diffs
> -
> 
>   src/site/apt/admin/monitoring.apt 9429394 
> 
> Diff: https://reviews.apache.org/r/39221/diff/
> 
> 
> Testing
> ---
> 
> Verified by running mvn site:run
> 
> 
> Thanks,
> 
> Amareshwari Sriramadasu
> 
>

Re: Review Request 38521: LENS-607: Fix Test failures in java8

2015-10-12 Thread Raju Bairishetti 


> On Oct. 12, 2015, 6:31 a.m., Rajat Khandelwal wrote:
> > lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java, lines 
> > 210-213
> > 
> >
> > let's also implement `toString` function.

Implemented toString() already :). I can improve toString() method if required.


- Raju


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38521/#review102213
---


On Oct. 11, 2015, 5:31 a.m., Raju Bairishetti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38521/
> ---
> 
> (Updated Oct. 11, 2015, 5:31 a.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
> 
> 
> Bugs: LENS-607
> https://issues.apache.org/jira/browse/LENS-607
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Iterators in java7 and java8 are returning elements in different order. All 
> most all failures are because of this case.
> 
> Changes:
> TestBaseCubeQueries: Changed driver supported storages to single storage 
> instead of multiple
> TestCubeRewriter: Returning diffrent orders in the joins. Separated join part 
> from the actaul query part and verified join part and remaining query part 
> separately.
> TestStorageUtil: Multiple sets can answer the given partitions. Changed 
> asserts accordingly.
> TestTimeRangeResolver: Changed asserts to cover all the errors.
> 
> *ColumnSQLRewriter* : Changed all data structures to *Linked* datastructures 
> (Arraylist --> LinkedList, HashSet to LinkedHashSet, HashMap to 
> LinkedHashMap) to return the elements in insertion order.
> 
> TestColumnSQLRewriter: Changed the order of columns in queries.
> 
> 
> Diffs
> -
> 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 
> 39441c9 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 
> 0f76c76 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
> a58f5fe 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java
>  bde4edd 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java
>  493b8d6 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java 
> PRE-CREATION 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestStorageUtil.java 
> 81f515b 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java 
> cb27d50 
>   
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java
>  295b476 
>   
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java
>  db09a4b 
> 
> Diff: https://reviews.apache.org/r/38521/diff/
> 
> 
> Testing
> ---
> 
> Tested on both java7 and java8. Build is successful. Will post the build 
> artifact summary soon.
> 
> c1mng0pxdty3:lens raju.bairishetti$ java -version
> **java version "1.8.0_40"**
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules .. SUCCESS [  4.849 
> s]
> [INFO] Lens ... SUCCESS [  5.806 
> s]
> [INFO] Lens API ... SUCCESS [ 31.562 
> s]
> [INFO] Lens API for server and extensions . SUCCESS [ 23.200 
> s]
> [INFO] Lens Cube .. SUCCESS [06:19 
> min]
> [INFO] Lens DB storage  SUCCESS [ 23.015 
> s]
> [INFO] Lens Query Library . SUCCESS [ 18.249 
> s]
> [INFO] Lens Hive Driver ... SUCCESS [03:11 
> min]
> [INFO] Lens Driver for JDBC ... SUCCESS [ 41.094 
> s]
> [INFO] Lens Elastic Search Driver . SUCCESS [ 26.188 
> s]
> [INFO] Lens Server  SUCCESS [12:38 
> min]
> [INFO] Lens client  SUCCESS [ 44.951 
> s]
> [INFO] Lens CLI ... SUCCESS [04:57 
> min]
> [INFO] Lens Examples .. SUCCESS [ 11.491 
> s]
> [INFO] Lens Distribution .. SUCCESS [ 19.483 
> s]
> [INFO] Lens ML Lib  SUCCESS [02:35 
> min]
> [INFO] Lens ML Ext Distribution ... SUCCESS [  7.919 
> s]
> [INFO] Lens Regression  SUCCESS [ 11.523 
> s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
>

Re: Review Request 38521: LENS-607: Fix Test failures in java8

2015-10-12 Thread Raju Bairishetti 


> On Oct. 9, 2015, 8:38 a.m., Rajat Khandelwal wrote:
> > lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java,
> >  lines 180-181
> > 
> >
> > This can be avoided if `columnNotFound` is storing arguments in a set 
> > instead of a list. Small change there can avoid big changes here.
> 
> Raju Bairishetti wrote:
> It requries changes in multiple source files. Can we fix it in the follow 
> up jira?
> 
> Getting the columns from JoinChain class. It is currently using hashset. 
> We should use other collection(like arraylist) instead of hashset for getting 
> the elements in the insertion order. 
> ```
> public Set getSourceColumns() {
> Set srcFields = new HashSet();
> ```
> this is called from multiple files.

Created [LENS-812](https://issues.apache.org/jira/browse/LENS-812) for fixing 
this.


- Raju


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38521/#review102029
---


On Oct. 12, 2015, 8:06 a.m., Raju Bairishetti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38521/
> ---
> 
> (Updated Oct. 12, 2015, 8:06 a.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
> 
> 
> Bugs: LENS-607
> https://issues.apache.org/jira/browse/LENS-607
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Iterators in java7 and java8 are returning elements in different order. All 
> most all failures are because of this case.
> 
> Changes:
> TestBaseCubeQueries: Changed driver supported storages to single storage 
> instead of multiple
> TestCubeRewriter: Returning diffrent orders in the joins. Separated join part 
> from the actaul query part and verified join part and remaining query part 
> separately.
> TestStorageUtil: Multiple sets can answer the given partitions. Changed 
> asserts accordingly.
> TestTimeRangeResolver: Changed asserts to cover all the errors.
> 
> *ColumnSQLRewriter* : Changed all data structures to *Linked* datastructures 
> (Arraylist --> LinkedList, HashSet to LinkedHashSet, HashMap to 
> LinkedHashMap) to return the elements in insertion order.
> 
> TestColumnSQLRewriter: Changed the order of columns in queries.
> 
> 
> Diffs
> -
> 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 
> 39441c9 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 
> 0f76c76 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
> a58f5fe 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java
>  bde4edd 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java
>  493b8d6 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java 
> PRE-CREATION 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestStorageUtil.java 
> 81f515b 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java 
> cb27d50 
>   
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java
>  295b476 
>   
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java
>  db09a4b 
> 
> Diff: https://reviews.apache.org/r/38521/diff/
> 
> 
> Testing
> ---
> 
> Tested on both java7 and java8. Build is successful. Will post the build 
> artifact summary soon.
> 
> c1mng0pxdty3:lens raju.bairishetti$ java -version
> **java version "1.8.0_40"**
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules .. SUCCESS [  4.849 
> s]
> [INFO] Lens ... SUCCESS [  5.806 
> s]
> [INFO] Lens API ... SUCCESS [ 31.562 
> s]
> [INFO] Lens API for server and extensions . SUCCESS [ 23.200 
> s]
> [INFO] Lens Cube .. SUCCESS [06:19 
> min]
> [INFO] Lens DB storage  SUCCESS [ 23.015 
> s]
> [INFO] Lens Query Library . SUCCESS [ 18.249 
> s]
> [INFO] Lens Hive Driver ... SUCCESS [03:11 
> min]
> [INFO] Lens Driver for JDBC ... SUCCESS [ 41.094 
> s]
> [INFO] Lens Elastic Search Driver . SUCCESS [ 26.188 
> s]
> [INFO] Lens Server  SUCCESS [12:38 
> min]
> [INFO] Lens client  SUCCESS [ 44.951 
> s]
> [INFO] Lens CLI

Re: Review Request 39191: LENS-615 Refactoring of testQueryCommands test case

2015-10-12 Thread Raju Bairishetti 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39191/#review102212
---



lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java (line 45)


Why this import is moved below to "import lombok.extern.slf4j.Slf4j;". 
Seems it will throw a checkstyle error.


- Raju Bairishetti


On Oct. 9, 2015, 10:14 p.m., Gabor Liptak wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39191/
> ---
> 
> (Updated Oct. 9, 2015, 10:14 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-615
> https://issues.apache.org/jira/browse/LENS-615
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> LENS-615 Refactoring of testQueryCommands test case
> 
> 
> Diffs
> -
> 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 
> 308c036d5e3c52c6892b347d9600cd2d2c7f7fd7 
> 
> Diff: https://reviews.apache.org/r/39191/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gabor Liptak
> 
>

Review Request 39221: LENS-533 : Update critical metrics on monitoring doc

2015-10-12 Thread Amareshwari Sriramadasu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39221/
---

Review request for lens.


Bugs: LENS-533
https://issues.apache.org/jira/browse/LENS-533


Repository: lens


Description
---

Added critical metrics section


Diffs
-

  src/site/apt/admin/monitoring.apt 9429394 

Diff: https://reviews.apache.org/r/39221/diff/


Testing
---

Verified by running mvn site:run


Thanks,

Amareshwari Sriramadasu

[jira] [Created] (LENS-811) Altering of conceptual/logical tables should update removing of properties

2015-10-12 Thread Amareshwari Sriramadasu (JIRA) 
Amareshwari Sriramadasu created LENS-811:


 Summary: Altering of conceptual/logical tables should update 
removing of properties
 Key: LENS-811
 URL: https://issues.apache.org/jira/browse/LENS-811
 Project: Apache Lens
  Issue Type: Bug
  Components: cube
Reporter: Amareshwari Sriramadasu
 Fix For: 2.5


Right now, altering of conceptual tables (cubes/dimensions), logical tables 
(facts/dimtables) is not reflecting wrt removals.

For ex: if description or display string is removed for a field - its not 
reflecting the same. A property that is removed is not getting reflected.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 38521: LENS-607: Fix Test failures in java8

2015-10-12 Thread Rajat Khandelwal 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38521/#review102213
---



lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java (line 80)


end index redundant.



lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java (line 200)


let's not `fail()` inside `equals`. `equals` is supposed to return 
`true/false` without throwing exceptions. 

You can make another method `assertEquals` inside `TestQuery` which can 
`fail()` or pass through without any return value.



lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java (lines 205 - 
208)


let's also implement `toString` function.



lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java
 (lines 94 - 110)


Can we use `TestQuery` here?


- Rajat Khandelwal


On Oct. 11, 2015, 11:01 a.m., Raju Bairishetti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38521/
> ---
> 
> (Updated Oct. 11, 2015, 11:01 a.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
> 
> 
> Bugs: LENS-607
> https://issues.apache.org/jira/browse/LENS-607
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Iterators in java7 and java8 are returning elements in different order. All 
> most all failures are because of this case.
> 
> Changes:
> TestBaseCubeQueries: Changed driver supported storages to single storage 
> instead of multiple
> TestCubeRewriter: Returning diffrent orders in the joins. Separated join part 
> from the actaul query part and verified join part and remaining query part 
> separately.
> TestStorageUtil: Multiple sets can answer the given partitions. Changed 
> asserts accordingly.
> TestTimeRangeResolver: Changed asserts to cover all the errors.
> 
> *ColumnSQLRewriter* : Changed all data structures to *Linked* datastructures 
> (Arraylist --> LinkedList, HashSet to LinkedHashSet, HashMap to 
> LinkedHashMap) to return the elements in insertion order.
> 
> TestColumnSQLRewriter: Changed the order of columns in queries.
> 
> 
> Diffs
> -
> 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 
> 39441c9 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 
> 0f76c76 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
> a58f5fe 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java
>  bde4edd 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java
>  493b8d6 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java 
> PRE-CREATION 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestStorageUtil.java 
> 81f515b 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java 
> cb27d50 
>   
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java
>  295b476 
>   
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java
>  db09a4b 
> 
> Diff: https://reviews.apache.org/r/38521/diff/
> 
> 
> Testing
> ---
> 
> Tested on both java7 and java8. Build is successful. Will post the build 
> artifact summary soon.
> 
> c1mng0pxdty3:lens raju.bairishetti$ java -version
> **java version "1.8.0_40"**
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules .. SUCCESS [  4.849 
> s]
> [INFO] Lens ... SUCCESS [  5.806 
> s]
> [INFO] Lens API ... SUCCESS [ 31.562 
> s]
> [INFO] Lens API for server and extensions . SUCCESS [ 23.200 
> s]
> [INFO] Lens Cube .. SUCCESS [06:19 
> min]
> [INFO] Lens DB storage  SUCCESS [ 23.015 
> s]
> [INFO] Lens Query Library . SUCCESS [ 18.249 
> s]
> [INFO] Lens Hive Driver ... SUCCESS [03:11 
> min]
> [INFO] Lens Driver for JDBC ... SUCCESS [ 41.094 
> s]
> [INFO] Lens Elastic Search Driver . SUCCESS [ 26.188 
> s]
> [INFO] Lens Server  SUCCESS [12:38 
> min]
> [INFO] Lens client  SUCCESS [ 44.951 
> s]
> [INFO] Lens CLI

Re: Review Request 38521: LENS-607: Fix Test failures in java8

2015-10-12 Thread Raju Bairishetti 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38521/
---

(Updated Oct. 12, 2015, 8:06 a.m.)


Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.


Changes
---

Fixed review comments and change the compareMethods method invocations in some 
places to make it more intutive.


Bugs: LENS-607
https://issues.apache.org/jira/browse/LENS-607


Repository: lens


Description
---

Iterators in java7 and java8 are returning elements in different order. All 
most all failures are because of this case.

Changes:
TestBaseCubeQueries: Changed driver supported storages to single storage 
instead of multiple
TestCubeRewriter: Returning diffrent orders in the joins. Separated join part 
from the actaul query part and verified join part and remaining query part 
separately.
TestStorageUtil: Multiple sets can answer the given partitions. Changed asserts 
accordingly.
TestTimeRangeResolver: Changed asserts to cover all the errors.

*ColumnSQLRewriter* : Changed all data structures to *Linked* datastructures 
(Arraylist --> LinkedList, HashSet to LinkedHashSet, HashMap to LinkedHashMap) 
to return the elements in insertion order.

TestColumnSQLRewriter: Changed the order of columns in queries.


Diffs (updated)
-

  lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 39441c9 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 
0f76c76 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
a58f5fe 
  
lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java
 bde4edd 
  
lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java 
493b8d6 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java 
PRE-CREATION 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestStorageUtil.java 
81f515b 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java 
cb27d50 
  
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java
 295b476 
  
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java
 db09a4b 

Diff: https://reviews.apache.org/r/38521/diff/


Testing
---

Tested on both java7 and java8. Build is successful. Will post the build 
artifact summary soon.

c1mng0pxdty3:lens raju.bairishetti$ java -version
**java version "1.8.0_40"**

[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules .. SUCCESS [  4.849 s]
[INFO] Lens ... SUCCESS [  5.806 s]
[INFO] Lens API ... SUCCESS [ 31.562 s]
[INFO] Lens API for server and extensions . SUCCESS [ 23.200 s]
[INFO] Lens Cube .. SUCCESS [06:19 min]
[INFO] Lens DB storage  SUCCESS [ 23.015 s]
[INFO] Lens Query Library . SUCCESS [ 18.249 s]
[INFO] Lens Hive Driver ... SUCCESS [03:11 min]
[INFO] Lens Driver for JDBC ... SUCCESS [ 41.094 s]
[INFO] Lens Elastic Search Driver . SUCCESS [ 26.188 s]
[INFO] Lens Server  SUCCESS [12:38 min]
[INFO] Lens client  SUCCESS [ 44.951 s]
[INFO] Lens CLI ... SUCCESS [04:57 min]
[INFO] Lens Examples .. SUCCESS [ 11.491 s]
[INFO] Lens Distribution .. SUCCESS [ 19.483 s]
[INFO] Lens ML Lib  SUCCESS [02:35 min]
[INFO] Lens ML Ext Distribution ... SUCCESS [  7.919 s]
[INFO] Lens Regression  SUCCESS [ 11.523 s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 34:13 min
[INFO] Finished at: 2015-09-19T12:13:27+05:30
[INFO] Final Memory: 158M/1483M
[INFO] 


JDK-7:  **sun-jdk-1.7.0_55**

regression-2.4.0-beta-SNAPSHOT-tests.jar
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules . SUCCESS [1.999s]
[INFO] Lens .. SUCCESS [2.816s]
[INFO] Lens API .. SUCCESS [23.685s]
[INFO] Lens API for server and extensions  SUCCESS [20.093s]
[INFO] Lens Cube

Re: Review Request 38521: LENS-607: Fix Test failures in java8

2015-10-12 Thread Raju Bairishetti 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38521/
---

(Updated Oct. 12, 2015, 8:23 a.m.)


Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.


Bugs: LENS-607
https://issues.apache.org/jira/browse/LENS-607


Repository: lens


Description
---

Iterators in java7 and java8 are returning elements in different order. All 
most all failures are because of this case.

Changes:
TestBaseCubeQueries: Changed driver supported storages to single storage 
instead of multiple
TestCubeRewriter: Returning diffrent orders in the joins. Separated join part 
from the actaul query part and verified join part and remaining query part 
separately.
TestStorageUtil: Multiple sets can answer the given partitions. Changed asserts 
accordingly.
TestTimeRangeResolver: Changed asserts to cover all the errors.

*ColumnSQLRewriter* : Changed all data structures to *Linked* datastructures 
(Arraylist --> LinkedList, HashSet to LinkedHashSet, HashMap to LinkedHashMap) 
to return the elements in insertion order.

TestColumnSQLRewriter: Changed the order of columns in queries.


Diffs (updated)
-

  lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 39441c9 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 
0f76c76 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
a58f5fe 
  
lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java
 bde4edd 
  
lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java 
493b8d6 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java 
PRE-CREATION 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestStorageUtil.java 
81f515b 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java 
cb27d50 
  
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java
 295b476 
  
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java
 db09a4b 

Diff: https://reviews.apache.org/r/38521/diff/


Testing
---

Tested on both java7 and java8. Build is successful. Will post the build 
artifact summary soon.

c1mng0pxdty3:lens raju.bairishetti$ java -version
**java version "1.8.0_40"**

[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules .. SUCCESS [  4.849 s]
[INFO] Lens ... SUCCESS [  5.806 s]
[INFO] Lens API ... SUCCESS [ 31.562 s]
[INFO] Lens API for server and extensions . SUCCESS [ 23.200 s]
[INFO] Lens Cube .. SUCCESS [06:19 min]
[INFO] Lens DB storage  SUCCESS [ 23.015 s]
[INFO] Lens Query Library . SUCCESS [ 18.249 s]
[INFO] Lens Hive Driver ... SUCCESS [03:11 min]
[INFO] Lens Driver for JDBC ... SUCCESS [ 41.094 s]
[INFO] Lens Elastic Search Driver . SUCCESS [ 26.188 s]
[INFO] Lens Server  SUCCESS [12:38 min]
[INFO] Lens client  SUCCESS [ 44.951 s]
[INFO] Lens CLI ... SUCCESS [04:57 min]
[INFO] Lens Examples .. SUCCESS [ 11.491 s]
[INFO] Lens Distribution .. SUCCESS [ 19.483 s]
[INFO] Lens ML Lib  SUCCESS [02:35 min]
[INFO] Lens ML Ext Distribution ... SUCCESS [  7.919 s]
[INFO] Lens Regression  SUCCESS [ 11.523 s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 34:13 min
[INFO] Finished at: 2015-09-19T12:13:27+05:30
[INFO] Final Memory: 158M/1483M
[INFO] 


JDK-7:  **sun-jdk-1.7.0_55**

regression-2.4.0-beta-SNAPSHOT-tests.jar
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules . SUCCESS [1.999s]
[INFO] Lens .. SUCCESS [2.816s]
[INFO] Lens API .. SUCCESS [23.685s]
[INFO] Lens API for server and extensions  SUCCESS [20.093s]
[INFO] Lens Cube . SUCCESS [5:02.073s]
[INFO] Lens DB storage ... SUCCESS [19.937s]
[INFO] Lens

[jira] [Commented] (LENS-533) Critical metrics for lens

2015-10-12 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/LENS-533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14952850#comment-14952850
 ] 

Hudson commented on LENS-533:
-

SUCCESS: Integrated in Lens-Commit #1106 (See 
[https://builds.apache.org/job/Lens-Commit/1106/])
LENS-533: Update critical metrics on monitoring doc (raju: rev 
a6d6294d859caab5c35a604715637123f724dbe1)
* src/site/apt/admin/monitoring.apt


> Critical metrics for lens
> -
>
> Key: LENS-533
> URL: https://issues.apache.org/jira/browse/LENS-533
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: docs, server
>Reporter: Biswajit Nayak
>Assignee: Amareshwari Sriramadasu
> Fix For: 2.4
>
> Attachments: LENS-533.patch
>
>
> There are around 800 metrics for lens that being emitted. I am little 
> confused which all to use in critical situation. 
> Below is the list of metrics:- 
> lens.gauges.memory.pools.PS-Perm-Gen.usage.value
> lens.gauges.org.apache.lens.server.api.query.QueryExecutionService.running-queries.value
> lens.gauges.memory.non-heap.used.value
> lens.gauges.jvm.uptime.value
> lens.gauges.jvm.name.value
> lens.gauges.memory.non-heap.max.value
> lens.gauges.gc.PS-Scavenge.count.value
> lens.gauges.gc.PS-MarkSweep.count.value
> lens.gauges.memory.non-heap.init.value
> lens.gauges.jvm.vendor.value
> lens.gauges.memory.heap.used.value
> lens.gauges.threads.waiting.count.value
> lens.gauges.memory.total.max.value
> lens.gauges.memory.total.committed.value
> lens.gauges.gc.PS-Scavenge.time.value
> lens.gauges.memory.non-heap.committed.value
> lens.gauges.memory.total.used.value
> lens.gauges.threads.timed_waiting.count.value
> lens.gauges.memory.total.init.value
> lens.gauges.memory.pools.PS-Survivor-Space.usage.value
> lens.gauges.org.apache.lens.server.api.query.QueryExecutionService.queued-queries.value
> lens.gauges.threads.new.count.value
> lens.gauges.threads.blocked.count.value
> lens.gauges.memory.pools.PS-Eden-Space.usage.value
> lens.gauges.org.apache.lens.server.api.query.QueryExecutionService.finished-queries.value
> lens.gauges.memory.pools.PS-Old-Gen.usage.value
> lens.gauges.threads.terminated.count.value
> lens.gauges.memory.heap.init.value
> lens.gauges.memory.heap.max.value
> lens.gauges.memory.non-heap.usage.value
> lens.gauges.memory.heap.committed.value
> lens.gauges.threads.runnable.count.value
> lens.gauges.memory.pools.Code-Cache.usage.value
> lens.gauges.threads.deadlocks.value
> lens.gauges.threads.count.value
> lens.gauges.gc.PS-MarkSweep.time.value
> lens.gauges.threads.daemon.count.value
> lens.meters.org.apache.lens.server.metastore.MetastoreResource.getAllDimensionNames.GET.meter.m5_rate
> lens.meters.org.apache.lens.server.metastore.MetastoreResource.getAllDimensionNames.GET.meter.count
> lens.meters.org.apache.lens.server.metastore.MetastoreResource.getAllDimensionNames.GET.meter.m1_rate
> lens.meters.org.apache.lens.server.metastore.MetastoreResource.getAllDimensionNames.GET.meter.m15_rate
> lens.meters.org.apache.lens.server.metastore.MetastoreResource.getAllDimensionNames.GET.meter.mean_rate
> lens.meters.org.apache.lens.server.metastore.MetastoreResource.getAllDimensionNames.GET.meter.units
> lens.meters.org.apache.lens.server.query.QueryServiceResource.getStatus.GET.meter.m5_rate
> lens.meters.org.apache.lens.server.query.QueryServiceResource.getStatus.GET.meter.count
> lens.meters.org.apache.lens.server.query.QueryServiceResource.getStatus.GET.meter.m1_rate
> lens.meters.org.apache.lens.server.query.QueryServiceResource.getStatus.GET.meter.m15_rate
> lens.meters.org.apache.lens.server.query.QueryServiceResource.getStatus.GET.meter.mean_rate
> lens.meters.org.apache.lens.server.query.QueryServiceResource.getStatus.GET.meter.units
> lens.meters.org.apache.lens.ser
> lens.meters.org.apache.lens.server.metastore.MetastoreResource.addPartitionsToFactStorage.POST.meter.count
> lens.meters.org.apache.lens.server.metastore.MetastoreResource.addPartitionsToFactStorage.POST.meter.m1_rate
> lens.meters.org.apache.lens.server.metastore.MetastoreResource.addPartitionsToFactStorage.POST.meter.m15_rate
> lens.meters.org.apache.lens.server.metastore.MetastoreResource.addPartitionsToFactStorage.POST.meter.mean_rate
> lens.meters.org.apache.lens.server.metastore.MetastoreResource.addPartitionsToFactStorage.POST.meter.units
> lens.meters.org.apache.lens.server.session.SessionResource.openSession.POST.meter.m5_rate
> lens.meters.org.apache.lens.server.session.SessionResource.openSession.POST.meter.count
> lens.meters.org.apache.lens.server.session.SessionResource.openSession.POST.meter.m1_rate
> lens
> lens.meters.org.apache.lens.server.session.SessionResource.openSession.POST.meter.mean_rate
> lens.meters.org.apache.lens.server.session.SessionResource.openSession.POST.meter.units
>

Re: Review Request 38521: LENS-607: Fix Test failures in java8

2015-10-12 Thread Rajat Khandelwal 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38521/#review102233
---

Ship it!


Ship It!

- Rajat Khandelwal


On Oct. 12, 2015, 1:53 p.m., Raju Bairishetti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38521/
> ---
> 
> (Updated Oct. 12, 2015, 1:53 p.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
> 
> 
> Bugs: LENS-607
> https://issues.apache.org/jira/browse/LENS-607
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Iterators in java7 and java8 are returning elements in different order. All 
> most all failures are because of this case.
> 
> Changes:
> TestBaseCubeQueries: Changed driver supported storages to single storage 
> instead of multiple
> TestCubeRewriter: Returning diffrent orders in the joins. Separated join part 
> from the actaul query part and verified join part and remaining query part 
> separately.
> TestStorageUtil: Multiple sets can answer the given partitions. Changed 
> asserts accordingly.
> TestTimeRangeResolver: Changed asserts to cover all the errors.
> 
> *ColumnSQLRewriter* : Changed all data structures to *Linked* datastructures 
> (Arraylist --> LinkedList, HashSet to LinkedHashSet, HashMap to 
> LinkedHashMap) to return the elements in insertion order.
> 
> TestColumnSQLRewriter: Changed the order of columns in queries.
> 
> 
> Diffs
> -
> 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 
> 39441c9 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 
> 0f76c76 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
> a58f5fe 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java
>  bde4edd 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java
>  493b8d6 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java 
> PRE-CREATION 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestStorageUtil.java 
> 81f515b 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java 
> cb27d50 
>   
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java
>  295b476 
>   
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java
>  db09a4b 
> 
> Diff: https://reviews.apache.org/r/38521/diff/
> 
> 
> Testing
> ---
> 
> Tested on both java7 and java8. Build is successful. Will post the build 
> artifact summary soon.
> 
> c1mng0pxdty3:lens raju.bairishetti$ java -version
> **java version "1.8.0_40"**
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules .. SUCCESS [  4.849 
> s]
> [INFO] Lens ... SUCCESS [  5.806 
> s]
> [INFO] Lens API ... SUCCESS [ 31.562 
> s]
> [INFO] Lens API for server and extensions . SUCCESS [ 23.200 
> s]
> [INFO] Lens Cube .. SUCCESS [06:19 
> min]
> [INFO] Lens DB storage  SUCCESS [ 23.015 
> s]
> [INFO] Lens Query Library . SUCCESS [ 18.249 
> s]
> [INFO] Lens Hive Driver ... SUCCESS [03:11 
> min]
> [INFO] Lens Driver for JDBC ... SUCCESS [ 41.094 
> s]
> [INFO] Lens Elastic Search Driver . SUCCESS [ 26.188 
> s]
> [INFO] Lens Server  SUCCESS [12:38 
> min]
> [INFO] Lens client  SUCCESS [ 44.951 
> s]
> [INFO] Lens CLI ... SUCCESS [04:57 
> min]
> [INFO] Lens Examples .. SUCCESS [ 11.491 
> s]
> [INFO] Lens Distribution .. SUCCESS [ 19.483 
> s]
> [INFO] Lens ML Lib  SUCCESS [02:35 
> min]
> [INFO] Lens ML Ext Distribution ... SUCCESS [  7.919 
> s]
> [INFO] Lens Regression  SUCCESS [ 11.523 
> s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 34:13 min
> [INFO] Finished at: 2015-09-19T12:13:27+05:30
> [INFO] Final Memory: 158M/1483M
> [INFO] 
> 
> 
> 
> JDK-7:  **sun-jdk-1.7.0_55**
> 
>

[jira] [Created] (LENS-814) Queued queries should be listed in order.

2015-10-12 Thread Rajat Khandelwal (JIRA) 
Rajat Khandelwal created LENS-814:
-

 Summary: Queued queries should be listed in order. 
 Key: LENS-814
 URL: https://issues.apache.org/jira/browse/LENS-814
 Project: Apache Lens
  Issue Type: Bug
Reporter: Rajat Khandelwal






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-533) Critical metrics for lens

2015-10-12 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/LENS-533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14952848#comment-14952848
 ] 

Hudson commented on LENS-533:
-

UNSTABLE: Integrated in Lens-Commit-Java8 #15 (See 
[https://builds.apache.org/job/Lens-Commit-Java8/15/])
LENS-533: Update critical metrics on monitoring doc (raju: rev 
a6d6294d859caab5c35a604715637123f724dbe1)
* src/site/apt/admin/monitoring.apt


> Critical metrics for lens
> -
>
> Key: LENS-533
> URL: https://issues.apache.org/jira/browse/LENS-533
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: docs, server
>Reporter: Biswajit Nayak
>Assignee: Amareshwari Sriramadasu
> Fix For: 2.4
>
> Attachments: LENS-533.patch
>
>
> There are around 800 metrics for lens that being emitted. I am little 
> confused which all to use in critical situation. 
> Below is the list of metrics:- 
> lens.gauges.memory.pools.PS-Perm-Gen.usage.value
> lens.gauges.org.apache.lens.server.api.query.QueryExecutionService.running-queries.value
> lens.gauges.memory.non-heap.used.value
> lens.gauges.jvm.uptime.value
> lens.gauges.jvm.name.value
> lens.gauges.memory.non-heap.max.value
> lens.gauges.gc.PS-Scavenge.count.value
> lens.gauges.gc.PS-MarkSweep.count.value
> lens.gauges.memory.non-heap.init.value
> lens.gauges.jvm.vendor.value
> lens.gauges.memory.heap.used.value
> lens.gauges.threads.waiting.count.value
> lens.gauges.memory.total.max.value
> lens.gauges.memory.total.committed.value
> lens.gauges.gc.PS-Scavenge.time.value
> lens.gauges.memory.non-heap.committed.value
> lens.gauges.memory.total.used.value
> lens.gauges.threads.timed_waiting.count.value
> lens.gauges.memory.total.init.value
> lens.gauges.memory.pools.PS-Survivor-Space.usage.value
> lens.gauges.org.apache.lens.server.api.query.QueryExecutionService.queued-queries.value
> lens.gauges.threads.new.count.value
> lens.gauges.threads.blocked.count.value
> lens.gauges.memory.pools.PS-Eden-Space.usage.value
> lens.gauges.org.apache.lens.server.api.query.QueryExecutionService.finished-queries.value
> lens.gauges.memory.pools.PS-Old-Gen.usage.value
> lens.gauges.threads.terminated.count.value
> lens.gauges.memory.heap.init.value
> lens.gauges.memory.heap.max.value
> lens.gauges.memory.non-heap.usage.value
> lens.gauges.memory.heap.committed.value
> lens.gauges.threads.runnable.count.value
> lens.gauges.memory.pools.Code-Cache.usage.value
> lens.gauges.threads.deadlocks.value
> lens.gauges.threads.count.value
> lens.gauges.gc.PS-MarkSweep.time.value
> lens.gauges.threads.daemon.count.value
> lens.meters.org.apache.lens.server.metastore.MetastoreResource.getAllDimensionNames.GET.meter.m5_rate
> lens.meters.org.apache.lens.server.metastore.MetastoreResource.getAllDimensionNames.GET.meter.count
> lens.meters.org.apache.lens.server.metastore.MetastoreResource.getAllDimensionNames.GET.meter.m1_rate
> lens.meters.org.apache.lens.server.metastore.MetastoreResource.getAllDimensionNames.GET.meter.m15_rate
> lens.meters.org.apache.lens.server.metastore.MetastoreResource.getAllDimensionNames.GET.meter.mean_rate
> lens.meters.org.apache.lens.server.metastore.MetastoreResource.getAllDimensionNames.GET.meter.units
> lens.meters.org.apache.lens.server.query.QueryServiceResource.getStatus.GET.meter.m5_rate
> lens.meters.org.apache.lens.server.query.QueryServiceResource.getStatus.GET.meter.count
> lens.meters.org.apache.lens.server.query.QueryServiceResource.getStatus.GET.meter.m1_rate
> lens.meters.org.apache.lens.server.query.QueryServiceResource.getStatus.GET.meter.m15_rate
> lens.meters.org.apache.lens.server.query.QueryServiceResource.getStatus.GET.meter.mean_rate
> lens.meters.org.apache.lens.server.query.QueryServiceResource.getStatus.GET.meter.units
> lens.meters.org.apache.lens.ser
> lens.meters.org.apache.lens.server.metastore.MetastoreResource.addPartitionsToFactStorage.POST.meter.count
> lens.meters.org.apache.lens.server.metastore.MetastoreResource.addPartitionsToFactStorage.POST.meter.m1_rate
> lens.meters.org.apache.lens.server.metastore.MetastoreResource.addPartitionsToFactStorage.POST.meter.m15_rate
> lens.meters.org.apache.lens.server.metastore.MetastoreResource.addPartitionsToFactStorage.POST.meter.mean_rate
> lens.meters.org.apache.lens.server.metastore.MetastoreResource.addPartitionsToFactStorage.POST.meter.units
> lens.meters.org.apache.lens.server.session.SessionResource.openSession.POST.meter.m5_rate
> lens.meters.org.apache.lens.server.session.SessionResource.openSession.POST.meter.count
> lens.meters.org.apache.lens.server.session.SessionResource.openSession.POST.meter.m1_rate
> lens
> lens.meters.org.apache.lens.server.session.SessionResource.openSession.POST.meter.mean_rate
> lens.meters.org.apache.lens.server.session.SessionResource.openSession.POST.meter.units
>

[jira] [Created] (LENS-815) query list api should have an option to filter by driver

2015-10-12 Thread Rajat Khandelwal (JIRA) 
Rajat Khandelwal created LENS-815:
-

 Summary: query list api should have an option to filter by driver
 Key: LENS-815
 URL: https://issues.apache.org/jira/browse/LENS-815
 Project: Apache Lens
  Issue Type: Bug
Reporter: Rajat Khandelwal






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work started] (LENS-816) ThreadSafeEstimatedQueryCollection is ignoring driver argument in getQueries and getQueryCount

2015-10-12 Thread Rajat Khandelwal (JIRA) 

 [ 
https://issues.apache.org/jira/browse/LENS-816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on LENS-816 started by Rajat Khandelwal.
-
> ThreadSafeEstimatedQueryCollection is ignoring driver argument in getQueries 
> and getQueryCount
> --
>
> Key: LENS-816
> URL: https://issues.apache.org/jira/browse/LENS-816
> Project: Apache Lens
>  Issue Type: Bug
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (LENS-816) ThreadSafeEstimatedQueryCollection is ignoring driver argument in getQueries and getQueryCount

2015-10-12 Thread Rajat Khandelwal (JIRA) 
Rajat Khandelwal created LENS-816:
-

 Summary: ThreadSafeEstimatedQueryCollection is ignoring driver 
argument in getQueries and getQueryCount
 Key: LENS-816
 URL: https://issues.apache.org/jira/browse/LENS-816
 Project: Apache Lens
  Issue Type: Bug
Reporter: Rajat Khandelwal
Assignee: Rajat Khandelwal






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Review Request 39233: LENS-816: ThreadSafeEstimatedQueryCollection is ignoring driver argument in getQueries and getQueryCount

2015-10-12 Thread Rajat Khandelwal 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39233/
---

Review request for lens.


Bugs: LENS-816
https://issues.apache.org/jira/browse/LENS-816


Repository: lens


Description
---


Diffs
-

  
lens-server-api/src/test/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraintTest.java
 55a2eea110f9001c962faede01cef396e8c91b6c 
  
lens-server/src/main/java/org/apache/lens/server/query/collect/ThreadSafeEstimatedQueryCollection.java
 5d243798ebfe221a83afdbfc2ac42b3064244476 
  
lens-server/src/test/java/org/apache/lens/server/query/constraint/ThreadSafeEstimatedQueryCollectionTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/39233/diff/


Testing
---


Thanks,

Rajat Khandelwal