Re: Review Request 40899: LENS-851: Replace columns with aliases in where clause of the inner query

[Amareshwari Sriramadasu]

> On Dec. 3, 2015, 11:34 p.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java, line 179
> > 
> >
> > I think we already have error code for parsing, can we use that here?
> 
> Rajat Khandelwal wrote:
> We're using SYNTAX_ERROR in other places, used that here too :)

SYNTAX_ERROR is for query, and expression parsing is for metastore. Please 
confirm if my statement is correct.
Shall we create a metastore error code (>3100) and pass it from parseExpr ?


- Amareshwari


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40899/#review108909
---


On Dec. 4, 2015, 11:39 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40899/
> ---
> 
> (Updated Dec. 4, 2015, 11:39 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-851
> https://issues.apache.org/jira/browse/LENS-851
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java 
> b4185174c7ca7365bf9de7e2a0a0f75bdde6ba4b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 
> 7f8146158c1e2d883ee9327c4bf847883d0e1004 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java 
> 97088a146729d4d2fb6ed6c55c2d16bfa8c75339 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 
> 9a9d1348cce1b90fa9d558cc6399d441cca9fca1 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java 
> 60b2dde8a7e088d8712879c68cd98193bb72de03 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java
>  418ef5a7b64f717618c3b16fe3755141c07beb76 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java 
> c9ba561bc8da1abb59898619620bbd47ec43028c 
>   
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java
>  e415a5adeb5a8af16bad56c96b9f9a32cb7afcbb 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
> fea70b72cbde190d69d46f68d163fd9e541c53f8 
> 
> Diff: https://reviews.apache.org/r/40899/diff/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules . SUCCESS [2.226s]
> [INFO] Lens .. SUCCESS [1.371s]
> [INFO] Lens API .. SUCCESS [7.419s]
> [INFO] Lens API for server and extensions  SUCCESS [9.282s]
> [INFO] Lens Cube . SUCCESS [5:14.939s]
> [INFO] Lens DB storage ... SUCCESS [11.174s]
> [INFO] Lens Query Library  SUCCESS [5.068s]
> [INFO] Lens Hive Driver .. SUCCESS [2:37.060s]
> [INFO] Lens Driver for JDBC .. SUCCESS [23.202s]
> [INFO] Lens Elastic Search Driver  SUCCESS [5.523s]
> [INFO] Lens Server ... SUCCESS 
> [10:04.272s]
> [INFO] Lens client ... SUCCESS [23.400s]
> [INFO] Lens CLI .. SUCCESS [40.574s]
> [INFO] Lens Examples . SUCCESS [0.455s]
> [INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [0.338s]
> [INFO] Lens Distribution . SUCCESS [8.315s]
> [INFO] Lens ML Lib ... SUCCESS [1:05.857s]
> [INFO] Lens ML Ext Distribution .. SUCCESS [1.877s]
> [INFO] Lens Regression ... SUCCESS [2.549s]
> [INFO] Lens UI ... SUCCESS [26.262s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 21:52.090s
> [INFO] Finished at: Thu Dec 03 08:36:40 UTC 2015
> [INFO] Final Memory: 170M/922M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

[jira] [Commented] (LENS-891) Weekly covering info for last Sunday of year and first Sunday of next year is wrong

[Rajat Khandelwal (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15046555#comment-15046555
 ] 

Rajat Khandelwal commented on LENS-891:
---

Created https://reviews.apache.org/r/41083/

> Weekly covering info for last Sunday of year and first Sunday of next year is 
> wrong
> ---
>
> Key: LENS-891
> URL: https://issues.apache.org/jira/browse/LENS-891
> Project: Apache Lens
>  Issue Type: Bug
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work started] (LENS-891) Weekly covering info for last Sunday of year and first Sunday of next year is wrong

[Rajat Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on LENS-891 started by Rajat Khandelwal.
-
> Weekly covering info for last Sunday of year and first Sunday of next year is 
> wrong
> ---
>
> Key: LENS-891
> URL: https://issues.apache.org/jira/browse/LENS-891
> Project: Apache Lens
>  Issue Type: Bug
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (LENS-891) Weekly covering info for last Sunday of year and first Sunday of next year is wrong

[Rajat Khandelwal (JIRA)]

Rajat Khandelwal created LENS-891:
-

 Summary: Weekly covering info for last Sunday of year and first 
Sunday of next year is wrong
 Key: LENS-891
 URL: https://issues.apache.org/jira/browse/LENS-891
 Project: Apache Lens
  Issue Type: Bug
Reporter: Rajat Khandelwal
Assignee: Rajat Khandelwal






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 40899: LENS-851: Replace columns with aliases in where clause of the inner query

[Rajat Khandelwal]

> On Dec. 4, 2015, 5:04 a.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java, line 179
> > 
> >
> > I think we already have error code for parsing, can we use that here?
> 
> Rajat Khandelwal wrote:
> We're using SYNTAX_ERROR in other places, used that here too :)
> 
> Amareshwari Sriramadasu wrote:
> SYNTAX_ERROR is for query, and expression parsing is for metastore. 
> Please confirm if my statement is correct.
> Shall we create a metastore error code (>3100) and pass it from parseExpr 
> ?

parseExpr is used in both `cube.metadata` and `cube.parse` modules. wrong 
expressions can also occur while processing a query.


- Rajat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40899/#review108909
---


On Dec. 4, 2015, 5:09 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40899/
> ---
> 
> (Updated Dec. 4, 2015, 5:09 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-851
> https://issues.apache.org/jira/browse/LENS-851
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java 
> b4185174c7ca7365bf9de7e2a0a0f75bdde6ba4b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 
> 7f8146158c1e2d883ee9327c4bf847883d0e1004 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java 
> 97088a146729d4d2fb6ed6c55c2d16bfa8c75339 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 
> 9a9d1348cce1b90fa9d558cc6399d441cca9fca1 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java 
> 60b2dde8a7e088d8712879c68cd98193bb72de03 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java
>  418ef5a7b64f717618c3b16fe3755141c07beb76 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java 
> c9ba561bc8da1abb59898619620bbd47ec43028c 
>   
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java
>  e415a5adeb5a8af16bad56c96b9f9a32cb7afcbb 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
> fea70b72cbde190d69d46f68d163fd9e541c53f8 
> 
> Diff: https://reviews.apache.org/r/40899/diff/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules . SUCCESS [2.226s]
> [INFO] Lens .. SUCCESS [1.371s]
> [INFO] Lens API .. SUCCESS [7.419s]
> [INFO] Lens API for server and extensions  SUCCESS [9.282s]
> [INFO] Lens Cube . SUCCESS [5:14.939s]
> [INFO] Lens DB storage ... SUCCESS [11.174s]
> [INFO] Lens Query Library  SUCCESS [5.068s]
> [INFO] Lens Hive Driver .. SUCCESS [2:37.060s]
> [INFO] Lens Driver for JDBC .. SUCCESS [23.202s]
> [INFO] Lens Elastic Search Driver  SUCCESS [5.523s]
> [INFO] Lens Server ... SUCCESS 
> [10:04.272s]
> [INFO] Lens client ... SUCCESS [23.400s]
> [INFO] Lens CLI .. SUCCESS [40.574s]
> [INFO] Lens Examples . SUCCESS [0.455s]
> [INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [0.338s]
> [INFO] Lens Distribution . SUCCESS [8.315s]
> [INFO] Lens ML Lib ... SUCCESS [1:05.857s]
> [INFO] Lens ML Ext Distribution .. SUCCESS [1.877s]
> [INFO] Lens Regression ... SUCCESS [2.549s]
> [INFO] Lens UI ... SUCCESS [26.262s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 21:52.090s
> [INFO] Finished at: Thu Dec 03 08:36:40 UTC 2015
> [INFO] Final Memory: 170M/922M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

[jira] [Commented] (LENS-890) Allow per-queue driver max launched queries constraints

[Mohammad Rafi (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15046686#comment-15046686
 ] 

Mohammad Rafi commented on LENS-890:


+1

Need this feature.

> Allow per-queue driver max launched queries constraints
> ---
>
> Key: LENS-890
> URL: https://issues.apache.org/jira/browse/LENS-890
> Project: Apache Lens
>  Issue Type: Improvement
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (LENS-892) Log lens Session details in Query Logs

[Puneet Gupta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Puneet Gupta reassigned LENS-892:
-

Assignee: Puneet Gupta

> Log  lens Session details in Query Logs
> ---
>
> Key: LENS-892
> URL: https://issues.apache.org/jira/browse/LENS-892
> Project: Apache Lens
>  Issue Type: Improvement
>Reporter: Puneet Gupta
>Assignee: Puneet Gupta
>Priority: Trivial
>  Labels: newbie
>
> As of now its not easy to map Lens Queries to Lens Sessions . 
> It can be made trivial if the session details are logged in query logs .
> This can be required in many scenarios. 
> One such scenario : attribute a lens session close (say a user issued a query 
> via CLI and then exited the CLI before query was scheduled for a run on lens 
> server)  as a reason for  failure/cancellation of queries triggered via that 
> session . 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (LENS-892) Log lens Session details in Query Logs

[Puneet Gupta (JIRA)]

Puneet Gupta created LENS-892:
-

 Summary: Log  lens Session details in Query Logs
 Key: LENS-892
 URL: https://issues.apache.org/jira/browse/LENS-892
 Project: Apache Lens
  Issue Type: Improvement
Reporter: Puneet Gupta
Priority: Trivial


As of now its not easy to map Lens Queries to Lens Sessions . 
It can be made trivial if the session details are logged in query logs .

This can be required in many scenarios. 
One such scenario : attribute a lens session close (say a user issued a query 
via CLI and then exited the CLI before query was scheduled for a run on lens 
server)  as a reason for  failure/cancellation of queries triggered via that 
session . 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (LENS-743) Query failure retries for transient errors

[Rajat Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal reassigned LENS-743:
-

Assignee: Rajat Khandelwal

> Query failure retries for transient errors
> --
>
> Key: LENS-743
> URL: https://issues.apache.org/jira/browse/LENS-743
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>Reporter: Amareshwari Sriramadasu
>Assignee: Rajat Khandelwal
>  Labels: newbie
>
> There have to be retries for query failures for transient errors like network 
> errors (Hive server not reachable/ Metastore not reachable/ DB not 
> reachable). Retries should be available for each phase - submission, 
> execution, updating status, fetching results and formatting.
> Right now, any such failure results in marking query as failed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-654) Cassandra storage for Lens

[Arvind Jayaprakash (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15046867#comment-15046867
 ] 

Arvind Jayaprakash commented on LENS-654:
-

CQL in all likelihood does not support full SQL in cases where performance 
could be a big issue. Transparently generating those expensive queries might 
not be such a good idea. An experiment CQL support on an _as-is_ basis would be 
interesting to start exploring.

> Cassandra storage for Lens
> --
>
> Key: LENS-654
> URL: https://issues.apache.org/jira/browse/LENS-654
> Project: Apache Lens
>  Issue Type: New Feature
>  Components: drivers
>Reporter: Yash Sharma
>  Labels: Hackathon-July
>
> Cassandra datastax driver can be used to support Cassandra as a storage for 
> Lens.
> CQL however is very limited and supports only subsets of SQL. Other 
> unsupported sql operations has to be handled in code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-879) Base framework for Scheduler.

[Rajat Khandelwal (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15046903#comment-15046903
 ] 

Rajat Khandelwal commented on LENS-879:
---

Failure due to LENS-891, reproduced and fixed, Still in review though. 



> Base framework for Scheduler.
> -
>
> Key: LENS-879
> URL: https://issues.apache.org/jira/browse/LENS-879
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: server
>Reporter: Ajay Yadava
>Assignee: Ajay Yadava
> Attachments: LENS-879-v1.patch, LENS-879-v2.patch, LENS-879-v3.patch, 
> LENS-879.patch
>
>
> Add interfaces for scheduler service and xsd for job.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 40638: Base framework for scheduler.

[Ajay Yadava]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40638/
---

(Updated Dec. 8, 2015, 2:06 p.m.)


Review request for lens.


Changes
---

Addressed the latest review comments.


Bugs: LENS-879
https://issues.apache.org/jira/browse/LENS-879


Repository: lens


Description
---

Base framework for lens scheduler service and job definition.


Diffs (updated)
-

  lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java 
PRE-CREATION 
  lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInfo.java 
PRE-CREATION 
  
lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java
 PRE-CREATION 
  
lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java 
PRE-CREATION 
  lens-api/src/main/resources/scheduler-job-0.1.xsd PRE-CREATION 
  lens-examples/src/main/resources/example-job.xml PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/QuerySchedulerService.java
 9f48d27 
  
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobStats.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java
 PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java
 3389aba 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java
 24949bd 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
 PRE-CREATION 
  lens-server/src/main/resources/lensserver-default.xml 39b72dc 
  
lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java
 e11413e 
  pom.xml 732b3bb 
  src/site/apt/admin/config.apt bcf4b7d 

Diff: https://reviews.apache.org/r/40638/diff/


Testing
---


Thanks,

Ajay Yadava

[jira] [Updated] (LENS-879) Base framework for Scheduler.

[Ajay Yadava (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ajay Yadava updated LENS-879:
-
Attachment: LENS-879-v3.patch

Addressed the review comments. Please review.

> Base framework for Scheduler.
> -
>
> Key: LENS-879
> URL: https://issues.apache.org/jira/browse/LENS-879
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: server
>Reporter: Ajay Yadava
>Assignee: Ajay Yadava
> Attachments: LENS-879-v1.patch, LENS-879-v2.patch, LENS-879-v3.patch, 
> LENS-879.patch
>
>
> Add interfaces for scheduler service and xsd for job.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-879) Base framework for Scheduler.

[Ajay Yadava (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ajay Yadava updated LENS-879:
-
Status: Open  (was: Patch Available)

> Base framework for Scheduler.
> -
>
> Key: LENS-879
> URL: https://issues.apache.org/jira/browse/LENS-879
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: server
>Reporter: Ajay Yadava
>Assignee: Ajay Yadava
> Attachments: LENS-879-v1.patch, LENS-879-v2.patch, LENS-879-v3.patch, 
> LENS-879.patch
>
>
> Add interfaces for scheduler service and xsd for job.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-879) Base framework for Scheduler.

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15046900#comment-15046900
 ] 

Hadoop QA commented on LENS-879:


Applied patch: 
[LENS-879-v3.patch|https://issues.apache.org/jira/secure/attachment/12776318/LENS-879-v3.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/209/

> Base framework for Scheduler.
> -
>
> Key: LENS-879
> URL: https://issues.apache.org/jira/browse/LENS-879
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: server
>Reporter: Ajay Yadava
>Assignee: Ajay Yadava
> Attachments: LENS-879-v1.patch, LENS-879-v2.patch, LENS-879-v3.patch, 
> LENS-879.patch
>
>
> Add interfaces for scheduler service and xsd for job.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 40638: Base framework for scheduler.

[Ajay Yadava]

> On Nov. 30, 2015, 5:16 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInfo.java, 
> > line 38
> > 
> >
> > Is this not ScheduleJobHandle ?

Yes. It changed after review request and I forgot to update. Will fix it.


> On Nov. 30, 2015, 5:16 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInfo.java, 
> > lines 47-87
> > 
> >
> > I think all of these fields should be replaced with single object XJob

Agreed, will fix.


> On Nov. 30, 2015, 5:16 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java,
> >  line 33
> > 
> >
> > Should be SchedulerJobInstanceHandle

Yes. Will fix it.


> On Nov. 30, 2015, 5:16 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java,
> >  line 36
> > 
> >
> > Why is this new session handle. Should be "session handle in which 
> > instance was run"

The thought was that the setter gets the new value which needs to be set.


> On Nov. 30, 2015, 5:16 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java,
> >  line 39
> > 
> >
> > Return LensSessionHandle ?

Will fix.


> On Nov. 30, 2015, 5:16 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java,
> >  line 42
> > 
> >
> > StartTime - when the instance started to run.
> > 
> > I see all other comments are also saying the values to be set. Instead 
> > they are actually when it ran.

These are the documentations which will be generated on the setter methods. You 
pass in the value which you want to be set and hence the language. @returns 
documentation is exactly what you have suggested. I think it is correct, let me 
know if you think otherwise.


> On Nov. 30, 2015, 5:16 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/resources/scheduler-job-0.1.xsd, line 47
> > 
> >
> > Should be "Name of the scheduled job" ?

Yes. Will update.


> On Nov. 30, 2015, 5:16 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/resources/scheduler-job-0.1.xsd, line 102
> > 
> >
> > If we are separating session into separate type, resource_path should 
> > be actually part of session.

Sure. Fixed it.


> On Nov. 30, 2015, 5:16 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/resources/scheduler-job-0.1.xsd, line 117
> > 
> >
> > Can we be consistent with names for types and elements? All types can 
> > start with x_type and elements would contain actual names and no x_ ?

Definitely. Sorry for the oversight.


> On Nov. 30, 2015, 5:16 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/resources/scheduler-job-0.1.xsd, line 153
> > 
> >
> > Comment needs to be updated.

Will fix.


> On Nov. 30, 2015, 5:16 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/resources/scheduler-job-0.1.xsd, line 122
> > 
> >
> > Can you change the comment to "Database name to be used in session" ?

Sure. Will update.


> On Nov. 30, 2015, 5:16 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java,
> >  line 81
> > 
> >
> > I dont think we would allow modification of an instance, so should not 
> > be required.

Yes. will fix


> On Nov. 30, 2015, 5:16 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInfo.java, 
> > line 55
> > 
> >
> > we should return XJob instead of Clob.

Makes sense, will fix.


> On Nov. 30, 2015, 5:16 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInfo.java, 
> > line 63
> > 
> >
> > Instead of Clob we should return correspondig objects. Applies for all 
> > Clob objects.

Re: Review Request 40751: LENS - 882: provide option from CLI as well to list queries by driver

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40751/#review109334
---



lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 
(line 221)


Javadoc needs update



lens-client/src/main/java/org/apache/lens/client/LensStatement.java (line 385)


javadoc needs update


- Amareshwari Sriramadasu


On Dec. 7, 2015, 8:41 p.m., Deepak Barr wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40751/
> ---
> 
> (Updated Dec. 7, 2015, 8:41 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-882
> https://issues.apache.org/jira/browse/LENS-882
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> After this change,  a CLI user will be able to find a list of queries that 
> ran on a particular driver.
> eg. lens-shell>query list --driver org.apache.lens.driver.hive.HiveDriver
> 
> 
> Diffs
> -
> 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 
> fe9b84d 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 
> 48b3ebb 
>   lens-client/src/main/java/org/apache/lens/client/LensClient.java 5fd04c4 
>   lens-client/src/main/java/org/apache/lens/client/LensStatement.java 40e6d76 
>   src/site/apt/user/cli.apt c266c6d 
> 
> Diff: https://reviews.apache.org/r/40751/diff/
> 
> 
> Testing
> ---
> 
> Yes.
> 
> INFO] 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .. SUCCESS [  2.401 
> s]
> [INFO] Lens ... SUCCESS [  4.075 
> s]
> [INFO] Lens API ... SUCCESS [ 19.117 
> s]
> [INFO] Lens API for server and extensions . SUCCESS [ 16.010 
> s]
> [INFO] Lens Cube .. SUCCESS [04:54 
> min]
> [INFO] Lens DB storage  SUCCESS [ 15.088 
> s]
> [INFO] Lens Query Library . SUCCESS [ 11.770 
> s]
> [INFO] Lens Hive Driver ... SUCCESS [02:24 
> min]
> [INFO] Lens Driver for JDBC ... SUCCESS [ 29.353 
> s]
> [INFO] Lens Elastic Search Driver . SUCCESS [ 14.007 
> s]
> [INFO] Lens Server  SUCCESS [12:05 
> min]
> [INFO] Lens client  SUCCESS [ 29.389 
> s]
> [INFO] Lens CLI ... SUCCESS [ 44.601 
> s]
> [INFO] Lens Examples .. SUCCESS [  6.650 
> s]
> [INFO] Lens Ship Jars to Distributed Cache  SUCCESS [  0.863 
> s]
> [INFO] Lens Distribution .. SUCCESS [ 10.363 
> s]
> [INFO] Lens ML Lib  SUCCESS [01:21 
> min]
> [INFO] Lens ML Ext Distribution ... SUCCESS [  3.111 
> s]
> [INFO] Lens Regression  SUCCESS [ 10.240 
> s]
> [INFO] Lens UI  SUCCESS [  3.515 
> s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 24:26 min
> [INFO] Finished at: 2015-11-26T18:04:55+05:30
> [INFO] Final Memory: 143M/857M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Deepak Barr
> 
>

Re: Review Request 41033: LENS-836: Query commands in CLI should take default value for query handle as the last executed query

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41033/#review109333
---



lens-cube/src/test/java/org/apache/lens/cube/metadata/timeline/TestPartitionTimelines.java
 (line 53)


Not sure why this is changed only to weekly


- Amareshwari Sriramadasu


On Dec. 8, 2015, 7:39 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41033/
> ---
> 
> (Updated Dec. 8, 2015, 7:39 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-836
> https://issues.apache.org/jira/browse/LENS-836
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 
> fe9b84dd5574b922c6b8a16a1b8c5b7518aa400a 
>   lens-client/src/main/java/org/apache/lens/client/LensClient.java 
> 5fd04c4591264ac2e5082f1a60281b15fac9 
>   lens-client/src/main/java/org/apache/lens/client/LensStatement.java 
> 40e6d76d20dbb1359d4d6dc64ff7c41f324c7662 
>   
> lens-cube/src/test/java/org/apache/lens/cube/metadata/timeline/TestPartitionTimelines.java
>  3f9e1258536da5955ed6a846fbe25ce074547625 
> 
> Diff: https://reviews.apache.org/r/41033/diff/
> 
> 
> Testing
> ---
> 
> http://showterm.io/2bbd961fd3bcc859adbc8
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>