[jira] [Commented] (LENS-899) Create Attempt framework

2016-09-01 Thread Amareshwari Sriramadasu (JIRA)

[ 
https://issues.apache.org/jira/browse/LENS-899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15457616#comment-15457616
 ] 

Amareshwari Sriramadasu commented on LENS-899:
--

Over all approach looks fine. 

bq. If the policy has some backoff, this query will be put to waiting-queries, 
and some other query will be launched. This query won't be re-looked at until 
one query finishes.
We might have to add more notification policies (time based) for taking queries 
from waiting queries - other than one other query finishing.

> Create Attempt framework
> 
>
> Key: LENS-899
> URL: https://issues.apache.org/jira/browse/LENS-899
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: server
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (LENS-1306) Wrong hsql query is created when there are multiple facts and no dimension.

2016-09-01 Thread Amareshwari Sriramadasu (JIRA)

[ 
https://issues.apache.org/jira/browse/LENS-1306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15457596#comment-15457596
 ] 

Amareshwari Sriramadasu commented on LENS-1306:
---

[~lavkesh], Can you include a test case as well?

> Wrong hsql query is created when there are multiple facts and no dimension. 
> 
>
> Key: LENS-1306
> URL: https://issues.apache.org/jira/browse/LENS-1306
> Project: Apache Lens
>  Issue Type: Bug
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Attachments: multifact-fix.patch
>
>
> When there are more than 2 fact tables resolved and there are no dimension, 
> It results into wrong HSQL query. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (LENS-1306) Wrong hsql query is created when there are multiple facts and no dimension.

2016-09-01 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/LENS-1306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15455773#comment-15455773
 ] 

Hadoop QA commented on LENS-1306:
-

Applied patch: 
[multifact-fix.patch|https://issues.apache.org/jira/secure/attachment/12826642/multifact-fix.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/856/

> Wrong hsql query is created when there are multiple facts and no dimension. 
> 
>
> Key: LENS-1306
> URL: https://issues.apache.org/jira/browse/LENS-1306
> Project: Apache Lens
>  Issue Type: Bug
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Attachments: multifact-fix.patch
>
>
> When there are more than 2 fact tables resolved and there are no dimension, 
> It results into wrong HSQL query. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (LENS-1306) Wrong hsql query is created when there are multiple facts and no dimension.

2016-09-01 Thread Lavkesh Lahngir (JIRA)

 [ 
https://issues.apache.org/jira/browse/LENS-1306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lavkesh Lahngir updated LENS-1306:
--
Status: Patch Available  (was: Open)

> Wrong hsql query is created when there are multiple facts and no dimension. 
> 
>
> Key: LENS-1306
> URL: https://issues.apache.org/jira/browse/LENS-1306
> Project: Apache Lens
>  Issue Type: Bug
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Attachments: multifact-fix.patch
>
>
> When there are more than 2 fact tables resolved and there are no dimension, 
> It results into wrong HSQL query. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (LENS-1306) Wrong hsql query is created when there are multiple facts and no dimension.

2016-09-01 Thread Lavkesh Lahngir (JIRA)

 [ 
https://issues.apache.org/jira/browse/LENS-1306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lavkesh Lahngir updated LENS-1306:
--
Attachment: multifact-fix.patch

> Wrong hsql query is created when there are multiple facts and no dimension. 
> 
>
> Key: LENS-1306
> URL: https://issues.apache.org/jira/browse/LENS-1306
> Project: Apache Lens
>  Issue Type: Bug
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Attachments: multifact-fix.patch
>
>
> When there are more than 2 fact tables resolved and there are no dimension, 
> It results into wrong HSQL query. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (LENS-1306) Wrong hsql query is created when there are multiple facts and no dimension.

2016-09-01 Thread Lavkesh Lahngir (JIRA)
Lavkesh Lahngir created LENS-1306:
-

 Summary: Wrong hsql query is created when there are multiple facts 
and no dimension. 
 Key: LENS-1306
 URL: https://issues.apache.org/jira/browse/LENS-1306
 Project: Apache Lens
  Issue Type: Bug
Reporter: Lavkesh Lahngir
Assignee: Lavkesh Lahngir


When there are more than 2 fact tables resolved and there are no dimension, It 
results into wrong HSQL query. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Review Request 51548: LENS-1304 Log Driver query in lens finished_queries

2016-09-01 Thread Raghavendra Singh

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51548/
---

(Updated Sept. 1, 2016, 2:03 p.m.)


Review request for lens.


Changes
---

set selected driver query while doing finished query to driver context 
conversion


Bugs: LENS-1304
https://issues.apache.org/jira/browse/LENS-1304


Repository: lens


Description
---

Make driver query available in the finished_queries stats for deeper analytics


Diffs (updated)
-

  
lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java
 1d56757 
  lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java 
47159b5 
  lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 
74d9a1f 

Diff: https://reviews.apache.org/r/51548/diff/


Testing
---

Test added in TestLensDAO.java

[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules .. SUCCESS [ 12.621 s]
[INFO] Lens ... SUCCESS [ 14.930 s]
[INFO] Lens API ... SUCCESS [ 44.131 s]
[INFO] Lens API for server and extensions . SUCCESS [ 46.240 s]
[INFO] Lens Cube .. SUCCESS [21:11 min]
[INFO] Lens DB storage  SUCCESS [ 32.606 s]
[INFO] Lens Query Library . SUCCESS [ 28.387 s]
[INFO] Lens Hive Driver ... SUCCESS [02:47 min]
[INFO] Lens Driver for JDBC ... SUCCESS [ 56.947 s]
[INFO] Lens Elastic Search Driver . SUCCESS [ 33.325 s]
[INFO] Lens Server  SUCCESS [22:44 min]
[INFO] Lens client  SUCCESS [02:10 min]
[INFO] Lens CLI ... SUCCESS [02:07 min]
[INFO] Lens Examples .. SUCCESS [ 16.364 s]
[INFO] Lens Ship Jars to Distributed Cache  SUCCESS [  2.979 s]
[INFO] Lens Distribution .. SUCCESS [ 38.824 s]
[INFO] Lens ML Lib  SUCCESS [02:40 min]
[INFO] Lens ML Ext Distribution ... SUCCESS [ 22.394 s]
[INFO] Lens Regression  SUCCESS [ 26.432 s]
[INFO] Lens UI  SUCCESS [ 21.591 s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 01:00 h
[INFO] Finished at: 2016-08-30T19:25:13+05:30
[INFO] Final Memory: 199M/1058M
[INFO] 


Thanks,

Raghavendra Singh



[jira] [Created] (LENS-1305) Literals with double spaces are getting trimmed when queried from CLI

2016-09-01 Thread Archana H (JIRA)
Archana H created LENS-1305:
---

 Summary: Literals with double spaces are getting trimmed when 
queried from CLI
 Key: LENS-1305
 URL: https://issues.apache.org/jira/browse/LENS-1305
 Project: Apache Lens
  Issue Type: Bug
Reporter: Archana H


User Query : cube select id,name from sample_db_dim where name != 'fir  st'

Final rewritten query for driver: jdbc/jdbc1 is: 
SELECT (sample_db_dim.id), (sample_db_dim.name) FROM exp_yoda.mydb_dim_table3 
sample_db_dim WHERE sample_db_dim.name) != 'fir st')))



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (LENS-1033) Literals with double spaces are losing spaces in HQLParser

2016-09-01 Thread Archana H (JIRA)

 [ 
https://issues.apache.org/jira/browse/LENS-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Archana H closed LENS-1033.
---

> Literals with double spaces are losing spaces in HQLParser
> --
>
> Key: LENS-1033
> URL: https://issues.apache.org/jira/browse/LENS-1033
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Amareshwari Sriramadasu
>Assignee: Amareshwari Sriramadasu
> Fix For: 2.6
>
> Attachments: LENS-1033.1.patch
>
>
> Literals with more spaces in where clauses (the filter values) are losing 
> spaces, which are resulting in wrong report outputs



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (LENS-1300) Queries submissions are not getting rejected on sessions marked for close

2016-09-01 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/LENS-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15455054#comment-15455054
 ] 

Hadoop QA commented on LENS-1300:
-

Applied patch: 
[LENS-1300.02.patch|https://issues.apache.org/jira/secure/attachment/12826159/LENS-1300.02.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/855/

> Queries submissions are not getting rejected on sessions marked for close
> -
>
> Key: LENS-1300
> URL: https://issues.apache.org/jira/browse/LENS-1300
> Project: Apache Lens
>  Issue Type: Bug
>Affects Versions: 2.6
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Fix For: 2.7
>
> Attachments: LENS-1300.02.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (LENS-950) Bridge table join should ignore join type config

2016-09-01 Thread Archana H (JIRA)

 [ 
https://issues.apache.org/jira/browse/LENS-950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Archana H closed LENS-950.
--

> Bridge table join should ignore join type config
> 
>
> Key: LENS-950
> URL: https://issues.apache.org/jira/browse/LENS-950
> Project: Apache Lens
>  Issue Type: Improvement
>Affects Versions: 2.5
>Reporter: Amareshwari Sriramadasu
>Assignee: Amareshwari Sriramadasu
> Fix For: 2.6
>
> Attachments: LENS-950.patch
>
>
> Right now, if user specifies join type config to be left outer join or right 
> outer join, the bridge table joins( i.e. join between dimension tables) 
> should discard this, as bridge table join should be alway inner join. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (LENS-853) Quitting shell(quitshell()) is not closing session some times.

2016-09-01 Thread Archana H (JIRA)

 [ 
https://issues.apache.org/jira/browse/LENS-853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Archana H closed LENS-853.
--

> Quitting shell(quitshell()) is not closing session some times.
> --
>
> Key: LENS-853
> URL: https://issues.apache.org/jira/browse/LENS-853
> Project: Apache Lens
>  Issue Type: Bug
>  Components: client
>Reporter: Raju Bairishetti
>Assignee: Raju Bairishetti
>  Labels: newbie
> Fix For: 2.6
>
> Attachments: LENS-853.patch, LENS-853_01.patch
>
>
> Quitting session through programmatically is not closing the session some 
> times. 
> First it checks whether connection to server is active or not to close the 
> session. It is depending on isConnectionActive variable to check the 
> connection is active or not. Right now we are setting isConnectionActive to 
> true only  if user calls  getClient(). isConnectionActive should be set to 
> true when user calls setClient(client). 
> code snippets:
> 
> {code}
>   public LensClient getClient() {
> if (lensClient == null) {
>   setClient(getClientWrapper().getClient());
>   isConnectionActive = true;
> }
> return lensClient;
>   }
> {code}
> {code}
> protected static synchronized void closeClientConnection() {
> if (isConnectionActive) {
>   log.debug("Request for stopping lens cli received");
>   getClientWrapper().getClient().closeConnection();
>   isConnectionActive = false;
> }
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (LENS-952) Bump up enunciate version to work with java 8

2016-09-01 Thread Archana H (JIRA)

 [ 
https://issues.apache.org/jira/browse/LENS-952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Archana H closed LENS-952.
--

> Bump up enunciate version to work with java 8
> -
>
> Key: LENS-952
> URL: https://issues.apache.org/jira/browse/LENS-952
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: build
>Reporter: Amareshwari Sriramadasu
>Assignee: Deepak Barr
> Fix For: 2.6
>
> Attachments: LENS-952.2.patch, LENS-952.3.patch
>
>
> We are depending on 1.28 version of enunciate, which does not work on java 8. 
> We should move to latest version to work fine with java8.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (LENS-290) Add doc/run book for failures of lens REST api

2016-09-01 Thread Archana H (JIRA)

 [ 
https://issues.apache.org/jira/browse/LENS-290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Archana H updated LENS-290:
---
Fix Version/s: (was: 2.6)

> Add doc/run book for failures of lens REST api
> --
>
> Key: LENS-290
> URL: https://issues.apache.org/jira/browse/LENS-290
> Project: Apache Lens
>  Issue Type: Task
>  Components: docs, operations
>Reporter: Amareshwari Sriramadasu
>
> This doc should capture various responses that could be returned from REST 
> api and debugging steps.
> We can add them in java doc itself, they by goes in REST api generated doc. 
> Thoughts?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (LENS-289) Add doc/ run book for debugging query failures

2016-09-01 Thread Archana H (JIRA)

 [ 
https://issues.apache.org/jira/browse/LENS-289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Archana H updated LENS-289:
---
Fix Version/s: (was: 2.6)

> Add doc/ run book for debugging query failures
> --
>
> Key: LENS-289
> URL: https://issues.apache.org/jira/browse/LENS-289
> Project: Apache Lens
>  Issue Type: Task
>  Components: docs, operations
>Reporter: Amareshwari Sriramadasu
>
> This doc should capture the various query failure reasons and a way for user 
> to take next step.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (LENS-291) Add doc for lens administrator to debug lens server issues

2016-09-01 Thread Archana H (JIRA)

 [ 
https://issues.apache.org/jira/browse/LENS-291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Archana H updated LENS-291:
---
Fix Version/s: (was: 2.6)

> Add doc for lens administrator to debug lens server issues 
> ---
>
> Key: LENS-291
> URL: https://issues.apache.org/jira/browse/LENS-291
> Project: Apache Lens
>  Issue Type: Task
>  Components: docs, operations
>Reporter: Amareshwari Sriramadasu
>
> This doc should capture various system errors that lens server could face in 
> production and a guide to administrator to take next steps.
> For example : Email notification failure can say check for smtp host and 
> port, and how to go about the error seen.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (LENS-953) Unclosed InputStream in DatabaseUtil#initializeDatabaseStorage()

2016-09-01 Thread Archana H (JIRA)

 [ 
https://issues.apache.org/jira/browse/LENS-953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Archana H closed LENS-953.
--

> Unclosed InputStream in DatabaseUtil#initializeDatabaseStorage()
> 
>
> Key: LENS-953
> URL: https://issues.apache.org/jira/browse/LENS-953
> Project: Apache Lens
>  Issue Type: Bug
>  Components: client
>Reporter: Ted Yu
>Assignee: Ajay Yadava
>Priority: Minor
> Fix For: 2.6
>
> Attachments: LENS-953-v1.patch, LENS-953.patch
>
>
> Here is related code:
> {code}
> InputStream file = 
> DatabaseUtil.class.getClassLoader().getResourceAsStream("db-storage-schema.sql");
> BufferedReader reader = new BufferedReader(new InputStreamReader(file, 
> "UTF-8"));
> {code}
> Neither file nor reader is closed upon exit from the method.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (LENS-1149) Union queries with dim-attribute expressions are not written properly

2016-09-01 Thread Archana H (JIRA)

 [ 
https://issues.apache.org/jira/browse/LENS-1149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Archana H closed LENS-1149.
---

> Union queries with dim-attribute expressions are not written properly
> -
>
> Key: LENS-1149
> URL: https://issues.apache.org/jira/browse/LENS-1149
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Amareshwari Sriramadasu
>Assignee: Amareshwari Sriramadasu
> Fix For: 2.6
>
> Attachments: LENS-1149.patch
>
>
> We are seeing the inner group by and outer group by clause are not correct 
> for union queries involving dim attribute expressions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (LENS-954) await() is not inside loop in FairPriorityBlockingQueue#waitUntilNotEmpty()

2016-09-01 Thread Archana H (JIRA)

 [ 
https://issues.apache.org/jira/browse/LENS-954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Archana H closed LENS-954.
--

> await() is not inside loop in FairPriorityBlockingQueue#waitUntilNotEmpty()
> ---
>
> Key: LENS-954
> URL: https://issues.apache.org/jira/browse/LENS-954
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Ted Yu
>Assignee: Ajay Yadava
>Priority: Minor
> Fix For: 2.6
>
> Attachments: LENS-954.patch
>
>
> {code}
>   private void waitUntilNotEmpty() throws InterruptedException {
> conditionalWaitLock.lock();
> try {
>   notEmpty.await();
> } finally {
>   conditionalWaitLock.unlock();
> }
> {code}
> From 
> http://docs.oracle.com/javase/1.5.0/docs/api/java/lang/Object.html#wait%28long%29
>  :
> A thread can wake up without being notified, interrupted, a so-called 
> spurious wakeup. While this will rarely occur in practice, applications must 
> guard against it by testing for the condition that should have caused the 
> thread to be awakened.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (LENS-1300) Queries submissions are not getting rejected on sessions marked for close

2016-09-01 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/LENS-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15454653#comment-15454653
 ] 

Hadoop QA commented on LENS-1300:
-

Applied patch: 
[LENS-1300.02.patch|https://issues.apache.org/jira/secure/attachment/12826159/LENS-1300.02.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/853/

> Queries submissions are not getting rejected on sessions marked for close
> -
>
> Key: LENS-1300
> URL: https://issues.apache.org/jira/browse/LENS-1300
> Project: Apache Lens
>  Issue Type: Bug
>Affects Versions: 2.6
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Fix For: 2.7
>
> Attachments: LENS-1300.02.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (LENS-1168) Isolate submissions for each driver

2016-09-01 Thread Archana H (JIRA)

 [ 
https://issues.apache.org/jira/browse/LENS-1168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Archana H closed LENS-1168.
---

> Isolate submissions for each driver
> ---
>
> Key: LENS-1168
> URL: https://issues.apache.org/jira/browse/LENS-1168
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>Reporter: Amareshwari Sriramadasu
>Assignee: Amareshwari Sriramadasu
> Fix For: 2.6
>
> Attachments: LENS-1168.4.patch, LENS-1168.5.patch
>
>
> We need to isolate query submitters for each driver to be different. We have 
> seen scenarios where hive submission takes time and other interactive queries 
> on jdbc are queued because querysubmitter was busy. 
> Also, each driver can have a pool of submitters - which should benefit 
> interactive queries with immediate submissions, especially the ones submitted 
> on EXECUTE_WITH_TIMEOUT



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)