[jira] [Updated] (LENS-1384) Update error message for data completeness check

[Narayan Periwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Narayan Periwal updated LENS-1384:
--
Attachment: LENS-1384-v3.patch

> Update error message for data completeness check
> 
>
> Key: LENS-1384
> URL: https://issues.apache.org/jira/browse/LENS-1384
> Project: Apache Lens
>  Issue Type: Task
>  Components: cube
>Reporter: Narayan Periwal
>Assignee: Narayan Periwal
>Priority: Minor
> Attachments: LENS-1384-v3.patch
>
>
> We can make the error message for the data completeness check less verbose.
> New message can be something like -  Requested metrics are only partially 
> complete. Partially complete metrics: . Try 
> again later or remove metric and re-run report.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1384) Update error message for data completeness check

[Narayan Periwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Narayan Periwal updated LENS-1384:
--
Status: Patch Available  (was: In Progress)

> Update error message for data completeness check
> 
>
> Key: LENS-1384
> URL: https://issues.apache.org/jira/browse/LENS-1384
> Project: Apache Lens
>  Issue Type: Task
>  Components: cube
>Reporter: Narayan Periwal
>Assignee: Narayan Periwal
>Priority: Minor
> Attachments: LENS-1384-v3.patch
>
>
> We can make the error message for the data completeness check less verbose.
> New message can be something like -  Requested metrics are only partially 
> complete. Partially complete metrics: . Try 
> again later or remove metric and re-run report.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 55715: Update error message for data completeness check

[Narayan Periwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55715/
---

(Updated Jan. 25, 2017, 7:31 a.m.)


Review request for lens.


Bugs: LENS-1384
https://issues.apache.org/jira/browse/LENS-1384


Repository: lens


Description
---

We can make the error message for the data completeness check less verbose.
New message can be something like -  Requested metrics are only partially 
complete. Partially complete metrics: . Try 
again later or remove metric and re-run report.


Diffs (updated)
-

  
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
 2ad6e20 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
c9e7c29 

Diff: https://reviews.apache.org/r/55715/diff/


Testing
---


Thanks,

Narayan Periwal

Re: Review Request 55715: Update error message for data completeness check

[Puneet Gupta]

> On Jan. 19, 2017, 2:06 p.m., Puneet Gupta wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java,
> >  line 151
> > 
> >
> > Should we say  
> > 
> > "Data for the requested metrics is only partially available. Partially 
> > available metrics are : %s. Please try again later."

Data for the requested metrics is only partially complete. Partially complete 
metrics are : %s. Please try again later or rerun after removing incomplete 
metrics


- Puneet


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55715/#review162281
---


On Jan. 25, 2017, 6:29 a.m., Narayan Periwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55715/
> ---
> 
> (Updated Jan. 25, 2017, 6:29 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1384
> https://issues.apache.org/jira/browse/LENS-1384
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> We can make the error message for the data completeness check less verbose.
> New message can be something like -  Requested metrics are only partially 
> complete. Partially complete metrics: . Try 
> again later or remove metric and re-run report.
> 
> 
> Diffs
> -
> 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
>  2ad6e20 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
> c9e7c29 
> 
> Diff: https://reviews.apache.org/r/55715/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Narayan Periwal
> 
>

Re: Review Request 55715: Update error message for data completeness check

[Narayan Periwal]

> On Jan. 24, 2017, 8:32 a.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java, 
> > line 975
> > 
> >
> > Can you add assert for actual messsage containing measure name as part 
> > of the message?

Added.


- Narayan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55715/#review162789
---


On Jan. 25, 2017, 6:29 a.m., Narayan Periwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55715/
> ---
> 
> (Updated Jan. 25, 2017, 6:29 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1384
> https://issues.apache.org/jira/browse/LENS-1384
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> We can make the error message for the data completeness check less verbose.
> New message can be something like -  Requested metrics are only partially 
> complete. Partially complete metrics: . Try 
> again later or remove metric and re-run report.
> 
> 
> Diffs
> -
> 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
>  2ad6e20 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
> c9e7c29 
> 
> Diff: https://reviews.apache.org/r/55715/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Narayan Periwal
> 
>

Re: Review Request 55715: Update error message for data completeness check

[Narayan Periwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55715/
---

(Updated Jan. 25, 2017, 6:29 a.m.)


Review request for lens.


Bugs: LENS-1384
https://issues.apache.org/jira/browse/LENS-1384


Repository: lens


Description
---

We can make the error message for the data completeness check less verbose.
New message can be something like -  Requested metrics are only partially 
complete. Partially complete metrics: . Try 
again later or remove metric and re-run report.


Diffs (updated)
-

  
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
 2ad6e20 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
c9e7c29 

Diff: https://reviews.apache.org/r/55715/diff/


Testing
---


Thanks,

Narayan Periwal

Re: Review Request 55712: Fact Schema change to support all update periods in one storage

[Lavkesh Lahngir]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55712/
---

(Updated Jan. 24, 2017, 2:57 p.m.)


Review request for lens.


Bugs: LENS-1386
https://issues.apache.org/jira/browse/LENS-1386


Repository: lens


Description
---

A new data structure XUpdatePeriodTableDescriptor is introduced which contains 
an update period and table descriptor. Now the XUpdatePeriods will contain a 
list of XUpdatePeriodTableDescriptor or XUpdatePeriod


Diffs (updated)
-

  lens-api/src/main/resources/cube-0.1.xsd f438f48 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 
adb6c92 
  
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 
6c9cde2 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 
53cf8af 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java cd9f705 
  
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java
 e21dc2a 
  
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java
 8b10d1d 
  lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 
51fcb43 

Diff: https://reviews.apache.org/r/55712/diff/


Testing
---


Thanks,

Lavkesh Lahngir

Re: Review Request 55712: Fact Schema change to support all update periods in one storage

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55712/#review162787
---




lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java (line 
37)


Please update the comment to state the value is table_name_prefix



lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java (line 
39)


Lets change the map to Map>



lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java (line 
111)


Should this map be populated for Facts which are created before this 
feature as well?



lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 
(line 189)


Is the method giving StorageTableName or storageTablePrefix ? Please name 
method or variable accordingly.



lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 
(line 192)


Why is storageTablePrefix required for look up on partitionTimelineCache ?

what is passed for key?



lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 
(lines 225 - 229)


Did not understand why these code changes are required.



lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 
(line 345)


We need understand why storagePrefix is required for PartitionTimeline.

I feel it should not be required.



lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 
(line 754)


Can you update the comment to what is it now?



lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 
(line 973)


Why is getPrefix method taking storageTableName as parameter?



lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 
(line 977)


Same as above, why is getPrefix taking storageTableName as prefix?



lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 
(line 2275)


How will this work if is same table is mapped for all update periods?



lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 
(line 2278)


I see drop is already happening before.



lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 
(line 2490)


Please name the variable and method appropriately. And should this method 
be moved to CubeFactTable?



lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java (line 133)


Should we name the param as storageTableNamePrefix? Also, please update 
javadoc accordingly.



lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java (line 266)


Rename param to storageTableNamePrefix?



lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java (line 387)


Rename param to storageTableNamePrefix?



lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java (line 
860)


Can we rename the map appropriately?


- Amareshwari Sriramadasu


On Jan. 23, 2017, 2:51 p.m., Lavkesh Lahngir wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55712/
> ---
> 
> (Updated Jan. 23, 2017, 2:51 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1386
> https://issues.apache.org/jira/browse/LENS-1386
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> A new data structure XUpdatePeriodTableDescriptor is introduced which 
> contains an update period and table descriptor. Now the XUpdatePeriods will 
> contain a list of XUpdatePeriodTableDescriptor or XUpdatePeriod
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/resources/cube-0.1.xsd f438f48 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 
> adb6c92 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java
>  6c9cde2 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 
> 53cf8af 

Re: Review Request 55715: Update error message for data completeness check

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55715/#review162789
---




lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java (line 
975)


Can you add assert for actual messsage containing measure name as part of 
the message?


- Amareshwari Sriramadasu


On Jan. 19, 2017, 12:25 p.m., Narayan Periwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55715/
> ---
> 
> (Updated Jan. 19, 2017, 12:25 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1384
> https://issues.apache.org/jira/browse/LENS-1384
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> We can make the error message for the data completeness check less verbose.
> New message can be something like -  Requested metrics are only partially 
> complete. Partially complete metrics: . Try 
> again later or remove metric and re-run report.
> 
> 
> Diffs
> -
> 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
>  2ad6e20 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
> c9e7c29 
> 
> Diff: https://reviews.apache.org/r/55715/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Narayan Periwal
> 
>