Re: Report for the month of February

2017-01-31 Thread Rajat Khandelwal 
+1

On Wed, Feb 1, 2017 at 11:30 AM Amareshwari Sriramdasu <
amareshw...@apache.org> wrote:

> Hello Lens contributors,
>
> Have put up the report for the month here -
> https://cwiki.apache.org/confluence/display/LENS/February%2C2017. Please
> review and post your comments.
>
> I see this quarter has the least engagement wrt mailing lists, jira
> activity and commits. More details on putting this up in the report will
> help.
>
> ---
> ## JIRA activity:
>
>  - 15 JIRA tickets created in the last 3 months
>  - 16 JIRA tickets closed/resolved in the last 3 months
> ---
> ## Mailing list activity:
>
>  - dev@lens.apache.org:
> - 401 emails sent to list (2402 in previous quarter)
>
>  - u...@lens.apache.org:
> - 2 emails sent to list (150 in previous quarter)
> ---
>
> Thanks
> Amareshwari
>

Report for the month of February

2017-01-31 Thread Amareshwari Sriramdasu 
Hello Lens contributors,

Have put up the report for the month here -
https://cwiki.apache.org/confluence/display/LENS/February%2C2017. Please
review and post your comments.

I see this quarter has the least engagement wrt mailing lists, jira
activity and commits. More details on putting this up in the report will
help.

---
## JIRA activity:

 - 15 JIRA tickets created in the last 3 months
 - 16 JIRA tickets closed/resolved in the last 3 months
---
## Mailing list activity:

 - dev@lens.apache.org:
- 401 emails sent to list (2402 in previous quarter)

 - u...@lens.apache.org:
- 2 emails sent to list (150 in previous quarter)
---

Thanks
Amareshwari

Re: Review Request 55712: Fact Schema change to support all update periods in one storage

2017-01-31 Thread Amareshwari Sriramadasu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55712/#review163785
---




lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 
(line 190)


Seems variable is not used, can be removed?



lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 
(line 347)


Why is timeLineKey storageTableName? And tableName is only constructed with 
fact and storage names?


- Amareshwari Sriramadasu


On Jan. 31, 2017, 1:53 p.m., Lavkesh Lahngir wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55712/
> ---
> 
> (Updated Jan. 31, 2017, 1:53 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1386
> https://issues.apache.org/jira/browse/LENS-1386
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> A new data structure XUpdatePeriodTableDescriptor is introduced which 
> contains an update period and table descriptor. Now the XUpdatePeriods will 
> contain a list of XUpdatePeriodTableDescriptor or XUpdatePeriod
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/resources/cube-0.1.xsd f438f48 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 
> adb6c92 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java
>  6c9cde2 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 
> 53cf8af 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java cd9f705 
>   
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java
>  e21dc2a 
>   
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java
>  8b10d1d 
>   lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 
> 51fcb43 
> 
> Diff: https://reviews.apache.org/r/55712/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Lavkesh Lahngir
> 
>

Re: Review Request 55712: Fact Schema change to support all update periods in one storage

2017-01-31 Thread Lavkesh Lahngir 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55712/
---

(Updated Jan. 31, 2017, 1:53 p.m.)


Review request for lens.


Changes
---

Updated TimeLineCache and addded test case


Bugs: LENS-1386
https://issues.apache.org/jira/browse/LENS-1386


Repository: lens


Description
---

A new data structure XUpdatePeriodTableDescriptor is introduced which contains 
an update period and table descriptor. Now the XUpdatePeriods will contain a 
list of XUpdatePeriodTableDescriptor or XUpdatePeriod


Diffs (updated)
-

  lens-api/src/main/resources/cube-0.1.xsd f438f48 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 
adb6c92 
  
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 
6c9cde2 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 
53cf8af 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java cd9f705 
  
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java
 e21dc2a 
  
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java
 8b10d1d 
  lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 
51fcb43 

Diff: https://reviews.apache.org/r/55712/diff/


Testing
---


Thanks,

Lavkesh Lahngir