[jira] [Updated] (LENS-1413) Estimates failing with Task rejection errors

2017-04-24 Thread Lavkesh Lahngir (JIRA) 

 [ 
https://issues.apache.org/jira/browse/LENS-1413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lavkesh Lahngir updated LENS-1413:
--
Status: Patch Available  (was: Open)

> Estimates failing with Task rejection errors
> 
>
> Key: LENS-1413
> URL: https://issues.apache.org/jira/browse/LENS-1413
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Attachments: LENS-1413.patch
>
>
> # Cancel estimates for other drivers when the estimate pool queue is full. 
> # Return the appropriate error message



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (LENS-1413) Estimates failing with Task rejection errors

2017-04-24 Thread Lavkesh Lahngir (JIRA) 

 [ 
https://issues.apache.org/jira/browse/LENS-1413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lavkesh Lahngir updated LENS-1413:
--
Attachment: LENS-1413.patch

> Estimates failing with Task rejection errors
> 
>
> Key: LENS-1413
> URL: https://issues.apache.org/jira/browse/LENS-1413
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Attachments: LENS-1413.patch
>
>
> # Cancel estimates for other drivers when the estimate pool queue is full. 
> # Return the appropriate error message



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 57947: LENS-974: Add cube-segmentation for base cube

2017-04-24 Thread Rajat Khandelwal 


> On April 20, 2017, 4:15 p.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java
> > Line 271 (original), 271 (patched)
> > 
> >
> > This looks a wrong assignment of storageTable to storageName.

Fixed. Now it's `String storageName = sc.getStorageName();`


- Rajat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57947/#review172464
---


On April 24, 2017, 12:15 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57947/
> ---
> 
> (Updated April 24, 2017, 12:15 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-974
> https://issues.apache.org/jira/browse/LENS-974
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> With cube segmentation a cube can have multiple cubes and all these child 
> cubes together will make the cube complete. 
> 
> CubeSegmentation and  CubeFactTable will sit together, which means it can 
> belong to only one base cube. A base cube can have one or more cube 
> segmentations. Fields of segmentation will be intersection of all columns of 
> its cubes. Segmentation will have weight to compare with its buddies (facts 
> or other segmentations). Also it can have start and end time defined or it 
> can derive from its underline facts. 
> 
> eg: 
> base_cube
>   |_fact1
>   |_fact2
>   |_cube_segment1
>  |_cube1
> |_fact_11
> |_fact_12
> ... 
>   ...
>   |_cube_segment2
>  |_cube2
> |_fact_21
> |_fact_22
> ... 
>   ...
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/resources/cube-0.1.xsd 
> 1d8a6241a85066f111b8490e8e03516e4848cf41 
>   
> lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFactAvailableException.java
>  21dda1685e8211357b0e35884ab3a96800451e9e 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/Cube.java 
> b376aaf463f991c540b7c711a90271551848a6e2 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/DateUtil.java 
> 99ad2331dc68d893703523ea4f0511333cb7b837 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 
> 599027fbc32bace298d58b0797f2585d627115e2 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRange.java 
> 2e85111583eb8d80427df91607411581d4ccd38c 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/TimeRange.java 
> 82868949e9fbf38046548a6a32c7406f81b2dcfa 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java 
> 30b1a904ddf2dcc4a3cd66732059fb146acc0c20 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java 
> bbf8ab9d37e60b3211ff6cd99336409b5ff71c79 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/Candidate.java 
> f241cb3111426f820beffe7c63209162bfb50f39 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateCoveringSetsResolver.java
>  b22d9729252a9bb389e881032f63a950510c4081 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateExploder.java 
> PRE-CREATION 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
>  1c0d35684f13baeaa9c28fe2cf824dbab82ec5cb 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java
>  6d61f1fc152eb89efa71ac7a1a26f81f9eadafbf 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java 
> b9ff0eff271c62020800b9309a223f4f0db8d296 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java 
> 300d798f9dd5760853d86d106ec2b9fc1e91afb5 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 
> c63c4c0f2204591521f44584239fc9e275a60649 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 
> 6bee3864e26a83c695e9389f8cbf6d93ca3fa37c 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DefaultQueryAST.java 
> 29da0a2cf64f28cd1dbd2d52cc6609aaefc07a50 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java
>  30fa873c255df408563f3c20062a6ccfca0f3811 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java 
> 95d65728457d24ac58fcaedc0d4c7a9b2e71fd71 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 
> 6f6572ea3ba5ae5c6cb7ad2bc0eb9ce058f0ccc2 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 
> 926a4d0e0eaead318be64e37c2d3950d7b883fcb 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java 
> 1b30c0b25d3ac861fa289f699421d4e420195b50 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLContextInterface.java 
>

Re: Review Request 57947: LENS-974: Add cube-segmentation for base cube

2017-04-24 Thread Rajat Khandelwal 


> On April 11, 2017, 4:31 p.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java
> > Lines 841 (patched)
> > 
> >
> > Can we move this to a resovler, which happens after 
> > StorageTableResolver? 
> > 
> > It should remove itself from candidates if it is not eligible.
> > 
> > Also we will add SEGMENT_PRUNED message with which carries the reasons 
> > why all of its candidates got pruned in detail error.

Moved and added SEGMENTATION_PRUNED and SEGMENTATION_PRUNED_WITH_ERROR as 
discussed


- Rajat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57947/#review171551
---


On April 24, 2017, 12:15 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57947/
> ---
> 
> (Updated April 24, 2017, 12:15 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-974
> https://issues.apache.org/jira/browse/LENS-974
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> With cube segmentation a cube can have multiple cubes and all these child 
> cubes together will make the cube complete. 
> 
> CubeSegmentation and  CubeFactTable will sit together, which means it can 
> belong to only one base cube. A base cube can have one or more cube 
> segmentations. Fields of segmentation will be intersection of all columns of 
> its cubes. Segmentation will have weight to compare with its buddies (facts 
> or other segmentations). Also it can have start and end time defined or it 
> can derive from its underline facts. 
> 
> eg: 
> base_cube
>   |_fact1
>   |_fact2
>   |_cube_segment1
>  |_cube1
> |_fact_11
> |_fact_12
> ... 
>   ...
>   |_cube_segment2
>  |_cube2
> |_fact_21
> |_fact_22
> ... 
>   ...
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/resources/cube-0.1.xsd 
> 1d8a6241a85066f111b8490e8e03516e4848cf41 
>   
> lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFactAvailableException.java
>  21dda1685e8211357b0e35884ab3a96800451e9e 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/Cube.java 
> b376aaf463f991c540b7c711a90271551848a6e2 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/DateUtil.java 
> 99ad2331dc68d893703523ea4f0511333cb7b837 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 
> 599027fbc32bace298d58b0797f2585d627115e2 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRange.java 
> 2e85111583eb8d80427df91607411581d4ccd38c 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/TimeRange.java 
> 82868949e9fbf38046548a6a32c7406f81b2dcfa 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java 
> 30b1a904ddf2dcc4a3cd66732059fb146acc0c20 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java 
> bbf8ab9d37e60b3211ff6cd99336409b5ff71c79 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/Candidate.java 
> f241cb3111426f820beffe7c63209162bfb50f39 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateCoveringSetsResolver.java
>  b22d9729252a9bb389e881032f63a950510c4081 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateExploder.java 
> PRE-CREATION 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
>  1c0d35684f13baeaa9c28fe2cf824dbab82ec5cb 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java
>  6d61f1fc152eb89efa71ac7a1a26f81f9eadafbf 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java 
> b9ff0eff271c62020800b9309a223f4f0db8d296 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java 
> 300d798f9dd5760853d86d106ec2b9fc1e91afb5 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 
> c63c4c0f2204591521f44584239fc9e275a60649 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 
> 6bee3864e26a83c695e9389f8cbf6d93ca3fa37c 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DefaultQueryAST.java 
> 29da0a2cf64f28cd1dbd2d52cc6609aaefc07a50 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java
>  30fa873c255df408563f3c20062a6ccfca0f3811 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java 
> 95d65728457d24ac58fcaedc0d4c7a9b2e71fd71 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 
> 6f6572ea3ba5ae5c6cb7ad2bc0eb9ce058f0ccc2 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 
>

Re: Review Request 57947: LENS-974: Add cube-segmentation for base cube

2017-04-24 Thread Rajat Khandelwal 


> On April 11, 2017, 3:51 p.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/test/resources/schema/segmentations/seg1.xml
> > Lines 26-30 (original), 26-32 (patched)
> > 
> >
> > Can we finish the TODOs ?

No segment properties in use as of now.


- Rajat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57947/#review171541
---


On April 24, 2017, 12:15 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57947/
> ---
> 
> (Updated April 24, 2017, 12:15 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-974
> https://issues.apache.org/jira/browse/LENS-974
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> With cube segmentation a cube can have multiple cubes and all these child 
> cubes together will make the cube complete. 
> 
> CubeSegmentation and  CubeFactTable will sit together, which means it can 
> belong to only one base cube. A base cube can have one or more cube 
> segmentations. Fields of segmentation will be intersection of all columns of 
> its cubes. Segmentation will have weight to compare with its buddies (facts 
> or other segmentations). Also it can have start and end time defined or it 
> can derive from its underline facts. 
> 
> eg: 
> base_cube
>   |_fact1
>   |_fact2
>   |_cube_segment1
>  |_cube1
> |_fact_11
> |_fact_12
> ... 
>   ...
>   |_cube_segment2
>  |_cube2
> |_fact_21
> |_fact_22
> ... 
>   ...
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/resources/cube-0.1.xsd 
> 1d8a6241a85066f111b8490e8e03516e4848cf41 
>   
> lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFactAvailableException.java
>  21dda1685e8211357b0e35884ab3a96800451e9e 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/Cube.java 
> b376aaf463f991c540b7c711a90271551848a6e2 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/DateUtil.java 
> 99ad2331dc68d893703523ea4f0511333cb7b837 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 
> 599027fbc32bace298d58b0797f2585d627115e2 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRange.java 
> 2e85111583eb8d80427df91607411581d4ccd38c 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/TimeRange.java 
> 82868949e9fbf38046548a6a32c7406f81b2dcfa 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java 
> 30b1a904ddf2dcc4a3cd66732059fb146acc0c20 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java 
> bbf8ab9d37e60b3211ff6cd99336409b5ff71c79 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/Candidate.java 
> f241cb3111426f820beffe7c63209162bfb50f39 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateCoveringSetsResolver.java
>  b22d9729252a9bb389e881032f63a950510c4081 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateExploder.java 
> PRE-CREATION 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
>  1c0d35684f13baeaa9c28fe2cf824dbab82ec5cb 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java
>  6d61f1fc152eb89efa71ac7a1a26f81f9eadafbf 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java 
> b9ff0eff271c62020800b9309a223f4f0db8d296 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java 
> 300d798f9dd5760853d86d106ec2b9fc1e91afb5 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 
> c63c4c0f2204591521f44584239fc9e275a60649 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 
> 6bee3864e26a83c695e9389f8cbf6d93ca3fa37c 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DefaultQueryAST.java 
> 29da0a2cf64f28cd1dbd2d52cc6609aaefc07a50 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java
>  30fa873c255df408563f3c20062a6ccfca0f3811 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java 
> 95d65728457d24ac58fcaedc0d4c7a9b2e71fd71 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 
> 6f6572ea3ba5ae5c6cb7ad2bc0eb9ce058f0ccc2 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 
> 926a4d0e0eaead318be64e37c2d3950d7b883fcb 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java 
> 1b30c0b25d3ac861fa289f699421d4e420195b50 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLContextInterface.java 
> 78d448ab1d145925ebfe27bb86333c8a971339ae 
>

Re: Review Request 57947: LENS-974: Add cube-segmentation for base cube

2017-04-24 Thread Rajat Khandelwal 


> On April 18, 2017, 2:47 p.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateExploder.java
> > Lines 38 (patched)
> > 
> >
> > How is prune cause getting populated?

Updated the method with the same


- Rajat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57947/#review172173
---


On April 24, 2017, 12:15 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57947/
> ---
> 
> (Updated April 24, 2017, 12:15 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-974
> https://issues.apache.org/jira/browse/LENS-974
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> With cube segmentation a cube can have multiple cubes and all these child 
> cubes together will make the cube complete. 
> 
> CubeSegmentation and  CubeFactTable will sit together, which means it can 
> belong to only one base cube. A base cube can have one or more cube 
> segmentations. Fields of segmentation will be intersection of all columns of 
> its cubes. Segmentation will have weight to compare with its buddies (facts 
> or other segmentations). Also it can have start and end time defined or it 
> can derive from its underline facts. 
> 
> eg: 
> base_cube
>   |_fact1
>   |_fact2
>   |_cube_segment1
>  |_cube1
> |_fact_11
> |_fact_12
> ... 
>   ...
>   |_cube_segment2
>  |_cube2
> |_fact_21
> |_fact_22
> ... 
>   ...
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/resources/cube-0.1.xsd 
> 1d8a6241a85066f111b8490e8e03516e4848cf41 
>   
> lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFactAvailableException.java
>  21dda1685e8211357b0e35884ab3a96800451e9e 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/Cube.java 
> b376aaf463f991c540b7c711a90271551848a6e2 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/DateUtil.java 
> 99ad2331dc68d893703523ea4f0511333cb7b837 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 
> 599027fbc32bace298d58b0797f2585d627115e2 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRange.java 
> 2e85111583eb8d80427df91607411581d4ccd38c 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/TimeRange.java 
> 82868949e9fbf38046548a6a32c7406f81b2dcfa 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java 
> 30b1a904ddf2dcc4a3cd66732059fb146acc0c20 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java 
> bbf8ab9d37e60b3211ff6cd99336409b5ff71c79 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/Candidate.java 
> f241cb3111426f820beffe7c63209162bfb50f39 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateCoveringSetsResolver.java
>  b22d9729252a9bb389e881032f63a950510c4081 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateExploder.java 
> PRE-CREATION 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
>  1c0d35684f13baeaa9c28fe2cf824dbab82ec5cb 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java
>  6d61f1fc152eb89efa71ac7a1a26f81f9eadafbf 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java 
> b9ff0eff271c62020800b9309a223f4f0db8d296 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java 
> 300d798f9dd5760853d86d106ec2b9fc1e91afb5 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 
> c63c4c0f2204591521f44584239fc9e275a60649 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 
> 6bee3864e26a83c695e9389f8cbf6d93ca3fa37c 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DefaultQueryAST.java 
> 29da0a2cf64f28cd1dbd2d52cc6609aaefc07a50 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java
>  30fa873c255df408563f3c20062a6ccfca0f3811 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java 
> 95d65728457d24ac58fcaedc0d4c7a9b2e71fd71 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 
> 6f6572ea3ba5ae5c6cb7ad2bc0eb9ce058f0ccc2 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 
> 926a4d0e0eaead318be64e37c2d3950d7b883fcb 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java 
> 1b30c0b25d3ac861fa289f699421d4e420195b50 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLContextInterface.java 
> 78d448ab1d145925ebfe27bb86333c8a971339ae 
>

Re: Review Request 58604: Handle Estimates failing with task rejection errors

2017-04-24 Thread Amareshwari Sriramadasu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58604/#review172774
---


Ship it!




Ship It!

- Amareshwari Sriramadasu


On April 24, 2017, 11:43 a.m., Lavkesh Lahngir wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58604/
> ---
> 
> (Updated April 24, 2017, 11:43 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1413
> https://issues.apache.org/jira/browse/LENS-1413
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> 1. Cancel estimates for other drivers when the estimate pool queue is full.
> 2. Return the appropriate error message
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/resources/lens-errors.conf 236d678 
>   
> lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java
>  14a31e2 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
>  c6fbeda 
>   
> lens-server/src/test/java/org/apache/lens/server/common/FailingQueryDriver.java
>  7e9133e 
>   
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 
> 7d8c977 
>   lens-server/src/test/resources/lens-site.xml 334a9c4 
> 
> 
> Diff: https://reviews.apache.org/r/58604/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Lavkesh Lahngir
> 
>

Re: Review Request 58604: Handle Estimates failing with task rejection errors

2017-04-24 Thread Lavkesh Lahngir 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58604/
---

(Updated April 24, 2017, 11:43 a.m.)


Review request for lens.


Bugs: LENS-1413
https://issues.apache.org/jira/browse/LENS-1413


Repository: lens


Description
---

1. Cancel estimates for other drivers when the estimate pool queue is full.
2. Return the appropriate error message


Diffs (updated)
-

  lens-api/src/main/resources/lens-errors.conf 236d678 
  
lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java 
14a31e2 
  
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
 c6fbeda 
  
lens-server/src/test/java/org/apache/lens/server/common/FailingQueryDriver.java 
7e9133e 
  lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 
7d8c977 
  lens-server/src/test/resources/lens-site.xml 334a9c4 


Diff: https://reviews.apache.org/r/58604/diff/4/

Changes: https://reviews.apache.org/r/58604/diff/3-4/


Testing
---


Thanks,

Lavkesh Lahngir

[jira] [Updated] (LENS-1411) Queries not rewritten correctly when aggregate expression used inside "case when..."

2017-04-24 Thread Rajat Khandelwal (JIRA) 

 [ 
https://issues.apache.org/jira/browse/LENS-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-1411:
---
Fix Version/s: 2.7

> Queries not rewritten correctly when aggregate expression used inside "case 
> when..."
> 
>
> Key: LENS-1411
> URL: https://issues.apache.org/jira/browse/LENS-1411
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Sushil Mohanty
>Assignee: Sushil Mohanty
> Fix For: 2.7
>
> Attachments: LENS-1411.patch
>
>
> Found error in rewritten query when aggregate expressions used inside "case 
> when" statement. 
> for eg  : 
> {CODE}
> CASE
> WHEN (sum((db.msr1)) = 0) THEN 0
> ELSE ((sum((db.msr2)) / sum((db.msr1))) * 1000)
> END AS `expr1`
> {CODE}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (LENS-1411) Queries not rewritten correctly when aggregate expression used inside "case when..."

2017-04-24 Thread Rajat Khandelwal (JIRA) 

 [ 
https://issues.apache.org/jira/browse/LENS-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-1411:
---
Resolution: Fixed
Status: Resolved  (was: Patch Available)

> Queries not rewritten correctly when aggregate expression used inside "case 
> when..."
> 
>
> Key: LENS-1411
> URL: https://issues.apache.org/jira/browse/LENS-1411
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Sushil Mohanty
>Assignee: Sushil Mohanty
> Fix For: 2.7
>
> Attachments: LENS-1411.patch
>
>
> Found error in rewritten query when aggregate expressions used inside "case 
> when" statement. 
> for eg  : 
> {CODE}
> CASE
> WHEN (sum((db.msr1)) = 0) THEN 0
> ELSE ((sum((db.msr2)) / sum((db.msr1))) * 1000)
> END AS `expr1`
> {CODE}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (LENS-1411) Queries not rewritten correctly when aggregate expression used inside "case when..."

2017-04-24 Thread Rajat Khandelwal (JIRA) 

[ 
https://issues.apache.org/jira/browse/LENS-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15980924#comment-15980924
 ] 

Rajat Khandelwal commented on LENS-1411:


Committed. Thanks [~sushilmohanty]

> Queries not rewritten correctly when aggregate expression used inside "case 
> when..."
> 
>
> Key: LENS-1411
> URL: https://issues.apache.org/jira/browse/LENS-1411
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Sushil Mohanty
>Assignee: Sushil Mohanty
> Fix For: 2.7
>
> Attachments: LENS-1411.patch
>
>
> Found error in rewritten query when aggregate expressions used inside "case 
> when" statement. 
> for eg  : 
> {CODE}
> CASE
> WHEN (sum((db.msr1)) = 0) THEN 0
> ELSE ((sum((db.msr2)) / sum((db.msr1))) * 1000)
> END AS `expr1`
> {CODE}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 57947: LENS-974: Add cube-segmentation for base cube

2017-04-24 Thread Rajat Khandelwal 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57947/
---

(Updated April 24, 2017, 12:15 p.m.)


Review request for lens.


Bugs: LENS-974
https://issues.apache.org/jira/browse/LENS-974


Repository: lens


Description
---

With cube segmentation a cube can have multiple cubes and all these child cubes 
together will make the cube complete. 

CubeSegmentation and  CubeFactTable will sit together, which means it can 
belong to only one base cube. A base cube can have one or more cube 
segmentations. Fields of segmentation will be intersection of all columns of 
its cubes. Segmentation will have weight to compare with its buddies (facts or 
other segmentations). Also it can have start and end time defined or it can 
derive from its underline facts. 

eg: 
base_cube
  |_fact1
  |_fact2
  |_cube_segment1
 |_cube1
|_fact_11
|_fact_12
... 
  ...
  |_cube_segment2
 |_cube2
|_fact_21
|_fact_22
... 
  ...


Diffs (updated)
-

  lens-api/src/main/resources/cube-0.1.xsd 
1d8a6241a85066f111b8490e8e03516e4848cf41 
  
lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFactAvailableException.java
 21dda1685e8211357b0e35884ab3a96800451e9e 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/Cube.java 
b376aaf463f991c540b7c711a90271551848a6e2 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/DateUtil.java 
99ad2331dc68d893703523ea4f0511333cb7b837 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 
599027fbc32bace298d58b0797f2585d627115e2 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRange.java 
2e85111583eb8d80427df91607411581d4ccd38c 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/TimeRange.java 
82868949e9fbf38046548a6a32c7406f81b2dcfa 
  lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java 
30b1a904ddf2dcc4a3cd66732059fb146acc0c20 
  lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java 
bbf8ab9d37e60b3211ff6cd99336409b5ff71c79 
  lens-cube/src/main/java/org/apache/lens/cube/parse/Candidate.java 
f241cb3111426f820beffe7c63209162bfb50f39 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateCoveringSetsResolver.java
 b22d9729252a9bb389e881032f63a950510c4081 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateExploder.java 
PRE-CREATION 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
 1c0d35684f13baeaa9c28fe2cf824dbab82ec5cb 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 
6d61f1fc152eb89efa71ac7a1a26f81f9eadafbf 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java 
b9ff0eff271c62020800b9309a223f4f0db8d296 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java 
300d798f9dd5760853d86d106ec2b9fc1e91afb5 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 
c63c4c0f2204591521f44584239fc9e275a60649 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 
6bee3864e26a83c695e9389f8cbf6d93ca3fa37c 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DefaultQueryAST.java 
29da0a2cf64f28cd1dbd2d52cc6609aaefc07a50 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 
30fa873c255df408563f3c20062a6ccfca0f3811 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java 
95d65728457d24ac58fcaedc0d4c7a9b2e71fd71 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 
6f6572ea3ba5ae5c6cb7ad2bc0eb9ce058f0ccc2 
  lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 
926a4d0e0eaead318be64e37c2d3950d7b883fcb 
  lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java 
1b30c0b25d3ac861fa289f699421d4e420195b50 
  lens-cube/src/main/java/org/apache/lens/cube/parse/HQLContextInterface.java 
78d448ab1d145925ebfe27bb86333c8a971339ae 
  lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 
8a70535203f038b07f387b20adf7343e593d899d 
  lens-cube/src/main/java/org/apache/lens/cube/parse/JoinCandidate.java 
52085ea35a0ba0df61742167457ba08ae410411f 
  lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java 
02e3dc7b6b93a108b1a239e4a7d01460df2666b4 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/LeastPartitionResolver.java 
a9bd164b8f6d9e8b27396d491dace56eef3248c3 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/MultiCandidateQueryWriterContext.java
 PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/parse/PruneCauses.java 
0996db52322582a141af45137a030b108dbaa0a3 
  lens-cube/src/main/java/org/apache/lens/cube/parse/QueriedPhraseContext.java 
310a655cd2102ce7c8da19ae3301cf9b241caff4 
  lens-cube/src/main/java/org/apache/lens/cube/parse/QueryWriter.java 
PRE-CREATION