Re: Review Request 57947: LENS-974: Add cube-segmentation for base cube

2017-04-26 Thread Amareshwari Sriramadasu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57947/#review173030
---




lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java
Line 264 (original), 265 (patched)


New variable to be defined for holding storageTableName ?


- Amareshwari Sriramadasu


On April 25, 2017, 2:18 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57947/
> ---
> 
> (Updated April 25, 2017, 2:18 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-974
> https://issues.apache.org/jira/browse/LENS-974
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> With cube segmentation a cube can have multiple cubes and all these child 
> cubes together will make the cube complete. 
> 
> CubeSegmentation and  CubeFactTable will sit together, which means it can 
> belong to only one base cube. A base cube can have one or more cube 
> segmentations. Fields of segmentation will be intersection of all columns of 
> its cubes. Segmentation will have weight to compare with its buddies (facts 
> or other segmentations). Also it can have start and end time defined or it 
> can derive from its underline facts. 
> 
> eg: 
> base_cube
>   |_fact1
>   |_fact2
>   |_cube_segment1
>  |_cube1
> |_fact_11
> |_fact_12
> ... 
>   ...
>   |_cube_segment2
>  |_cube2
> |_fact_21
> |_fact_22
> ... 
>   ...
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/resources/cube-0.1.xsd 
> 1d8a6241a85066f111b8490e8e03516e4848cf41 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java 
> befe4e6617ff4149136bd4bc2d2a8196414cba41 
>   
> lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFactAvailableException.java
>  21dda1685e8211357b0e35884ab3a96800451e9e 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/Cube.java 
> b376aaf463f991c540b7c711a90271551848a6e2 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 
> e00122db06a4afcb8f227419669ee6e544888f2e 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/DateUtil.java 
> 99ad2331dc68d893703523ea4f0511333cb7b837 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 
> 599027fbc32bace298d58b0797f2585d627115e2 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRange.java 
> 2e85111583eb8d80427df91607411581d4ccd38c 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/TimeRange.java 
> 82868949e9fbf38046548a6a32c7406f81b2dcfa 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java 
> 30b1a904ddf2dcc4a3cd66732059fb146acc0c20 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java 
> bbf8ab9d37e60b3211ff6cd99336409b5ff71c79 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/Candidate.java 
> f241cb3111426f820beffe7c63209162bfb50f39 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateCoveringSetsResolver.java
>  b22d9729252a9bb389e881032f63a950510c4081 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateExploder.java 
> PRE-CREATION 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
>  1c0d35684f13baeaa9c28fe2cf824dbab82ec5cb 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java
>  6d61f1fc152eb89efa71ac7a1a26f81f9eadafbf 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java 
> b9ff0eff271c62020800b9309a223f4f0db8d296 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java 
> 300d798f9dd5760853d86d106ec2b9fc1e91afb5 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 
> c63c4c0f2204591521f44584239fc9e275a60649 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 
> 6bee3864e26a83c695e9389f8cbf6d93ca3fa37c 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DefaultQueryAST.java 
> 29da0a2cf64f28cd1dbd2d52cc6609aaefc07a50 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java
>  30fa873c255df408563f3c20062a6ccfca0f3811 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java 
> 95d65728457d24ac58fcaedc0d4c7a9b2e71fd71 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 
> 6f6572ea3ba5ae5c6cb7ad2bc0eb9ce058f0ccc2 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 
> 926a4d0e0eaead318be64e37c2d3950d7b883fcb 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java 
> 1b30c0b25d3ac861fa289f699421d4e420195b50 
>   lens-cube/src/main/java/org/

Re: Review Request 57947: LENS-974: Add cube-segmentation for base cube

2017-04-26 Thread Amareshwari Sriramadasu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57947/#review173027
---




lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java
Lines 912 (patched)


commented code?



lens-cube/src/main/java/org/apache/lens/cube/parse/SegmentationCandidate.java
Lines 96 (patched)


Getter called without any consumption?


- Amareshwari Sriramadasu


On April 25, 2017, 2:18 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57947/
> ---
> 
> (Updated April 25, 2017, 2:18 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-974
> https://issues.apache.org/jira/browse/LENS-974
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> With cube segmentation a cube can have multiple cubes and all these child 
> cubes together will make the cube complete. 
> 
> CubeSegmentation and  CubeFactTable will sit together, which means it can 
> belong to only one base cube. A base cube can have one or more cube 
> segmentations. Fields of segmentation will be intersection of all columns of 
> its cubes. Segmentation will have weight to compare with its buddies (facts 
> or other segmentations). Also it can have start and end time defined or it 
> can derive from its underline facts. 
> 
> eg: 
> base_cube
>   |_fact1
>   |_fact2
>   |_cube_segment1
>  |_cube1
> |_fact_11
> |_fact_12
> ... 
>   ...
>   |_cube_segment2
>  |_cube2
> |_fact_21
> |_fact_22
> ... 
>   ...
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/resources/cube-0.1.xsd 
> 1d8a6241a85066f111b8490e8e03516e4848cf41 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java 
> befe4e6617ff4149136bd4bc2d2a8196414cba41 
>   
> lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFactAvailableException.java
>  21dda1685e8211357b0e35884ab3a96800451e9e 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/Cube.java 
> b376aaf463f991c540b7c711a90271551848a6e2 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 
> e00122db06a4afcb8f227419669ee6e544888f2e 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/DateUtil.java 
> 99ad2331dc68d893703523ea4f0511333cb7b837 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 
> 599027fbc32bace298d58b0797f2585d627115e2 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRange.java 
> 2e85111583eb8d80427df91607411581d4ccd38c 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/TimeRange.java 
> 82868949e9fbf38046548a6a32c7406f81b2dcfa 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java 
> 30b1a904ddf2dcc4a3cd66732059fb146acc0c20 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java 
> bbf8ab9d37e60b3211ff6cd99336409b5ff71c79 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/Candidate.java 
> f241cb3111426f820beffe7c63209162bfb50f39 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateCoveringSetsResolver.java
>  b22d9729252a9bb389e881032f63a950510c4081 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateExploder.java 
> PRE-CREATION 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
>  1c0d35684f13baeaa9c28fe2cf824dbab82ec5cb 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java
>  6d61f1fc152eb89efa71ac7a1a26f81f9eadafbf 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java 
> b9ff0eff271c62020800b9309a223f4f0db8d296 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java 
> 300d798f9dd5760853d86d106ec2b9fc1e91afb5 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 
> c63c4c0f2204591521f44584239fc9e275a60649 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 
> 6bee3864e26a83c695e9389f8cbf6d93ca3fa37c 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DefaultQueryAST.java 
> 29da0a2cf64f28cd1dbd2d52cc6609aaefc07a50 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java
>  30fa873c255df408563f3c20062a6ccfca0f3811 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java 
> 95d65728457d24ac58fcaedc0d4c7a9b2e71fd71 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 
> 6f6572ea3ba5ae5c6cb7ad2bc0eb9ce058f0ccc2 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 
> 926a4d0e0eaead318be64e37c2d3950d7b883fcb 
>   lens-cube/src/main/ja