Re: Review Request 60115: Unit test cases for Virtual fact [LENS-1437] and fix in virtual fact update command [LENS-1440]
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60115/ --- (Updated June 15, 2017, 3:46 p.m.) Review request for lens and Amareshwari Sriramadasu. Summary (updated) - Unit test cases for Virtual fact [LENS-1437] and fix in virtual fact update command [LENS-1440] Repository: lens Description (updated) --- Unit test cases for Virtual fact Fix in virtual fact update command in schema Diffs (updated) - lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java aca1cf9 lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 48869c2 lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java d8c7335 lens-cube/src/test/java/org/apache/lens/cube/parse/TestVirtualFactQueries.java PRE-CREATION lens-cube/src/test/resources/schema/cubes/base/testcube2.xml PRE-CREATION lens-cube/src/test/resources/schema/cubes/base/virtualcube.xml 2a5e0b0 lens-cube/src/test/resources/schema/facts/testfact7_base.xml PRE-CREATION lens-cube/src/test/resources/schema/facts/testfact8_base.xml PRE-CREATION lens-cube/src/test/resources/schema/facts/testfact9_base.xml PRE-CREATION lens-cube/src/test/resources/schema/facts/virtual/virtualfact.xml 860965f Diff: https://reviews.apache.org/r/60115/diff/2/ Changes: https://reviews.apache.org/r/60115/diff/1-2/ Testing --- Thanks, Rajitha R
[jira] [Created] (LENS-1440) schema command failing update for virtual facts
Rajitha R created LENS-1440: --- Summary: schema command failing update for virtual facts Key: LENS-1440 URL: https://issues.apache.org/jira/browse/LENS-1440 Project: Apache Lens Issue Type: Bug Components: client Reporter: Rajitha R Assignee: Rajitha R Schema command having incorrect syntax for update in virtual fact. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
Re: Review Request 60115: Unit test cases for Virtual fact [LENS-1437]
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60115/ --- (Updated June 15, 2017, 3:36 p.m.) Review request for lens and Amareshwari Sriramadasu. Summary (updated) - Unit test cases for Virtual fact [LENS-1437] Repository: lens Description --- Unit test cases for Virtual fact Diffs - lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 48869c2 lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java d8c7335 lens-cube/src/test/java/org/apache/lens/cube/parse/TestVirtualFactQueries.java PRE-CREATION lens-cube/src/test/resources/schema/cubes/base/testcube2.xml PRE-CREATION lens-cube/src/test/resources/schema/cubes/base/virtualcube.xml 2a5e0b0 lens-cube/src/test/resources/schema/facts/testfact7_base.xml PRE-CREATION lens-cube/src/test/resources/schema/facts/testfact8_base.xml PRE-CREATION lens-cube/src/test/resources/schema/facts/testfact9_base.xml PRE-CREATION lens-cube/src/test/resources/schema/facts/virtual/virtualfact.xml 860965f Diff: https://reviews.apache.org/r/60115/diff/1/ Testing --- Thanks, Rajitha R
[jira] [Commented] (LENS-1437) Missing unit test cases for virtual fact
[ https://issues.apache.org/jira/browse/LENS-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16050404#comment-16050404 ] Hadoop QA commented on LENS-1437: - Applied patch: [LENS-1437.patch|https://issues.apache.org/jira/secure/attachment/12873095/LENS-1437.patch] and ran command: mvn clean install -fae. Result: Failure. Build Job: https://builds.apache.org/job/PreCommit-Lens-Build/1335/ > Missing unit test cases for virtual fact > - > > Key: LENS-1437 > URL: https://issues.apache.org/jira/browse/LENS-1437 > Project: Apache Lens > Issue Type: Task > Components: cube >Reporter: Rajitha R >Assignee: Rajitha R > Attachments: LENS-1437.patch > > > Need unit test cases for following : > 1. Virtual fact union with direct/base fact > 2. LENS-1433 > 3. Virtual fact join with Dim table -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (LENS-1439) Having clause getting skipped if query goes to a segmentation containing single segment
[
https://issues.apache.org/jira/browse/LENS-1439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16050349#comment-16050349
]
Hadoop QA commented on LENS-1439:
-
Applied patch:
[LENS-1439.01.patch|https://issues.apache.org/jira/secure/attachment/12873075/LENS-1439.01.patch]
and ran command: mvn clean install -fae. Result: Failure. Build Job:
https://builds.apache.org/job/PreCommit-Lens-Build/1334/
> Having clause getting skipped if query goes to a segmentation containing
> single segment
> ---
>
> Key: LENS-1439
> URL: https://issues.apache.org/jira/browse/LENS-1439
> Project: Apache Lens
> Issue Type: Bug
> Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1439.01.patch
>
>
> The condition of {{setHaving(null)}} is wrong in singleCandidatehqlcontext
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
Review Request 60115: Unit test cases for Virtual fact
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60115/ --- Review request for lens and Amareshwari Sriramadasu. Repository: lens Description --- Unit test cases for Virtual fact Diffs - lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 48869c2 lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java d8c7335 lens-cube/src/test/java/org/apache/lens/cube/parse/TestVirtualFactQueries.java PRE-CREATION lens-cube/src/test/resources/schema/cubes/base/testcube2.xml PRE-CREATION lens-cube/src/test/resources/schema/cubes/base/virtualcube.xml 2a5e0b0 lens-cube/src/test/resources/schema/facts/testfact7_base.xml PRE-CREATION lens-cube/src/test/resources/schema/facts/testfact8_base.xml PRE-CREATION lens-cube/src/test/resources/schema/facts/testfact9_base.xml PRE-CREATION lens-cube/src/test/resources/schema/facts/virtual/virtualfact.xml 860965f Diff: https://reviews.apache.org/r/60115/diff/1/ Testing --- Thanks, Rajitha R
[jira] [Updated] (LENS-1437) Missing unit test cases for virtual fact
[ https://issues.apache.org/jira/browse/LENS-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajitha R updated LENS-1437: Status: Patch Available (was: Open) > Missing unit test cases for virtual fact > - > > Key: LENS-1437 > URL: https://issues.apache.org/jira/browse/LENS-1437 > Project: Apache Lens > Issue Type: Task > Components: cube >Reporter: Rajitha R >Assignee: Rajitha R > Attachments: LENS-1437.patch > > > Need unit test cases for following : > 1. Virtual fact union with direct/base fact > 2. LENS-1433 > 3. Virtual fact join with Dim table -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (LENS-1437) Missing unit test cases for virtual fact
[ https://issues.apache.org/jira/browse/LENS-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajitha R updated LENS-1437: Attachment: LENS-1437.patch > Missing unit test cases for virtual fact > - > > Key: LENS-1437 > URL: https://issues.apache.org/jira/browse/LENS-1437 > Project: Apache Lens > Issue Type: Task > Components: cube >Reporter: Rajitha R >Assignee: Rajitha R > Attachments: LENS-1437.patch > > > Need unit test cases for following : > 1. Virtual fact union with direct/base fact > 2. LENS-1433 > 3. Virtual fact join with Dim table -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (LENS-1437) Missing unit test cases for virtual fact
[ https://issues.apache.org/jira/browse/LENS-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajitha R updated LENS-1437: Description: Need unit test cases for following : 1. Virtual fact union with direct/base fact 2. LENS-1433 3. Virtual fact join with Dim table was: Need unit test cases for following : 1. Virtual fact union with another virtual fact 2. Virtual fact union with direct/base fact 3. LENS-1433 4. Virtual fact join with Dim table > Missing unit test cases for virtual fact > - > > Key: LENS-1437 > URL: https://issues.apache.org/jira/browse/LENS-1437 > Project: Apache Lens > Issue Type: Task > Components: cube >Reporter: Rajitha R >Assignee: Rajitha R > > Need unit test cases for following : > 1. Virtual fact union with direct/base fact > 2. LENS-1433 > 3. Virtual fact join with Dim table -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (LENS-1439) Having clause getting skipped if query goes to a segmentation containing single segment
[
https://issues.apache.org/jira/browse/LENS-1439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rajat Khandelwal updated LENS-1439:
---
Attachment: LENS-1439.01.patch
> Having clause getting skipped if query goes to a segmentation containing
> single segment
> ---
>
> Key: LENS-1439
> URL: https://issues.apache.org/jira/browse/LENS-1439
> Project: Apache Lens
> Issue Type: Bug
> Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1439.01.patch
>
>
> The condition of {{setHaving(null)}} is wrong in singleCandidatehqlcontext
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (LENS-1439) Having clause getting skipped if query goes to a segmentation containing single segment
[
https://issues.apache.org/jira/browse/LENS-1439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16050117#comment-16050117
]
Rajat Khandelwal commented on LENS-1439:
Taking patch from reviewboard and attaching
> Having clause getting skipped if query goes to a segmentation containing
> single segment
> ---
>
> Key: LENS-1439
> URL: https://issues.apache.org/jira/browse/LENS-1439
> Project: Apache Lens
> Issue Type: Bug
> Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1439.01.patch
>
>
> The condition of {{setHaving(null)}} is wrong in singleCandidatehqlcontext
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (LENS-1439) Having clause getting skipped if query goes to a segmentation containing single segment
[
https://issues.apache.org/jira/browse/LENS-1439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rajat Khandelwal updated LENS-1439:
---
Status: Patch Available (was: In Progress)
> Having clause getting skipped if query goes to a segmentation containing
> single segment
> ---
>
> Key: LENS-1439
> URL: https://issues.apache.org/jira/browse/LENS-1439
> Project: Apache Lens
> Issue Type: Bug
> Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1439.01.patch
>
>
> The condition of {{setHaving(null)}} is wrong in singleCandidatehqlcontext
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (LENS-1439) Having clause getting skipped if query goes to a segmentation containing single segment
[
https://issues.apache.org/jira/browse/LENS-1439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16050116#comment-16050116
]
Rajat Khandelwal commented on LENS-1439:
Created https://reviews.apache.org/r/60111/
> Having clause getting skipped if query goes to a segmentation containing
> single segment
> ---
>
> Key: LENS-1439
> URL: https://issues.apache.org/jira/browse/LENS-1439
> Project: Apache Lens
> Issue Type: Bug
> Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
>
> The condition of {{setHaving(null)}} is wrong in singleCandidatehqlcontext
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Work started] (LENS-1439) Having clause getting skipped if query goes to a segmentation containing single segment
[
https://issues.apache.org/jira/browse/LENS-1439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on LENS-1439 started by Rajat Khandelwal.
--
> Having clause getting skipped if query goes to a segmentation containing
> single segment
> ---
>
> Key: LENS-1439
> URL: https://issues.apache.org/jira/browse/LENS-1439
> Project: Apache Lens
> Issue Type: Bug
> Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
>
> The condition of {{setHaving(null)}} is wrong in singleCandidatehqlcontext
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
Review Request 60111: LENS-1439: Having clause getting skipped if query goes to a segmentation containing single segment
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60111/
---
Review request for lens.
Bugs: LENS-1439
https://issues.apache.org/jira/browse/LENS-1439
Repository: lens
Description
---
The condition of {{setHaving(null)}} is wrong in singleCandidatehqlcontext
Diffs
-
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidateHQLContext.java
cca39c07a067b5bd646609f02e966ac5ef37e6aa
Diff: https://reviews.apache.org/r/60111/diff/1/
Testing
---
Thanks,
Rajat Khandelwal
[jira] [Created] (LENS-1439) Having clause getting skipped if query goes to a segmentation containing single segment
Rajat Khandelwal created LENS-1439:
--
Summary: Having clause getting skipped if query goes to a
segmentation containing single segment
Key: LENS-1439
URL: https://issues.apache.org/jira/browse/LENS-1439
Project: Apache Lens
Issue Type: Bug
Components: cube
Reporter: Rajat Khandelwal
Assignee: Rajat Khandelwal
The condition of {{setHaving(null)}} is wrong in singleCandidatehqlcontext
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
