[jira] [Commented] (LENS-1455) Getting expression ast to generate default expression should consider all expression contexts

2017-07-19 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/LENS-1455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16093247#comment-16093247
 ] 

Hadoop QA commented on LENS-1455:
-

Applied patch: 
[LENS-1455.01.patch|https://issues.apache.org/jira/secure/attachment/12878006/LENS-1455.01.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1367/

> Getting expression ast to generate default expression should consider all 
> expression contexts
> -
>
> Key: LENS-1455
> URL: https://issues.apache.org/jira/browse/LENS-1455
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1455.01.patch
>
>
> in case an expression is answered from a segmentation, the default expression 
> can't be generated. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (LENS-1455) Getting expression ast to generate default expression should consider all expression contexts

2017-07-19 Thread Rajat Khandelwal (JIRA)

 [ 
https://issues.apache.org/jira/browse/LENS-1455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-1455:
---
Attachment: LENS-1455.01.patch

> Getting expression ast to generate default expression should consider all 
> expression contexts
> -
>
> Key: LENS-1455
> URL: https://issues.apache.org/jira/browse/LENS-1455
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1455.01.patch
>
>
> in case an expression is answered from a segmentation, the default expression 
> can't be generated. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (LENS-1455) Getting expression ast to generate default expression should consider all expression contexts

2017-07-19 Thread Rajat Khandelwal (JIRA)

[ 
https://issues.apache.org/jira/browse/LENS-1455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16093238#comment-16093238
 ] 

Rajat Khandelwal commented on LENS-1455:


Taking patch from reviewboard and attaching

> Getting expression ast to generate default expression should consider all 
> expression contexts
> -
>
> Key: LENS-1455
> URL: https://issues.apache.org/jira/browse/LENS-1455
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1455.01.patch
>
>
> in case an expression is answered from a segmentation, the default expression 
> can't be generated. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (LENS-1455) Getting expression ast to generate default expression should consider all expression contexts

2017-07-19 Thread Rajat Khandelwal (JIRA)

 [ 
https://issues.apache.org/jira/browse/LENS-1455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-1455:
---
Status: Patch Available  (was: In Progress)

> Getting expression ast to generate default expression should consider all 
> expression contexts
> -
>
> Key: LENS-1455
> URL: https://issues.apache.org/jira/browse/LENS-1455
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1455.01.patch
>
>
> in case an expression is answered from a segmentation, the default expression 
> can't be generated. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Work started] (LENS-1455) Getting expression ast to generate default expression should consider all expression contexts

2017-07-19 Thread Rajat Khandelwal (JIRA)

 [ 
https://issues.apache.org/jira/browse/LENS-1455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on LENS-1455 started by Rajat Khandelwal.
--
> Getting expression ast to generate default expression should consider all 
> expression contexts
> -
>
> Key: LENS-1455
> URL: https://issues.apache.org/jira/browse/LENS-1455
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
>
> in case an expression is answered from a segmentation, the default expression 
> can't be generated. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


Review Request 60973: LENS-1455: Getting expression ast to generate default expression should consider all expression contexts

2017-07-19 Thread Rajat Khandelwal

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60973/
---

Review request for lens.


Bugs: LENS-1455
https://issues.apache.org/jira/browse/LENS-1455


Repository: lens


Description
---

in case an expression is answered from a segmentation, the default expression 
can't be generated.


Diffs
-

  lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 
66b043e51b1a838139090e851d62dcb249fab382 


Diff: https://reviews.apache.org/r/60973/diff/1/


Testing
---


Thanks,

Rajat Khandelwal



[jira] [Commented] (LENS-1454) Time Covering set algorithm is skipping some combinations

2017-07-19 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/LENS-1454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16093153#comment-16093153
 ] 

Hadoop QA commented on LENS-1454:
-

Applied patch: 
[LENS-1454.01.patch|https://issues.apache.org/jira/secure/attachment/12877973/LENS-1454.01.patch]
 and ran command: mvn clean install -fae. Result: Success. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1366/

> Time Covering set algorithm is skipping some combinations
> -
>
> Key: LENS-1454
> URL: https://issues.apache.org/jira/browse/LENS-1454
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1454.01.patch
>
>
> The current algorithm is incomplete. Will attach a patch. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (LENS-1454) Time Covering set algorithm is skipping some combinations

2017-07-19 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/LENS-1454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16092994#comment-16092994
 ] 

Hadoop QA commented on LENS-1454:
-

Applied patch: 
[LENS-1454.01.patch|https://issues.apache.org/jira/secure/attachment/12877973/LENS-1454.01.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1365/

> Time Covering set algorithm is skipping some combinations
> -
>
> Key: LENS-1454
> URL: https://issues.apache.org/jira/browse/LENS-1454
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1454.01.patch
>
>
> The current algorithm is incomplete. Will attach a patch. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (LENS-1454) Time Covering set algorithm is skipping some combinations

2017-07-19 Thread Rajat Khandelwal (JIRA)

 [ 
https://issues.apache.org/jira/browse/LENS-1454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-1454:
---
Status: Patch Available  (was: In Progress)

> Time Covering set algorithm is skipping some combinations
> -
>
> Key: LENS-1454
> URL: https://issues.apache.org/jira/browse/LENS-1454
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1454.01.patch
>
>
> The current algorithm is incomplete. Will attach a patch. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (LENS-1454) Time Covering set algorithm is skipping some combinations

2017-07-19 Thread Rajat Khandelwal (JIRA)

[ 
https://issues.apache.org/jira/browse/LENS-1454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16092966#comment-16092966
 ] 

Rajat Khandelwal commented on LENS-1454:


Taking patch from reviewboard and attaching

> Time Covering set algorithm is skipping some combinations
> -
>
> Key: LENS-1454
> URL: https://issues.apache.org/jira/browse/LENS-1454
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1454.01.patch
>
>
> The current algorithm is incomplete. Will attach a patch. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (LENS-1453) Method metrics names duplicate for segmentation inner rewrite

2017-07-19 Thread Rajat Khandelwal (JIRA)

[ 
https://issues.apache.org/jira/browse/LENS-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16092925#comment-16092925
 ] 

Rajat Khandelwal commented on LENS-1453:


Created https://reviews.apache.org/r/60964/

> Method metrics names duplicate for segmentation inner rewrite
> -
>
> Key: LENS-1453
> URL: https://issues.apache.org/jira/browse/LENS-1453
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1453.01.patch
>
>
> {noformat}
> java.lang.IllegalArgumentException: A metric named 
> lens.MethodMetricGauge.9a18f287-a40f-4108-b499-932c3edf6eaa-hive/prod-org.apache.lens.cube.parse.ColumnResolver-ITER-0
>  already exists
>   at com.codahale.metrics.MetricRegistry.register(MetricRegistry.java:91) 
> ~[metrics-core-3.0.2.jar:3.0.2]
>   at 
> org.apache.lens.server.api.metrics.MethodMetricGauge.markSuccess(MethodMetricGauge.java:61)
>  ~[lens-server-api-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
>   at 
> org.apache.lens.cube.parse.CubeQueryRewriter.rewrite(CubeQueryRewriter.java:264)
>  ~[lens-cube-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
>   at 
> org.apache.lens.cube.parse.CubeQueryRewriter.rewrite(CubeQueryRewriter.java:232)
>  ~[lens-cube-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
>   at 
> org.apache.lens.cube.parse.SegmentationCandidate.rewriteInternal(SegmentationCandidate.java:145)
>  ~[lens-cube-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
>   at 
> org.apache.lens.cube.parse.SegmentationInnerRewriter$Exploder.shouldBeRemoved(SegmentationInnerRewriter.java:57)
>  ~[lens-cube-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
>   at 
> org.apache.lens.cube.parse.SegmentationInnerRewriter$Exploder.access$300(SegmentationInnerRewriter.java:49)
>  ~[lens-cube-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
>   at 
> org.apache.lens.cube.parse.SegmentationInnerRewriter.lambda$rewriteContext$0(SegmentationInnerRewriter.java:46)
>  ~[lens-cube-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
>   at 
> org.apache.lens.cube.parse.SegmentationInnerRewriter$$Lambda$82/1668365591.test(Unknown
>  Source) ~[na:na]
>   at java.util.Collection.removeIf(Collection.java:414) ~[na:1.8.0_40]
>   at 
> org.apache.lens.cube.parse.SegmentationInnerRewriter.rewriteContext(SegmentationInnerRewriter.java:46)
>  ~[lens-cube-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
>   at 
> org.apache.lens.cube.parse.CubeQueryRewriter.rewrite(CubeQueryRewriter.java:263)
>  ~[lens-cube-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
>   at 
> org.apache.lens.cube.parse.CubeQueryRewriter.rewrite(CubeQueryRewriter.java:232)
>  ~[lens-cube-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
>   at 
> org.apache.lens.cube.parse.CubeQueryRewriter.rewrite(CubeQueryRewriter.java:248)
>  ~[lens-cube-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
>   at 
> org.apache.lens.server.rewrite.RewriteUtil$DriverRewriterRunnable.run(RewriteUtil.java:392)
>  ~[classes/:na]
>   at 
> org.apache.lens.server.query.QueryExecutionServiceImpl$RewriteEstimateRunnable.run(QueryExecutionServiceImpl.java:1855)
>  [classes/:na]
>   at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) 
> [na:1.8.0_40]
>   at java.util.concurrent.FutureTask.run(FutureTask.java:266) 
> [na:1.8.0_40]
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>  [na:1.8.0_40]
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>  [na:1.8.0_40]
>   at java.lang.Thread.run(Thread.java:745) [na:1.8.0_40]
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (LENS-1453) Method metrics names duplicate for segmentation inner rewrite

2017-07-19 Thread Rajat Khandelwal (JIRA)
Rajat Khandelwal created LENS-1453:
--

 Summary: Method metrics names duplicate for segmentation inner 
rewrite
 Key: LENS-1453
 URL: https://issues.apache.org/jira/browse/LENS-1453
 Project: Apache Lens
  Issue Type: Bug
  Components: cube
Reporter: Rajat Khandelwal
Assignee: Rajat Khandelwal


{noformat}
java.lang.IllegalArgumentException: A metric named 
lens.MethodMetricGauge.9a18f287-a40f-4108-b499-932c3edf6eaa-hive/prod-org.apache.lens.cube.parse.ColumnResolver-ITER-0
 already exists
at com.codahale.metrics.MetricRegistry.register(MetricRegistry.java:91) 
~[metrics-core-3.0.2.jar:3.0.2]
at 
org.apache.lens.server.api.metrics.MethodMetricGauge.markSuccess(MethodMetricGauge.java:61)
 ~[lens-server-api-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
at 
org.apache.lens.cube.parse.CubeQueryRewriter.rewrite(CubeQueryRewriter.java:264)
 ~[lens-cube-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
at 
org.apache.lens.cube.parse.CubeQueryRewriter.rewrite(CubeQueryRewriter.java:232)
 ~[lens-cube-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
at 
org.apache.lens.cube.parse.SegmentationCandidate.rewriteInternal(SegmentationCandidate.java:145)
 ~[lens-cube-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
at 
org.apache.lens.cube.parse.SegmentationInnerRewriter$Exploder.shouldBeRemoved(SegmentationInnerRewriter.java:57)
 ~[lens-cube-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
at 
org.apache.lens.cube.parse.SegmentationInnerRewriter$Exploder.access$300(SegmentationInnerRewriter.java:49)
 ~[lens-cube-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
at 
org.apache.lens.cube.parse.SegmentationInnerRewriter.lambda$rewriteContext$0(SegmentationInnerRewriter.java:46)
 ~[lens-cube-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
at 
org.apache.lens.cube.parse.SegmentationInnerRewriter$$Lambda$82/1668365591.test(Unknown
 Source) ~[na:na]
at java.util.Collection.removeIf(Collection.java:414) ~[na:1.8.0_40]
at 
org.apache.lens.cube.parse.SegmentationInnerRewriter.rewriteContext(SegmentationInnerRewriter.java:46)
 ~[lens-cube-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
at 
org.apache.lens.cube.parse.CubeQueryRewriter.rewrite(CubeQueryRewriter.java:263)
 ~[lens-cube-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
at 
org.apache.lens.cube.parse.CubeQueryRewriter.rewrite(CubeQueryRewriter.java:232)
 ~[lens-cube-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
at 
org.apache.lens.cube.parse.CubeQueryRewriter.rewrite(CubeQueryRewriter.java:248)
 ~[lens-cube-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
at 
org.apache.lens.server.rewrite.RewriteUtil$DriverRewriterRunnable.run(RewriteUtil.java:392)
 ~[classes/:na]
at 
org.apache.lens.server.query.QueryExecutionServiceImpl$RewriteEstimateRunnable.run(QueryExecutionServiceImpl.java:1855)
 [classes/:na]
at 
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) 
[na:1.8.0_40]
at java.util.concurrent.FutureTask.run(FutureTask.java:266) 
[na:1.8.0_40]
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) 
[na:1.8.0_40]
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) 
[na:1.8.0_40]
at java.lang.Thread.run(Thread.java:745) [na:1.8.0_40]

{noformat}




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)