Re: Review Request 61938: Fix for time_range_in clause not resolving in rewrite

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61938/#review184022
---



Can you add a testcase?


lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java
Line 936 (original), 936 (patched)


Line above is truncating partitions, isnt get Partitions here empty always?


- Amareshwari Sriramadasu


On Aug. 28, 2017, 11:38 a.m., Rajitha R wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61938/
> ---
> 
> (Updated Aug. 28, 2017, 11:38 a.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Fix for time_range_in clause not resolving in rewrite
> 
> 
> Diffs
> -
> 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 
> 2b1add3 
> 
> 
> Diff: https://reviews.apache.org/r/61938/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajitha R
> 
>

[jira] [Commented] (LENS-1465) Sync queries blocking threads

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143829#comment-16143829
 ] 

Hadoop QA commented on LENS-1465:
-

Applied patch: 
[LENS-1465.01.patch|https://issues.apache.org/jira/secure/attachment/12884027/LENS-1465.01.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1393/

> Sync queries blocking threads
> -
>
> Key: LENS-1465
> URL: https://issues.apache.org/jira/browse/LENS-1465
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1465.01.patch
>
>
> Sync queries taking more time than timeout are blocking threads due to a 
> deadlock. Each sync query is blocking one thread from jdbc execution pool and 
> one thread from query completion pool. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LENS-1467) CubeQueryContext.getAllFilters is returning incorrect list of filters in case there is an "OR" in the filters

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143809#comment-16143809
 ] 

Hadoop QA commented on LENS-1467:
-

Applied patch: 
[LENS-1467.01.patch|https://issues.apache.org/jira/secure/attachment/12884052/LENS-1467.01.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1395/

> CubeQueryContext.getAllFilters is returning incorrect list of filters in case 
> there is an "OR" in the filters
> -
>
> Key: LENS-1467
> URL: https://issues.apache.org/jira/browse/LENS-1467
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1467.01.patch
>
>
> "a and (b or c)" is converted to ["a", "b", "c"] which are then ANDed 
> together, which is wrong. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LENS-1464) One or two queued queries failing with ConcurrentModificationException on restart

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143807#comment-16143807
 ] 

Hadoop QA commented on LENS-1464:
-

Applied patch: 
[LENS-1464.02.patch|https://issues.apache.org/jira/secure/attachment/12884043/LENS-1464.02.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1394/

> One or two queued queries failing with ConcurrentModificationException on 
> restart 
> --
>
> Key: LENS-1464
> URL: https://issues.apache.org/jira/browse/LENS-1464
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1464.01.patch, LENS-1464.02.patch
>
>
> Happens because of synchronizations issues. If two queries are simultaneously 
> launching, both try to add resources to hive driver. One of those queries can 
> fail then. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Work started] (LENS-1467) CubeQueryContext.getAllFilters is returning incorrect list of filters in case there is an "OR" in the filters

[Rajat Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on LENS-1467 started by Rajat Khandelwal.
--
> CubeQueryContext.getAllFilters is returning incorrect list of filters in case 
> there is an "OR" in the filters
> -
>
> Key: LENS-1467
> URL: https://issues.apache.org/jira/browse/LENS-1467
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1467.01.patch
>
>
> "a and (b or c)" is converted to ["a", "b", "c"] which are then ANDed 
> together, which is wrong. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LENS-1467) CubeQueryContext.getAllFilters is returning incorrect list of filters in case there is an "OR" in the filters

[Rajat Khandelwal (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143796#comment-16143796
 ] 

Rajat Khandelwal commented on LENS-1467:


Taking patch from reviewboard and attaching

> CubeQueryContext.getAllFilters is returning incorrect list of filters in case 
> there is an "OR" in the filters
> -
>
> Key: LENS-1467
> URL: https://issues.apache.org/jira/browse/LENS-1467
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1467.01.patch
>
>
> "a and (b or c)" is converted to ["a", "b", "c"] which are then ANDed 
> together, which is wrong. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LENS-1467) CubeQueryContext.getAllFilters is returning incorrect list of filters in case there is an "OR" in the filters

[Rajat Khandelwal (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143794#comment-16143794
 ] 

Rajat Khandelwal commented on LENS-1467:


Created https://reviews.apache.org/r/61942/

> CubeQueryContext.getAllFilters is returning incorrect list of filters in case 
> there is an "OR" in the filters
> -
>
> Key: LENS-1467
> URL: https://issues.apache.org/jira/browse/LENS-1467
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1467.01.patch
>
>
> "a and (b or c)" is converted to ["a", "b", "c"] which are then ANDed 
> together, which is wrong. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (LENS-1467) CubeQueryContext.getAllFilters is returning incorrect list of filters in case there is an "OR" in the filters

[Rajat Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-1467:
---
Attachment: LENS-1467.01.patch

> CubeQueryContext.getAllFilters is returning incorrect list of filters in case 
> there is an "OR" in the filters
> -
>
> Key: LENS-1467
> URL: https://issues.apache.org/jira/browse/LENS-1467
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1467.01.patch
>
>
> "a and (b or c)" is converted to ["a", "b", "c"] which are then ANDed 
> together, which is wrong. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Review Request 61942: LENS-1467: CubeQueryContext.getAllFilters is returning incorrect list of filters in case there is an "OR" in the filters

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61942/
---

Review request for lens.


Bugs: LENS-1467
https://issues.apache.org/jira/browse/LENS-1467


Repository: lens


Description
---

"a and (b or c)" is converted to ["a", "b", "c"] which are then ANDed together, 
which is wrong.


Diffs
-

  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 
8b9583aa62ce3fc0ed94b2b849f12ee48fa16a9b 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidateHQLContext.java
 494b08e3b04bcdfea3de449f3740589cc481ba38 
  lens-cube/src/main/java/org/apache/lens/cube/parse/join/JoinClause.java 
866149641fbc2d00263fbe9679b1e89f5325e601 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeQueryContextTest.java 
PRE-CREATION 


Diff: https://reviews.apache.org/r/61942/diff/1/


Testing
---


Thanks,

Rajat Khandelwal

[jira] [Created] (LENS-1467) CubeQueryContext.getAllFilters is returning incorrect list of filters in case there is an "OR" in the filters

[Rajat Khandelwal (JIRA)]

Rajat Khandelwal created LENS-1467:
--

 Summary: CubeQueryContext.getAllFilters is returning incorrect 
list of filters in case there is an "OR" in the filters
 Key: LENS-1467
 URL: https://issues.apache.org/jira/browse/LENS-1467
 Project: Apache Lens
  Issue Type: Bug
  Components: cube
Reporter: Rajat Khandelwal
Assignee: Rajat Khandelwal


"a and (b or c)" is converted to ["a", "b", "c"] which are then ANDed together, 
which is wrong. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LENS-1464) One or two queued queries failing with ConcurrentModificationException on restart

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143755#comment-16143755
 ] 

Hadoop QA commented on LENS-1464:
-

Applied patch: 
[LENS-1464.02.patch|https://issues.apache.org/jira/secure/attachment/12884043/LENS-1464.02.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1392/

> One or two queued queries failing with ConcurrentModificationException on 
> restart 
> --
>
> Key: LENS-1464
> URL: https://issues.apache.org/jira/browse/LENS-1464
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1464.01.patch, LENS-1464.02.patch
>
>
> Happens because of synchronizations issues. If two queries are simultaneously 
> launching, both try to add resources to hive driver. One of those queries can 
> fail then. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (LENS-1464) One or two queued queries failing with ConcurrentModificationException on restart

[Rajat Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-1464:
---
Attachment: LENS-1464.02.patch

> One or two queued queries failing with ConcurrentModificationException on 
> restart 
> --
>
> Key: LENS-1464
> URL: https://issues.apache.org/jira/browse/LENS-1464
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1464.01.patch, LENS-1464.02.patch
>
>
> Happens because of synchronizations issues. If two queries are simultaneously 
> launching, both try to add resources to hive driver. One of those queries can 
> fail then. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LENS-1464) One or two queued queries failing with ConcurrentModificationException on restart

[Rajat Khandelwal (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143740#comment-16143740
 ] 

Rajat Khandelwal commented on LENS-1464:


Taking patch from reviewboard and attaching

> One or two queued queries failing with ConcurrentModificationException on 
> restart 
> --
>
> Key: LENS-1464
> URL: https://issues.apache.org/jira/browse/LENS-1464
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1464.01.patch, LENS-1464.02.patch
>
>
> Happens because of synchronizations issues. If two queries are simultaneously 
> launching, both try to add resources to hive driver. One of those queries can 
> fail then. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: Review Request 61934: LENS-1464: One or two queued queries failing with ConcurrentModificationException on restart

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61934/
---

(Updated Aug. 28, 2017, 6:22 p.m.)


Review request for lens.


Bugs: LENS-1464
https://issues.apache.org/jira/browse/LENS-1464


Repository: lens


Description
---

Happens because of synchronizations issues. If two queries are simultaneously 
launching, both try to add resources to hive driver. One of those queries can 
fail then.


Diffs (updated)
-

  
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
 e70d2905a435f696f62239b1dc30eaa476dc229c 


Diff: https://reviews.apache.org/r/61934/diff/2/

Changes: https://reviews.apache.org/r/61934/diff/1-2/


Testing
---


Thanks,

Rajat Khandelwal

Re: Review Request 61934: LENS-1464: One or two queued queries failing with ConcurrentModificationException on restart

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61934/#review183920
---




lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
Line 3485 (original), 3485 (patched)


Should we do this at session level ?


- Puneet Gupta


On Aug. 28, 2017, 10:34 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61934/
> ---
> 
> (Updated Aug. 28, 2017, 10:34 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1464
> https://issues.apache.org/jira/browse/LENS-1464
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Happens because of synchronizations issues. If two queries are simultaneously 
> launching, both try to add resources to hive driver. One of those queries can 
> fail then.
> 
> 
> Diffs
> -
> 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
>  e70d2905a435f696f62239b1dc30eaa476dc229c 
> 
> 
> Diff: https://reviews.apache.org/r/61934/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

[jira] [Commented] (LENS-1463) Valid Columns addition in Virtual Fact

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143678#comment-16143678
 ] 

Hudson commented on LENS-1463:
--

UNSTABLE: Integrated in Jenkins build Lens-Commit #1434 (See 
[https://builds.apache.org/job/Lens-Commit/1434/])
LENS-1463 : Valid Columns addition in Virtual Fact (amareshwari: rev 
b3352997ca851b6a68e7e0d57caeb514d7e134d3)
* (edit) lens-cube/src/test/resources/schema/facts/testfact9_base.xml
* (edit) 
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java
* (edit) lens-cube/src/test/resources/schema/facts/virtual/virtualfact.xml
* (edit) 
lens-cube/src/test/java/org/apache/lens/cube/parse/TestVirtualFactQueries.java
* (edit) lens-cube/src/test/resources/schema/cubes/base/testcube2.xml


> Valid Columns addition in Virtual Fact 
> ---
>
> Key: LENS-1463
> URL: https://issues.apache.org/jira/browse/LENS-1463
> Project: Apache Lens
>  Issue Type: Task
>  Components: server
>Reporter: Rajitha R
>Assignee: Rajitha R
> Fix For: 2.8
>
> Attachments: LENS-1463.patch
>
>
> This feature would allow virtual fact to override valid columns of its 
> base/source fact.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (LENS-1466) Rewritten queries not resolving time_range_in clause

[Rajitha R (JIRA)]

Rajitha R created LENS-1466:
---

 Summary: Rewritten queries not resolving time_range_in clause
 Key: LENS-1466
 URL: https://issues.apache.org/jira/browse/LENS-1466
 Project: Apache Lens
  Issue Type: Bug
  Components: cube
Reporter: Rajitha R
Assignee: Rajitha R


Few Queries with look ahead are not resolving time_range_in clause. This is 
causing queries to fail on jdbc.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: Review Request 61936: LENS-1465: Sync queries blocking threads

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61936/#review183914
---


Ship it!




Ship It!

- Puneet Gupta


On Aug. 28, 2017, 10:46 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61936/
> ---
> 
> (Updated Aug. 28, 2017, 10:46 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1465
> https://issues.apache.org/jira/browse/LENS-1465
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Sync queries taking more time than timeout are blocking threads due to a 
> deadlock. Each sync query is blocking one thread from jdbc execution pool and 
> one thread from query completion pool.
> 
> 
> Diffs
> -
> 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
>  466fb25992dd3aa89813fe0bbd6aa65bead4d375 
> 
> 
> Diff: https://reviews.apache.org/r/61936/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

[jira] [Updated] (LENS-1463) Valid Columns addition in Virtual Fact

[Amareshwari Sriramadasu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-1463:
--
   Resolution: Fixed
Fix Version/s: 2.8
   Status: Resolved  (was: Patch Available)

Committed. Thanks [~rajitha.r]

> Valid Columns addition in Virtual Fact 
> ---
>
> Key: LENS-1463
> URL: https://issues.apache.org/jira/browse/LENS-1463
> Project: Apache Lens
>  Issue Type: Task
>  Components: server
>Reporter: Rajitha R
>Assignee: Rajitha R
> Fix For: 2.8
>
> Attachments: LENS-1463.patch
>
>
> This feature would allow virtual fact to override valid columns of its 
> base/source fact.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LENS-1463) Valid Columns addition in Virtual Fact

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143641#comment-16143641
 ] 

Hadoop QA commented on LENS-1463:
-

Applied patch: 
[LENS-1463.patch|https://issues.apache.org/jira/secure/attachment/12883500/LENS-1463.patch]
 and ran command: mvn clean install -fae. Result: Success. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1389/

> Valid Columns addition in Virtual Fact 
> ---
>
> Key: LENS-1463
> URL: https://issues.apache.org/jira/browse/LENS-1463
> Project: Apache Lens
>  Issue Type: Task
>  Components: server
>Reporter: Rajitha R
>Assignee: Rajitha R
> Attachments: LENS-1463.patch
>
>
> This feature would allow virtual fact to override valid columns of its 
> base/source fact.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LENS-1465) Sync queries blocking threads

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143634#comment-16143634
 ] 

Hadoop QA commented on LENS-1465:
-

Applied patch: 
[LENS-1465.01.patch|https://issues.apache.org/jira/secure/attachment/12884027/LENS-1465.01.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1391/

> Sync queries blocking threads
> -
>
> Key: LENS-1465
> URL: https://issues.apache.org/jira/browse/LENS-1465
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1465.01.patch
>
>
> Sync queries taking more time than timeout are blocking threads due to a 
> deadlock. Each sync query is blocking one thread from jdbc execution pool and 
> one thread from query completion pool. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LENS-1465) Sync queries blocking threads

[Rajat Khandelwal (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143629#comment-16143629
 ] 

Rajat Khandelwal commented on LENS-1465:


Taking patch from reviewboard and attaching

> Sync queries blocking threads
> -
>
> Key: LENS-1465
> URL: https://issues.apache.org/jira/browse/LENS-1465
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1465.01.patch
>
>
> Sync queries taking more time than timeout are blocking threads due to a 
> deadlock. Each sync query is blocking one thread from jdbc execution pool and 
> one thread from query completion pool. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (LENS-1465) Sync queries blocking threads

[Rajat Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-1465:
---
Status: Patch Available  (was: In Progress)

> Sync queries blocking threads
> -
>
> Key: LENS-1465
> URL: https://issues.apache.org/jira/browse/LENS-1465
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1465.01.patch
>
>
> Sync queries taking more time than timeout are blocking threads due to a 
> deadlock. Each sync query is blocking one thread from jdbc execution pool and 
> one thread from query completion pool. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (LENS-1465) Sync queries blocking threads

[Rajat Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-1465:
---
Attachment: LENS-1465.01.patch

> Sync queries blocking threads
> -
>
> Key: LENS-1465
> URL: https://issues.apache.org/jira/browse/LENS-1465
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1465.01.patch
>
>
> Sync queries taking more time than timeout are blocking threads due to a 
> deadlock. Each sync query is blocking one thread from jdbc execution pool and 
> one thread from query completion pool. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Work started] (LENS-1465) Sync queries blocking threads

[Rajat Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on LENS-1465 started by Rajat Khandelwal.
--
> Sync queries blocking threads
> -
>
> Key: LENS-1465
> URL: https://issues.apache.org/jira/browse/LENS-1465
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
>
> Sync queries taking more time than timeout are blocking threads due to a 
> deadlock. Each sync query is blocking one thread from jdbc execution pool and 
> one thread from query completion pool. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LENS-1465) Sync queries blocking threads

[Rajat Khandelwal (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143627#comment-16143627
 ] 

Rajat Khandelwal commented on LENS-1465:


Created https://reviews.apache.org/r/61936/

> Sync queries blocking threads
> -
>
> Key: LENS-1465
> URL: https://issues.apache.org/jira/browse/LENS-1465
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
>
> Sync queries taking more time than timeout are blocking threads due to a 
> deadlock. Each sync query is blocking one thread from jdbc execution pool and 
> one thread from query completion pool. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Review Request 61936: LENS-1465: Sync queries blocking threads

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61936/
---

Review request for lens.


Bugs: LENS-1465
https://issues.apache.org/jira/browse/LENS-1465


Repository: lens


Description
---

Sync queries taking more time than timeout are blocking threads due to a 
deadlock. Each sync query is blocking one thread from jdbc execution pool and 
one thread from query completion pool.


Diffs
-

  
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
 466fb25992dd3aa89813fe0bbd6aa65bead4d375 


Diff: https://reviews.apache.org/r/61936/diff/1/


Testing
---


Thanks,

Rajat Khandelwal

Re: Review Request 61683: LENS-1439: Having clause getting skipped if query goes to a segmentation containing single segment

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61683/#review183913
---


Ship it!




Ship It!

- Amareshwari Sriramadasu


On Aug. 21, 2017, 8:23 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61683/
> ---
> 
> (Updated Aug. 21, 2017, 8:23 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1439
> https://issues.apache.org/jira/browse/LENS-1439
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> The condition of {{setHaving(null)}} is wrong in singleCandidatehqlcontext
> 
> 
> Diffs
> -
> 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidateHQLContext.java
>  494b08e3b04bcdfea3de449f3740589cc481ba38 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeSegmentationRewriter.java
>  7e1714bc301a748bf2c49dc9a707c1072c36f66b 
>   lens-cube/src/test/resources/schema/cubes/derived/union_join_ctx_der1.xml 
> c23a029b80ab4342e130d4778eb84559c6806b7e 
> 
> 
> Diff: https://reviews.apache.org/r/61683/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

[jira] [Commented] (LENS-1464) One or two queued queries failing with ConcurrentModificationException on restart

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143622#comment-16143622
 ] 

Hadoop QA commented on LENS-1464:
-

Applied patch: 
[LENS-1464.01.patch|https://issues.apache.org/jira/secure/attachment/12884026/LENS-1464.01.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1390/

> One or two queued queries failing with ConcurrentModificationException on 
> restart 
> --
>
> Key: LENS-1464
> URL: https://issues.apache.org/jira/browse/LENS-1464
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1464.01.patch
>
>
> Happens because of synchronizations issues. If two queries are simultaneously 
> launching, both try to add resources to hive driver. One of those queries can 
> fail then. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (LENS-1465) Sync queries blocking threads

[Rajat Khandelwal (JIRA)]

Rajat Khandelwal created LENS-1465:
--

 Summary: Sync queries blocking threads
 Key: LENS-1465
 URL: https://issues.apache.org/jira/browse/LENS-1465
 Project: Apache Lens
  Issue Type: Bug
  Components: server
Reporter: Rajat Khandelwal
Assignee: Rajat Khandelwal


Sync queries taking more time than timeout are blocking threads due to a 
deadlock. Each sync query is blocking one thread from jdbc execution pool and 
one thread from query completion pool. 




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: Review Request 61881: Lens-1461:Lens services state are not persisted correctly

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61881/#review183912
---




lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
Lines 428 (patched)


ClientError path should not come in server path. Can we avoid this?


- Amareshwari Sriramadasu


On Aug. 24, 2017, 8:11 a.m., Ankit Kailaswar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61881/
> ---
> 
> (Updated Aug. 24, 2017, 8:11 a.m.)
> 
> 
> Review request for lens and Puneet Gupta.
> 
> 
> Bugs: LENS-1461
> https://issues.apache.org/jira/browse/LENS-1461
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Persist process for Session service should not fail if any session in 
> invalid. Persist service should ignore these session and continue persisting 
> state of other session instead of failing.
> 
> 
> Diffs
> -
> 
>   
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
>  b480d14 
> 
> 
> Diff: https://reviews.apache.org/r/61881/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ankit Kailaswar
> 
>

[jira] [Updated] (LENS-1464) One or two queued queries failing with ConcurrentModificationException on restart

[Rajat Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-1464:
---
Attachment: LENS-1464.01.patch

> One or two queued queries failing with ConcurrentModificationException on 
> restart 
> --
>
> Key: LENS-1464
> URL: https://issues.apache.org/jira/browse/LENS-1464
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1464.01.patch
>
>
> Happens because of synchronizations issues. If two queries are simultaneously 
> launching, both try to add resources to hive driver. One of those queries can 
> fail then. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LENS-1464) One or two queued queries failing with ConcurrentModificationException on restart

[Rajat Khandelwal (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143612#comment-16143612
 ] 

Rajat Khandelwal commented on LENS-1464:


Created https://reviews.apache.org/r/61934/

> One or two queued queries failing with ConcurrentModificationException on 
> restart 
> --
>
> Key: LENS-1464
> URL: https://issues.apache.org/jira/browse/LENS-1464
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1464.01.patch
>
>
> Happens because of synchronizations issues. If two queries are simultaneously 
> launching, both try to add resources to hive driver. One of those queries can 
> fail then. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LENS-1464) One or two queued queries failing with ConcurrentModificationException on restart

[Rajat Khandelwal (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143613#comment-16143613
 ] 

Rajat Khandelwal commented on LENS-1464:


Taking patch from reviewboard and attaching

> One or two queued queries failing with ConcurrentModificationException on 
> restart 
> --
>
> Key: LENS-1464
> URL: https://issues.apache.org/jira/browse/LENS-1464
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1464.01.patch
>
>
> Happens because of synchronizations issues. If two queries are simultaneously 
> launching, both try to add resources to hive driver. One of those queries can 
> fail then. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Work started] (LENS-1464) One or two queued queries failing with ConcurrentModificationException on restart

[Rajat Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on LENS-1464 started by Rajat Khandelwal.
--
> One or two queued queries failing with ConcurrentModificationException on 
> restart 
> --
>
> Key: LENS-1464
> URL: https://issues.apache.org/jira/browse/LENS-1464
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1464.01.patch
>
>
> Happens because of synchronizations issues. If two queries are simultaneously 
> launching, both try to add resources to hive driver. One of those queries can 
> fail then. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (LENS-1464) One or two queued queries failing with ConcurrentModificationException on restart

[Rajat Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-1464:
---
Status: Patch Available  (was: In Progress)

> One or two queued queries failing with ConcurrentModificationException on 
> restart 
> --
>
> Key: LENS-1464
> URL: https://issues.apache.org/jira/browse/LENS-1464
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1464.01.patch
>
>
> Happens because of synchronizations issues. If two queries are simultaneously 
> launching, both try to add resources to hive driver. One of those queries can 
> fail then. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Review Request 61934: LENS-1464: One or two queued queries failing with ConcurrentModificationException on restart

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61934/
---

Review request for lens.


Bugs: LENS-1464
https://issues.apache.org/jira/browse/LENS-1464


Repository: lens


Description
---

Happens because of synchronizations issues. If two queries are simultaneously 
launching, both try to add resources to hive driver. One of those queries can 
fail then.


Diffs
-

  
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
 e70d2905a435f696f62239b1dc30eaa476dc229c 


Diff: https://reviews.apache.org/r/61934/diff/1/


Testing
---


Thanks,

Rajat Khandelwal

[jira] [Created] (LENS-1464) One or two queued queries failing with ConcurrentModificationException on restart

[Rajat Khandelwal (JIRA)]

Rajat Khandelwal created LENS-1464:
--

 Summary: One or two queued queries failing with 
ConcurrentModificationException on restart 
 Key: LENS-1464
 URL: https://issues.apache.org/jira/browse/LENS-1464
 Project: Apache Lens
  Issue Type: Bug
  Components: server
Reporter: Rajat Khandelwal
Assignee: Rajat Khandelwal


Happens because of synchronizations issues. If two queries are simultaneously 
launching, both try to add resources to hive driver. One of those queries can 
fail then. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LENS-1463) Valid Columns addition in Virtual Fact

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143593#comment-16143593
 ] 

Hadoop QA commented on LENS-1463:
-

Applied patch: 
[LENS-1463.patch|https://issues.apache.org/jira/secure/attachment/12883500/LENS-1463.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1388/

> Valid Columns addition in Virtual Fact 
> ---
>
> Key: LENS-1463
> URL: https://issues.apache.org/jira/browse/LENS-1463
> Project: Apache Lens
>  Issue Type: Task
>  Components: server
>Reporter: Rajitha R
>Assignee: Rajitha R
> Attachments: LENS-1463.patch
>
>
> This feature would allow virtual fact to override valid columns of its 
> base/source fact.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LENS-1463) Valid Columns addition in Virtual Fact

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143564#comment-16143564
 ] 

Hadoop QA commented on LENS-1463:
-

Applied patch: 
[LENS-1463.patch|https://issues.apache.org/jira/secure/attachment/12883500/LENS-1463.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1387/

> Valid Columns addition in Virtual Fact 
> ---
>
> Key: LENS-1463
> URL: https://issues.apache.org/jira/browse/LENS-1463
> Project: Apache Lens
>  Issue Type: Task
>  Components: server
>Reporter: Rajitha R
>Assignee: Rajitha R
> Attachments: LENS-1463.patch
>
>
> This feature would allow virtual fact to override valid columns of its 
> base/source fact.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LENS-1463) Valid Columns addition in Virtual Fact

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143550#comment-16143550
 ] 

Hadoop QA commented on LENS-1463:
-

Applied patch: 
[LENS-1463.patch|https://issues.apache.org/jira/secure/attachment/12883500/LENS-1463.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1386/

> Valid Columns addition in Virtual Fact 
> ---
>
> Key: LENS-1463
> URL: https://issues.apache.org/jira/browse/LENS-1463
> Project: Apache Lens
>  Issue Type: Task
>  Components: server
>Reporter: Rajitha R
>Assignee: Rajitha R
> Attachments: LENS-1463.patch
>
>
> This feature would allow virtual fact to override valid columns of its 
> base/source fact.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)