[jira] [Commented] (LENS-1472) Populate sample metastore on example db is failing

2017-09-04 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/LENS-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152637#comment-16152637
 ] 

Hadoop QA commented on LENS-1472:
-

Applied patch: 
[LENS-1472.02.patch|https://issues.apache.org/jira/secure/attachment/12885263/LENS-1472.02.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1432/

> Populate sample metastore on example db is failing
> --
>
> Key: LENS-1472
> URL: https://issues.apache.org/jira/browse/LENS-1472
> Project: Apache Lens
>  Issue Type: Bug
>  Components: examples
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1472.01.patch, LENS-1472.02.patch
>
>
> {noformat}
> Error Message: Internal Server Error.: 
> MetaException(message:file:/usr/local/lens/client/examples/data/sales_aggr_fact2_local4
>  is not a directory or unable to create one)
>   at 
> org.apache.lens.client.LensMetadataClient.translate(LensMetadataClient.java:73)
>   at 
> org.apache.lens.client.LensMetadataClient.addPartitionsToFactTable(LensMetadataClient.java:875)
>   at 
> org.apache.lens.examples.PopulateSampleMetastore.createFactPartitions(PopulateSampleMetastore.java:172)
>   at 
> org.apache.lens.examples.PopulateSampleMetastore.populateFactTables(PopulateSampleMetastore.java:196)
>   at 
> org.apache.lens.examples.PopulateSampleMetastore.populateAll(PopulateSampleMetastore.java:84)
>   at 
> org.apache.lens.examples.PopulateSampleMetastore.main(PopulateSampleMetastore.java:71)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


Re: Review Request 62063: LENS-1472: Populate sample metastore on example db is failing

2017-09-04 Thread Rajat Khandelwal

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62063/
---

(Updated Sept. 4, 2017, 7:05 p.m.)


Review request for lens.


Bugs: LENS-1472
https://issues.apache.org/jira/browse/LENS-1472


Repository: lens


Description
---

{noformat}
Error Message: Internal Server Error.: 
MetaException(message:file:/usr/local/lens/client/examples/data/sales_aggr_fact2_local4
 is not a directory or unable to create one)
at 
org.apache.lens.client.LensMetadataClient.translate(LensMetadataClient.java:73)
at 
org.apache.lens.client.LensMetadataClient.addPartitionsToFactTable(LensMetadataClient.java:875)
at 
org.apache.lens.examples.PopulateSampleMetastore.createFactPartitions(PopulateSampleMetastore.java:172)
at 
org.apache.lens.examples.PopulateSampleMetastore.populateFactTables(PopulateSampleMetastore.java:196)
at 
org.apache.lens.examples.PopulateSampleMetastore.populateAll(PopulateSampleMetastore.java:84)
at 
org.apache.lens.examples.PopulateSampleMetastore.main(PopulateSampleMetastore.java:71)
{noformat}


Diffs
-

  lens-dist/src/main/assembly/bin-dist.xml 
c3f8f17d71e52249af4859b656ec3bed07cf5fc2 
  
lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java
 4fc15a62bcea0e2e87e4b5e47adb3962aa695982 
  lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java 
e5a397b6476cea48b5646c8f376940986cb23c81 
  lens-examples/src/main/resources/sales-aggr-fact2-local4.data PRE-CREATION 


Diff: https://reviews.apache.org/r/62063/diff/2/


Testing (updated)
---

rajat.khandelwal@IM1258-X1 client :) $bin/run-examples.sh
Error: Unknown or unspecified command ''

Usage: bin/run-examples.sh sample-metastore [-db dbname] --conf 
   bin/run-examples.sh populate-metastore [-db dbname] --conf 
   bin/run-examples.sh runqueries [-db dbname] --conf 
rajat.khandelwal@IM1258-X1 client :( $bin/run-examples.sh sample-metastore -db 
blah
Created DB storages
Created sample metastore!
Database:blah
Storages:[cluster1, local, mydb]
Cubes:[sales, cube11, sample_cube, cube22, cube33]
Dimensions:[sample_dim2, city, product, sample_db_dim, interests, sample_dim, 
customer, customer_interests]
Fact tables:[sales_aggr_continuous_fact, fact2, fact1, sales_raw_fact, 
sales_aggr_fact2, sales_aggr_fact1, rawfact]
Dimension tables:[city_table, customer_interests_table, dim_table, dim_table2, 
dim_table4, dim_table3, customer_table, city_subset, product_table, 
interests_table, product_db_table]
Segmentations:[seg1]
rajat.khandelwal@IM1258-X1 client :) $bin/run-examples.sh populate-metastore 
-db blah
Added partition from:dim1-local-part.xml
Added partition from:dim2-local-part.xml
Added partition from:dim4-local-part.xml
Added partitions from:product-local-parts.xml
Added partition from:city-local-part.xml
Added partition from:customer-local-part.xml
Added partition from:customer-interests-local-part.xml
Added partition from:interests-local-part.xml
Added partition from:fact1-local-part1.xml
Added partition from:fact1-local-part2.xml
Added partition from:fact1-local-part3.xml
Added partition from:fact2-local-part1.xml
Added partition from:fact2-local-part2.xml
Added partition from:fact2-local-part3.xml
Added partition from:raw-local-part1.xml
Added partition from:raw-local-part2.xml
Added partition from:raw-local-part3.xml
Added partition from:raw-local-part4.xml
Added partition from:raw-local-part5.xml
Added partition from:raw-local-part6.xml
Added partitions from:sales-raw-local-parts.xml
Added partitions from:sales-aggr-fact1-local-parts.xml
Added partitions from:sales-aggr-fact2-local-parts.xml
Added partitions from:sales-aggr-fact1-mydb-parts.xml
Added partitions from:sales-aggr-fact2-mydb-parts.xml


Thanks,

Rajat Khandelwal



[jira] [Commented] (LENS-1471) JoinCandidate's children should not share same instance of a storage candidate

2017-09-04 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/LENS-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152621#comment-16152621
 ] 

Hadoop QA commented on LENS-1471:
-

Applied patch: 
[LENS-1471.03.patch|https://issues.apache.org/jira/secure/attachment/12885259/LENS-1471.03.patch]
 and ran command: mvn clean install -fae. Result: Success. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1430/

> JoinCandidate's children should not share same instance of a storage 
> candidate 
> ---
>
> Key: LENS-1471
> URL: https://issues.apache.org/jira/browse/LENS-1471
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1471.01.patch, LENS-1471.02.patch, 
> LENS-1471.03.patch
>
>
> The issue is in Join candidates of the kind {{Join\[Union\[a,b\]; 
> Union\[a,c\]\]}}. If the instance of {{a}} is shared in different trees of a 
> JoinCandidate, the rewritten query will be wrong. JoinCandidate's children 
> set exclusive measure phrase indices, and that is done via {{retain}} method 
> of list. So let's say union1 is answering {{\[0,1\]}} measures and union2 is 
> answering {{\[2,3\]}} measures, and since 
> {{\[0,1,2,3\].retain(\[0,1\]).retain(\[2,3\]) == \[\]}}, it ends up answering 
> no measures at all



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (LENS-1472) Populate sample metastore on example db is failing

2017-09-04 Thread Rajat Khandelwal (JIRA)

 [ 
https://issues.apache.org/jira/browse/LENS-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-1472:
---
Attachment: LENS-1472.02.patch

> Populate sample metastore on example db is failing
> --
>
> Key: LENS-1472
> URL: https://issues.apache.org/jira/browse/LENS-1472
> Project: Apache Lens
>  Issue Type: Bug
>  Components: examples
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1472.01.patch, LENS-1472.02.patch
>
>
> {noformat}
> Error Message: Internal Server Error.: 
> MetaException(message:file:/usr/local/lens/client/examples/data/sales_aggr_fact2_local4
>  is not a directory or unable to create one)
>   at 
> org.apache.lens.client.LensMetadataClient.translate(LensMetadataClient.java:73)
>   at 
> org.apache.lens.client.LensMetadataClient.addPartitionsToFactTable(LensMetadataClient.java:875)
>   at 
> org.apache.lens.examples.PopulateSampleMetastore.createFactPartitions(PopulateSampleMetastore.java:172)
>   at 
> org.apache.lens.examples.PopulateSampleMetastore.populateFactTables(PopulateSampleMetastore.java:196)
>   at 
> org.apache.lens.examples.PopulateSampleMetastore.populateAll(PopulateSampleMetastore.java:84)
>   at 
> org.apache.lens.examples.PopulateSampleMetastore.main(PopulateSampleMetastore.java:71)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (LENS-1472) Populate sample metastore on example db is failing

2017-09-04 Thread Rajat Khandelwal (JIRA)

[ 
https://issues.apache.org/jira/browse/LENS-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152619#comment-16152619
 ] 

Rajat Khandelwal commented on LENS-1472:


Taking patch from reviewboard and attaching

> Populate sample metastore on example db is failing
> --
>
> Key: LENS-1472
> URL: https://issues.apache.org/jira/browse/LENS-1472
> Project: Apache Lens
>  Issue Type: Bug
>  Components: examples
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1472.01.patch, LENS-1472.02.patch
>
>
> {noformat}
> Error Message: Internal Server Error.: 
> MetaException(message:file:/usr/local/lens/client/examples/data/sales_aggr_fact2_local4
>  is not a directory or unable to create one)
>   at 
> org.apache.lens.client.LensMetadataClient.translate(LensMetadataClient.java:73)
>   at 
> org.apache.lens.client.LensMetadataClient.addPartitionsToFactTable(LensMetadataClient.java:875)
>   at 
> org.apache.lens.examples.PopulateSampleMetastore.createFactPartitions(PopulateSampleMetastore.java:172)
>   at 
> org.apache.lens.examples.PopulateSampleMetastore.populateFactTables(PopulateSampleMetastore.java:196)
>   at 
> org.apache.lens.examples.PopulateSampleMetastore.populateAll(PopulateSampleMetastore.java:84)
>   at 
> org.apache.lens.examples.PopulateSampleMetastore.main(PopulateSampleMetastore.java:71)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


Re: Review Request 62063: LENS-1472: Populate sample metastore on example db is failing

2017-09-04 Thread Rajat Khandelwal

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62063/
---

(Updated Sept. 4, 2017, 7:01 p.m.)


Review request for lens.


Bugs: LENS-1472
https://issues.apache.org/jira/browse/LENS-1472


Repository: lens


Description
---

{noformat}
Error Message: Internal Server Error.: 
MetaException(message:file:/usr/local/lens/client/examples/data/sales_aggr_fact2_local4
 is not a directory or unable to create one)
at 
org.apache.lens.client.LensMetadataClient.translate(LensMetadataClient.java:73)
at 
org.apache.lens.client.LensMetadataClient.addPartitionsToFactTable(LensMetadataClient.java:875)
at 
org.apache.lens.examples.PopulateSampleMetastore.createFactPartitions(PopulateSampleMetastore.java:172)
at 
org.apache.lens.examples.PopulateSampleMetastore.populateFactTables(PopulateSampleMetastore.java:196)
at 
org.apache.lens.examples.PopulateSampleMetastore.populateAll(PopulateSampleMetastore.java:84)
at 
org.apache.lens.examples.PopulateSampleMetastore.main(PopulateSampleMetastore.java:71)
{noformat}


Diffs (updated)
-

  lens-dist/src/main/assembly/bin-dist.xml 
c3f8f17d71e52249af4859b656ec3bed07cf5fc2 
  
lens-examples/src/main/java/org/apache/lens/examples/PopulateSampleMetastore.java
 4fc15a62bcea0e2e87e4b5e47adb3962aa695982 
  lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java 
e5a397b6476cea48b5646c8f376940986cb23c81 
  lens-examples/src/main/resources/sales-aggr-fact2-local4.data PRE-CREATION 


Diff: https://reviews.apache.org/r/62063/diff/2/

Changes: https://reviews.apache.org/r/62063/diff/1-2/


Testing
---


Thanks,

Rajat Khandelwal



[jira] [Commented] (LENS-1472) Populate sample metastore on example db is failing

2017-09-04 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/LENS-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152601#comment-16152601
 ] 

Hadoop QA commented on LENS-1472:
-

Applied patch: 
[LENS-1472.01.patch|https://issues.apache.org/jira/secure/attachment/12885260/LENS-1472.01.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1431/

> Populate sample metastore on example db is failing
> --
>
> Key: LENS-1472
> URL: https://issues.apache.org/jira/browse/LENS-1472
> Project: Apache Lens
>  Issue Type: Bug
>  Components: examples
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1472.01.patch
>
>
> {noformat}
> Error Message: Internal Server Error.: 
> MetaException(message:file:/usr/local/lens/client/examples/data/sales_aggr_fact2_local4
>  is not a directory or unable to create one)
>   at 
> org.apache.lens.client.LensMetadataClient.translate(LensMetadataClient.java:73)
>   at 
> org.apache.lens.client.LensMetadataClient.addPartitionsToFactTable(LensMetadataClient.java:875)
>   at 
> org.apache.lens.examples.PopulateSampleMetastore.createFactPartitions(PopulateSampleMetastore.java:172)
>   at 
> org.apache.lens.examples.PopulateSampleMetastore.populateFactTables(PopulateSampleMetastore.java:196)
>   at 
> org.apache.lens.examples.PopulateSampleMetastore.populateAll(PopulateSampleMetastore.java:84)
>   at 
> org.apache.lens.examples.PopulateSampleMetastore.main(PopulateSampleMetastore.java:71)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (LENS-1472) Populate sample metastore on example db is failing

2017-09-04 Thread Archana H (JIRA)

[ 
https://issues.apache.org/jira/browse/LENS-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152594#comment-16152594
 ] 

Archana H commented on LENS-1472:
-

One more error in the same
{CODE}
Exception in thread "main" java.sql.SQLSyntaxErrorException: user lacks 
privilege or object not found: MYDB_SALES_AGGR_CONTINUOUS_FACT
at org.hsqldb.jdbc.Util.sqlException(Unknown Source)
at org.hsqldb.jdbc.Util.sqlException(Unknown Source)
at org.hsqldb.jdbc.JDBCStatement.fetchResult(Unknown Source)
at org.hsqldb.jdbc.JDBCStatement.execute(Unknown Source)
at 
org.apache.lens.examples.PopulateSampleMetastore.createContinuousFactData(PopulateSampleMetastore.java:122)
at 
org.apache.lens.examples.PopulateSampleMetastore.populateFactTables(PopulateSampleMetastore.java:199)
at 
org.apache.lens.examples.PopulateSampleMetastore.populateAll(PopulateSampleMetastore.java:84)
at 
org.apache.lens.examples.PopulateSampleMetastore.main(PopulateSampleMetastore.java:71)
Caused by: org.hsqldb.HsqlException: user lacks privilege or object not found: 
MYDB_SALES_AGGR_CONTINUOUS_FACT
at org.hsqldb.error.Error.error(Unknown Source)
at org.hsqldb.error.Error.error(Unknown Source)
at org.hsqldb.SchemaManager.getTable(Unknown Source)
at org.hsqldb.ParserDQL.readTableName(Unknown Source)
at org.hsqldb.ParserDQL.readRangeVariableForDataChange(Unknown Source)
at org.hsqldb.ParserDML.compileInsertStatement(Unknown Source)
at org.hsqldb.ParserCommand.compilePart(Unknown Source)
at org.hsqldb.ParserCommand.compileStatements(Unknown Source)
at org.hsqldb.Session.executeDirectStatement(Unknown Source)
at org.hsqldb.Session.execute(Unknown Source)
{CODE}

> Populate sample metastore on example db is failing
> --
>
> Key: LENS-1472
> URL: https://issues.apache.org/jira/browse/LENS-1472
> Project: Apache Lens
>  Issue Type: Bug
>  Components: examples
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1472.01.patch
>
>
> {noformat}
> Error Message: Internal Server Error.: 
> MetaException(message:file:/usr/local/lens/client/examples/data/sales_aggr_fact2_local4
>  is not a directory or unable to create one)
>   at 
> org.apache.lens.client.LensMetadataClient.translate(LensMetadataClient.java:73)
>   at 
> org.apache.lens.client.LensMetadataClient.addPartitionsToFactTable(LensMetadataClient.java:875)
>   at 
> org.apache.lens.examples.PopulateSampleMetastore.createFactPartitions(PopulateSampleMetastore.java:172)
>   at 
> org.apache.lens.examples.PopulateSampleMetastore.populateFactTables(PopulateSampleMetastore.java:196)
>   at 
> org.apache.lens.examples.PopulateSampleMetastore.populateAll(PopulateSampleMetastore.java:84)
>   at 
> org.apache.lens.examples.PopulateSampleMetastore.main(PopulateSampleMetastore.java:71)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (LENS-1472) Populate sample metastore on example db is failing

2017-09-04 Thread Rajat Khandelwal (JIRA)

 [ 
https://issues.apache.org/jira/browse/LENS-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-1472:
---
Attachment: LENS-1472.01.patch

> Populate sample metastore on example db is failing
> --
>
> Key: LENS-1472
> URL: https://issues.apache.org/jira/browse/LENS-1472
> Project: Apache Lens
>  Issue Type: Bug
>  Components: examples
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1472.01.patch
>
>
> {noformat}
> Error Message: Internal Server Error.: 
> MetaException(message:file:/usr/local/lens/client/examples/data/sales_aggr_fact2_local4
>  is not a directory or unable to create one)
>   at 
> org.apache.lens.client.LensMetadataClient.translate(LensMetadataClient.java:73)
>   at 
> org.apache.lens.client.LensMetadataClient.addPartitionsToFactTable(LensMetadataClient.java:875)
>   at 
> org.apache.lens.examples.PopulateSampleMetastore.createFactPartitions(PopulateSampleMetastore.java:172)
>   at 
> org.apache.lens.examples.PopulateSampleMetastore.populateFactTables(PopulateSampleMetastore.java:196)
>   at 
> org.apache.lens.examples.PopulateSampleMetastore.populateAll(PopulateSampleMetastore.java:84)
>   at 
> org.apache.lens.examples.PopulateSampleMetastore.main(PopulateSampleMetastore.java:71)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (LENS-1472) Populate sample metastore on example db is failing

2017-09-04 Thread Rajat Khandelwal (JIRA)

[ 
https://issues.apache.org/jira/browse/LENS-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152581#comment-16152581
 ] 

Rajat Khandelwal commented on LENS-1472:


Taking patch from reviewboard and attaching

> Populate sample metastore on example db is failing
> --
>
> Key: LENS-1472
> URL: https://issues.apache.org/jira/browse/LENS-1472
> Project: Apache Lens
>  Issue Type: Bug
>  Components: examples
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1472.01.patch
>
>
> {noformat}
> Error Message: Internal Server Error.: 
> MetaException(message:file:/usr/local/lens/client/examples/data/sales_aggr_fact2_local4
>  is not a directory or unable to create one)
>   at 
> org.apache.lens.client.LensMetadataClient.translate(LensMetadataClient.java:73)
>   at 
> org.apache.lens.client.LensMetadataClient.addPartitionsToFactTable(LensMetadataClient.java:875)
>   at 
> org.apache.lens.examples.PopulateSampleMetastore.createFactPartitions(PopulateSampleMetastore.java:172)
>   at 
> org.apache.lens.examples.PopulateSampleMetastore.populateFactTables(PopulateSampleMetastore.java:196)
>   at 
> org.apache.lens.examples.PopulateSampleMetastore.populateAll(PopulateSampleMetastore.java:84)
>   at 
> org.apache.lens.examples.PopulateSampleMetastore.main(PopulateSampleMetastore.java:71)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (LENS-1472) Populate sample metastore on example db is failing

2017-09-04 Thread Rajat Khandelwal (JIRA)

 [ 
https://issues.apache.org/jira/browse/LENS-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-1472:
---
Status: Patch Available  (was: In Progress)

> Populate sample metastore on example db is failing
> --
>
> Key: LENS-1472
> URL: https://issues.apache.org/jira/browse/LENS-1472
> Project: Apache Lens
>  Issue Type: Bug
>  Components: examples
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1472.01.patch
>
>
> {noformat}
> Error Message: Internal Server Error.: 
> MetaException(message:file:/usr/local/lens/client/examples/data/sales_aggr_fact2_local4
>  is not a directory or unable to create one)
>   at 
> org.apache.lens.client.LensMetadataClient.translate(LensMetadataClient.java:73)
>   at 
> org.apache.lens.client.LensMetadataClient.addPartitionsToFactTable(LensMetadataClient.java:875)
>   at 
> org.apache.lens.examples.PopulateSampleMetastore.createFactPartitions(PopulateSampleMetastore.java:172)
>   at 
> org.apache.lens.examples.PopulateSampleMetastore.populateFactTables(PopulateSampleMetastore.java:196)
>   at 
> org.apache.lens.examples.PopulateSampleMetastore.populateAll(PopulateSampleMetastore.java:84)
>   at 
> org.apache.lens.examples.PopulateSampleMetastore.main(PopulateSampleMetastore.java:71)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


Review Request 62063: LENS-1472: Populate sample metastore on example db is failing

2017-09-04 Thread Rajat Khandelwal

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62063/
---

Review request for lens.


Bugs: LENS-1472
https://issues.apache.org/jira/browse/LENS-1472


Repository: lens


Description
---

{noformat}
Error Message: Internal Server Error.: 
MetaException(message:file:/usr/local/lens/client/examples/data/sales_aggr_fact2_local4
 is not a directory or unable to create one)
at 
org.apache.lens.client.LensMetadataClient.translate(LensMetadataClient.java:73)
at 
org.apache.lens.client.LensMetadataClient.addPartitionsToFactTable(LensMetadataClient.java:875)
at 
org.apache.lens.examples.PopulateSampleMetastore.createFactPartitions(PopulateSampleMetastore.java:172)
at 
org.apache.lens.examples.PopulateSampleMetastore.populateFactTables(PopulateSampleMetastore.java:196)
at 
org.apache.lens.examples.PopulateSampleMetastore.populateAll(PopulateSampleMetastore.java:84)
at 
org.apache.lens.examples.PopulateSampleMetastore.main(PopulateSampleMetastore.java:71)
{noformat}


Diffs
-

  lens-dist/src/main/assembly/bin-dist.xml 
c3f8f17d71e52249af4859b656ec3bed07cf5fc2 
  lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java 
e5a397b6476cea48b5646c8f376940986cb23c81 
  lens-examples/src/main/resources/sales-aggr-fact2-local4.data PRE-CREATION 


Diff: https://reviews.apache.org/r/62063/diff/1/


Testing
---


Thanks,

Rajat Khandelwal



[jira] [Work started] (LENS-1472) Populate sample metastore on example db is failing

2017-09-04 Thread Rajat Khandelwal (JIRA)

 [ 
https://issues.apache.org/jira/browse/LENS-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on LENS-1472 started by Rajat Khandelwal.
--
> Populate sample metastore on example db is failing
> --
>
> Key: LENS-1472
> URL: https://issues.apache.org/jira/browse/LENS-1472
> Project: Apache Lens
>  Issue Type: Bug
>  Components: examples
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
>
> {noformat}
> Error Message: Internal Server Error.: 
> MetaException(message:file:/usr/local/lens/client/examples/data/sales_aggr_fact2_local4
>  is not a directory or unable to create one)
>   at 
> org.apache.lens.client.LensMetadataClient.translate(LensMetadataClient.java:73)
>   at 
> org.apache.lens.client.LensMetadataClient.addPartitionsToFactTable(LensMetadataClient.java:875)
>   at 
> org.apache.lens.examples.PopulateSampleMetastore.createFactPartitions(PopulateSampleMetastore.java:172)
>   at 
> org.apache.lens.examples.PopulateSampleMetastore.populateFactTables(PopulateSampleMetastore.java:196)
>   at 
> org.apache.lens.examples.PopulateSampleMetastore.populateAll(PopulateSampleMetastore.java:84)
>   at 
> org.apache.lens.examples.PopulateSampleMetastore.main(PopulateSampleMetastore.java:71)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (LENS-1472) Populate sample metastore on example db is failing

2017-09-04 Thread Rajat Khandelwal (JIRA)

[ 
https://issues.apache.org/jira/browse/LENS-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152580#comment-16152580
 ] 

Rajat Khandelwal commented on LENS-1472:


Created https://reviews.apache.org/r/62063/

> Populate sample metastore on example db is failing
> --
>
> Key: LENS-1472
> URL: https://issues.apache.org/jira/browse/LENS-1472
> Project: Apache Lens
>  Issue Type: Bug
>  Components: examples
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
>
> {noformat}
> Error Message: Internal Server Error.: 
> MetaException(message:file:/usr/local/lens/client/examples/data/sales_aggr_fact2_local4
>  is not a directory or unable to create one)
>   at 
> org.apache.lens.client.LensMetadataClient.translate(LensMetadataClient.java:73)
>   at 
> org.apache.lens.client.LensMetadataClient.addPartitionsToFactTable(LensMetadataClient.java:875)
>   at 
> org.apache.lens.examples.PopulateSampleMetastore.createFactPartitions(PopulateSampleMetastore.java:172)
>   at 
> org.apache.lens.examples.PopulateSampleMetastore.populateFactTables(PopulateSampleMetastore.java:196)
>   at 
> org.apache.lens.examples.PopulateSampleMetastore.populateAll(PopulateSampleMetastore.java:84)
>   at 
> org.apache.lens.examples.PopulateSampleMetastore.main(PopulateSampleMetastore.java:71)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (LENS-1471) JoinCandidate's children should not share same instance of a storage candidate

2017-09-04 Thread Rajat Khandelwal (JIRA)

[ 
https://issues.apache.org/jira/browse/LENS-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152579#comment-16152579
 ] 

Rajat Khandelwal commented on LENS-1471:


Taking patch from reviewboard and attaching

> JoinCandidate's children should not share same instance of a storage 
> candidate 
> ---
>
> Key: LENS-1471
> URL: https://issues.apache.org/jira/browse/LENS-1471
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1471.01.patch, LENS-1471.02.patch, 
> LENS-1471.03.patch
>
>
> The issue is in Join candidates of the kind {{Join\[Union\[a,b\]; 
> Union\[a,c\]\]}}. If the instance of {{a}} is shared in different trees of a 
> JoinCandidate, the rewritten query will be wrong. JoinCandidate's children 
> set exclusive measure phrase indices, and that is done via {{retain}} method 
> of list. So let's say union1 is answering {{\[0,1\]}} measures and union2 is 
> answering {{\[2,3\]}} measures, and since 
> {{\[0,1,2,3\].retain(\[0,1\]).retain(\[2,3\]) == \[\]}}, it ends up answering 
> no measures at all



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (LENS-1471) JoinCandidate's children should not share same instance of a storage candidate

2017-09-04 Thread Rajat Khandelwal (JIRA)

 [ 
https://issues.apache.org/jira/browse/LENS-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-1471:
---
Attachment: LENS-1471.03.patch

> JoinCandidate's children should not share same instance of a storage 
> candidate 
> ---
>
> Key: LENS-1471
> URL: https://issues.apache.org/jira/browse/LENS-1471
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1471.01.patch, LENS-1471.02.patch, 
> LENS-1471.03.patch
>
>
> The issue is in Join candidates of the kind {{Join\[Union\[a,b\]; 
> Union\[a,c\]\]}}. If the instance of {{a}} is shared in different trees of a 
> JoinCandidate, the rewritten query will be wrong. JoinCandidate's children 
> set exclusive measure phrase indices, and that is done via {{retain}} method 
> of list. So let's say union1 is answering {{\[0,1\]}} measures and union2 is 
> answering {{\[2,3\]}} measures, and since 
> {{\[0,1,2,3\].retain(\[0,1\]).retain(\[2,3\]) == \[\]}}, it ends up answering 
> no measures at all



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


Re: Review Request 62060: LENS-1471: JoinCandidate's children should not share same storage candidate

2017-09-04 Thread Rajat Khandelwal

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62060/
---

(Updated Sept. 4, 2017, 6:20 p.m.)


Review request for lens.


Bugs: LENS-1471
https://issues.apache.org/jira/browse/LENS-1471


Repository: lens


Description
---

The issue is in Join candidates of the kind {{Join\[Union\[a,b\]; 
Union\[a,c\]\]}}. If the instance of {{a}} is shared in different trees of a 
JoinCandidate, the rewritten query will be wrong. JoinCandidate's children set 
exclusive measure phrase indices, and that is done via truncate method of list. 
So let's say union1 is answering {{\[0,1\]}} measures and union2 is answering 
{{\[2,3\]}} measures, and since {{\[0,1,2,3\].retain(\[0,1\]).retain(\[2,3\]) 
== \[\]}}, it ends up answering no measures at all


Diffs (updated)
-

  
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateCoveringSetsResolver.java
 1cff4a424fddb7e124531837ce29a5d8ed97d49c 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 
27835b371c51579ae35d526fc6245f6cf5c7ffb4 
  lens-cube/src/main/java/org/apache/lens/cube/parse/UnionCandidate.java 
510ea0c5b1edf1dd60b5380ba3b2a47844ed2219 


Diff: https://reviews.apache.org/r/62060/diff/3/

Changes: https://reviews.apache.org/r/62060/diff/2-3/


Testing
---


Thanks,

Rajat Khandelwal



[jira] [Created] (LENS-1472) Populate sample metastore on example db is failing

2017-09-04 Thread Rajat Khandelwal (JIRA)
Rajat Khandelwal created LENS-1472:
--

 Summary: Populate sample metastore on example db is failing
 Key: LENS-1472
 URL: https://issues.apache.org/jira/browse/LENS-1472
 Project: Apache Lens
  Issue Type: Bug
  Components: examples
Reporter: Rajat Khandelwal
Assignee: Rajat Khandelwal


{noformat}
Error Message: Internal Server Error.: 
MetaException(message:file:/usr/local/lens/client/examples/data/sales_aggr_fact2_local4
 is not a directory or unable to create one)
at 
org.apache.lens.client.LensMetadataClient.translate(LensMetadataClient.java:73)
at 
org.apache.lens.client.LensMetadataClient.addPartitionsToFactTable(LensMetadataClient.java:875)
at 
org.apache.lens.examples.PopulateSampleMetastore.createFactPartitions(PopulateSampleMetastore.java:172)
at 
org.apache.lens.examples.PopulateSampleMetastore.populateFactTables(PopulateSampleMetastore.java:196)
at 
org.apache.lens.examples.PopulateSampleMetastore.populateAll(PopulateSampleMetastore.java:84)
at 
org.apache.lens.examples.PopulateSampleMetastore.main(PopulateSampleMetastore.java:71)
{noformat}




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (LENS-1471) JoinCandidate's children should not share same instance of a storage candidate

2017-09-04 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/LENS-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152497#comment-16152497
 ] 

Hadoop QA commented on LENS-1471:
-

Applied patch: 
[LENS-1471.02.patch|https://issues.apache.org/jira/secure/attachment/12885243/LENS-1471.02.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1429/

> JoinCandidate's children should not share same instance of a storage 
> candidate 
> ---
>
> Key: LENS-1471
> URL: https://issues.apache.org/jira/browse/LENS-1471
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1471.01.patch, LENS-1471.02.patch
>
>
> The issue is in Join candidates of the kind {{Join\[Union\[a,b\]; 
> Union\[a,c\]\]}}. If the instance of {{a}} is shared in different trees of a 
> JoinCandidate, the rewritten query will be wrong. JoinCandidate's children 
> set exclusive measure phrase indices, and that is done via {{retain}} method 
> of list. So let's say union1 is answering {{\[0,1\]}} measures and union2 is 
> answering {{\[2,3\]}} measures, and since 
> {{\[0,1,2,3\].retain(\[0,1\]).retain(\[2,3\]) == \[\]}}, it ends up answering 
> no measures at all



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (LENS-1471) JoinCandidate's children should not share same instance of a storage candidate

2017-09-04 Thread Rajat Khandelwal (JIRA)

 [ 
https://issues.apache.org/jira/browse/LENS-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-1471:
---
Attachment: LENS-1471.02.patch

> JoinCandidate's children should not share same instance of a storage 
> candidate 
> ---
>
> Key: LENS-1471
> URL: https://issues.apache.org/jira/browse/LENS-1471
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1471.01.patch, LENS-1471.02.patch
>
>
> The issue is in Join candidates of the kind {{Join\[Union\[a,b\]; 
> Union\[a,c\]\]}}. If the instance of {{a}} is shared in different trees of a 
> JoinCandidate, the rewritten query will be wrong. JoinCandidate's children 
> set exclusive measure phrase indices, and that is done via {{retain}} method 
> of list. So let's say union1 is answering {{\[0,1\]}} measures and union2 is 
> answering {{\[2,3\]}} measures, and since 
> {{\[0,1,2,3\].retain(\[0,1\]).retain(\[2,3\]) == \[\]}}, it ends up answering 
> no measures at all



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (LENS-1471) JoinCandidate's children should not share same instance of a storage candidate

2017-09-04 Thread Rajat Khandelwal (JIRA)

[ 
https://issues.apache.org/jira/browse/LENS-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152490#comment-16152490
 ] 

Rajat Khandelwal commented on LENS-1471:


Taking patch from reviewboard and attaching

> JoinCandidate's children should not share same instance of a storage 
> candidate 
> ---
>
> Key: LENS-1471
> URL: https://issues.apache.org/jira/browse/LENS-1471
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1471.01.patch, LENS-1471.02.patch
>
>
> The issue is in Join candidates of the kind {{Join\[Union\[a,b\]; 
> Union\[a,c\]\]}}. If the instance of {{a}} is shared in different trees of a 
> JoinCandidate, the rewritten query will be wrong. JoinCandidate's children 
> set exclusive measure phrase indices, and that is done via {{retain}} method 
> of list. So let's say union1 is answering {{\[0,1\]}} measures and union2 is 
> answering {{\[2,3\]}} measures, and since 
> {{\[0,1,2,3\].retain(\[0,1\]).retain(\[2,3\]) == \[\]}}, it ends up answering 
> no measures at all



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


Re: Review Request 62060: LENS-1471: JoinCandidate's children should not share same storage candidate

2017-09-04 Thread Rajat Khandelwal

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62060/
---

(Updated Sept. 4, 2017, 4:55 p.m.)


Review request for lens.


Bugs: LENS-1471
https://issues.apache.org/jira/browse/LENS-1471


Repository: lens


Description
---

The issue is in Join candidates of the kind {{Join\[Union\[a,b\]; 
Union\[a,c\]\]}}. If the instance of {{a}} is shared in different trees of a 
JoinCandidate, the rewritten query will be wrong. JoinCandidate's children set 
exclusive measure phrase indices, and that is done via truncate method of list. 
So let's say union1 is answering {{\[0,1\]}} measures and union2 is answering 
{{\[2,3\]}} measures, and since {{\[0,1,2,3\].retain(\[0,1\]).retain(\[2,3\]) 
== \[\]}}, it ends up answering no measures at all


Diffs (updated)
-

  
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateCoveringSetsResolver.java
 1cff4a424fddb7e124531837ce29a5d8ed97d49c 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 
27835b371c51579ae35d526fc6245f6cf5c7ffb4 
  lens-cube/src/main/java/org/apache/lens/cube/parse/UnionCandidate.java 
510ea0c5b1edf1dd60b5380ba3b2a47844ed2219 


Diff: https://reviews.apache.org/r/62060/diff/2/

Changes: https://reviews.apache.org/r/62060/diff/1-2/


Testing
---


Thanks,

Rajat Khandelwal



[jira] [Updated] (LENS-1471) JoinCandidate's children should not share same instance of a storage candidate

2017-09-04 Thread Rajat Khandelwal (JIRA)

 [ 
https://issues.apache.org/jira/browse/LENS-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-1471:
---
Description: The issue is in Join candidates of the kind 
{{Join\[Union\[a,b\]; Union\[a,c\]\]}}. If the instance of {{a}} is shared in 
different trees of a JoinCandidate, the rewritten query will be wrong. 
JoinCandidate's children set exclusive measure phrase indices, and that is done 
via {{retain}} method of list. So let's say union1 is answering {{\[0,1\]}} 
measures and union2 is answering {{\[2,3\]}} measures, and since 
{{\[0,1,2,3\].retain(\[0,1\]).retain(\[2,3\]) == \[\]}}, it ends up answering 
no measures at all  (was: The issue is in Join candidates of the kind 
{{Join\[Union\[a,b\]; Union\[a,c\]\]}}. If the instance of {{a}} is shared in 
different trees of a JoinCandidate, the rewritten query will be wrong. 
JoinCandidate's children set exclusive measure phrase indices, and that is done 
via truncate method of list. So let's say union1 is answering {{\[0,1\]}} 
measures and union2 is answering {{\[2,3\]}} measures, and since 
{{\[0,1,2,3\].retain(\[0,1\]).retain(\[2,3\]) == \[\]}}, it ends up answering 
no measures at all)

> JoinCandidate's children should not share same instance of a storage 
> candidate 
> ---
>
> Key: LENS-1471
> URL: https://issues.apache.org/jira/browse/LENS-1471
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1471.01.patch
>
>
> The issue is in Join candidates of the kind {{Join\[Union\[a,b\]; 
> Union\[a,c\]\]}}. If the instance of {{a}} is shared in different trees of a 
> JoinCandidate, the rewritten query will be wrong. JoinCandidate's children 
> set exclusive measure phrase indices, and that is done via {{retain}} method 
> of list. So let's say union1 is answering {{\[0,1\]}} measures and union2 is 
> answering {{\[2,3\]}} measures, and since 
> {{\[0,1,2,3\].retain(\[0,1\]).retain(\[2,3\]) == \[\]}}, it ends up answering 
> no measures at all



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


Review Request 62060: LENS-1471: JoinCandidate's children should not share same storage candidate

2017-09-04 Thread Rajat Khandelwal

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62060/
---

Review request for lens.


Bugs: LENS-1471
https://issues.apache.org/jira/browse/LENS-1471


Repository: lens


Description
---

The issue is in Join candidates of the kind {{Join\[Union\[a,b\]; 
Union\[a,c\]\]}}. If the instance of {{a}} is shared in different trees of a 
JoinCandidate, the rewritten query will be wrong. JoinCandidate's children set 
exclusive measure phrase indices, and that is done via truncate method of list. 
So let's say union1 is answering {{\[0,1\]}} measures and union2 is answering 
{{\[2,3\]}} measures, and since {{\[0,1,2,3\].retain(\[0,1\]).retain(\[2,3\]) 
== \[\]}}, it ends up answering no measures at all


Diffs
-

  
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateCoveringSetsResolver.java
 1cff4a424fddb7e124531837ce29a5d8ed97d49c 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 
27835b371c51579ae35d526fc6245f6cf5c7ffb4 
  lens-cube/src/main/java/org/apache/lens/cube/parse/UnionCandidate.java 
510ea0c5b1edf1dd60b5380ba3b2a47844ed2219 


Diff: https://reviews.apache.org/r/62060/diff/1/


Testing
---


Thanks,

Rajat Khandelwal



[jira] [Updated] (LENS-1471) JoinCandidate's children should not share same storage candidate

2017-09-04 Thread Rajat Khandelwal (JIRA)

 [ 
https://issues.apache.org/jira/browse/LENS-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-1471:
---
Attachment: LENS-1471.01.patch

> JoinCandidate's children should not share same storage candidate 
> -
>
> Key: LENS-1471
> URL: https://issues.apache.org/jira/browse/LENS-1471
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1471.01.patch
>
>
> The issue is in Join candidates of the kind {{Join\[Union\[a,b\]; 
> Union\[a,c\]\]}}. If the instance of {{a}} is shared in different trees of a 
> JoinCandidate, the rewritten query will be wrong. JoinCandidate's children 
> set exclusive measure phrase indices, and that is done via truncate method of 
> list. So let's say union1 is answering {{\[0,1\]}} measures and union2 is 
> answering {{\[2,3\]}} measures, and since 
> {{\[0,1,2,3\].retain(\[0,1\]).retain(\[2,3\]) == \[\]}}, it ends up answering 
> no measures at all



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (LENS-1471) JoinCandidate's children should not share same storage candidate

2017-09-04 Thread Rajat Khandelwal (JIRA)

 [ 
https://issues.apache.org/jira/browse/LENS-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-1471:
---
Status: Patch Available  (was: In Progress)

> JoinCandidate's children should not share same storage candidate 
> -
>
> Key: LENS-1471
> URL: https://issues.apache.org/jira/browse/LENS-1471
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1471.01.patch
>
>
> The issue is in Join candidates of the kind {{Join\[Union\[a,b\]; 
> Union\[a,c\]\]}}. If the instance of {{a}} is shared in different trees of a 
> JoinCandidate, the rewritten query will be wrong. JoinCandidate's children 
> set exclusive measure phrase indices, and that is done via truncate method of 
> list. So let's say union1 is answering {{\[0,1\]}} measures and union2 is 
> answering {{\[2,3\]}} measures, and since 
> {{\[0,1,2,3\].retain(\[0,1\]).retain(\[2,3\]) == \[\]}}, it ends up answering 
> no measures at all



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (LENS-1471) JoinCandidate's children should not share same storage candidate

2017-09-04 Thread Rajat Khandelwal (JIRA)

[ 
https://issues.apache.org/jira/browse/LENS-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152474#comment-16152474
 ] 

Rajat Khandelwal commented on LENS-1471:


Taking patch from reviewboard and attaching

> JoinCandidate's children should not share same storage candidate 
> -
>
> Key: LENS-1471
> URL: https://issues.apache.org/jira/browse/LENS-1471
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1471.01.patch
>
>
> The issue is in Join candidates of the kind {{Join\[Union\[a,b\]; 
> Union\[a,c\]\]}}. If the instance of {{a}} is shared in different trees of a 
> JoinCandidate, the rewritten query will be wrong. JoinCandidate's children 
> set exclusive measure phrase indices, and that is done via truncate method of 
> list. So let's say union1 is answering {{\[0,1\]}} measures and union2 is 
> answering {{\[2,3\]}} measures, and since 
> {{\[0,1,2,3\].retain(\[0,1\]).retain(\[2,3\]) == \[\]}}, it ends up answering 
> no measures at all



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Work started] (LENS-1471) JoinCandidate's children should not share same storage candidate

2017-09-04 Thread Rajat Khandelwal (JIRA)

 [ 
https://issues.apache.org/jira/browse/LENS-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on LENS-1471 started by Rajat Khandelwal.
--
> JoinCandidate's children should not share same storage candidate 
> -
>
> Key: LENS-1471
> URL: https://issues.apache.org/jira/browse/LENS-1471
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
>
> The issue is in Join candidates of the kind {{Join\[Union\[a,b\]; 
> Union\[a,c\]\]}}. If the instance of {{a}} is shared in different trees of a 
> JoinCandidate, the rewritten query will be wrong. JoinCandidate's children 
> set exclusive measure phrase indices, and that is done via truncate method of 
> list. So let's say union1 is answering {{\[0,1\]}} measures and union2 is 
> answering {{\[2,3\]}} measures, and since 
> {{\[0,1,2,3\].retain(\[0,1\]).retain(\[2,3\]) == \[\]}}, it ends up answering 
> no measures at all



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (LENS-1471) JoinCandidate's children should not share same instance of a storage candidate

2017-09-04 Thread Rajat Khandelwal (JIRA)

 [ 
https://issues.apache.org/jira/browse/LENS-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-1471:
---
Summary: JoinCandidate's children should not share same instance of a 
storage candidate   (was: JoinCandidate's children should not share same 
storage candidate )

> JoinCandidate's children should not share same instance of a storage 
> candidate 
> ---
>
> Key: LENS-1471
> URL: https://issues.apache.org/jira/browse/LENS-1471
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1471.01.patch
>
>
> The issue is in Join candidates of the kind {{Join\[Union\[a,b\]; 
> Union\[a,c\]\]}}. If the instance of {{a}} is shared in different trees of a 
> JoinCandidate, the rewritten query will be wrong. JoinCandidate's children 
> set exclusive measure phrase indices, and that is done via truncate method of 
> list. So let's say union1 is answering {{\[0,1\]}} measures and union2 is 
> answering {{\[2,3\]}} measures, and since 
> {{\[0,1,2,3\].retain(\[0,1\]).retain(\[2,3\]) == \[\]}}, it ends up answering 
> no measures at all



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (LENS-1471) JoinCandidate's children should not share same storage candidate

2017-09-04 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/LENS-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152485#comment-16152485
 ] 

Hadoop QA commented on LENS-1471:
-

Applied patch: 
[LENS-1471.01.patch|https://issues.apache.org/jira/secure/attachment/12885240/LENS-1471.01.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1428/

> JoinCandidate's children should not share same storage candidate 
> -
>
> Key: LENS-1471
> URL: https://issues.apache.org/jira/browse/LENS-1471
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1471.01.patch
>
>
> The issue is in Join candidates of the kind {{Join\[Union\[a,b\]; 
> Union\[a,c\]\]}}. If the instance of {{a}} is shared in different trees of a 
> JoinCandidate, the rewritten query will be wrong. JoinCandidate's children 
> set exclusive measure phrase indices, and that is done via truncate method of 
> list. So let's say union1 is answering {{\[0,1\]}} measures and union2 is 
> answering {{\[2,3\]}} measures, and since 
> {{\[0,1,2,3\].retain(\[0,1\]).retain(\[2,3\]) == \[\]}}, it ends up answering 
> no measures at all



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (LENS-1471) JoinCandidate's children should not share same storage candidate

2017-09-04 Thread Rajat Khandelwal (JIRA)

[ 
https://issues.apache.org/jira/browse/LENS-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152472#comment-16152472
 ] 

Rajat Khandelwal commented on LENS-1471:


Created https://reviews.apache.org/r/62060/

> JoinCandidate's children should not share same storage candidate 
> -
>
> Key: LENS-1471
> URL: https://issues.apache.org/jira/browse/LENS-1471
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
>
> The issue is in Join candidates of the kind {{Join\[Union\[a,b\]; 
> Union\[a,c\]\]}}. If the instance of {{a}} is shared in different trees of a 
> JoinCandidate, the rewritten query will be wrong. JoinCandidate's children 
> set exclusive measure phrase indices, and that is done via truncate method of 
> list. So let's say union1 is answering {{\[0,1\]}} measures and union2 is 
> answering {{\[2,3\]}} measures, and since 
> {{\[0,1,2,3\].retain(\[0,1\]).retain(\[2,3\]) == \[\]}}, it ends up answering 
> no measures at all



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (LENS-1471) JoinCandidate's children should not share same storage candidate

2017-09-04 Thread Rajat Khandelwal (JIRA)
Rajat Khandelwal created LENS-1471:
--

 Summary: JoinCandidate's children should not share same storage 
candidate 
 Key: LENS-1471
 URL: https://issues.apache.org/jira/browse/LENS-1471
 Project: Apache Lens
  Issue Type: Bug
  Components: cube
Reporter: Rajat Khandelwal
Assignee: Rajat Khandelwal


The issue is in Join candidates of the kind {{Join\[Union\[a,b\]; 
Union\[a,c\]\]}}. If the instance of {{a}} is shared in different trees of a 
JoinCandidate, the rewritten query will be wrong. JoinCandidate's children set 
exclusive measure phrase indices, and that is done via truncate method of list. 
So let's say union1 is answering {{\[0,1\]}} measures and union2 is answering 
{{\[2,3\]}} measures, and since {{\[0,1,2,3\].retain(\[0,1\]).retain(\[2,3\]) 
== \[\]}}, it ends up answering no measures at all



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (LENS-1470) Email notification should specify if the result is downloadable

2017-09-04 Thread Amit Khanna (JIRA)

 [ 
https://issues.apache.org/jira/browse/LENS-1470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amit Khanna updated LENS-1470:
--
Attachment: LENS-1470.patch

> Email notification should specify if the result is downloadable
> ---
>
> Key: LENS-1470
> URL: https://issues.apache.org/jira/browse/LENS-1470
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: api
>Reporter: Amit Khanna
> Attachments: LENS-1470.patch
>
>
> Email notification should have information about the provided result whether 
> it is downloadable or not.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (LENS-1470) Email notification should specify if the result is downloadable

2017-09-04 Thread Amit Khanna (JIRA)

 [ 
https://issues.apache.org/jira/browse/LENS-1470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amit Khanna updated LENS-1470:
--
Issue Type: Improvement  (was: Bug)

> Email notification should specify if the result is downloadable
> ---
>
> Key: LENS-1470
> URL: https://issues.apache.org/jira/browse/LENS-1470
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: api
>Reporter: Amit Khanna
>
> Email notification should have information about the provided result whether 
> it is downloadable or not.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (LENS-1470) Email notification should specify if the result is downloadable

2017-09-04 Thread Amit Khanna (JIRA)
Amit Khanna created LENS-1470:
-

 Summary: Email notification should specify if the result is 
downloadable
 Key: LENS-1470
 URL: https://issues.apache.org/jira/browse/LENS-1470
 Project: Apache Lens
  Issue Type: Bug
  Components: api
Reporter: Amit Khanna


Email notification should have information about the provided result whether it 
is downloadable or not.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)