[jira] [Resolved] (LENS-1517) Python3 compatibility issues with python client

2018-06-04 Thread Ankit Kailaswar (JIRA) 


 [ 
https://issues.apache.org/jira/browse/LENS-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ankit Kailaswar resolved LENS-1517.
---
Resolution: Fixed

> Python3 compatibility issues with python client
> ---
>
> Key: LENS-1517
> URL: https://issues.apache.org/jira/browse/LENS-1517
> Project: Apache Lens
>  Issue Type: Bug
>  Components: python-client
>Affects Versions: 3.0, 2.8
> Environment: Python 3.5.2
> Commit: c6423ae01a4776383f0edcd8591124ac643b9e3e
>Reporter: Michael McCarthy
>Assignee: Michael McCarthy
>Priority: Major
>
> Using the python client in Python3 fails on import:
> {noformat}
> from lens.client import LensClient
> ---
> ImportError   Traceback (most recent call last)
>  in ()
> > 1 from lens.client import LensClient
> /data/d1/users/ds-exp/python-virtualenvs/python3.5/src/lenspythonclient/contrib/clients/python/lens/client/__init__.py
>  in ()
>  15 # limitations under the License.
>  16 #
> ---> 17 from .main import LensClient
>  18 
>  19 __all__ = ['LensClient']
> /data/d1/users/ds-exp/python-virtualenvs/python3.5/src/lenspythonclient/contrib/clients/python/lens/client/main.py
>  in ()
>  18 
>  19 from six import string_types
> ---> 20 from .log import LensLogClient
>  21 from .session import LensSessionClient
>  22 from .query import LensQueryClient
> /data/d1/users/ds-exp/python-virtualenvs/python3.5/src/lenspythonclient/contrib/clients/python/lens/client/log.py
>  in ()
>  15 # limitations under the License.
>  16 #
> ---> 17 from .auth import SpnegoAuth
>  18 import requests
>  19 
> /data/d1/users/ds-exp/python-virtualenvs/python3.5/src/lenspythonclient/contrib/clients/python/lens/client/auth.py
>  in ()
>  19 import subprocess
>  20 import threading
> ---> 21 from urlparse import urlparse
>  22 
>  23 
> ImportError: No module named 'urlparse'
> {noformat}
> This appears to be due to the fact that in Python3, {{urlparse}} is 
> {{urllib.parse}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (LENS-1518) Missing self for ignore cert variable in query.py file

2018-06-04 Thread Rajat Khandelwal (JIRA) 


 [ 
https://issues.apache.org/jira/browse/LENS-1518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajat Khandelwal updated LENS-1518:
---
Resolution: Fixed
Status: Resolved  (was: Patch Available)

> Missing self for ignore cert variable in query.py file
> --
>
> Key: LENS-1518
> URL: https://issues.apache.org/jira/browse/LENS-1518
> Project: Apache Lens
>  Issue Type: Bug
>  Components: client
>Reporter: Ankit Kailaswar
>Assignee: Ankit Kailaswar
>Priority: Major
> Attachments: Lens-1518.patch
>
>
> Self is missing for variable corresponding to ignore cert. This is causing 
> python query builder to fail while creating request object.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (LENS-1518) Missing self for ignore cert variable in query.py file

2018-06-04 Thread Rajat Khandelwal (JIRA) 


[ 
https://issues.apache.org/jira/browse/LENS-1518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16499965#comment-16499965
 ] 

Rajat Khandelwal commented on LENS-1518:


Committed. Thanks [~ankitkailaswar]

> Missing self for ignore cert variable in query.py file
> --
>
> Key: LENS-1518
> URL: https://issues.apache.org/jira/browse/LENS-1518
> Project: Apache Lens
>  Issue Type: Bug
>  Components: client
>Reporter: Ankit Kailaswar
>Assignee: Ankit Kailaswar
>Priority: Major
> Attachments: Lens-1518.patch
>
>
> Self is missing for variable corresponding to ignore cert. This is causing 
> python query builder to fail while creating request object.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (LENS-1518) Missing self for ignore cert variable in query.py file

2018-06-04 Thread Ankit Kailaswar (JIRA) 


 [ 
https://issues.apache.org/jira/browse/LENS-1518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ankit Kailaswar updated LENS-1518:
--
Status: Patch Available  (was: Open)

> Missing self for ignore cert variable in query.py file
> --
>
> Key: LENS-1518
> URL: https://issues.apache.org/jira/browse/LENS-1518
> Project: Apache Lens
>  Issue Type: Bug
>  Components: client
>Reporter: Ankit Kailaswar
>Assignee: Ankit Kailaswar
>Priority: Major
> Attachments: Lens-1518.patch
>
>
> Self is missing for variable corresponding to ignore cert. This is causing 
> python query builder to fail while creating request object.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (LENS-1518) Missing self for ignore cert variable in query.py file

2018-06-04 Thread Ankit Kailaswar (JIRA) 


 [ 
https://issues.apache.org/jira/browse/LENS-1518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ankit Kailaswar updated LENS-1518:
--
Attachment: Lens-1518.patch

> Missing self for ignore cert variable in query.py file
> --
>
> Key: LENS-1518
> URL: https://issues.apache.org/jira/browse/LENS-1518
> Project: Apache Lens
>  Issue Type: Bug
>  Components: client
>Reporter: Ankit Kailaswar
>Assignee: Ankit Kailaswar
>Priority: Major
> Attachments: Lens-1518.patch
>
>
> Self is missing for variable corresponding to ignore cert. This is causing 
> python query builder to fail while creating request object.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 67432: changes for Python3 compatibility issues with python client and ignore cert fo self signed cert

2018-06-04 Thread Rajat Khandelwal 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67432/#review204246
---


Ship it!




Ship It!

- Rajat Khandelwal


On June 4, 2018, 2:42 p.m., Ankit Kailaswar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67432/
> ---
> 
> (Updated June 4, 2018, 2:42 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Fix of urlparse import in auth.py to make compatibiliy with Python 2 and 3.
> Jira : https://issues.apache.org/jira/browse/LENS-1517
> And
> Fir for ignore cert variable in query.py
> Jira : https://issues.apache.org/jira/browse/LENS-1518
> 
> 
> Diffs
> -
> 
>   contrib/clients/python/lens/client/auth.py fccc75c9 
>   contrib/clients/python/lens/client/query.py 8b0616b6 
>   contrib/clients/python/setup.py 5c64067e 
> 
> 
> Diff: https://reviews.apache.org/r/67432/diff/1/
> 
> 
> Testing
> ---
> 
> Tested with Python 2.7.12 and Python 3.5.2 by Michael McCarthy for Lens-1517.
> Tested with Python 2.7 for Lens-1518 and queried on self signed and ca signed 
> cert.
> 
> 
> Thanks,
> 
> Ankit Kailaswar
> 
>

Review Request 67432: changes for Python3 compatibility issues with python client and ignore cert fo self signed cert

2018-06-04 Thread Ankit Kailaswar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67432/
---

Review request for lens.


Repository: lens


Description
---

Fix of urlparse import in auth.py to make compatibiliy with Python 2 and 3.
Jira : https://issues.apache.org/jira/browse/LENS-1517
And
Fir for ignore cert variable in query.py
Jira : https://issues.apache.org/jira/browse/LENS-1518


Diffs
-

  contrib/clients/python/lens/client/auth.py fccc75c9 
  contrib/clients/python/lens/client/query.py 8b0616b6 
  contrib/clients/python/setup.py 5c64067e 


Diff: https://reviews.apache.org/r/67432/diff/1/


Testing
---

Tested with Python 2.7.12 and Python 3.5.2 by Michael McCarthy for Lens-1517.
Tested with Python 2.7 for Lens-1518 and queried on self signed and ca signed 
cert.


Thanks,

Ankit Kailaswar

[jira] [Created] (LENS-1518) Missing self for ignore cert variable in query.py file

2018-06-04 Thread Ankit Kailaswar (JIRA) 
Ankit Kailaswar created LENS-1518:
-

 Summary: Missing self for ignore cert variable in query.py file
 Key: LENS-1518
 URL: https://issues.apache.org/jira/browse/LENS-1518
 Project: Apache Lens
  Issue Type: Bug
  Components: client
Reporter: Ankit Kailaswar
Assignee: Ankit Kailaswar


Self is missing for variable corresponding to ignore cert. This is causing 
python query builder to fail while creating request object.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 67427: LENS-1517: Python3 compatibility issues with python client

2018-06-04 Thread Barun Kumar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67427/#review204243
---




contrib/clients/python/lens/client/auth.py
Lines 17 (patched)


Can you add "future" module to setup.py install_requires as well?


- Barun Kumar


On June 3, 2018, 2:51 p.m., Michael McCarthy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67427/
> ---
> 
> (Updated June 3, 2018, 2:51 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Fix of urlparse import in auth.py to make compatibiliy with Python 2 and 3.
> 
> 
> Diffs
> -
> 
>   contrib/clients/python/lens/client/auth.py fccc75c9 
> 
> 
> Diff: https://reviews.apache.org/r/67427/diff/1/
> 
> 
> Testing
> ---
> 
> Tested with Python 2.7.12 and Python 3.5.2.
> 
> 
> Thanks,
> 
> Michael McCarthy
> 
>