Re: [VOTE] Break up lens code into two sub projects

[rajitha r]

+1

On Fri, Sep 13, 2019 at 9:39 AM Raju Bairishetti  wrote:

> +1
>
> On Thu, 12 Sep 2019, 11:53 Rajat Khandelwal, 
> wrote:
>
> > +1
> >
> >
> > Rajat Khandelwal
> >
> > On Wed, 28 Aug, 2019, 17:18 Puneet Gupta, 
> wrote:
> >
> > > +1 from me.
> > >
> > > On Wed, 28 Aug, 2019, 4:42 PM Amareshwari Sriramdasu, <
> > > amareshw...@apache.org> wrote:
> > >
> > > > +1 from my side.
> > > >
> > > > On Wed, Aug 28, 2019 at 4:41 PM Amareshwari Sriramdasu <
> > > > amareshw...@apache.org> wrote:
> > > >
> > > > > Hi,
> > > > >
> > > > > After the discussion on Lens roadmap thread, calling this vote to
> get
> > > > > consensus from developers of Lens for the proposal.
> > > > >
> > > > > Lens codebase can be broken down into two sub projects : one for
> > > > metastore
> > > > > and other for query. Query service can have dependency on metastore
> > > > > service. This shall help these subprojects evolve separately.
> > > > >
> > > > > To achieve the same we shall do 2.8 release from current master
> with
> > > all
> > > > > changes for current stack. Move master to 3.0 with refactored code
> of
> > > > > subprojects, which can be build separately.
> > > > >
> > > > > Lens developers, do cast your vote for the above
> > > > >
> > > > > [+1] if you approve
> > > > > [0] if no opinion
> > > > > [-] if you are not approving, with reasons.
> > > > >
> > > > > Do express your comments as well.
> > > > >
> > > > > Thanks
> > > > > Amareshwari
> > > > >
> > > > >
> > > > >
> > > >
> > >
> >
>


-- 
Regards,

Rajitha.R

[jira] [Commented] (LENS-1541) Documentation changes required for code merge changes

[Rajitha R (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16751993#comment-16751993
 ] 

Rajitha R commented on LENS-1541:
-

Hi [~amareshwari],

Do we still need the patch to be uploaded separately in the Jira or that can be 
skipped? 

Also trying to understand the impact of that on the automatic jenkins setup. 
Please advise.

> Documentation changes required for code merge changes
> -
>
> Key: LENS-1541
> URL: https://issues.apache.org/jira/browse/LENS-1541
> Project: Apache Lens
>  Issue Type: Task
>  Components: docs
>    Reporter: Rajitha R
>    Assignee: Rajitha R
>Priority: Major
>
> Based on following voting, 
> [https://lists.apache.org/thread.html/73d86d2f1f73732c7ade60773956d0052458d1433b1f7688bba8caea@%3Cdev.lens.apache.org%3E]
> the documentation needs minor changes. The ticket captures the same.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (LENS-1541) Documentation changes required for code merge changes

[Rajitha R (JIRA)]

Rajitha R created LENS-1541:
---

 Summary: Documentation changes required for code merge changes
 Key: LENS-1541
 URL: https://issues.apache.org/jira/browse/LENS-1541
 Project: Apache Lens
  Issue Type: Task
  Components: docs
Reporter: Rajitha R
Assignee: Rajitha R


Based on following voting, 

[https://lists.apache.org/thread.html/73d86d2f1f73732c7ade60773956d0052458d1433b1f7688bba8caea@%3Cdev.lens.apache.org%3E]

the documentation needs minor changes. The ticket captures the same.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [VOTE] Lens - Code Commit using Pull Requests

[Rajitha R]

Hi All,

With most of you agreeing on the change, we will be going ahead.

Voting closes now. The required documentation changes will be published soon.

Regards,
Rajitha

On 2019/01/18 16:48:15, Rajitha R  wrote: 
> Hi All,
> 
> Many of you are aware that we have migrated Lens to Gitbox
> <https://gitbox.apache.org/>service. With this, committers are now allowed
> to push code changes to apache projects through pull requests on the
> GitHub website directly. This will eliminate the current process of
> publishing changes on the review board and separately merging the commit on
> GitHub.
> 
> Committers will have to go through 3 steps mentioned here
> <https://gitbox.apache.org/setup/> to enable this for their account.
> 
> This mail is for an approval from you all regarding the process change.
> [ ] +1 approve
> [ ] 0 no opinion
> [ ] -1 disapprove (and reason why)
> 
> +1 from my side for this activity.
> 
> Regards,
> Rajitha
> 
> -- 
> Regards,
> 
> Rajitha.R
> 

[VOTE] Lens - Code Commit using Pull Requests

[rajitha r]

Hi All,

Many of you are aware that we have migrated Lens to Gitbox
service. With this, committers are now allowed
to push code changes to apache projects through pull requests  on the
GitHub website directly. This will eliminate the current process of
publishing changes on the review board and separately merging the commit on
GitHub.

Committers will have to go through 3 steps mentioned here
 to enable this for their account.

This mail is for an approval from you all regarding the process change.
[ ] +1 approve
[ ] 0 no opinion
[ ] -1 disapprove (and reason why)

+1 from my side for this activity.

Regards,
Rajitha

-- 
Regards,

Rajitha.R

[jira] [Updated] (LENS-1540) Update git-wip-us by gitbox in Lens documentation

[Rajitha R (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajitha R updated LENS-1540:

   Resolution: Fixed
Fix Version/s: 2.8
   Status: Resolved  (was: Patch Available)

> Update git-wip-us by gitbox in Lens documentation
> -
>
> Key: LENS-1540
> URL: https://issues.apache.org/jira/browse/LENS-1540
> Project: Apache Lens
>  Issue Type: Task
>  Components: docs
>    Reporter: Rajitha R
>    Assignee: Rajitha R
>Priority: Major
> Fix For: 2.8
>
> Attachments: LENS-1540.patch
>
>
> The git-wip-us url needs to be update by gitbox in Lens documentation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (LENS-1539) Authentication Changes in Ranger authorizer

[Rajitha R (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16742916#comment-16742916
 ] 

Rajitha R commented on LENS-1539:
-

Review board : https://reviews.apache.org/r/69741/

> Authentication Changes in Ranger authorizer 
> 
>
> Key: LENS-1539
> URL: https://issues.apache.org/jira/browse/LENS-1539
> Project: Apache Lens
>  Issue Type: Task
>  Components: server
>    Reporter: Rajitha R
>    Assignee: Rajitha R
>Priority: Major
> Attachments: LENS-1539.patch
>
>
> The policyrefresher thread in ranger needs to pass on the lens service keytab 
> to connect to a secure Ranger environment. This ticket captures the changes 
> required for the same.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (LENS-1540) Update git-wip-us by gitbox in Lens documentation

[Rajitha R (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16742915#comment-16742915
 ] 

Rajitha R commented on LENS-1540:
-

Review board : https://reviews.apache.org/r/69748/

> Update git-wip-us by gitbox in Lens documentation
> -
>
> Key: LENS-1540
> URL: https://issues.apache.org/jira/browse/LENS-1540
> Project: Apache Lens
>  Issue Type: Task
>  Components: docs
>    Reporter: Rajitha R
>    Assignee: Rajitha R
>Priority: Major
> Attachments: LENS-1540.patch
>
>
> The git-wip-us url needs to be update by gitbox in Lens documentation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Review Request 69748: Update git-wip-us by gitbox in Lens doc

[Rajitha R]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69748/
---

Review request for lens and Amareshwari Sriramadasu.


Bugs: LENS-1540
https://issues.apache.org/jira/browse/LENS-1540


Repository: lens


Description
---

Update git-wip-us by gitbox in Lens doc


Diffs
-

  lens-server/enunciate.xml 36b68d1 
  lens-ui/package.json b35d300 
  pom.xml 562e06e 
  src/site/apt/developer/commit.apt a99b6b8 
  src/site/apt/developer/contribute.apt 3358052 


Diff: https://reviews.apache.org/r/69748/diff/1/


Testing
---

N/A


Thanks,

Rajitha R

[jira] [Updated] (LENS-1540) Update git-wip-us by gitbox in Lens documentation

[Rajitha R (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajitha R updated LENS-1540:

Status: Patch Available  (was: Open)

> Update git-wip-us by gitbox in Lens documentation
> -
>
> Key: LENS-1540
> URL: https://issues.apache.org/jira/browse/LENS-1540
> Project: Apache Lens
>  Issue Type: Task
>  Components: docs
>    Reporter: Rajitha R
>    Assignee: Rajitha R
>Priority: Major
> Attachments: LENS-1540.patch
>
>
> The git-wip-us url needs to be update by gitbox in Lens documentation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (LENS-1540) Update git-wip-us by gitbox in Lens documentation

[Rajitha R (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajitha R updated LENS-1540:

Attachment: LENS-1540.patch

> Update git-wip-us by gitbox in Lens documentation
> -
>
> Key: LENS-1540
> URL: https://issues.apache.org/jira/browse/LENS-1540
> Project: Apache Lens
>  Issue Type: Task
>  Components: docs
>    Reporter: Rajitha R
>    Assignee: Rajitha R
>Priority: Major
> Attachments: LENS-1540.patch
>
>
> The git-wip-us url needs to be update by gitbox in Lens documentation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (LENS-1540) Update git-wip-us by gitbox in Lens documentation

[Rajitha R (JIRA)]

Rajitha R created LENS-1540:
---

 Summary: Update git-wip-us by gitbox in Lens documentation
 Key: LENS-1540
 URL: https://issues.apache.org/jira/browse/LENS-1540
 Project: Apache Lens
  Issue Type: Task
  Components: docs
Reporter: Rajitha R
Assignee: Rajitha R
 Attachments: LENS-1540.patch

The git-wip-us url needs to be update by gitbox in Lens documentation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (LENS-1539) Authentication Changes in Ranger authorizer

[Rajitha R (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajitha R updated LENS-1539:

Attachment: LENS-1539.patch

> Authentication Changes in Ranger authorizer 
> 
>
> Key: LENS-1539
> URL: https://issues.apache.org/jira/browse/LENS-1539
> Project: Apache Lens
>  Issue Type: Task
>  Components: server
>    Reporter: Rajitha R
>    Assignee: Rajitha R
>Priority: Major
> Attachments: LENS-1539.patch
>
>
> The policyrefresher thread in ranger needs to pass on the lens service keytab 
> to connect to a secure Ranger environment. This ticket captures the changes 
> required for the same.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (LENS-1539) Authentication Changes in Ranger authorizer

[Rajitha R (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajitha R updated LENS-1539:

Status: Patch Available  (was: Open)

> Authentication Changes in Ranger authorizer 
> 
>
> Key: LENS-1539
> URL: https://issues.apache.org/jira/browse/LENS-1539
> Project: Apache Lens
>  Issue Type: Task
>  Components: server
>    Reporter: Rajitha R
>    Assignee: Rajitha R
>Priority: Major
> Attachments: LENS-1539.patch
>
>
> The policyrefresher thread in ranger needs to pass on the lens service keytab 
> to connect to a secure Ranger environment. This ticket captures the changes 
> required for the same.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [DISCUSS] Lens Migration from Git-wip to Gitbox

[Rajitha R]

This activity is complete.
https://issues.apache.org/jira/browse/INFRA-17583

Regards,
Rajitha

On 2019/01/07 05:29:54, Rajitha R  wrote: 
> Hi All,
> 
> ASF infra has decided to move all git repositories from git-wip-us.apache.org 
> URL to gitbox.apache.org with the former service being decommisioned. 
> 
> This mail is to get a consensus from all of you regarding the migration. 
> 
> Please vote within next 24 hours, which can help me in raising the Infra jira 
> before the published timeline. 
> 
> [ ] +1 approve
> [ ] 0 no opinion
> [ ] -1 disapprove (and reason why)
> 
> +1 from my side for the activity.
> 
> For folks looking for more details, please refer this link : 
> 
> https://blogs.apache.org/infra/entry/relocation-of-apache-git-repositories
> 
> Regards,
> Rajitha.R
> 

Review Request 69741: Authentication Changes in Ranger authorizer

[Rajitha R]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69741/
---

Review request for lens, Amareshwari Sriramadasu and Puneet Gupta.


Bugs: LENS-1539
https://issues.apache.org/jira/browse/LENS-1539


Repository: lens


Description
---

The policyrefresher thread in ranger needs to pass on the lens service keytab 
to connect to a secure Ranger environment.


Diffs
-

  
lens-cube/src/main/java/org/apache/lens/cube/authorization/RangerLensAuthorizer.java
 2fe08ef 
  lens-cube/src/test/java/org/apache/lens/cube/parse/MockAuthorizer.java 
d410083 
  
lens-server-api/src/main/java/org/apache/lens/server/api/AbstractLensAuthorizer.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 
cb82f06 
  
lens-server-api/src/main/java/org/apache/lens/server/api/authorization/DefaultAuthorizer.java
 553fa3c 
  
lens-server-api/src/main/java/org/apache/lens/server/api/authorization/LensAuthorizer.java
 f8c6b9c 
  lens-server/src/main/resources/lensserver-default.xml e5d94e7 
  src/site/apt/admin/config.apt 4cee5ae 


Diff: https://reviews.apache.org/r/69741/diff/1/


Testing
---

[INFO] Lens Checkstyle Rules .. SUCCESS [  2.372 s]
[INFO] Lens ... SUCCESS [  4.382 s]
[INFO] Lens API ... SUCCESS [ 27.489 s]
[INFO] Lens API for server and extensions . SUCCESS [ 29.105 s]
[INFO] Lens Cube .. SUCCESS [08:31 min]
[INFO] Lens DB storage  SUCCESS [ 33.885 s]
[INFO] Lens Query Library . SUCCESS [ 15.003 s]
[INFO] Lens Hive Driver ... SUCCESS [01:42 min]
[INFO] Lens Driver for JDBC ... SUCCESS [01:11 min]
[INFO] Lens Elastic Search Driver . SUCCESS [ 37.583 s]
[INFO] Lens Server  SUCCESS [12:28 min]
[INFO] Lens client  SUCCESS [02:20 min]
[INFO] Lens CLI ... SUCCESS [02:06 min]
[INFO] Lens Examples .. SUCCESS [ 10.728 s]
[INFO] Lens Ship Jars to Distributed Cache  SUCCESS [  2.248 s]
[INFO] Lens Distribution .. SUCCESS [ 22.910 s]
[INFO] Lens ML Lib  SUCCESS [01:40 min]
[INFO] Lens ML Ext Distribution ... SUCCESS [  6.576 s]
[INFO] Lens Regression  SUCCESS [ 16.409 s]
[INFO] Lens UI  SUCCESS [  5.128 s]
[INFO] Lens Contrib ... SUCCESS [  0.438 s]
[INFO] Lens Contributed Clients ... SUCCESS [  0.463 s]
[INFO] Lens Python Client . SUCCESS [  0.402 s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 33:37 min
[INFO] Finished at: 2019-01-14T17:21:38+05:30
[INFO] Final Memory: 271M/1581M
[INFO] 


Thanks,

Rajitha R

[jira] [Created] (LENS-1539) Authentication Changes in Ranger authorizer

[Rajitha R (JIRA)]

Rajitha R created LENS-1539:
---

 Summary: Authentication Changes in Ranger authorizer 
 Key: LENS-1539
 URL: https://issues.apache.org/jira/browse/LENS-1539
 Project: Apache Lens
  Issue Type: Task
  Components: server
Reporter: Rajitha R
Assignee: Rajitha R


The policyrefresher thread in ranger needs to pass on the lens service keytab 
to connect to a secure Ranger environment. This ticket captures the changes 
required for the same.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[DISCUSS] Lens Migration from Git-wip to Gitbox

[Rajitha R]

Hi All,

ASF infra has decided to move all git repositories from git-wip-us.apache.org 
URL to gitbox.apache.org with the former service being decommisioned. 

This mail is to get a consensus from all of you regarding the migration. 

Please vote within next 24 hours, which can help me in raising the Infra jira 
before the published timeline. 

[ ] +1 approve
[ ] 0 no opinion
[ ] -1 disapprove (and reason why)

+1 from my side for the activity.

For folks looking for more details, please refer this link : 

https://blogs.apache.org/infra/entry/relocation-of-apache-git-repositories

Regards,
Rajitha.R

Re: [NOTICE] Mandatory migration of git repositories to gitbox.apache.org

[rajitha r]

Sure, will do.

On Mon, Jan 7, 2019 at 9:24 AM Amareshwari Sriramdasu <
amareshw...@apache.org> wrote:

> Rajitha,
>
> Can you please help with this?
>
> Thanks
>
> On Thu, Jan 3, 2019 at 6:49 PM Apache Infrastructure Team <
> infrastruct...@apache.org> wrote:
>
>> Hello, lens folks.
>> As stated earlier in 2018, all git repositories must be migrated from
>> the git-wip-us.apache.org URL to gitbox.apache.org, as the old service
>> is being decommissioned. Your project is receiving this email because
>> you still have repositories on git-wip-us that needs to be migrated.
>>
>> The following repositories on git-wip-us belong to your project:
>>  - lens.git
>>
>>
>> We are now entering the mandated (coordinated) move stage of the roadmap,
>> and you are asked to please coordinate migration with the Apache
>> Infrastructure Team before February 7th. All repositories not migrated
>> on February 7th will be mass migrated without warning, and we'd appreciate
>> it if we could work together to avoid a big mess that day :-).
>>
>> Moving to gitbox means you will get full write access on GitHub as well,
>> and be able to close/merge pull requests and much more.
>>
>> To have your repositories moved, please follow these steps:
>>
>> - Ensure consensus on the move (a link to a lists.apache.org thread will
>>   suffice for us as evidence).
>> - Create a JIRA ticket at https://issues.apache.org/jira/browse/INFRA
>>
>> Your migration should only take a few minutes. If you wish to migrate
>> at a specific time of day or date, please do let us know in the ticket.
>>
>> As always, we appreciate your understanding and patience as we move
>> things around and work to provide better services and features for
>> the Apache Family.
>>
>> Should you wish to contact us with feedback or questions, please do so
>> at: us...@infra.apache.org.
>>
>>
>> With regards,
>> Apache Infrastructure
>>
>>

-- 
Regards,

Rajitha.R

Re: Review Request 69554: Lens HA changes

[Rajitha R]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69554/#review211463
---




lens-server-api/src/main/java/org/apache/lens/server/api/SessionValidator.java
Lines 31 (patched)
<https://reviews.apache.org/r/69554/#comment296617>

Can we not retain the same name validateSession?



lens-server/src/main/java/org/apache/lens/server/BaseLensService.java
Line 392 (original), 401 (patched)
<https://reviews.apache.org/r/69554/#comment296673>

validatesession not being called here



lens-server/src/main/java/org/apache/lens/server/BaseLensService.java
Lines 604 (patched)
<https://reviews.apache.org/r/69554/#comment296669>

possibility of npe



lens-server/src/main/java/org/apache/lens/server/BaseLensService.java
Lines 604 (patched)
<https://reviews.apache.org/r/69554/#comment296670>

no null check on persistinfo, possibility of npe



lens-server/src/main/java/org/apache/lens/server/BaseLensService.java
Lines 607 (patched)
<https://reviews.apache.org/r/69554/#comment296671>

Any particular reason we are throwing e here and not daoE? May be throw e 
should be outside the if condition.



lens-server/src/main/java/org/apache/lens/server/BaseLensService.java
Lines 611 (patched)
<https://reviews.apache.org/r/69554/#comment296668>

can validateSession and validateSessionId api's be swapped here such that 
no changes will be required where validateSession api is called?



lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java
Lines 501 (patched)
<https://reviews.apache.org/r/69554/#comment296676>

Can we have same naming convention for better clarity? we can have 
insertActionSession like insertActiveQuery instead of insertActionSessions , 
same applies to update



lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java
Lines 701 (patched)
<https://reviews.apache.org/r/69554/#comment296618>

These should be moved to final block?



lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
Lines 142 (patched)
<https://reviews.apache.org/r/69554/#comment296621>

can we have a more intuitive name like? ACTIVE_QUERY_INSERT_ERROR_COUNTER



lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
Lines 1175 (patched)
<https://reviews.apache.org/r/69554/#comment296672>

I am afraid if these continuous db updates will slow down the system



lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
Line 1541 (original), 1566 (patched)
<https://reviews.apache.org/r/69554/#comment296620>

why is db update statement NOT called outside the switch statement and only 
in EXECUTED case ?



lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
Lines 429 (patched)
<https://reviews.apache.org/r/69554/#comment296674>

can this be reverted?



lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
Lines 538 (patched)
<https://reviews.apache.org/r/69554/#comment296675>

Why is this required? Can we not implement these counters in the existing 
way by calling notifyevent?


- Rajitha R


On Dec. 18, 2018, 12:20 p.m., Ankit Kailaswar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69554/
> ---
> 
> (Updated Dec. 18, 2018, 12:20 p.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu and Rajitha R.
> 
> 
> Bugs: LENS-1538
> https://issues.apache.org/jira/browse/LENS-1538
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Implementation
> 
> Session
> 
> We need to persist all client session in database.
> This involve persisting client session’s id and configuration in mysql 
> server. persisting entire session object is not required. We need to do this 
> as first thing while creating user session.
> For each request from client lens server should not validate session id 
> from its in memory map. It should rather validate it from persisted session 
> in mysql server.
> 
> if
> 
> session is present in mysql and not present in lens server’s in memory 
> map(session manager) then it should create a lens session with same session 
> id and add it to in memory map
> 
> else If
> 
> session is not present in mysql and present in server’s in memory map then it 
> signifies that user have initiated close session from other host and we will 
> need to remove this session from current host’s in memory map as well
> 
> else if
>

Re: Review Request 69554: Lens HA changes

[Rajitha R]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69554/#review211269
---




lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java
Lines 617 (patched)
<https://reviews.apache.org/r/69554/#comment296215>

can this be moved to the if condition? this would ensure there is atleast 
one row



lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java
Lines 623 (patched)
<https://reviews.apache.org/r/69554/#comment296216>

Can this be shifted to final block? Also DBUtils.close(stmt) and 
DBUtils.close(rs) makes more sense. This applies here and everywhere else



lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java
Line 390 (original), 827 (patched)
<https://reviews.apache.org/r/69554/#comment296217>

while all of existing code in lensserverdao is using commons db utils, any 
particular reason we are using vanilla java code in the new code? to maintain 
consistency in the code, it seems better to use the db utils library to define 
the new apis as well, IMO



lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
Lines 2258 (patched)
<https://reviews.apache.org/r/69554/#comment296222>

makes more sense to move this to all executequery apis than in 
createcontext api to be in sync with the api definition



lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
Lines 2367 (patched)
<https://reviews.apache.org/r/69554/#comment296223>

How is this supposed to work?
Given the scenario where Lens 2 is given a query Q1 from Lens 1, the db may 
still contain an older status which it could have updated before going down
Who exactly is updating the latest status of Q1 in the db?



lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
Lines 3680 (patched)
<https://reviews.apache.org/r/69554/#comment296224>

Why can't we put this code in existing validatesession in Baselensservice 
than defining a new api altogether?



lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
Lines 431 (patched)
<https://reviews.apache.org/r/69554/#comment296220>

can't see any calls to this api anywhere
Also from our offline discussion, from my understanding , both instances 
share a separate persistent state(on hdfs) and they read session state from db 
only when it can't find a given session id in its memory
Why does it require changes in existing restoresession in the first place?



lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
Lines 590 (patched)
<https://reviews.apache.org/r/69554/#comment296219>

Instead of making a db call for every session , we need to have some 
batching mechanism for better performance



lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
Line 579 (original), 616 (patched)
<https://reviews.apache.org/r/69554/#comment296221>

While all the write operations on sessions are handled in this code, I am 
not able to see any changes in list and get kind of apis in this class
For instance, what happens if getAllSessionParameters api gets called with 
a session id from other lens instance, in which case I assume , 
restoresessionfrom db needs to be called in the getSession api of 
BaseLensService, which doesn't seem to be handled here
restoresessionfromdb might have to be called in other apis involving write 
operations as well, which I am unable to see



lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java
Line 615 (original), 616 (patched)
<https://reviews.apache.org/r/69554/#comment296218>

    public interface Externalizable extends Serializable {


- Rajitha R


On Dec. 12, 2018, 8:21 a.m., Ankit Kailaswar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69554/
> ---
> 
> (Updated Dec. 12, 2018, 8:21 a.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu and Rajitha R.
> 
> 
> Bugs: LENS-1538
> https://issues.apache.org/jira/browse/LENS-1538
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Implementation
> 
> Session
> 
> We need to persist all client session in database.
> This involve persisting client session’s id and configuration in mysql 
> server. persisting entire session object is not required. We need to do this 
> as first thing while creating user session.
> For each request from client lens server should not validate session id 
> from its in memory map. It sho

Re: Review Request 69554: Lens HA changes

[Rajitha R]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69554/#review211230
---




lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
Line 54 (original), 55 (patched)
<https://reviews.apache.org/r/69554/#comment296171>

AbstractQueryContext already implements Serialzable



lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionService.java
Lines 69 (patched)
<https://reviews.apache.org/r/69554/#comment296172>

A new implementation for existing restoresession would make more sense than 
adding new api



lens-server/src/main/java/org/apache/lens/server/BaseLensService.java
Line 24 (original)
<https://reviews.apache.org/r/69554/#comment296173>

can this be reverted ?



lens-server/src/main/java/org/apache/lens/server/BaseLensService.java
Line 583 (original), 580 (patched)
<https://reviews.apache.org/r/69554/#comment296174>

"should not validate session id from its in memory map. It should rather 
validate it from persisted session in mysql server"
The above statement says to validate session from mysql, but here its 
checking inmemory and throwing the exception


- Rajitha R


On Dec. 12, 2018, 8:21 a.m., Ankit Kailaswar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69554/
> ---
> 
> (Updated Dec. 12, 2018, 8:21 a.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu and Rajitha R.
> 
> 
> Bugs: LENS-1538
> https://issues.apache.org/jira/browse/LENS-1538
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Implementation
> 
> Session
> 
> We need to persist all client session in database.
> This involve persisting client session’s id and configuration in mysql 
> server. persisting entire session object is not required. We need to do this 
> as first thing while creating user session.
> For each request from client lens server should not validate session id 
> from its in memory map. It should rather validate it from persisted session 
> in mysql server.
> 
> if
> 
> session is present in mysql and not present in lens server’s in memory 
> map(session manager) then it should create a lens session with same session 
> id and add it to in memory map
> 
> else If
> 
> session is not present in mysql and present in server’s in memory map then it 
> signifies that user have initiated close session from other host and we will 
> need to remove this session from current host’s in memory map as well
> 
> else if
> 
> session is not present in mysql and in server’s in memory map then return 
> “invalid session”.
> 
> Whenever session expired/closed then we need to remove this session from 
> lens server’s in memory map and mysql.
> 
>  
> 
> Query
> 
> For sync queries lens server will close connection as soon as it is 
> stopped or failed with appropriate failure message. Client will be retrying 
> the query.
> For async-light queries and async-heavy queries lens server takes care of 
> rescheduling all queries which were in running or queued state at the time of 
> restart. we can use this to make query ids available with both servers.
> For async queries we need to persist all non finished async user queries 
> in mysql server in new table current_query.
> If user executes query on host1 and it goes down and nginx points to 
> host2 then user should be able to poll on query status. Lens server will 
> first check query id in its inmemory maps if it is not present then it will 
> check in “finished_query” table in mysql else in “current_query” table in 
> mysql. In this case we will continue showing old status of query since it is 
> scheduled by host1. As soon as host1 comes up it will reschedule these 
> queries and will change the status. Optionally we can have host2 to move 
> these queries in “allqueries” map of its query service which will take care 
> of recovering, in this case we don't need to wait for host1 to come up and 
> reschedule.
> While moving query from ”finished_quey” map to “finished_query” table in 
> mysql we will need to remove it from “current_query” tables as well.
> This flow will remain same for request ids/query ids generated for query 
> plan/estimate.
> 
>  
> 
> Issue addressed
> 
> Lens downtime will be zero in case of deployment and if primary fail.
> User will not have to create a new session whenever switch happens
>

[jira] [Commented] (LENS-1537) Adding support for Partition Columns to queried without giving additional xml tag valid.columns -- Patch for Build Failure.

[Rajitha R (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623250#comment-16623250
 ] 

Rajitha R commented on LENS-1537:
-

Committed. Thanks [~rajashekha...@inmobi.com]

> Adding support for Partition Columns to queried without giving additional xml 
> tag valid.columns -- Patch for Build Failure.
> ---
>
> Key: LENS-1537
> URL: https://issues.apache.org/jira/browse/LENS-1537
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>Affects Versions: 2.8
>Reporter: Rajashekhar
>Assignee: Rajashekhar
>Priority: Major
> Fix For: 2.8
>
> Attachments: LENS-1537.patch
>
>
> Reference to LENS-1533
> It contains patch for the build failure of LENS-1533.
>  
> https://reviews.apache.org/r/68794/



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 68794: Adding support for Partition Columns to queried without giving additional xml tag valid.columns -- Patch for Build Failure.

[Rajitha R]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68794/#review208838
---


Ship it!




Ship It!

- Rajitha R


On Sept. 21, 2018, 8:11 a.m., Rajashekhar Choukimath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68794/
> ---
> 
> (Updated Sept. 21, 2018, 8:11 a.m.)
> 
> 
> Review request for lens and Rajitha R.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Adding support for Partition Columns to queried without giving additional xml 
> tag valid.columns -- Patch for Build Failure.
> 
> 
> Diffs
> -
> 
>   lens-examples/src/main/resources/fact3-local-part.xml 05ed8151 
>   lens-examples/src/test/resources/yaml/sample-cube.yaml 5ccc1af6 
> 
> 
> Diff: https://reviews.apache.org/r/68794/diff/1/
> 
> 
> Testing
> ---
> 
> done.
> 
> 
> Thanks,
> 
> Rajashekhar Choukimath
> 
>

[jira] [Commented] (LENS-1537) Adding support for Partition Columns to queried without giving additional xml tag valid.columns -- Patch for Build Failure.

[Rajitha R (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623221#comment-16623221
 ] 

Rajitha R commented on LENS-1537:
-

Please share the review board request here.

> Adding support for Partition Columns to queried without giving additional xml 
> tag valid.columns -- Patch for Build Failure.
> ---
>
> Key: LENS-1537
> URL: https://issues.apache.org/jira/browse/LENS-1537
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>Affects Versions: 2.8
>Reporter: Rajashekhar
>Assignee: Rajashekhar
>Priority: Major
> Fix For: 2.8
>
> Attachments: LENS-1537.patch
>
>
> Reference to LENS-1533
> It contains patch for the build failure of LENS-1533.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (LENS-1537) Adding support for Partition Columns to queried without giving additional xml tag valid.columns -- Patch for Build Failure.

[Rajitha R (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajitha R reassigned LENS-1537:
---

Assignee: Rajashekhar  (was: Rajitha R)

> Adding support for Partition Columns to queried without giving additional xml 
> tag valid.columns -- Patch for Build Failure.
> ---
>
> Key: LENS-1537
> URL: https://issues.apache.org/jira/browse/LENS-1537
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>Affects Versions: 2.8
>Reporter: Rajashekhar
>Assignee: Rajashekhar
>Priority: Major
> Fix For: 2.8
>
> Attachments: LENS-1537.patch
>
>
> Reference to LENS-1533
> It contains patch for the build failure of LENS-1533.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (LENS-1533) Adding support for Partition Columns to queried without giving additional xml tag valid.columns

[Rajitha R (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajitha R updated LENS-1533:

Resolution: Fixed
Status: Resolved  (was: Patch Available)

> Adding support for Partition Columns to queried without giving additional xml 
> tag valid.columns
> ---
>
> Key: LENS-1533
> URL: https://issues.apache.org/jira/browse/LENS-1533
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>Affects Versions: 2.8
>Reporter: Rajashekhar
>Priority: Major
> Fix For: 2.8
>
> Attachments: LENS-1533.1.patch, LENS-1533.patch
>
>
> Adding support for Partition Columns to queried without giving additional xml 
> tag valid.columns
> PR:
> https://reviews.apache.org/r/68520/



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Closed] (LENS-1533) Adding support for Partition Columns to queried without giving additional xml tag valid.columns

[Rajitha R (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajitha R closed LENS-1533.
---

> Adding support for Partition Columns to queried without giving additional xml 
> tag valid.columns
> ---
>
> Key: LENS-1533
> URL: https://issues.apache.org/jira/browse/LENS-1533
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>Affects Versions: 2.8
>Reporter: Rajashekhar
>Priority: Major
> Fix For: 2.8
>
> Attachments: LENS-1533.1.patch, LENS-1533.patch
>
>
> Adding support for Partition Columns to queried without giving additional xml 
> tag valid.columns
> PR:
> https://reviews.apache.org/r/68520/



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (LENS-1533) Adding support for Partition Columns to queried without giving additional xml tag valid.columns

[Rajitha R (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621904#comment-16621904
 ] 

Rajitha R commented on LENS-1533:
-

Committed. Thanks [~rajashekha...@inmobi.com]

> Adding support for Partition Columns to queried without giving additional xml 
> tag valid.columns
> ---
>
> Key: LENS-1533
> URL: https://issues.apache.org/jira/browse/LENS-1533
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>Affects Versions: 2.8
>Reporter: Rajashekhar
>Priority: Major
> Fix For: 2.8
>
> Attachments: LENS-1533.1.patch, LENS-1533.patch
>
>
> Adding support for Partition Columns to queried without giving additional xml 
> tag valid.columns
> PR:
> https://reviews.apache.org/r/68520/



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (LENS-1534) Authorizer Instance to be made singleton for resource optimization

[Rajitha R (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajitha R updated LENS-1534:

   Resolution: Fixed
Fix Version/s: 2.8
   Status: Resolved  (was: Patch Available)

> Authorizer Instance to be made singleton for resource optimization
> --
>
> Key: LENS-1534
> URL: https://issues.apache.org/jira/browse/LENS-1534
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>    Reporter: Rajitha R
>    Assignee: Rajitha R
>Priority: Major
> Fix For: 2.8
>
> Attachments: LENS-1534.1.patch, LENS-1534.patch
>
>
> The current authorizer instantiation is separated in cubemetastore and 
> queryrewrite. There is a need to merge this by creating only a single 
> instance of authorizer for resource optimzation.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (LENS-1534) Authorizer Instance to be made singleton for resource optimization

[Rajitha R (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609001#comment-16609001
 ] 

Rajitha R commented on LENS-1534:
-

Committed.

> Authorizer Instance to be made singleton for resource optimization
> --
>
> Key: LENS-1534
> URL: https://issues.apache.org/jira/browse/LENS-1534
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>    Reporter: Rajitha R
>    Assignee: Rajitha R
>Priority: Major
> Fix For: 2.8
>
> Attachments: LENS-1534.1.patch, LENS-1534.patch
>
>
> The current authorizer instantiation is separated in cubemetastore and 
> queryrewrite. There is a need to merge this by creating only a single 
> instance of authorizer for resource optimzation.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (LENS-1534) Authorizer Instance to be made singleton for resource optimization

[Rajitha R (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajitha R updated LENS-1534:

Attachment: LENS-1534.1.patch

> Authorizer Instance to be made singleton for resource optimization
> --
>
> Key: LENS-1534
> URL: https://issues.apache.org/jira/browse/LENS-1534
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>    Reporter: Rajitha R
>    Assignee: Rajitha R
>Priority: Major
> Attachments: LENS-1534.1.patch, LENS-1534.patch
>
>
> The current authorizer instantiation is separated in cubemetastore and 
> queryrewrite. There is a need to merge this by creating only a single 
> instance of authorizer for resource optimzation.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (LENS-1536) Details required on FieldsCannotBeQueriedTogetherException

[Rajitha R (JIRA)]

Rajitha R created LENS-1536:
---

 Summary: Details required on 
FieldsCannotBeQueriedTogetherException 
 Key: LENS-1536
 URL: https://issues.apache.org/jira/browse/LENS-1536
 Project: Apache Lens
  Issue Type: Improvement
  Components: cube
Reporter: Rajitha R


The FieldsCannotBeQueriedTogetherException currently only displays the fields 
that cannot be queried. However it doesn't give a deeper insight as to which 
columns need to be removed for the query to work.

It will be good to have the possible list of fields which can be removed to 
help the user proceed. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (LENS-1535) Add "isDeprecated" property to field definition in cube

[Rajitha R (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajitha R reassigned LENS-1535:
---

Assignee: (was: Rajitha R)

> Add "isDeprecated" property to field definition in cube
> ---
>
> Key: LENS-1535
> URL: https://issues.apache.org/jira/browse/LENS-1535
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: cube
>Reporter: Rajitha R
>Priority: Major
>
> Overtime, some of the fields in cube tend to get deprecated and hence there 
> is a need to add some tag/property to classify them as deprecated. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (LENS-1535) Add "isDeprecated" property to field definition in cube

[Rajitha R (JIRA)]

Rajitha R created LENS-1535:
---

 Summary: Add "isDeprecated" property to field definition in cube
 Key: LENS-1535
 URL: https://issues.apache.org/jira/browse/LENS-1535
 Project: Apache Lens
  Issue Type: Improvement
  Components: cube
Reporter: Rajitha R
Assignee: Rajitha R


Overtime, some of the fields in cube tend to get deprecated and hence there is 
a need to add some tag/property to classify them as deprecated. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 68670: Authorizer Instance to be made singleton for resource optimization

[Rajitha R]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68670/
---

(Updated Sept. 10, 2018, 4:28 a.m.)


Review request for lens, Amareshwari Sriramadasu and Ankit Kailaswar.


Bugs: LENS-1534
https://issues.apache.org/jira/browse/LENS-1534


Repository: lens


Description
---

The current authorizer instantiation is separated in cubemetastore and 
queryrewrite. There is a need to merge this by creating only a single instance 
of authorizer for resource optimization.


Diffs (updated)
-

  
lens-cube/src/main/java/org/apache/lens/cube/authorization/AuthorizationUtil.java
 5ae2cfd 
  
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 
b1c1ae4 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 
5bdfea4 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/QueryAuthorizationResolver.java
 f1376ca 
  
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java
 9499f0c 
  
lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryAuthorizationResolver.java
 13b345f 
  
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 
efaf5d2 
  
lens-server-api/src/main/java/org/apache/lens/server/api/authorization/LensAuthorizer.java
 PRE-CREATION 
  lens-server/src/main/java/org/apache/lens/server/LensServer.java 701ebbe 
  lens-server/src/main/resources/lensserver-default.xml 2ea73a3 
  lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 7cccf30 
  src/site/apt/admin/config.apt e900f98 


Diff: https://reviews.apache.org/r/68670/diff/2/

Changes: https://reviews.apache.org/r/68670/diff/1-2/


Testing
---

[INFO] 
[INFO] Lens Checkstyle Rules . SUCCESS [1.399s]
[INFO] Lens .. SUCCESS [2.545s]
[INFO] Lens API .. SUCCESS [17.979s]
[INFO] Lens API for server and extensions  SUCCESS [15.777s]
[INFO] Lens Cube . SUCCESS [3:15.811s]
[INFO] Lens DB storage ... SUCCESS [12.376s]
[INFO] Lens Query Library  SUCCESS [9.909s]
[INFO] Lens Hive Driver .. SUCCESS [1:04.683s]
[INFO] Lens Driver for JDBC .. SUCCESS [39.626s]
[INFO] Lens Elastic Search Driver  SUCCESS [17.802s]
[INFO] Lens Server ... SUCCESS [10:15.769s]
[INFO] Lens client ... SUCCESS [1:19.107s]
[INFO] Lens CLI .. SUCCESS [1:09.361s]
[INFO] Lens Examples . SUCCESS [5.984s]
[INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [0.616s]
[INFO] Lens Distribution . SUCCESS [10.112s]
[INFO] Lens ML Lib ... SUCCESS [57.461s]
[INFO] Lens ML Ext Distribution .. SUCCESS [2.303s]
[INFO] Lens Regression ... SUCCESS [9.392s]
[INFO] Lens UI ... SUCCESS [24.584s]
[INFO] Lens Contrib .. SUCCESS [0.255s]
[INFO] Lens Contributed Clients .. SUCCESS [0.234s]
[INFO] Lens Python Client  SUCCESS [0.235s]
[INFO] -


Thanks,

Rajitha R

[jira] [Updated] (LENS-1534) Authorizer Instance to be made singleton for resource optimization

[Rajitha R (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajitha R updated LENS-1534:

Status: Patch Available  (was: Open)

> Authorizer Instance to be made singleton for resource optimization
> --
>
> Key: LENS-1534
> URL: https://issues.apache.org/jira/browse/LENS-1534
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>    Reporter: Rajitha R
>    Assignee: Rajitha R
>Priority: Major
> Attachments: LENS-1534.patch
>
>
> The current authorizer instantiation is separated in cubemetastore and 
> queryrewrite. There is a need to merge this by creating only a single 
> instance of authorizer for resource optimzation.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (LENS-1534) Authorizer Instance to be made singleton for resource optimization

[Rajitha R (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajitha R updated LENS-1534:

Attachment: LENS-1534.patch

> Authorizer Instance to be made singleton for resource optimization
> --
>
> Key: LENS-1534
> URL: https://issues.apache.org/jira/browse/LENS-1534
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>    Reporter: Rajitha R
>    Assignee: Rajitha R
>Priority: Major
> Attachments: LENS-1534.patch
>
>
> The current authorizer instantiation is separated in cubemetastore and 
> queryrewrite. There is a need to merge this by creating only a single 
> instance of authorizer for resource optimzation.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Review Request 68670: Authorizer Instance to be made singleton for resource optimization

[Rajitha R]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68670/
---

Review request for lens, Amareshwari Sriramadasu and Ankit Kailaswar.


Bugs: LENS-1534
https://issues.apache.org/jira/browse/LENS-1534


Repository: lens


Description
---

The current authorizer instantiation is separated in cubemetastore and 
queryrewrite. There is a need to merge this by creating only a single instance 
of authorizer for resource optimization.


Diffs
-

  
lens-cube/src/main/java/org/apache/lens/cube/authorization/AuthorizationUtil.java
 5ae2cfd 
  
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 
b1c1ae4 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 
5bdfea4 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/QueryAuthorizationResolver.java
 f1376ca 
  
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java
 9499f0c 
  
lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryAuthorizationResolver.java
 13b345f 
  
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 
efaf5d2 
  
lens-server-api/src/main/java/org/apache/lens/server/api/authorization/LensAuthorizer.java
 PRE-CREATION 
  lens-server/src/main/java/org/apache/lens/server/LensServer.java 701ebbe 
  lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 7cccf30 


Diff: https://reviews.apache.org/r/68670/diff/1/


Testing
---

[INFO] 
[INFO] Lens Checkstyle Rules . SUCCESS [1.399s]
[INFO] Lens .. SUCCESS [2.545s]
[INFO] Lens API .. SUCCESS [17.979s]
[INFO] Lens API for server and extensions  SUCCESS [15.777s]
[INFO] Lens Cube . SUCCESS [3:15.811s]
[INFO] Lens DB storage ... SUCCESS [12.376s]
[INFO] Lens Query Library  SUCCESS [9.909s]
[INFO] Lens Hive Driver .. SUCCESS [1:04.683s]
[INFO] Lens Driver for JDBC .. SUCCESS [39.626s]
[INFO] Lens Elastic Search Driver  SUCCESS [17.802s]
[INFO] Lens Server ... SUCCESS [10:15.769s]
[INFO] Lens client ... SUCCESS [1:19.107s]
[INFO] Lens CLI .. SUCCESS [1:09.361s]
[INFO] Lens Examples . SUCCESS [5.984s]
[INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [0.616s]
[INFO] Lens Distribution . SUCCESS [10.112s]
[INFO] Lens ML Lib ... SUCCESS [57.461s]
[INFO] Lens ML Ext Distribution .. SUCCESS [2.303s]
[INFO] Lens Regression ... SUCCESS [9.392s]
[INFO] Lens UI ... SUCCESS [24.584s]
[INFO] Lens Contrib .. SUCCESS [0.255s]
[INFO] Lens Contributed Clients .. SUCCESS [0.234s]
[INFO] Lens Python Client  SUCCESS [0.235s]
[INFO] -


Thanks,

Rajitha R

[jira] [Created] (LENS-1534) Authorizer Instance to be made singleton for resource optimization

[Rajitha R (JIRA)]

Rajitha R created LENS-1534:
---

 Summary: Authorizer Instance to be made singleton for resource 
optimization
 Key: LENS-1534
 URL: https://issues.apache.org/jira/browse/LENS-1534
 Project: Apache Lens
  Issue Type: Improvement
  Components: server
Reporter: Rajitha R
Assignee: Rajitha R


The current authorizer instantiation is separated in cubemetastore and 
queryrewrite. There is a need to merge this by creating only a single instance 
of authorizer for resource optimzation.

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (LENS-1529) Add Unit tests for Lens Authorization

[Rajitha R (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajitha R resolved LENS-1529.
-
   Resolution: Fixed
Fix Version/s: 2.8

> Add Unit tests for Lens Authorization
> -
>
> Key: LENS-1529
> URL: https://issues.apache.org/jira/browse/LENS-1529
> Project: Apache Lens
>  Issue Type: Task
>  Components: cube, server
>    Reporter: Rajitha R
>    Assignee: Rajitha R
>Priority: Major
> Fix For: 2.8
>
>
> Add Unit tests for Lens Authorization



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Work stopped] (LENS-1529) Add Unit tests for Lens Authorization

[Rajitha R (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on LENS-1529 stopped by Rajitha R.
---
> Add Unit tests for Lens Authorization
> -
>
> Key: LENS-1529
> URL: https://issues.apache.org/jira/browse/LENS-1529
> Project: Apache Lens
>  Issue Type: Task
>  Components: cube, server
>    Reporter: Rajitha R
>    Assignee: Rajitha R
>Priority: Major
>
> Add Unit tests for Lens Authorization



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (LENS-1532) Authorization check to accept session conf

[Rajitha R (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605371#comment-16605371
 ] 

Rajitha R commented on LENS-1532:
-

Added test cases in same review request : 

https://reviews.apache.org/r/68471/

> Authorization check to accept session conf 
> ---
>
> Key: LENS-1532
> URL: https://issues.apache.org/jira/browse/LENS-1532
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>    Reporter: Rajitha R
>    Assignee: Rajitha R
>Priority: Major
> Attachments: LENS-1532.1.patch, LENS-1532.patch
>
>
> The current isAuthorized call in AuthorizationUtil is checking for session 
> related configuration from service conf which should rather be session conf. 
> This leads to incorrect session params  being read for different sessions 
> causing authorization failures. This behaviour needs to be fixed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 68471: Authorization check to accept session conf

[Rajitha R]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68471/
---

(Updated Sept. 6, 2018, 7:10 a.m.)


Review request for lens, Amareshwari Sriramadasu and Puneet Gupta.


Bugs: LENS-1529 and LENS-1532
https://issues.apache.org/jira/browse/LENS-1529
https://issues.apache.org/jira/browse/LENS-1532


Repository: lens


Description
---

The current isAuthorized call in AuthorizationUtil is checking for session 
related configuration from service conf which should rather be session conf. 
This leads to incorrect session params  being read for different sessions 
causing authorization failures


Diffs
-

  
lens-cube/src/main/java/org/apache/lens/cube/authorization/AuthorizationUtil.java
 ccd46a3 
  
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 
e6afcff 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/QueryAuthorizationResolver.java
 78dd642 
  
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java
 6f054c4 
  lens-cube/src/test/java/org/apache/lens/cube/parse/MockAuthorizer.java 
PRE-CREATION 
  
lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryAuthorizationResolver.java
 PRE-CREATION 
  lens-cube/src/test/resources/schema/cubes/base/basecube.xml 6cc3201 


Diff: https://reviews.apache.org/r/68471/diff/4/


Testing
---

[INFO] 
[INFO] Lens Checkstyle Rules .. SUCCESS [  2.734 s]
[INFO] Lens ... SUCCESS [  5.553 s]
[INFO] Lens API ... SUCCESS [ 28.035 s]
[INFO] Lens API for server and extensions . SUCCESS [ 25.289 s]
[INFO] Lens Cube .. SUCCESS [08:06 min]
[INFO] Lens DB storage  SUCCESS [ 33.949 s]
[INFO] Lens Query Library . SUCCESS [ 16.945 s]
[INFO] Lens Hive Driver ... SUCCESS [01:57 min]
[INFO] Lens Driver for JDBC ... SUCCESS [01:11 min]
[INFO] Lens Elastic Search Driver . SUCCESS [ 40.179 s]
[INFO] Lens Server  SUCCESS [13:02 min]
[INFO] Lens client  SUCCESS [02:09 min]
[INFO] Lens CLI ... SUCCESS [02:14 min]
[INFO] Lens Examples .. SUCCESS [ 12.243 s]
[INFO] Lens Ship Jars to Distributed Cache  SUCCESS [  2.325 s]
[INFO] Lens Distribution .. SUCCESS [ 22.174 s]
[INFO] Lens ML Lib  SUCCESS [01:52 min]
[INFO] Lens ML Ext Distribution ... SUCCESS [  4.972 s]
[INFO] Lens Regression  SUCCESS [ 14.733 s]
[INFO] Lens UI  SUCCESS [  6.186 s]
[INFO] Lens Contrib ... SUCCESS [  0.438 s]
[INFO] Lens Contributed Clients ... SUCCESS [  0.347 s]
[INFO] Lens Python Client . SUCCESS [  0.543 s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 34:11 min
[INFO] Finished at: 2018-08-22T16:46:43+05:30
[INFO] Final Memory: 269M/1572M


Thanks,

Rajitha R

[jira] [Updated] (LENS-1532) Authorization check to accept session conf

[Rajitha R (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajitha R updated LENS-1532:

Status: Open  (was: Patch Available)

> Authorization check to accept session conf 
> ---
>
> Key: LENS-1532
> URL: https://issues.apache.org/jira/browse/LENS-1532
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>    Reporter: Rajitha R
>    Assignee: Rajitha R
>Priority: Major
> Attachments: LENS-1532.1.patch, LENS-1532.patch
>
>
> The current isAuthorized call in AuthorizationUtil is checking for session 
> related configuration from service conf which should rather be session conf. 
> This leads to incorrect session params  being read for different sessions 
> causing authorization failures. This behaviour needs to be fixed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (LENS-1532) Authorization check to accept session conf

[Rajitha R (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajitha R updated LENS-1532:

Status: Patch Available  (was: Open)

> Authorization check to accept session conf 
> ---
>
> Key: LENS-1532
> URL: https://issues.apache.org/jira/browse/LENS-1532
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>    Reporter: Rajitha R
>    Assignee: Rajitha R
>Priority: Major
> Attachments: LENS-1532.1.patch, LENS-1532.patch
>
>
> The current isAuthorized call in AuthorizationUtil is checking for session 
> related configuration from service conf which should rather be session conf. 
> This leads to incorrect session params  being read for different sessions 
> causing authorization failures. This behaviour needs to be fixed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (LENS-1532) Authorization check to accept session conf

[Rajitha R (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajitha R updated LENS-1532:

Attachment: LENS-1532.1.patch

> Authorization check to accept session conf 
> ---
>
> Key: LENS-1532
> URL: https://issues.apache.org/jira/browse/LENS-1532
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>    Reporter: Rajitha R
>    Assignee: Rajitha R
>Priority: Major
> Attachments: LENS-1532.1.patch, LENS-1532.patch
>
>
> The current isAuthorized call in AuthorizationUtil is checking for session 
> related configuration from service conf which should rather be session conf. 
> This leads to incorrect session params  being read for different sessions 
> causing authorization failures. This behaviour needs to be fixed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Work started] (LENS-1529) Add Unit tests for Lens Authorization

[Rajitha R (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on LENS-1529 started by Rajitha R.
---
> Add Unit tests for Lens Authorization
> -
>
> Key: LENS-1529
> URL: https://issues.apache.org/jira/browse/LENS-1529
> Project: Apache Lens
>  Issue Type: Task
>  Components: cube, server
>    Reporter: Rajitha R
>    Assignee: Rajitha R
>Priority: Major
>
> Add Unit tests for Lens Authorization



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Review Request 68471: Authorization check to accept session conf

[Rajitha R]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68471/
---

Review request for lens and Amareshwari Sriramadasu.


Repository: lens


Description
---

The current isAuthorized call in AuthorizationUtil is checking for session 
related configuration from service conf which should rather be session conf. 
This leads to incorrect session params  being read for different sessions 
causing authorization failures


Diffs
-

  
lens-cube/src/main/java/org/apache/lens/cube/authorization/AuthorizationUtil.java
 ccd46a3 
  
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 
e6afcff 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/QueryAuthorizationResolver.java
 78dd642 


Diff: https://reviews.apache.org/r/68471/diff/1/


Testing
---


Thanks,

Rajitha R

[jira] [Updated] (LENS-1532) Authorization check to accept session conf

[Rajitha R (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajitha R updated LENS-1532:

Status: Patch Available  (was: In Progress)

> Authorization check to accept session conf 
> ---
>
> Key: LENS-1532
> URL: https://issues.apache.org/jira/browse/LENS-1532
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>    Reporter: Rajitha R
>    Assignee: Rajitha R
>Priority: Major
> Attachments: LENS-1532.patch
>
>
> The current isAuthorized call in AuthorizationUtil is checking for session 
> related configuration from service conf which should rather be session conf. 
> This leads to incorrect session params  being read for different sessions 
> causing authorization failures. This behaviour needs to be fixed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (LENS-1532) Authorization check to accept session conf

[Rajitha R (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajitha R updated LENS-1532:

Attachment: LENS-1532.patch

> Authorization check to accept session conf 
> ---
>
> Key: LENS-1532
> URL: https://issues.apache.org/jira/browse/LENS-1532
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>    Reporter: Rajitha R
>    Assignee: Rajitha R
>Priority: Major
> Attachments: LENS-1532.patch
>
>
> The current isAuthorized call in AuthorizationUtil is checking for session 
> related configuration from service conf which should rather be session conf. 
> This leads to incorrect session params  being read for different sessions 
> causing authorization failures. This behaviour needs to be fixed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Work started] (LENS-1532) Authorization check to accept session conf

[Rajitha R (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on LENS-1532 started by Rajitha R.
---
> Authorization check to accept session conf 
> ---
>
> Key: LENS-1532
> URL: https://issues.apache.org/jira/browse/LENS-1532
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>    Reporter: Rajitha R
>    Assignee: Rajitha R
>Priority: Major
>
> The current isAuthorized call in AuthorizationUtil is checking for session 
> related configuration from service conf which should rather be session conf. 
> This leads to incorrect session params  being read for different sessions 
> causing authorization failures. This behaviour needs to be fixed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (LENS-1532) Authorization check to accept session conf

[Rajitha R (JIRA)]

Rajitha R created LENS-1532:
---

 Summary: Authorization check to accept session conf 
 Key: LENS-1532
 URL: https://issues.apache.org/jira/browse/LENS-1532
 Project: Apache Lens
  Issue Type: Bug
  Components: cube
Reporter: Rajitha R
Assignee: Rajitha R


The current isAuthorized call in AuthorizationUtil is checking for session 
related configuration from service conf which should rather be session conf. 
This leads to incorrect session params  being read for different sessions 
causing authorization failures. This behaviour needs to be fixed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (LENS-1525) Restrict past and future date range in user queries

[Rajitha R (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajitha R updated LENS-1525:

   Resolution: Fixed
Fix Version/s: 2.8
   Status: Resolved  (was: Patch Available)

> Restrict past and future date range in user queries
> ---
>
> Key: LENS-1525
> URL: https://issues.apache.org/jira/browse/LENS-1525
> Project: Apache Lens
>  Issue Type: Task
>  Components: cube
>    Reporter: Rajitha R
>    Assignee: Rajitha R
>Priority: Major
> Fix For: 2.8
>
> Attachments: LENS-1525.patch
>
>
> Lens currently allows users to give any start and end time in the queries. 
> There is a need to restrict this range to prevent service abuse and 
> degradation. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Closed] (LENS-1525) Restrict past and future date range in user queries

[Rajitha R (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajitha R closed LENS-1525.
---

> Restrict past and future date range in user queries
> ---
>
> Key: LENS-1525
> URL: https://issues.apache.org/jira/browse/LENS-1525
> Project: Apache Lens
>  Issue Type: Task
>  Components: cube
>    Reporter: Rajitha R
>    Assignee: Rajitha R
>Priority: Major
> Fix For: 2.8
>
> Attachments: LENS-1525.patch
>
>
> Lens currently allows users to give any start and end time in the queries. 
> There is a need to restrict this range to prevent service abuse and 
> degradation. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (LENS-1525) Restrict past and future date range in user queries

[Rajitha R (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16582050#comment-16582050
 ] 

Rajitha R commented on LENS-1525:
-

Committed. 

> Restrict past and future date range in user queries
> ---
>
> Key: LENS-1525
> URL: https://issues.apache.org/jira/browse/LENS-1525
> Project: Apache Lens
>  Issue Type: Task
>  Components: cube
>    Reporter: Rajitha R
>    Assignee: Rajitha R
>Priority: Major
> Attachments: LENS-1525.patch
>
>
> Lens currently allows users to give any start and end time in the queries. 
> There is a need to restrict this range to prevent service abuse and 
> degradation. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (LENS-1530) Add Unit tests for Lens Authentication

[Rajitha R (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16582044#comment-16582044
 ] 

Rajitha R commented on LENS-1530:
-

cc [~barunsthakur]

> Add Unit tests for Lens Authentication
> --
>
> Key: LENS-1530
> URL: https://issues.apache.org/jira/browse/LENS-1530
> Project: Apache Lens
>  Issue Type: Task
>  Components: server
>    Reporter: Rajitha R
>Priority: Major
>
> Add Unit tests for Lens Authentication



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (LENS-1529) Add Unit tests for Lens Authorization

[Rajitha R (JIRA)]

Rajitha R created LENS-1529:
---

 Summary: Add Unit tests for Lens Authorization
 Key: LENS-1529
 URL: https://issues.apache.org/jira/browse/LENS-1529
 Project: Apache Lens
  Issue Type: Task
  Components: cube, server
Reporter: Rajitha R
Assignee: Rajitha R


Add Unit tests for Lens Authorization



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (LENS-1530) Add Unit tests for Lens Authentication

[Rajitha R (JIRA)]

Rajitha R created LENS-1530:
---

 Summary: Add Unit tests for Lens Authentication
 Key: LENS-1530
 URL: https://issues.apache.org/jira/browse/LENS-1530
 Project: Apache Lens
  Issue Type: Task
  Components: server
Reporter: Rajitha R


Add Unit tests for Lens Authentication



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 68315: Start and end time for Cubes

[Rajitha R]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68315/
---

(Updated Aug. 14, 2018, 2:50 p.m.)


Review request for lens and Amareshwari Sriramadasu.


Bugs: LENS-1525
https://issues.apache.org/jira/browse/LENS-1525


Repository: lens


Description
---

Introducing start and end time feature in cube properties to restrict user 
queries from including past and future date ranges.


Diffs (updated)
-

  lens-api/src/main/resources/cube-0.1.xsd 4d10d24 
  lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 
ed076e2 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/Cube.java 7c3da2c 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeInterface.java 
6477a6b 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/DerivedCube.java 
4c73785 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 
945fe26 
  lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 
8e77a82 
  lens-cube/src/test/java/org/apache/lens/cube/metadata/DateFactory.java 
c4404f1 
  
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeStartAndEndTimes.java
 PRE-CREATION 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java 
181608f 
  lens-cube/src/test/resources/schema/cubes/base/testcube.xml 4cafd31 


Diff: https://reviews.apache.org/r/68315/diff/3/

Changes: https://reviews.apache.org/r/68315/diff/2-3/


Testing
---

[INFO] 
[INFO] Lens Checkstyle Rules .. SUCCESS [  5.814 s]
[INFO] Lens ... SUCCESS [  9.893 s]
[INFO] Lens API ... SUCCESS [01:05 min]
[INFO] Lens API for server and extensions . SUCCESS [ 52.959 s]
[INFO] Lens Cube .. SUCCESS [10:16 min]
[INFO] Lens DB storage  SUCCESS [01:11 min]
[INFO] Lens Query Library . SUCCESS [ 44.173 s]
[INFO] Lens Hive Driver ... SUCCESS [02:41 min]
[INFO] Lens Driver for JDBC ... SUCCESS [02:44 min]
[INFO] Lens Elastic Search Driver . SUCCESS [ 53.534 s]
[INFO] Lens Server  SUCCESS [15:06 min]
[INFO] Lens client  SUCCESS [02:35 min]
[INFO] Lens CLI ... SUCCESS [02:42 min]
[INFO] Lens Examples .. SUCCESS [ 14.654 s]
[INFO] Lens Ship Jars to Distributed Cache  SUCCESS [  1.738 s]
[INFO] Lens Distribution .. SUCCESS [ 21.231 s]
[INFO] Lens ML Lib  SUCCESS [02:24 min]
[INFO] Lens ML Ext Distribution ... SUCCESS [  9.879 s]
[INFO] Lens Regression  SUCCESS [ 24.848 s]
[INFO] Lens UI  SUCCESS [  8.120 s]
[INFO] Lens Contrib ... SUCCESS [  1.567 s]
[INFO] Lens Contributed Clients ... SUCCESS [  0.327 s]
[INFO] Lens Python Client . SUCCESS [  0.502 s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 45:00 min
[INFO] Finished at: 2018-08-13T13:12:18+05:30
[INFO] Final Memory: 261M/1420M
[INFO] 


Thanks,

Rajitha R

Re: Review Request 68315: Start and end time for Cubes

[Rajitha R]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68315/
---

(Updated Aug. 13, 2018, 11:09 p.m.)


Review request for lens and Amareshwari Sriramadasu.


Bugs: LENS-1525
https://issues.apache.org/jira/browse/LENS-1525


Repository: lens


Description
---

Introducing start and end time feature in cube properties to restrict user 
queries from including past and future date ranges.


Diffs
-

  lens-api/src/main/resources/cube-0.1.xsd 4d10d24 
  lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 
ed076e2 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/Cube.java 7c3da2c 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeInterface.java 
6477a6b 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/DerivedCube.java 
4c73785 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 
945fe26 
  lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 
8e77a82 
  lens-cube/src/test/java/org/apache/lens/cube/metadata/CubeTest.java 
PRE-CREATION 


Diff: https://reviews.apache.org/r/68315/diff/2/


Testing
---

[INFO] 
[INFO] Lens Checkstyle Rules .. SUCCESS [  5.814 s]
[INFO] Lens ... SUCCESS [  9.893 s]
[INFO] Lens API ... SUCCESS [01:05 min]
[INFO] Lens API for server and extensions . SUCCESS [ 52.959 s]
[INFO] Lens Cube .. SUCCESS [10:16 min]
[INFO] Lens DB storage  SUCCESS [01:11 min]
[INFO] Lens Query Library . SUCCESS [ 44.173 s]
[INFO] Lens Hive Driver ... SUCCESS [02:41 min]
[INFO] Lens Driver for JDBC ... SUCCESS [02:44 min]
[INFO] Lens Elastic Search Driver . SUCCESS [ 53.534 s]
[INFO] Lens Server  SUCCESS [15:06 min]
[INFO] Lens client  SUCCESS [02:35 min]
[INFO] Lens CLI ... SUCCESS [02:42 min]
[INFO] Lens Examples .. SUCCESS [ 14.654 s]
[INFO] Lens Ship Jars to Distributed Cache  SUCCESS [  1.738 s]
[INFO] Lens Distribution .. SUCCESS [ 21.231 s]
[INFO] Lens ML Lib  SUCCESS [02:24 min]
[INFO] Lens ML Ext Distribution ... SUCCESS [  9.879 s]
[INFO] Lens Regression  SUCCESS [ 24.848 s]
[INFO] Lens UI  SUCCESS [  8.120 s]
[INFO] Lens Contrib ... SUCCESS [  1.567 s]
[INFO] Lens Contributed Clients ... SUCCESS [  0.327 s]
[INFO] Lens Python Client . SUCCESS [  0.502 s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 45:00 min
[INFO] Finished at: 2018-08-13T13:12:18+05:30
[INFO] Final Memory: 261M/1420M
[INFO] 


Thanks,

Rajitha R

[jira] [Updated] (LENS-1525) Restrict past and future date range in user queries

[Rajitha R (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajitha R updated LENS-1525:

Status: Patch Available  (was: Open)

> Restrict past and future date range in user queries
> ---
>
> Key: LENS-1525
> URL: https://issues.apache.org/jira/browse/LENS-1525
> Project: Apache Lens
>  Issue Type: Task
>  Components: cube
>    Reporter: Rajitha R
>    Assignee: Rajitha R
>Priority: Major
> Attachments: LENS-1525.patch
>
>
> Lens currently allows users to give any start and end time in the queries. 
> There is a need to restrict this range to prevent service abuse and 
> degradation. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Work stopped] (LENS-1525) Restrict past and future date range in user queries

[Rajitha R (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on LENS-1525 stopped by Rajitha R.
---
> Restrict past and future date range in user queries
> ---
>
> Key: LENS-1525
> URL: https://issues.apache.org/jira/browse/LENS-1525
> Project: Apache Lens
>  Issue Type: Task
>  Components: cube
>    Reporter: Rajitha R
>    Assignee: Rajitha R
>Priority: Major
> Attachments: LENS-1525.patch
>
>
> Lens currently allows users to give any start and end time in the queries. 
> There is a need to restrict this range to prevent service abuse and 
> degradation. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (LENS-1525) Restrict past and future date range in user queries

[Rajitha R (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajitha R updated LENS-1525:

Attachment: LENS-1525.patch

> Restrict past and future date range in user queries
> ---
>
> Key: LENS-1525
> URL: https://issues.apache.org/jira/browse/LENS-1525
> Project: Apache Lens
>  Issue Type: Task
>  Components: cube
>    Reporter: Rajitha R
>    Assignee: Rajitha R
>Priority: Major
> Attachments: LENS-1525.patch
>
>
> Lens currently allows users to give any start and end time in the queries. 
> There is a need to restrict this range to prevent service abuse and 
> degradation. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Closed] (LENS-1527) Fix session restore issue

[Rajitha R (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajitha R closed LENS-1527.
---

> Fix session restore issue
> -
>
> Key: LENS-1527
> URL: https://issues.apache.org/jira/browse/LENS-1527
> Project: Apache Lens
>  Issue Type: Bug
>  Components: api, server
>Reporter: Barun Kumar
>Assignee: Barun Kumar
>Priority: Major
> Fix For: 2.8
>
> Attachments: LENS-1527_1.patch
>
>
> When a session is created in Lens, corresponding hive session is created for 
> cluster user and session count map for user is updated. But when Lens is 
> started and restores it's sessions, the session count map is updated for 
> cluster user.
>  
> Since many user may have same cluster user, on restart of Lens the session 
> count for cluster user will be a lot and if you try to create session using 
> that cluster user, you might get 429(which is sent when session limit is 
> exhausted for a user).
> The fix for this is while resotring the session, use loggedin user to update 
> the session count map.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (LENS-1527) Fix session restore issue

[Rajitha R (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajitha R updated LENS-1527:

   Resolution: Fixed
Fix Version/s: 2.8
   Status: Resolved  (was: Patch Available)

Committed. Thanks [~barunsthakur]

> Fix session restore issue
> -
>
> Key: LENS-1527
> URL: https://issues.apache.org/jira/browse/LENS-1527
> Project: Apache Lens
>  Issue Type: Bug
>  Components: api, server
>Reporter: Barun Kumar
>Assignee: Barun Kumar
>Priority: Major
> Fix For: 2.8
>
> Attachments: LENS-1527_1.patch
>
>
> When a session is created in Lens, corresponding hive session is created for 
> cluster user and session count map for user is updated. But when Lens is 
> started and restores it's sessions, the session count map is updated for 
> cluster user.
>  
> Since many user may have same cluster user, on restart of Lens the session 
> count for cluster user will be a lot and if you try to create session using 
> that cluster user, you might get 429(which is sent when session limit is 
> exhausted for a user).
> The fix for this is while resotring the session, use loggedin user to update 
> the session count map.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 68267: Lens api to display number of sessions created per user

[Rajitha R]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68267/#review207013
---


Ship it!




Ship It!

- Rajitha R


On Aug. 8, 2018, 3 p.m., Ankit Kailaswar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68267/
> ---
> 
> (Updated Aug. 8, 2018, 3 p.m.)
> 
> 
> Review request for lens and Rajitha R.
> 
> 
> Bugs: LENS-1526
> https://issues.apache.org/jira/browse/LENS-1526
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Exposing lens api to display number of sessions created per user.
> 
> There is already an API which displays session info for each session. This 
> API will dispplay number of sessions created per user.
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/session/SessionPerUserInfo.java 
> PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionService.java
>  20ec6869 
>   lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 
> 006ee887 
>   
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 
> dfecba54 
> 
> 
> Diff: https://reviews.apache.org/r/68267/diff/1/
> 
> 
> Testing
> ---
> 
> sample output,
> XX5ankit.kailaswar1
> 
> Jira,
> https://issues.apache.org/jira/browse/LENS-1526
> 
> Build output,
> 
> Installing 
> /d0/jenkins/workspace/Platform_Common_Job/lens-ship-jars/target/lens-ship-jars-2.8.0-SNAPSHOT-tests.jar
>  to 
> /home/jenkins/.m2/repository/org/apache/lens/lens-ship-jars/2.8.0-SNAPSHOT/lens-ship-jars-2.8.0-SNAPSHOT-tests.jar
> [INFO] Installing 
> /d0/jenkins/workspace/Platform_Common_Job/lens-ship-jars/target/lens-ship-jars-2.8.0-SNAPSHOT-sources.jar
>  to 
> /home/jenkins/.m2/repository/org/apache/lens/lens-ship-jars/2.8.0-SNAPSHOT/lens-ship-jars-2.8.0-SNAPSHOT-sources.jar
> [INFO]
>  
> [INFO] 
> 
> [INFO] Building Lens Distribution 2.8.0-SNAPSHOT
> [INFO] 
> 
> [INFO] 
> [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ lens-dist ---
> [INFO] 
> [INFO] --- maven-remote-resources-plugin:1.5:process (default) @ lens-dist ---
> [INFO] 
> [INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ 
> lens-dist ---
> [INFO] Using 'UTF-8' encoding to copy filtered resources.
> [INFO] Copying 4 resources to 
> /d0/jenkins/workspace/Platform_Common_Job/lens-dist/target/debian/control
> [INFO] skip non existing resourceDirectory 
> /d0/jenkins/workspace/Platform_Common_Job/lens-dist/src/main/resources
> [INFO] Copying 3 resources
> [INFO] 
> [INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @ lens-dist ---
> [INFO] No sources to compile
> [INFO] 
> [INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @ 
> lens-dist ---
> [INFO] Using 'UTF-8' encoding to copy filtered resources.
> [INFO] skip non existing resourceDirectory 
> /d0/jenkins/workspace/Platform_Common_Job/lens-dist/src/test/resources
> [INFO] Copying 3 resources
> [INFO] 
> [INFO] --- maven-compiler-plugin:3.1:testCompile (default-testCompile) @ 
> lens-dist ---
> [INFO] No sources to compile
> [INFO] 
> [INFO] --- maven-surefire-plugin:2.15:test (default-test) @ lens-dist ---
> [INFO] 
> [INFO] --- maven-jar-plugin:2.5:jar (default-jar) @ lens-dist ---
> [INFO] Building jar: 
> /d0/jenkins/workspace/Platform_Common_Job/lens-dist/target/lens-dist-2.8.0-SNAPSHOT.jar
> [INFO] 
> [INFO] --- maven-site-plugin:3.4:attach-descriptor (attach-descriptor) @ 
> lens-dist ---
> [INFO] 
> [INFO] --- apache-rat-plugin:0.11:check (rat-check) @ lens-dist ---
> [INFO] 51 implicit excludes (use -debug for more details).
> [INFO] Exclude: **/README.*
> [INFO] Exclude: DEPENDENCIES
> [INFO] Exclude: **/LICENSE*
> [INFO] Exclude: .git/**
> [INFO] Exclude: .reviewboardrc
> [INFO] Exclude: **/patchprocess/**
> [INFO] Exclude: .idea/**
> [INFO] Exclude: **/*.iml
> [INFO] Exclude: **/.classpath
> [INFO] Exclude: **/.project
> [INFO] Exclude: **/node/**
> [INFO] Exclude: **/node_modules/**
> [INFO] Exclude: **/.checkstyle
> [INFO] Exclude: **/.settings/**
> [INFO] Exclude: **/maven-eclipse.xml
> [INFO] Exclude: **/.externalToolBuilders/**
> [IN

[jira] [Updated] (LENS-1526) Lens api to display number of sessions created per user

[Rajitha R (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajitha R updated LENS-1526:

   Resolution: Fixed
Fix Version/s: 2.8
   Status: Resolved  (was: Patch Available)

> Lens api to display number of sessions created per user
> ---
>
> Key: LENS-1526
> URL: https://issues.apache.org/jira/browse/LENS-1526
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: api
>Reporter: Ankit Kailaswar
>Assignee: Ankit Kailaswar
>Priority: Major
> Fix For: 2.8
>
> Attachments: Lens-1526.patch
>
>
> Exposing lens api to display number of sessions created per user.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (LENS-1526) Lens api to display number of sessions created per user

[Rajitha R (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574460#comment-16574460
 ] 

Rajitha R commented on LENS-1526:
-

Committed. Thanks [~ankitkailaswar]

> Lens api to display number of sessions created per user
> ---
>
> Key: LENS-1526
> URL: https://issues.apache.org/jira/browse/LENS-1526
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: api
>Reporter: Ankit Kailaswar
>Assignee: Ankit Kailaswar
>Priority: Major
> Fix For: 2.8
>
> Attachments: Lens-1526.patch
>
>
> Exposing lens api to display number of sessions created per user.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Work started] (LENS-1525) Restrict past and future date range in user queries

[Rajitha R (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on LENS-1525 started by Rajitha R.
---
> Restrict past and future date range in user queries
> ---
>
> Key: LENS-1525
> URL: https://issues.apache.org/jira/browse/LENS-1525
> Project: Apache Lens
>  Issue Type: Task
>  Components: cube
>    Reporter: Rajitha R
>    Assignee: Rajitha R
>Priority: Major
>
> Lens currently allows users to give any start and end time in the queries. 
> There is a need to restrict this range to prevent service abuse and 
> degradation. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (LENS-1525) Restrict past and future date range in user queries

[Rajitha R (JIRA)]

Rajitha R created LENS-1525:
---

 Summary: Restrict past and future date range in user queries
 Key: LENS-1525
 URL: https://issues.apache.org/jira/browse/LENS-1525
 Project: Apache Lens
  Issue Type: Task
  Components: cube
Reporter: Rajitha R
Assignee: Rajitha R


Lens currently allows users to give any start and end time in the queries. 
There is a need to restrict this range to prevent service abuse and 
degradation. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Report for August, 2018

[rajitha r]

+1

On Tue, Aug 7, 2018 at 10:46 AM Amareshwari Sriramdasu <
amareshw...@apache.org> wrote:

> Hi,
>
> Have put up draft for August,2018 report
> https://cwiki.apache.org/confluence/display/LENS/August%2C+2018.
>
> Please review and let me know your comments.
>
> Thanks
> Amareshwari
>


-- 
Regards,

Rajitha.R

[jira] [Resolved] (LENS-1404) [New] Virtual Fact

[Rajitha R (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajitha R resolved LENS-1404.
-
   Resolution: Fixed
Fix Version/s: 2.7

> [New] Virtual Fact 
> ---
>
> Key: LENS-1404
> URL: https://issues.apache.org/jira/browse/LENS-1404
> Project: Apache Lens
>  Issue Type: New Feature
>  Components: cube
>    Reporter: Rajitha R
>    Assignee: Rajitha R
>Priority: Major
> Fix For: 2.7
>
>
> Need :
> 1. The current Fact definition does not allow a fact to participate in 
> multiple cubes. For scenarios where the same fact needs to be queried in 
> different cubes, this would be a limitation.
> 2. Fact definition also doesn’t support filters to be applied on the fact 
> data.
> Considering the above two major requirements, a new entity called Virtual 
> Fact has been proposed.
> Here is a brief overview about the features of Virtual fact : 
> 1. Virtual fact extends a Fact. 
> 2. It can belong to a different cube than its parent Fact Cube.
> 3. It can have additional filters which will be used in query rewriting.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Closed] (LENS-1404) [New] Virtual Fact

[Rajitha R (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajitha R closed LENS-1404.
---

> [New] Virtual Fact 
> ---
>
> Key: LENS-1404
> URL: https://issues.apache.org/jira/browse/LENS-1404
> Project: Apache Lens
>  Issue Type: New Feature
>  Components: cube
>    Reporter: Rajitha R
>    Assignee: Rajitha R
>Priority: Major
> Fix For: 2.7
>
>
> Need :
> 1. The current Fact definition does not allow a fact to participate in 
> multiple cubes. For scenarios where the same fact needs to be queried in 
> different cubes, this would be a limitation.
> 2. Fact definition also doesn’t support filters to be applied on the fact 
> data.
> Considering the above two major requirements, a new entity called Virtual 
> Fact has been proposed.
> Here is a brief overview about the features of Virtual fact : 
> 1. Virtual fact extends a Fact. 
> 2. It can belong to a different cube than its parent Fact Cube.
> 3. It can have additional filters which will be used in query rewriting.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (LENS-1508) Upgrade Hadoop version to 2.7.1

[Rajitha R (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajitha R updated LENS-1508:

Fix Version/s: (was: 2.8)
   2.7

> Upgrade Hadoop version to 2.7.1
> ---
>
> Key: LENS-1508
> URL: https://issues.apache.org/jira/browse/LENS-1508
> Project: Apache Lens
>  Issue Type: Task
>  Components: server
>    Reporter: Rajitha R
>    Assignee: Rajitha R
>Priority: Major
> Fix For: 2.7
>
> Attachments: LENS-1508.patch
>
>
> The hadoop version will be upgraded to 2.7.1 to enable the authentication and 
> authorization feature in Lens.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Closed] (LENS-1508) Upgrade Hadoop version to 2.7.1

[Rajitha R (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajitha R closed LENS-1508.
---

> Upgrade Hadoop version to 2.7.1
> ---
>
> Key: LENS-1508
> URL: https://issues.apache.org/jira/browse/LENS-1508
> Project: Apache Lens
>  Issue Type: Task
>  Components: server
>    Reporter: Rajitha R
>    Assignee: Rajitha R
>Priority: Major
> Fix For: 2.8
>
> Attachments: LENS-1508.patch
>
>
> The hadoop version will be upgraded to 2.7.1 to enable the authentication and 
> authorization feature in Lens.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (LENS-1508) Upgrade Hadoop version to 2.7.1

[Rajitha R (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajitha R updated LENS-1508:

Status: Patch Available  (was: Open)

> Upgrade Hadoop version to 2.7.1
> ---
>
> Key: LENS-1508
> URL: https://issues.apache.org/jira/browse/LENS-1508
> Project: Apache Lens
>  Issue Type: Task
>  Components: server
>    Reporter: Rajitha R
>    Assignee: Rajitha R
>Priority: Major
> Attachments: LENS-1508.patch
>
>
> The hadoop version will be upgraded to 2.7.1 to enable the authentication and 
> authorization feature in Lens.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (LENS-1508) Upgrade Hadoop version to 2.7.1

[Rajitha R (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajitha R updated LENS-1508:

   Resolution: Fixed
Fix Version/s: 2.8
   Status: Resolved  (was: Patch Available)

> Upgrade Hadoop version to 2.7.1
> ---
>
> Key: LENS-1508
> URL: https://issues.apache.org/jira/browse/LENS-1508
> Project: Apache Lens
>  Issue Type: Task
>  Components: server
>    Reporter: Rajitha R
>    Assignee: Rajitha R
>Priority: Major
> Fix For: 2.8
>
> Attachments: LENS-1508.patch
>
>
> The hadoop version will be upgraded to 2.7.1 to enable the authentication and 
> authorization feature in Lens.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Reopened] (LENS-1524) Exposing jmx port for monitoring the threads, cpu and memory

[Rajitha R (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajitha R reopened LENS-1524:
-

> Exposing jmx port for monitoring the threads, cpu and memory
> 
>
> Key: LENS-1524
> URL: https://issues.apache.org/jira/browse/LENS-1524
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>Reporter: Rajashekhar
>Priority: Major
>
> Exposing jmx port for monitoring the threads, cpu and memory
> The pull request is below:
> https://github.com/apache/lens/pull/26



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (LENS-1523) Adding serialversionUID in BackoffretryHandlers

[Rajitha R (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajitha R updated LENS-1523:

   Resolution: Fixed
Fix Version/s: 2.8
   Status: Resolved  (was: Patch Available)

> Adding serialversionUID in BackoffretryHandlers
> ---
>
> Key: LENS-1523
> URL: https://issues.apache.org/jira/browse/LENS-1523
> Project: Apache Lens
>  Issue Type: Task
>  Components: server
>    Reporter: Rajitha R
>    Assignee: Rajitha R
>Priority: Major
> Fix For: 2.8
>
> Attachments: LENS-1523.patch
>
>
> There is no existing serialversionUID defined in any of the classes 
> implementing BackOffHandlers. This makes it difficult to load a persisted 
> state of Queries whenver there are changes in the classes implementing the 
> BackOffHandlers. This needs to be fixed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (LENS-1523) Adding serialversionUID in BackoffretryHandlers

[Rajitha R (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16543015#comment-16543015
 ] 

Rajitha R commented on LENS-1523:
-

Committed.

> Adding serialversionUID in BackoffretryHandlers
> ---
>
> Key: LENS-1523
> URL: https://issues.apache.org/jira/browse/LENS-1523
> Project: Apache Lens
>  Issue Type: Task
>  Components: server
>    Reporter: Rajitha R
>    Assignee: Rajitha R
>Priority: Major
> Fix For: 2.8
>
> Attachments: LENS-1523.patch
>
>
> There is no existing serialversionUID defined in any of the classes 
> implementing BackOffHandlers. This makes it difficult to load a persisted 
> state of Queries whenver there are changes in the classes implementing the 
> BackOffHandlers. This needs to be fixed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (LENS-1523) Adding serialversionUID in BackoffretryHandlers

[Rajitha R (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajitha R updated LENS-1523:

Status: Patch Available  (was: In Progress)

> Adding serialversionUID in BackoffretryHandlers
> ---
>
> Key: LENS-1523
> URL: https://issues.apache.org/jira/browse/LENS-1523
> Project: Apache Lens
>  Issue Type: Task
>  Components: server
>    Reporter: Rajitha R
>    Assignee: Rajitha R
>Priority: Major
> Attachments: LENS-1523.patch
>
>
> There is no existing serialversionUID defined in any of the classes 
> implementing BackOffHandlers. This makes it difficult to load a persisted 
> state of Queries whenver there are changes in the classes implementing the 
> BackOffHandlers. This needs to be fixed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (LENS-1523) Adding serialversionUID in BackoffretryHandlers

[Rajitha R (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajitha R updated LENS-1523:

Attachment: LENS-1523.patch

> Adding serialversionUID in BackoffretryHandlers
> ---
>
> Key: LENS-1523
> URL: https://issues.apache.org/jira/browse/LENS-1523
> Project: Apache Lens
>  Issue Type: Task
>  Components: server
>    Reporter: Rajitha R
>    Assignee: Rajitha R
>Priority: Major
> Attachments: LENS-1523.patch
>
>
> There is no existing serialversionUID defined in any of the classes 
> implementing BackOffHandlers. This makes it difficult to load a persisted 
> state of Queries whenver there are changes in the classes implementing the 
> BackOffHandlers. This needs to be fixed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (LENS-1523) Adding serialversionUID in BackoffretryHandlers

[Rajitha R (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16542858#comment-16542858
 ] 

Rajitha R commented on LENS-1523:
-

https://reviews.apache.org/r/67898/

> Adding serialversionUID in BackoffretryHandlers
> ---
>
> Key: LENS-1523
> URL: https://issues.apache.org/jira/browse/LENS-1523
> Project: Apache Lens
>  Issue Type: Task
>  Components: server
>    Reporter: Rajitha R
>    Assignee: Rajitha R
>Priority: Major
>
> There is no existing serialversionUID defined in any of the classes 
> implementing BackOffHandlers. This makes it difficult to load a persisted 
> state of Queries whenver there are changes in the classes implementing the 
> BackOffHandlers. This needs to be fixed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Review Request 67898: Adding serialversionUID in BackoffretryHandlers

[Rajitha R]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67898/
---

Review request for lens and Rajat Khandelwal.


Bugs: LENS-1523
https://issues.apache.org/jira/browse/LENS-1523


Repository: lens


Description
---

Adding serialversionUID in BackoffretryHandlers


Diffs
-

  
lens-server-api/src/main/java/org/apache/lens/server/api/retry/FibonacciExponentialBackOffRetryHandler.java
 be3fc52 
  
lens-server-api/src/main/java/org/apache/lens/server/api/retry/ImmediateRetryHandler.java
 cea9df3 
  lens_bk d0d9adf 


Diff: https://reviews.apache.org/r/67898/diff/1/


Testing
---


Thanks,

Rajitha R

[jira] [Created] (LENS-1523) Adding serialversionUID in BackoffretryHandlers

[Rajitha R (JIRA)]

Rajitha R created LENS-1523:
---

 Summary: Adding serialversionUID in BackoffretryHandlers
 Key: LENS-1523
 URL: https://issues.apache.org/jira/browse/LENS-1523
 Project: Apache Lens
  Issue Type: Task
  Components: server
Reporter: Rajitha R
Assignee: Rajitha R


There is no existing serialversionUID defined in any of the classes 
implementing BackOffHandlers. This makes it difficult to load a persisted state 
of Queries whenver there are changes in the classes implementing the 
BackOffHandlers. This needs to be fixed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Work started] (LENS-1523) Adding serialversionUID in BackoffretryHandlers

[Rajitha R (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on LENS-1523 started by Rajitha R.
---
> Adding serialversionUID in BackoffretryHandlers
> ---
>
> Key: LENS-1523
> URL: https://issues.apache.org/jira/browse/LENS-1523
> Project: Apache Lens
>  Issue Type: Task
>  Components: server
>    Reporter: Rajitha R
>    Assignee: Rajitha R
>Priority: Major
>
> There is no existing serialversionUID defined in any of the classes 
> implementing BackOffHandlers. This makes it difficult to load a persisted 
> state of Queries whenver there are changes in the classes implementing the 
> BackOffHandlers. This needs to be fixed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (LENS-1371) Add a substring based retry policy for failures

[Rajitha R (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajitha R updated LENS-1371:

   Resolution: Fixed
Fix Version/s: 2.8
   Status: Resolved  (was: Patch Available)

> Add a substring based retry policy for failures
> ---
>
> Key: LENS-1371
> URL: https://issues.apache.org/jira/browse/LENS-1371
> Project: Apache Lens
>  Issue Type: New Feature
>Reporter: Lavkesh Lahngir
>    Assignee: Rajitha R
>Priority: Major
> Fix For: 2.8
>
> Attachments: 0001-Retry-patch.patch, 0001-Retry-policy.patch, 
> 0001-Retry-policy.patch, 0001-Retry-policy.patch, LENS-1371.1.patch, 
> LENS-1371.2.patch, LENS-1371.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Closed] (LENS-1371) Add a substring based retry policy for failures

[Rajitha R (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajitha R closed LENS-1371.
---

> Add a substring based retry policy for failures
> ---
>
> Key: LENS-1371
> URL: https://issues.apache.org/jira/browse/LENS-1371
> Project: Apache Lens
>  Issue Type: New Feature
>Reporter: Lavkesh Lahngir
>    Assignee: Rajitha R
>Priority: Major
> Fix For: 2.8
>
> Attachments: 0001-Retry-patch.patch, 0001-Retry-policy.patch, 
> 0001-Retry-policy.patch, 0001-Retry-policy.patch, LENS-1371.1.patch, 
> LENS-1371.2.patch, LENS-1371.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (LENS-1371) Add a substring based retry policy for failures

[Rajitha R (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajitha R updated LENS-1371:

Attachment: LENS-1371.2.patch

> Add a substring based retry policy for failures
> ---
>
> Key: LENS-1371
> URL: https://issues.apache.org/jira/browse/LENS-1371
> Project: Apache Lens
>  Issue Type: New Feature
>Reporter: Lavkesh Lahngir
>    Assignee: Rajitha R
>Priority: Major
> Attachments: 0001-Retry-patch.patch, 0001-Retry-policy.patch, 
> 0001-Retry-policy.patch, 0001-Retry-policy.patch, LENS-1371.1.patch, 
> LENS-1371.2.patch, LENS-1371.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (LENS-1371) Add a substring based retry policy for failures

[Rajitha R (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538152#comment-16538152
 ] 

Rajitha R commented on LENS-1371:
-

Review request : https://reviews.apache.org/r/64946

> Add a substring based retry policy for failures
> ---
>
> Key: LENS-1371
> URL: https://issues.apache.org/jira/browse/LENS-1371
> Project: Apache Lens
>  Issue Type: New Feature
>Reporter: Lavkesh Lahngir
>    Assignee: Rajitha R
>Priority: Major
> Attachments: 0001-Retry-patch.patch, 0001-Retry-policy.patch, 
> 0001-Retry-policy.patch, 0001-Retry-policy.patch, LENS-1371.1.patch, 
> LENS-1371.2.patch, LENS-1371.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (LENS-1502) For virtual facts, column start and end times are not working

[Rajitha R (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajitha R updated LENS-1502:

   Resolution: Fixed
Fix Version/s: 2.8
   Status: Resolved  (was: Patch Available)

> For virtual facts, column start and end times are not working
> -
>
> Key: LENS-1502
> URL: https://issues.apache.org/jira/browse/LENS-1502
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>    Reporter: Rajitha R
>    Assignee: Rajitha R
>Priority: Major
> Fix For: 2.8
>
> Attachments: LENS-1502.patch
>
>
> For virtual facts, column start and end times are not working after LENS-1480



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (LENS-1502) For virtual facts, column start and end times are not working

[Rajitha R (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajitha R updated LENS-1502:

Status: Patch Available  (was: Open)

> For virtual facts, column start and end times are not working
> -
>
> Key: LENS-1502
> URL: https://issues.apache.org/jira/browse/LENS-1502
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>    Reporter: Rajitha R
>    Assignee: Rajitha R
>Priority: Major
> Attachments: LENS-1502.patch
>
>
> For virtual facts, column start and end times are not working after LENS-1480



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (LENS-1502) For virtual facts, column start and end times are not working

[Rajitha R (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajitha R updated LENS-1502:

Attachment: LENS-1502.patch

> For virtual facts, column start and end times are not working
> -
>
> Key: LENS-1502
> URL: https://issues.apache.org/jira/browse/LENS-1502
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>    Reporter: Rajitha R
>    Assignee: Rajitha R
>Priority: Major
> Fix For: 2.8
>
> Attachments: LENS-1502.patch
>
>
> For virtual facts, column start and end times are not working after LENS-1480



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (LENS-1502) For virtual facts, column start and end times are not working

[Rajitha R (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524922#comment-16524922
 ] 

Rajitha R commented on LENS-1502:
-

Committed.

> For virtual facts, column start and end times are not working
> -
>
> Key: LENS-1502
> URL: https://issues.apache.org/jira/browse/LENS-1502
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>    Reporter: Rajitha R
>    Assignee: Rajitha R
>Priority: Major
> Fix For: 2.8
>
> Attachments: LENS-1502.patch
>
>
> For virtual facts, column start and end times are not working after LENS-1480



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (LENS-1521) Download url config needs to be specific to Query and not Service

[Rajitha R (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajitha R updated LENS-1521:

Status: Patch Available  (was: Open)

> Download url config needs to be specific to Query and not Service
> -
>
> Key: LENS-1521
> URL: https://issues.apache.org/jira/browse/LENS-1521
> Project: Apache Lens
>  Issue Type: Task
>  Components: server
>    Reporter: Rajitha R
>    Assignee: Rajitha R
>Priority: Major
> Attachments: LENS-1521.3.patch
>
>
> After LENS-1519 changes, the custom download url is being set in service conf 
> and not query specific conf. This needs to be fixed



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (LENS-1521) Download url config needs to be specific to Query and not Service

[Rajitha R (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajitha R updated LENS-1521:

Attachment: LENS-1521.3.patch

> Download url config needs to be specific to Query and not Service
> -
>
> Key: LENS-1521
> URL: https://issues.apache.org/jira/browse/LENS-1521
> Project: Apache Lens
>  Issue Type: Task
>  Components: server
>    Reporter: Rajitha R
>    Assignee: Rajitha R
>Priority: Major
> Fix For: 2.8
>
> Attachments: LENS-1521.3.patch
>
>
> After LENS-1519 changes, the custom download url is being set in service conf 
> and not query specific conf. This needs to be fixed



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (LENS-1521) Download url config needs to be specific to Query and not Service

[Rajitha R (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524906#comment-16524906
 ] 

Rajitha R commented on LENS-1521:
-

https://reviews.apache.org/r/67568/

> Download url config needs to be specific to Query and not Service
> -
>
> Key: LENS-1521
> URL: https://issues.apache.org/jira/browse/LENS-1521
> Project: Apache Lens
>  Issue Type: Task
>  Components: server
>    Reporter: Rajitha R
>    Assignee: Rajitha R
>Priority: Major
> Fix For: 2.8
>
> Attachments: LENS-1521.3.patch
>
>
> After LENS-1519 changes, the custom download url is being set in service conf 
> and not query specific conf. This needs to be fixed



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (LENS-1521) Download url config needs to be specific to Query and not Service

[Rajitha R (JIRA)]

Rajitha R created LENS-1521:
---

 Summary: Download url config needs to be specific to Query and not 
Service
 Key: LENS-1521
 URL: https://issues.apache.org/jira/browse/LENS-1521
 Project: Apache Lens
  Issue Type: Task
  Components: server
Reporter: Rajitha R
Assignee: Rajitha R


After LENS-1519 changes, the custom download url is being set in service conf 
and not query specific conf. This needs to be fixed



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (LENS-1520) Lens build failing due to test case failures

[Rajitha R (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajitha R updated LENS-1520:

   Resolution: Fixed
Fix Version/s: 2.8
   Status: Resolved  (was: Patch Available)

> Lens build failing due to test case failures
> 
>
> Key: LENS-1520
> URL: https://issues.apache.org/jira/browse/LENS-1520
> Project: Apache Lens
>  Issue Type: Task
>  Components: server
>    Reporter: Rajitha R
>    Assignee: Rajitha R
>Priority: Major
> Fix For: 2.8
>
> Attachments: LENS-1520.patch
>
>
> Lens build failing due to test case failures



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)