[jira] [Commented] (LENS-1308) User config loader database calls not inserting entries
[ https://issues.apache.org/jira/browse/LENS-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15568805#comment-15568805 ] Hudson commented on LENS-1308: -- UNSTABLE: Integrated in Jenkins build Lens-Commit #1358 (See [https://builds.apache.org/job/Lens-Commit/1358/]) LENS-1308: User config loader database calls not inserting entries (rajatgupta59: rev 39252f9afdffa2cd777f0c94c3426ee149359700) * (edit) lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java * (edit) lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java > User config loader database calls not inserting entries > --- > > Key: LENS-1308 > URL: https://issues.apache.org/jira/browse/LENS-1308 > Project: Apache Lens > Issue Type: Bug >Affects Versions: 2.3 >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Fix For: 2.7 > > Attachments: LENS-1308.01.patch, LENS-1308.02.patch, > LENS-1308.02.patch, LENS-1308.03.patch, LENS-1308.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1308) User config loader database calls not inserting entries
[ https://issues.apache.org/jira/browse/LENS-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15568632#comment-15568632 ] Rajat Khandelwal commented on LENS-1308: Committed myself. > User config loader database calls not inserting entries > --- > > Key: LENS-1308 > URL: https://issues.apache.org/jira/browse/LENS-1308 > Project: Apache Lens > Issue Type: Bug >Affects Versions: 2.3 >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Fix For: 2.7 > > Attachments: LENS-1308.01.patch, LENS-1308.02.patch, > LENS-1308.02.patch, LENS-1308.03.patch, LENS-1308.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1308) User config loader database calls not inserting entries
[ https://issues.apache.org/jira/browse/LENS-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15559498#comment-15559498 ] Hadoop QA commented on LENS-1308: - Applied patch: [LENS-1308.03.patch|https://issues.apache.org/jira/secure/attachment/12831492/LENS-1308.03.patch] and ran command: mvn clean install -fae. Result: Failure. Build Job: https://builds.apache.org/job/PreCommit-Lens-Build/1024/ > User config loader database calls not inserting entries > --- > > Key: LENS-1308 > URL: https://issues.apache.org/jira/browse/LENS-1308 > Project: Apache Lens > Issue Type: Bug >Affects Versions: 2.3 >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Fix For: 2.7 > > Attachments: LENS-1308.01.patch, LENS-1308.02.patch, > LENS-1308.02.patch, LENS-1308.03.patch, LENS-1308.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1308) User config loader database calls not inserting entries
[ https://issues.apache.org/jira/browse/LENS-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1249#comment-1249 ] Hadoop QA commented on LENS-1308: - Applied patch: [LENS-1308.03.patch|https://issues.apache.org/jira/secure/attachment/12831492/LENS-1308.03.patch] and ran command: mvn clean install -fae. Result: Failure. Build Job: https://builds.apache.org/job/PreCommit-Lens-Build/1008/ > User config loader database calls not inserting entries > --- > > Key: LENS-1308 > URL: https://issues.apache.org/jira/browse/LENS-1308 > Project: Apache Lens > Issue Type: Bug >Affects Versions: 2.3 >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Fix For: 2.7 > > Attachments: LENS-1308.01.patch, LENS-1308.02.patch, > LENS-1308.02.patch, LENS-1308.03.patch, LENS-1308.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1308) User config loader database calls not inserting entries
[ https://issues.apache.org/jira/browse/LENS-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15548197#comment-15548197 ] Hadoop QA commented on LENS-1308: - Applied patch: [LENS-1308.03.patch|https://issues.apache.org/jira/secure/attachment/12831492/LENS-1308.03.patch] and ran command: mvn clean install -fae. Result: Failure. Build Job: https://builds.apache.org/job/PreCommit-Lens-Build/987/ > User config loader database calls not inserting entries > --- > > Key: LENS-1308 > URL: https://issues.apache.org/jira/browse/LENS-1308 > Project: Apache Lens > Issue Type: Bug >Affects Versions: 2.3 >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Fix For: 2.7 > > Attachments: LENS-1308.01.patch, LENS-1308.02.patch, > LENS-1308.02.patch, LENS-1308.03.patch, LENS-1308.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1308) User config loader database calls not inserting entries
[ https://issues.apache.org/jira/browse/LENS-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15547999#comment-15547999 ] Hadoop QA commented on LENS-1308: - Applied patch: [LENS-1308.03.patch|https://issues.apache.org/jira/secure/attachment/12831492/LENS-1308.03.patch] and ran command: mvn clean install -fae. Result: Failure. Build Job: https://builds.apache.org/job/PreCommit-Lens-Build/985/ > User config loader database calls not inserting entries > --- > > Key: LENS-1308 > URL: https://issues.apache.org/jira/browse/LENS-1308 > Project: Apache Lens > Issue Type: Bug >Affects Versions: 2.3 >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Fix For: 2.7 > > Attachments: LENS-1308.01.patch, LENS-1308.02.patch, > LENS-1308.02.patch, LENS-1308.03.patch, LENS-1308.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1308) User config loader database calls not inserting entries
[ https://issues.apache.org/jira/browse/LENS-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15544878#comment-15544878 ] Hadoop QA commented on LENS-1308: - Applied patch: [LENS-1308.03.patch|https://issues.apache.org/jira/secure/attachment/12831492/LENS-1308.03.patch] and ran command: mvn clean install -fae. Result: Failure. Build Job: https://builds.apache.org/job/PreCommit-Lens-Build/983/ > User config loader database calls not inserting entries > --- > > Key: LENS-1308 > URL: https://issues.apache.org/jira/browse/LENS-1308 > Project: Apache Lens > Issue Type: Bug >Affects Versions: 2.3 >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Fix For: 2.7 > > Attachments: LENS-1308.01.patch, LENS-1308.02.patch, > LENS-1308.02.patch, LENS-1308.03.patch, LENS-1308.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1308) User config loader database calls not inserting entries
[ https://issues.apache.org/jira/browse/LENS-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15542785#comment-15542785 ] Hadoop QA commented on LENS-1308: - Applied patch: [LENS-1308.02.patch|https://issues.apache.org/jira/secure/attachment/12831294/LENS-1308.02.patch] and ran command: mvn clean install -fae. Result: Failure. Build Job: https://builds.apache.org/job/PreCommit-Lens-Build/982/ > User config loader database calls not inserting entries > --- > > Key: LENS-1308 > URL: https://issues.apache.org/jira/browse/LENS-1308 > Project: Apache Lens > Issue Type: Bug >Affects Versions: 2.3 >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Fix For: 2.7 > > Attachments: LENS-1308.01.patch, LENS-1308.02.patch, > LENS-1308.02.patch, LENS-1308.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1308) User config loader database calls not inserting entries
[ https://issues.apache.org/jira/browse/LENS-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15542139#comment-15542139 ] Hadoop QA commented on LENS-1308: - Applied patch: [LENS-1308.02.patch|https://issues.apache.org/jira/secure/attachment/12831291/LENS-1308.02.patch] and ran command: mvn clean install -fae. Result: Failure. Build Job: https://builds.apache.org/job/PreCommit-Lens-Build/975/ > User config loader database calls not inserting entries > --- > > Key: LENS-1308 > URL: https://issues.apache.org/jira/browse/LENS-1308 > Project: Apache Lens > Issue Type: Bug >Affects Versions: 2.3 >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Fix For: 2.7 > > Attachments: LENS-1308.01.patch, LENS-1308.02.patch, > LENS-1308.02.patch, LENS-1308.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1308) User config loader database calls not inserting entries
[ https://issues.apache.org/jira/browse/LENS-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15542112#comment-15542112 ] Rajat Khandelwal commented on LENS-1308: Taking patch from reviewboard and attaching > User config loader database calls not inserting entries > --- > > Key: LENS-1308 > URL: https://issues.apache.org/jira/browse/LENS-1308 > Project: Apache Lens > Issue Type: Bug >Affects Versions: 2.3 >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Fix For: 2.7 > > Attachments: LENS-1308.01.patch, LENS-1308.02.patch, > LENS-1308.02.patch, LENS-1308.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1308) User config loader database calls not inserting entries
[ https://issues.apache.org/jira/browse/LENS-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15542054#comment-15542054 ] Rajat Khandelwal commented on LENS-1308: Taking patch from reviewboard and attaching > User config loader database calls not inserting entries > --- > > Key: LENS-1308 > URL: https://issues.apache.org/jira/browse/LENS-1308 > Project: Apache Lens > Issue Type: Bug >Affects Versions: 2.3 >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Fix For: 2.7 > > Attachments: LENS-1308.01.patch, LENS-1308.02.patch, LENS-1308.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1308) User config loader database calls not inserting entries
[ https://issues.apache.org/jira/browse/LENS-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15523181#comment-15523181 ] Hadoop QA commented on LENS-1308: - Patch does not apply. Build job: https://builds.apache.org/job/PreCommit-Lens-Build/961/ > User config loader database calls not inserting entries > --- > > Key: LENS-1308 > URL: https://issues.apache.org/jira/browse/LENS-1308 > Project: Apache Lens > Issue Type: Bug >Affects Versions: 2.3 >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Fix For: 2.7 > > Attachments: LENS-1308.01.patch, LENS-1308.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1308) User config loader database calls not inserting entries
[ https://issues.apache.org/jira/browse/LENS-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15503166#comment-15503166 ] Rajat Khandelwal commented on LENS-1308: Created https://reviews.apache.org/r/52028/ > User config loader database calls not inserting entries > --- > > Key: LENS-1308 > URL: https://issues.apache.org/jira/browse/LENS-1308 > Project: Apache Lens > Issue Type: Bug >Affects Versions: 2.3 >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Fix For: 2.7 > > Attachments: LENS-1308.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1308) User config loader database calls not inserting entries
[ https://issues.apache.org/jira/browse/LENS-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15503086#comment-15503086 ] Rajat Khandelwal commented on LENS-1308: I'd like to move the entire codebase to either of these states: * *State1*: All the db interactions happen without explicit commits. * *State2*: All the db interactions happen with explicit commits. Since we are not using transactions anywhere, for us, both the states are equivalent and we can move to either. As it happens, moving to 1 is easier. It requires making autocommit true and removing the explicit commit statement for inserting a finished query. Will test further and update. > User config loader database calls not inserting entries > --- > > Key: LENS-1308 > URL: https://issues.apache.org/jira/browse/LENS-1308 > Project: Apache Lens > Issue Type: Bug >Affects Versions: 2.3 >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Fix For: 2.7 > > Attachments: LENS-1308.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1308) User config loader database calls not inserting entries
[
https://issues.apache.org/jira/browse/LENS-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15498498#comment-15498498
]
Puneet Gupta commented on LENS-1308:
Lets keep auto commit false by default and have explicit commit (like we are
doing in org.apache.lens.server.query.LensServerDAO#insertFinishedQuery). Or
else we need to follow a different model where we can keep autocommit true by
default and turn it off wherever we need transactions (may be very few places).
{noformat}
conn.setAutoCommit(false)
try
{
…some logic...
insert one row ..
insert another row..
conn.setAutoCommit(true)
} Exception { }
{noformat}
between 1st and 2nd row if there is an error we should not commit
Note sure if below are working in current state without any explicit commits.
1. org.apache.lens.server.query.LensServerDAO#createFinishedQueriesTable and
2. org.apache.lens.server.query.LensServerDAO#dropFinishedQueriesTable
> User config loader database calls not inserting entries
> ---
>
> Key: LENS-1308
> URL: https://issues.apache.org/jira/browse/LENS-1308
> Project: Apache Lens
> Issue Type: Bug
>Affects Versions: 2.3
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Fix For: 2.7
>
> Attachments: LENS-1308.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (LENS-1308) User config loader database calls not inserting entries
[ https://issues.apache.org/jira/browse/LENS-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15498257#comment-15498257 ] Amareshwari Sriramadasu commented on LENS-1308: --- [~deepak.barr], LENS-639 has made autocommit to false. [~prongs] is planning to make it true again here. We need to understand more on why it was required and what changes would be suggested here. >From the changes in LENS-639 with insertFinishedQuery, I see explicit commit >needs to called. [~prongs] Should we be doing explicit commit in user config >loader as well? > User config loader database calls not inserting entries > --- > > Key: LENS-1308 > URL: https://issues.apache.org/jira/browse/LENS-1308 > Project: Apache Lens > Issue Type: Bug >Affects Versions: 2.6 >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Fix For: 2.7 > > Attachments: LENS-1308.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1308) User config loader database calls not inserting entries
[ https://issues.apache.org/jira/browse/LENS-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15496191#comment-15496191 ] Hadoop QA commented on LENS-1308: - Applied patch: [LENS-1308.patch|https://issues.apache.org/jira/secure/attachment/12827352/LENS-1308.patch], [LENS-1323.01.patch|https://issues.apache.org/jira/secure/attachment/12828820/LENS-1323.01.patch] and ran command: mvn clean install -fae. Result: Failure. Build Job: https://builds.apache.org/job/PreCommit-Lens-Build/921/ > User config loader database calls not inserting entries > --- > > Key: LENS-1308 > URL: https://issues.apache.org/jira/browse/LENS-1308 > Project: Apache Lens > Issue Type: Bug >Affects Versions: 2.6 >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Fix For: 2.7 > > Attachments: LENS-1308.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1308) User config loader database calls not inserting entries
[ https://issues.apache.org/jira/browse/LENS-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15476413#comment-15476413 ] Hadoop QA commented on LENS-1308: - Applied patch: [LENS-1308.patch|https://issues.apache.org/jira/secure/attachment/12827352/LENS-1308.patch] and ran command: mvn clean install -fae. Result: Success. Build Job: https://builds.apache.org/job/PreCommit-Lens-Build/889/ > User config loader database calls not inserting entries > --- > > Key: LENS-1308 > URL: https://issues.apache.org/jira/browse/LENS-1308 > Project: Apache Lens > Issue Type: Bug >Affects Versions: 2.6 >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Fix For: 2.7 > > Attachments: LENS-1308.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1308) User config loader database calls not inserting entries
[ https://issues.apache.org/jira/browse/LENS-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15476334#comment-15476334 ] Hadoop QA commented on LENS-1308: - Applied patch: [LENS-1308.patch|https://issues.apache.org/jira/secure/attachment/12827352/LENS-1308.patch] and ran command: mvn clean install -fae. Result: Failure. Build Job: https://builds.apache.org/job/PreCommit-Lens-Build/884/ > User config loader database calls not inserting entries > --- > > Key: LENS-1308 > URL: https://issues.apache.org/jira/browse/LENS-1308 > Project: Apache Lens > Issue Type: Bug >Affects Versions: 2.6 >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Fix For: 2.7 > > Attachments: LENS-1308.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1308) User config loader database calls not inserting entries
[ https://issues.apache.org/jira/browse/LENS-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15476309#comment-15476309 ] Hadoop QA commented on LENS-1308: - Applied patch: [LENS-1308.patch|https://issues.apache.org/jira/secure/attachment/12827352/LENS-1308.patch] and ran command: mvn clean install -fae. Result: Failure. Build Job: https://builds.apache.org/job/PreCommit-Lens-Build/882/ > User config loader database calls not inserting entries > --- > > Key: LENS-1308 > URL: https://issues.apache.org/jira/browse/LENS-1308 > Project: Apache Lens > Issue Type: Bug >Affects Versions: 2.6 >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Fix For: 2.7 > > Attachments: LENS-1308.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1308) User config loader database calls not inserting entries
[ https://issues.apache.org/jira/browse/LENS-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15476063#comment-15476063 ] Hadoop QA commented on LENS-1308: - Applied patch: [LENS-1308.patch|https://issues.apache.org/jira/secure/attachment/12827352/LENS-1308.patch] and ran command: mvn clean install -fae. Result: Failure. Build Job: https://builds.apache.org/job/PreCommit-Lens-Build/876/ > User config loader database calls not inserting entries > --- > > Key: LENS-1308 > URL: https://issues.apache.org/jira/browse/LENS-1308 > Project: Apache Lens > Issue Type: Bug >Affects Versions: 2.6 >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Fix For: 2.7 > > Attachments: LENS-1308.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1308) User config loader database calls not inserting entries
[ https://issues.apache.org/jira/browse/LENS-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15470369#comment-15470369 ] Hadoop QA commented on LENS-1308: - Applied patch: [LENS-1308.patch|https://issues.apache.org/jira/secure/attachment/12827352/LENS-1308.patch] and ran command: mvn clean install -fae. Result: Failure. Build Job: https://builds.apache.org/job/PreCommit-Lens-Build/867/ > User config loader database calls not inserting entries > --- > > Key: LENS-1308 > URL: https://issues.apache.org/jira/browse/LENS-1308 > Project: Apache Lens > Issue Type: Bug >Affects Versions: 2.6 >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Fix For: 2.7 > > Attachments: LENS-1308.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
