[jira] [Commented] (LENS-1418) LensClient is not thread safe
[
https://issues.apache.org/jira/browse/LENS-1418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15998282#comment-15998282
]
Hudson commented on LENS-1418:
--
UNSTABLE: Integrated in Jenkins build Lens-Commit #1404 (See
[https://builds.apache.org/job/Lens-Commit/1404/])
LENS-1418: LensClient is not thread safe (rajatgupta59: rev
139f029ae88da7cc29a02afeee73a542f0c92eef)
* (edit) lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java
* (edit) src/site/apt/user/cli.apt
* (edit) lens-client/src/main/java/org/apache/lens/client/LensClient.java
> LensClient is not thread safe
> -
>
> Key: LENS-1418
> URL: https://issues.apache.org/jira/browse/LENS-1418
> Project: Apache Lens
> Issue Type: Bug
> Components: client
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Fix For: 2.7
>
> Attachments: LENS-1418.01.patch, LENS-1418.03.patch,
> LENS-1418.04.patch, LENS-1418.05.patch, LENS-1418.06.patch, LENS-1418.07.patch
>
>
> Using one lens client to fire two queries in two threads results in
> discrepencies. LensClient has a {{Map}} and also
> has a cached instance of {{LensStatement}}. When two threads fire queries,
> both use the same statement object. {{LensStatement}} object in turn caches
> {{LensQuery}} Object. So whichever thread fired query last is the last one to
> set lens query inside statement causing
> {{LensClient.getStatement().getQuery()}} to return that query object for all
> threads.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (LENS-1418) LensClient is not thread safe
[
https://issues.apache.org/jira/browse/LENS-1418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15998243#comment-15998243
]
Hadoop QA commented on LENS-1418:
-
Applied patch:
[LENS-1418.07.patch|https://issues.apache.org/jira/secure/attachment/12866600/LENS-1418.07.patch]
and ran command: mvn clean install -fae. Result: Success. Build Job:
https://builds.apache.org/job/PreCommit-Lens-Build/1293/
> LensClient is not thread safe
> -
>
> Key: LENS-1418
> URL: https://issues.apache.org/jira/browse/LENS-1418
> Project: Apache Lens
> Issue Type: Bug
> Components: client
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Fix For: 2.7
>
> Attachments: LENS-1418.01.patch, LENS-1418.03.patch,
> LENS-1418.04.patch, LENS-1418.05.patch, LENS-1418.06.patch, LENS-1418.07.patch
>
>
> Using one lens client to fire two queries in two threads results in
> discrepencies. LensClient has a {{Map}} and also
> has a cached instance of {{LensStatement}}. When two threads fire queries,
> both use the same statement object. {{LensStatement}} object in turn caches
> {{LensQuery}} Object. So whichever thread fired query last is the last one to
> set lens query inside statement causing
> {{LensClient.getStatement().getQuery()}} to return that query object for all
> threads.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (LENS-1418) LensClient is not thread safe
[
https://issues.apache.org/jira/browse/LENS-1418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15998201#comment-15998201
]
Rajat Khandelwal commented on LENS-1418:
Committed myself.
> LensClient is not thread safe
> -
>
> Key: LENS-1418
> URL: https://issues.apache.org/jira/browse/LENS-1418
> Project: Apache Lens
> Issue Type: Bug
> Components: client
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Fix For: 2.7
>
> Attachments: LENS-1418.01.patch, LENS-1418.03.patch,
> LENS-1418.04.patch, LENS-1418.05.patch, LENS-1418.06.patch, LENS-1418.07.patch
>
>
> Using one lens client to fire two queries in two threads results in
> discrepencies. LensClient has a {{Map}} and also
> has a cached instance of {{LensStatement}}. When two threads fire queries,
> both use the same statement object. {{LensStatement}} object in turn caches
> {{LensQuery}} Object. So whichever thread fired query last is the last one to
> set lens query inside statement causing
> {{LensClient.getStatement().getQuery()}} to return that query object for all
> threads.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (LENS-1418) LensClient is not thread safe
[
https://issues.apache.org/jira/browse/LENS-1418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15998190#comment-15998190
]
Rajat Khandelwal commented on LENS-1418:
Taking patch from reviewboard and attaching
> LensClient is not thread safe
> -
>
> Key: LENS-1418
> URL: https://issues.apache.org/jira/browse/LENS-1418
> Project: Apache Lens
> Issue Type: Bug
> Components: client
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1418.01.patch, LENS-1418.03.patch,
> LENS-1418.04.patch, LENS-1418.05.patch, LENS-1418.06.patch, LENS-1418.07.patch
>
>
> Using one lens client to fire two queries in two threads results in
> discrepencies. LensClient has a {{Map}} and also
> has a cached instance of {{LensStatement}}. When two threads fire queries,
> both use the same statement object. {{LensStatement}} object in turn caches
> {{LensQuery}} Object. So whichever thread fired query last is the last one to
> set lens query inside statement causing
> {{LensClient.getStatement().getQuery()}} to return that query object for all
> threads.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (LENS-1418) LensClient is not thread safe
[
https://issues.apache.org/jira/browse/LENS-1418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15998176#comment-15998176
]
Rajat Khandelwal commented on LENS-1418:
Taking patch from reviewboard and attaching
> LensClient is not thread safe
> -
>
> Key: LENS-1418
> URL: https://issues.apache.org/jira/browse/LENS-1418
> Project: Apache Lens
> Issue Type: Bug
> Components: client
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1418.01.patch, LENS-1418.03.patch,
> LENS-1418.04.patch, LENS-1418.05.patch, LENS-1418.06.patch
>
>
> Using one lens client to fire two queries in two threads results in
> discrepencies. LensClient has a {{Map}} and also
> has a cached instance of {{LensStatement}}. When two threads fire queries,
> both use the same statement object. {{LensStatement}} object in turn caches
> {{LensQuery}} Object. So whichever thread fired query last is the last one to
> set lens query inside statement causing
> {{LensClient.getStatement().getQuery()}} to return that query object for all
> threads.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (LENS-1418) LensClient is not thread safe
[
https://issues.apache.org/jira/browse/LENS-1418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15997996#comment-15997996
]
Hadoop QA commented on LENS-1418:
-
Applied patch:
[LENS-1418.05.patch|https://issues.apache.org/jira/secure/attachment/12866580/LENS-1418.05.patch]
and ran command: mvn clean install -fae. Result: Failure. Build Job:
https://builds.apache.org/job/PreCommit-Lens-Build/1291/
> LensClient is not thread safe
> -
>
> Key: LENS-1418
> URL: https://issues.apache.org/jira/browse/LENS-1418
> Project: Apache Lens
> Issue Type: Bug
> Components: client
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1418.01.patch, LENS-1418.03.patch,
> LENS-1418.04.patch, LENS-1418.05.patch
>
>
> Using one lens client to fire two queries in two threads results in
> discrepencies. LensClient has a {{Map}} and also
> has a cached instance of {{LensStatement}}. When two threads fire queries,
> both use the same statement object. {{LensStatement}} object in turn caches
> {{LensQuery}} Object. So whichever thread fired query last is the last one to
> set lens query inside statement causing
> {{LensClient.getStatement().getQuery()}} to return that query object for all
> threads.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (LENS-1418) LensClient is not thread safe
[
https://issues.apache.org/jira/browse/LENS-1418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15997966#comment-15997966
]
Rajat Khandelwal commented on LENS-1418:
Taking patch from reviewboard and attaching
> LensClient is not thread safe
> -
>
> Key: LENS-1418
> URL: https://issues.apache.org/jira/browse/LENS-1418
> Project: Apache Lens
> Issue Type: Bug
> Components: client
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1418.01.patch, LENS-1418.03.patch,
> LENS-1418.04.patch, LENS-1418.05.patch
>
>
> Using one lens client to fire two queries in two threads results in
> discrepencies. LensClient has a {{Map}} and also
> has a cached instance of {{LensStatement}}. When two threads fire queries,
> both use the same statement object. {{LensStatement}} object in turn caches
> {{LensQuery}} Object. So whichever thread fired query last is the last one to
> set lens query inside statement causing
> {{LensClient.getStatement().getQuery()}} to return that query object for all
> threads.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (LENS-1418) LensClient is not thread safe
[
https://issues.apache.org/jira/browse/LENS-1418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15997953#comment-15997953
]
Hadoop QA commented on LENS-1418:
-
Applied patch:
[LENS-1418.04.patch|https://issues.apache.org/jira/secure/attachment/12866573/LENS-1418.04.patch]
and ran command: mvn clean install -fae. Result: Failure. Build Job:
https://builds.apache.org/job/PreCommit-Lens-Build/1290/
> LensClient is not thread safe
> -
>
> Key: LENS-1418
> URL: https://issues.apache.org/jira/browse/LENS-1418
> Project: Apache Lens
> Issue Type: Bug
> Components: client
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1418.01.patch, LENS-1418.03.patch,
> LENS-1418.04.patch
>
>
> Using one lens client to fire two queries in two threads results in
> discrepencies. LensClient has a {{Map}} and also
> has a cached instance of {{LensStatement}}. When two threads fire queries,
> both use the same statement object. {{LensStatement}} object in turn caches
> {{LensQuery}} Object. So whichever thread fired query last is the last one to
> set lens query inside statement causing
> {{LensClient.getStatement().getQuery()}} to return that query object for all
> threads.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (LENS-1418) LensClient is not thread safe
[
https://issues.apache.org/jira/browse/LENS-1418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15997928#comment-15997928
]
Rajat Khandelwal commented on LENS-1418:
Taking patch from reviewboard and attaching
> LensClient is not thread safe
> -
>
> Key: LENS-1418
> URL: https://issues.apache.org/jira/browse/LENS-1418
> Project: Apache Lens
> Issue Type: Bug
> Components: client
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1418.01.patch, LENS-1418.03.patch,
> LENS-1418.04.patch
>
>
> Using one lens client to fire two queries in two threads results in
> discrepencies. LensClient has a {{Map}} and also
> has a cached instance of {{LensStatement}}. When two threads fire queries,
> both use the same statement object. {{LensStatement}} object in turn caches
> {{LensQuery}} Object. So whichever thread fired query last is the last one to
> set lens query inside statement causing
> {{LensClient.getStatement().getQuery()}} to return that query object for all
> threads.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (LENS-1418) LensClient is not thread safe
[
https://issues.apache.org/jira/browse/LENS-1418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15997881#comment-15997881
]
Hadoop QA commented on LENS-1418:
-
Applied patch:
[LENS-1418.03.patch|https://issues.apache.org/jira/secure/attachment/12866564/LENS-1418.03.patch]
and ran command: mvn clean install -fae. Result: Failure. Build Job:
https://builds.apache.org/job/PreCommit-Lens-Build/1289/
> LensClient is not thread safe
> -
>
> Key: LENS-1418
> URL: https://issues.apache.org/jira/browse/LENS-1418
> Project: Apache Lens
> Issue Type: Bug
> Components: client
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1418.01.patch, LENS-1418.03.patch
>
>
> Using one lens client to fire two queries in two threads results in
> discrepencies. LensClient has a {{Map}} and also
> has a cached instance of {{LensStatement}}. When two threads fire queries,
> both use the same statement object. {{LensStatement}} object in turn caches
> {{LensQuery}} Object. So whichever thread fired query last is the last one to
> set lens query inside statement causing
> {{LensClient.getStatement().getQuery()}} to return that query object for all
> threads.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (LENS-1418) LensClient is not thread safe
[
https://issues.apache.org/jira/browse/LENS-1418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15997860#comment-15997860
]
Rajat Khandelwal commented on LENS-1418:
Taking patch from reviewboard and attaching
> LensClient is not thread safe
> -
>
> Key: LENS-1418
> URL: https://issues.apache.org/jira/browse/LENS-1418
> Project: Apache Lens
> Issue Type: Bug
> Components: client
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1418.01.patch, LENS-1418.03.patch
>
>
> Using one lens client to fire two queries in two threads results in
> discrepencies. LensClient has a {{Map}} and also
> has a cached instance of {{LensStatement}}. When two threads fire queries,
> both use the same statement object. {{LensStatement}} object in turn caches
> {{LensQuery}} Object. So whichever thread fired query last is the last one to
> set lens query inside statement causing
> {{LensClient.getStatement().getQuery()}} to return that query object for all
> threads.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (LENS-1418) LensClient is not thread safe
[
https://issues.apache.org/jira/browse/LENS-1418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15996368#comment-15996368
]
Hadoop QA commented on LENS-1418:
-
Applied patch:
[LENS-1418.01.patch|https://issues.apache.org/jira/secure/attachment/12866354/LENS-1418.01.patch]
and ran command: mvn clean install -fae. Result: Failure. Build Job:
https://builds.apache.org/job/PreCommit-Lens-Build/1284/
> LensClient is not thread safe
> -
>
> Key: LENS-1418
> URL: https://issues.apache.org/jira/browse/LENS-1418
> Project: Apache Lens
> Issue Type: Bug
> Components: client
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1418.01.patch
>
>
> Using one lens client to fire two queries in two threads results in
> discrepencies. LensClient has a {{Map}} and also
> has a cached instance of {{LensStatement}}. When two threads fire queries,
> both use the same statement object. {{LensStatement}} object in turn caches
> {{LensQuery}} Object. So whichever thread fired query last is the last one to
> set lens query inside statement causing
> {{LensClient.getStatement().getQuery()}} to return that query object for all
> threads.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (LENS-1418) LensClient is not thread safe
[
https://issues.apache.org/jira/browse/LENS-1418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15996367#comment-15996367
]
Hadoop QA commented on LENS-1418:
-
Applied patch:
[LENS-1418.01.patch|https://issues.apache.org/jira/secure/attachment/12866354/LENS-1418.01.patch]
and ran command: mvn clean install -fae. Result: Failure. Build Job:
https://builds.apache.org/job/PreCommit-Lens-Build/1284/
> LensClient is not thread safe
> -
>
> Key: LENS-1418
> URL: https://issues.apache.org/jira/browse/LENS-1418
> Project: Apache Lens
> Issue Type: Bug
> Components: client
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1418.01.patch
>
>
> Using one lens client to fire two queries in two threads results in
> discrepencies. LensClient has a {{Map}} and also
> has a cached instance of {{LensStatement}}. When two threads fire queries,
> both use the same statement object. {{LensStatement}} object in turn caches
> {{LensQuery}} Object. So whichever thread fired query last is the last one to
> set lens query inside statement causing
> {{LensClient.getStatement().getQuery()}} to return that query object for all
> threads.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (LENS-1418) LensClient is not thread safe
[
https://issues.apache.org/jira/browse/LENS-1418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15996320#comment-15996320
]
Rajat Khandelwal commented on LENS-1418:
Taking patch from reviewboard and attaching
> LensClient is not thread safe
> -
>
> Key: LENS-1418
> URL: https://issues.apache.org/jira/browse/LENS-1418
> Project: Apache Lens
> Issue Type: Bug
> Components: client
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1418.01.patch
>
>
> Using one lens client to fire two queries in two threads results in
> discrepencies. LensClient has a {{Map}} and also
> has a cached instance of {{LensStatement}}. When two threads fire queries,
> both use the same statement object. {{LensStatement}} object in turn caches
> {{LensQuery}} Object. So whichever thread fired query last is the last one to
> set lens query inside statement causing
> {{LensClient.getStatement().getQuery()}} to return that query object for all
> threads.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (LENS-1418) LensClient is not thread safe
[
https://issues.apache.org/jira/browse/LENS-1418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15996317#comment-15996317
]
Rajat Khandelwal commented on LENS-1418:
Created https://reviews.apache.org/r/58986/
> LensClient is not thread safe
> -
>
> Key: LENS-1418
> URL: https://issues.apache.org/jira/browse/LENS-1418
> Project: Apache Lens
> Issue Type: Bug
> Components: client
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
>
> Using one lens client to fire two queries in two threads results in
> discrepencies. LensClient has a {{Map}} and also
> has a cached instance of {{LensStatement}}. When two threads fire queries,
> both use the same statement object. {{LensStatement}} object in turn caches
> {{LensQuery}} Object. So whichever thread fired query last is the last one to
> set lens query inside statement causing
> {{LensClient.getStatement().getQuery()}} to return that query object for all
> threads.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
