[jira] [Commented] (LENS-1461) Lens services state are not persisted correctly
[ https://issues.apache.org/jira/browse/LENS-1461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16237278#comment-16237278 ] Hudson commented on LENS-1461: -- UNSTABLE: Integrated in Jenkins build Lens-Commit #1447 (See [https://builds.apache.org/job/Lens-Commit/1447/]) LENS-1461 : Lens services state are not persisted correctly (sushilmohanty: rev 3b657dee40ef70d06e6ed589467bd455b77a5066) * (edit) lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java > Lens services state are not persisted correctly > --- > > Key: LENS-1461 > URL: https://issues.apache.org/jira/browse/LENS-1461 > Project: Apache Lens > Issue Type: Bug > Components: server >Reporter: Ankit Kailaswar >Assignee: Ankit Kailaswar >Priority: Major > Attachments: LENS-1461.patch_3, LENS-1461_3.patch > > > Lens services state are not persisted correctly causing lens to fail at > startup. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (LENS-1461) Lens services state are not persisted correctly
[ https://issues.apache.org/jira/browse/LENS-1461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16237204#comment-16237204 ] Hadoop QA commented on LENS-1461: - Applied patch: [LENS-1461_3.patch|https://issues.apache.org/jira/secure/attachment/12895578/LENS-1461_3.patch] and ran command: mvn clean install -fae. Result: Success. Build Job: https://builds.apache.org/job/PreCommit-Lens-Build/1459/ > Lens services state are not persisted correctly > --- > > Key: LENS-1461 > URL: https://issues.apache.org/jira/browse/LENS-1461 > Project: Apache Lens > Issue Type: Bug > Components: server >Reporter: Ankit Kailaswar >Assignee: Ankit Kailaswar >Priority: Major > Attachments: LENS-1461.patch_3, LENS-1461_3.patch > > > Lens services state are not persisted correctly causing lens to fail at > startup. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (LENS-1461) Lens services state are not persisted correctly
[ https://issues.apache.org/jira/browse/LENS-1461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16237194#comment-16237194 ] Hadoop QA commented on LENS-1461: - Applied patch: [LENS-1461_3.patch|https://issues.apache.org/jira/secure/attachment/12895578/LENS-1461_3.patch] and ran command: mvn clean install -fae. Result: Failure. Build Job: https://builds.apache.org/job/PreCommit-Lens-Build/1458/ > Lens services state are not persisted correctly > --- > > Key: LENS-1461 > URL: https://issues.apache.org/jira/browse/LENS-1461 > Project: Apache Lens > Issue Type: Bug > Components: server >Reporter: Ankit Kailaswar >Assignee: Ankit Kailaswar >Priority: Major > Attachments: LENS-1461.patch_3, LENS-1461_3.patch > > > Lens services state are not persisted correctly causing lens to fail at > startup. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (LENS-1461) Lens services state are not persisted correctly
[ https://issues.apache.org/jira/browse/LENS-1461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139749#comment-16139749 ] Ankit Kailaswar commented on LENS-1461: --- review request : https://reviews.apache.org/r/61881/ > Lens services state are not persisted correctly > --- > > Key: LENS-1461 > URL: https://issues.apache.org/jira/browse/LENS-1461 > Project: Apache Lens > Issue Type: Bug > Components: server >Reporter: Ankit Kailaswar >Assignee: Ankit Kailaswar > > Lens services state are not persisted correctly causing lens to fail at > startup. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (LENS-1461) Lens services state are not persisted correctly
[ https://issues.apache.org/jira/browse/LENS-1461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16132917#comment-16132917 ] Rajat Khandelwal commented on LENS-1461: bq. session timeout for lens and hive are 1 day and 3 days respectievely. For a session which is 2 days old session manager returns valid object for HiveSession but its no longer a instance of "LensSessionImpl" since lens session already expired. causing downcasting to initialize lens related member variable(LensSessionHandle, db, username, password etc) to null causing deserializer to fail for them. Not sure what you mean by this here. By my understanding, when {{LensServices}} is {{init}}ed, {{CLIService}} and {{CLIService.SessionManager}} are also {{init}}ed. In the {{init}} phase of {{SessionManager}}, session impl class is decided. That is configured to be {{LensSessionImpl.class}} in all the restarts of the Lens Server. What I am worried about though, is why the function {{org.apache.lens.server.api.session.SessionService#restoreSession}} has no usages in the project. bq. 2. downcasting is done in getsession() method in *LensSessionImpl* and referenced at lot of places. That might be causing other bugs apart from mentioned above. I assume you are talking about {{org.apache.lens.server.BaseLensService#getSession}}. {{getSession}} has another problem, it is throwing Jersey client exception. That exception is fine if it ends up to user facing api classes. But it's wrong if it is being thrown inside init/start phases. The two kind of usages' need to be served by two different functions. > Lens services state are not persisted correctly > --- > > Key: LENS-1461 > URL: https://issues.apache.org/jira/browse/LENS-1461 > Project: Apache Lens > Issue Type: Bug > Components: server >Reporter: Ankit Kailaswar >Assignee: Ankit Kailaswar > > Lens services state are not persisted correctly causing lens to fail at > startup. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (LENS-1461) Lens services state are not persisted correctly
[ https://issues.apache.org/jira/browse/LENS-1461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131977#comment-16131977 ] Ankit Kailaswar commented on LENS-1461: --- There were few issues found while persisting service states and using it to start lens server. 1. Session service is not getting persisted properly on few occasions. session service try to serialize few sessions which are invalid using its session handles throwing an exception uncaught at service level. Other services are getting persisted successfully. {panel:title=lens server log |borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1|bgColor=#CE} 14 Aug 2017 20:13:49 6daca8db-deb9-4ab0-ba2d-3f5e474ad545 Lens-server-snapshotter-Thread-1 WARN org.apache.lens.server.BaseLensService - {color:red} *Session cbc183be-8f05-4356-bb56-6ba43217518b not found* {color} org.apache.hive.service.cli.HiveSQLException: Invalid SessionHandle: SessionHandle cbc183be-8f05-4356-bb56-6ba43217518b at org.apache.hive.service.cli.session.SessionManager.getSession(SessionManager.java:389) ~hive-service-2.1.3-inm.jar:2.1.3-inm at org.apache.lens.server.BaseLensService.getSession(BaseLensService.java:366) ~classes/:na at org.apache.lens.server.session.HiveSessionService.writeExternal(HiveSessionService.java:425) classes/:na at org.apache.lens.server.LensServices.persistState(LensServices.java:369) classes/:na at org.apache.lens.server.LensServices.persistLensServiceState(LensServices.java:354) classes/:na at org.apache.lens.server.LensServices.access$100(LensServices.java:63) classes/:na at org.apache.lens.server.LensServices$1.run(LensServices.java:305) classes/:na at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) na:1.8.0_72 at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308) na:1.8.0_72 at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180) na:1.8.0_72 at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294) na:1.8.0_72 at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) na:1.8.0_72 at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) na:1.8.0_72 at java.lang.Thread.run(Thread.java:745) na:1.8.0_72 14 Aug 2017 20:13:49 ba8c2672-53a0-44ad-9d50-fc53e2286143 grizzly-http-server-12 INFO hive.metastore - Closed a connection to metastore, current connections: 282 14 Aug 2017 20:13:49 ba8c2672-53a0-44ad-9d50-fc53e2286143 grizzly-http-server-12 INFO org.apache.lens.server.BaseLensService - Closed session cbc183be-8f05-4356-bb56-6ba43217518b33a980a2-206c-4dbc-b3d9-ffa3a6b6de87 for yoda-admin user 14 Aug 2017 20:13:49 6daca8db-deb9-4ab0-ba2d-3f5e474ad545 Lens-server-snapshotter-Thread-1 ERROR org.apache.lens.server.LensServices - Error while persisting state for service session javax.ws.rs.ClientErrorException: Session cbc183be-8f05-4356-bb56-6ba43217518b is invalid cbc183be-8f05-4356-bb56-6ba43217518b33a980a2-206c-4dbc-b3d9-ffa3a6b6de87 at org.apache.lens.server.BaseLensService.getSession(BaseLensService.java:370) ~classes/:na at org.apache.lens.server.session.HiveSessionService.writeExternal(HiveSessionService.java:425) ~classes/:na at org.apache.lens.server.LensServices.persistState(LensServices.java:369) classes/:na at org.apache.lens.server.LensServices.persistLensServiceState(LensServices.java:354) classes/:na at org.apache.lens.server.LensServices.access$100(LensServices.java:63) classes/:na at org.apache.lens.server.LensServices$1.run(LensServices.java:305) classes/:na at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) na:1.8.0_72 at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308) na:1.8.0_72 at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180) na:1.8.0_72 at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294) na:1.8.0_72 at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) na:1.8.0_72 at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) na:1.8.0_72 at java.lang.Thread.run(Thread.java:745) na:1.8.0_72 Caused by: org.apache.hive.service.cli.HiveSQLException: Invalid SessionHandle: SessionHandle cbc183be-8f05-4356-bb56-6ba43217518b at org.apache.hive.service.cli.session.SessionManager.getSession(SessionManager.java:389) ~hive-service-2.1.3-inm.jar:2.1.3-inm at org.apache.lens.server.BaseLensService.getSession(BaseLensService.java:366) ~classes/:na