[jira] [Commented] (LENS-1471) JoinCandidate's children should not share same storage candidate

2017-09-04 Thread Rajat Khandelwal (JIRA)

[ 
https://issues.apache.org/jira/browse/LENS-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152474#comment-16152474
 ] 

Rajat Khandelwal commented on LENS-1471:


Taking patch from reviewboard and attaching

> JoinCandidate's children should not share same storage candidate 
> -
>
> Key: LENS-1471
> URL: https://issues.apache.org/jira/browse/LENS-1471
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1471.01.patch
>
>
> The issue is in Join candidates of the kind {{Join\[Union\[a,b\]; 
> Union\[a,c\]\]}}. If the instance of {{a}} is shared in different trees of a 
> JoinCandidate, the rewritten query will be wrong. JoinCandidate's children 
> set exclusive measure phrase indices, and that is done via truncate method of 
> list. So let's say union1 is answering {{\[0,1\]}} measures and union2 is 
> answering {{\[2,3\]}} measures, and since 
> {{\[0,1,2,3\].retain(\[0,1\]).retain(\[2,3\]) == \[\]}}, it ends up answering 
> no measures at all



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (LENS-1471) JoinCandidate's children should not share same storage candidate

2017-09-04 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/LENS-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152485#comment-16152485
 ] 

Hadoop QA commented on LENS-1471:
-

Applied patch: 
[LENS-1471.01.patch|https://issues.apache.org/jira/secure/attachment/12885240/LENS-1471.01.patch]
 and ran command: mvn clean install -fae. Result: Failure. Build Job: 
https://builds.apache.org/job/PreCommit-Lens-Build/1428/

> JoinCandidate's children should not share same storage candidate 
> -
>
> Key: LENS-1471
> URL: https://issues.apache.org/jira/browse/LENS-1471
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1471.01.patch
>
>
> The issue is in Join candidates of the kind {{Join\[Union\[a,b\]; 
> Union\[a,c\]\]}}. If the instance of {{a}} is shared in different trees of a 
> JoinCandidate, the rewritten query will be wrong. JoinCandidate's children 
> set exclusive measure phrase indices, and that is done via truncate method of 
> list. So let's say union1 is answering {{\[0,1\]}} measures and union2 is 
> answering {{\[2,3\]}} measures, and since 
> {{\[0,1,2,3\].retain(\[0,1\]).retain(\[2,3\]) == \[\]}}, it ends up answering 
> no measures at all



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (LENS-1471) JoinCandidate's children should not share same storage candidate

2017-09-04 Thread Rajat Khandelwal (JIRA)

[ 
https://issues.apache.org/jira/browse/LENS-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152472#comment-16152472
 ] 

Rajat Khandelwal commented on LENS-1471:


Created https://reviews.apache.org/r/62060/

> JoinCandidate's children should not share same storage candidate 
> -
>
> Key: LENS-1471
> URL: https://issues.apache.org/jira/browse/LENS-1471
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
>
> The issue is in Join candidates of the kind {{Join\[Union\[a,b\]; 
> Union\[a,c\]\]}}. If the instance of {{a}} is shared in different trees of a 
> JoinCandidate, the rewritten query will be wrong. JoinCandidate's children 
> set exclusive measure phrase indices, and that is done via truncate method of 
> list. So let's say union1 is answering {{\[0,1\]}} measures and union2 is 
> answering {{\[2,3\]}} measures, and since 
> {{\[0,1,2,3\].retain(\[0,1\]).retain(\[2,3\]) == \[\]}}, it ends up answering 
> no measures at all



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)