Re: Review Request 39419: LENS-824 Fix all javadoc warnings/errors
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39419/#review104675 --- Ship it! Ship It! - Amareshwari Sriramadasu On Oct. 19, 2015, 1:33 a.m., Gabor Liptak wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39419/ > --- > > (Updated Oct. 19, 2015, 1:33 a.m.) > > > Review request for lens. > > > Repository: lens > > > Description > --- > > LENS-824 Fix all javadoc warnings/errors > > > Diffs > - > > > lens-api/src/main/java/org/apache/lens/api/query/save/ParameterCollectionType.java > 971e794930e67a25404b4da75d596cfd26a7e17e > lens-api/src/main/java/org/apache/lens/api/result/PrettyPrintable.java > e6152b87cf008b4b4fcb57985c56d1449272b23d > lens-api/src/main/java/org/apache/lens/api/util/PathValidator.java > 92a936a91b7882e4de0b71b6aa9e4f3707770dce > lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java > 096fd7a09303c4da619bdf7cb73a4b25cfa3caaf > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > 4c8b525b118c280fe81e7e8ae3c6e98aab312a32 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > deb857213dc2e113d98f3cf854d0f84813455170 > > lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryDao.java > 9dfde0db7edad0c30528425479af8d4d64e894a7 > > lens-server/src/main/java/org/apache/lens/server/quota/QuotaServiceImpl.java > cc627cfcbcb266cf8586195d56742ab6ec8cbfba > > lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java > 3ea75246cb2b72376395e04eacacca1f88f8e347 > > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java > 22497ca31d710de0dcf3aef2a2a73f814e042f33 > pom.xml 714003835bccc217eb32e7c4ee782e1e6aacc434 > > Diff: https://reviews.apache.org/r/39419/diff/ > > > Testing > --- > > > Thanks, > > Gabor Liptak > >
Re: Review Request 39419: LENS-824 Fix all javadoc warnings/errors
> On Oct. 25, 2015, 3:40 a.m., Amareshwari Sriramadasu wrote: > > I see the issue is still open, but review request is closed. So, reopened. > > > > Gabor, Do you still see errors on generated doc? > > Raju/Gabor, Is that resulting in build failure in java-8? > > Raju Bairishetti wrote: > We have fixed all the javadoc errors earlier. We may get new javadoc > errors as many patches were in. > > Right now, build won't be failed as we are not generating the javadocs as > part of build. We need to fix all warnings & errors before adding javadoc to > build cycle. Raju/Gabor, Are you planning to do more work on this jira? If so, what is pending? Capturing in a review comment would make sense. If not, we should get this in. - Amareshwari --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39419/#review103931 --- On Oct. 19, 2015, 1:33 a.m., Gabor Liptak wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39419/ > --- > > (Updated Oct. 19, 2015, 1:33 a.m.) > > > Review request for lens. > > > Repository: lens > > > Description > --- > > LENS-824 Fix all javadoc warnings/errors > > > Diffs > - > > > lens-api/src/main/java/org/apache/lens/api/query/save/ParameterCollectionType.java > 971e794930e67a25404b4da75d596cfd26a7e17e > lens-api/src/main/java/org/apache/lens/api/result/PrettyPrintable.java > e6152b87cf008b4b4fcb57985c56d1449272b23d > lens-api/src/main/java/org/apache/lens/api/util/PathValidator.java > 92a936a91b7882e4de0b71b6aa9e4f3707770dce > lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java > 096fd7a09303c4da619bdf7cb73a4b25cfa3caaf > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > 4c8b525b118c280fe81e7e8ae3c6e98aab312a32 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > deb857213dc2e113d98f3cf854d0f84813455170 > > lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryDao.java > 9dfde0db7edad0c30528425479af8d4d64e894a7 > > lens-server/src/main/java/org/apache/lens/server/quota/QuotaServiceImpl.java > cc627cfcbcb266cf8586195d56742ab6ec8cbfba > > lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java > 3ea75246cb2b72376395e04eacacca1f88f8e347 > > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java > 22497ca31d710de0dcf3aef2a2a73f814e042f33 > pom.xml 714003835bccc217eb32e7c4ee782e1e6aacc434 > > Diff: https://reviews.apache.org/r/39419/diff/ > > > Testing > --- > > > Thanks, > > Gabor Liptak > >
Re: Review Request 39419: LENS-824 Fix all javadoc warnings/errors
> On Oct. 25, 2015, 3:40 a.m., Amareshwari Sriramadasu wrote: > > I see the issue is still open, but review request is closed. So, reopened. > > > > Gabor, Do you still see errors on generated doc? > > Raju/Gabor, Is that resulting in build failure in java-8? > > Raju Bairishetti wrote: > We have fixed all the javadoc errors earlier. We may get new javadoc > errors as many patches were in. > > Right now, build won't be failed as we are not generating the javadocs as > part of build. We need to fix all warnings & errors before adding javadoc to > build cycle. > > Amareshwari Sriramadasu wrote: > Raju/Gabor, Are you planning to do more work on this jira? If so, what is > pending? Capturing in a review comment would make sense. If not, we should > get this in. Yes, I had no solution to correct the javadoc errors in the generated code. mvn site does fail when running under Java8. - Gabor --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39419/#review103931 --- On Oct. 19, 2015, 1:33 a.m., Gabor Liptak wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39419/ > --- > > (Updated Oct. 19, 2015, 1:33 a.m.) > > > Review request for lens. > > > Repository: lens > > > Description > --- > > LENS-824 Fix all javadoc warnings/errors > > > Diffs > - > > > lens-api/src/main/java/org/apache/lens/api/query/save/ParameterCollectionType.java > 971e794930e67a25404b4da75d596cfd26a7e17e > lens-api/src/main/java/org/apache/lens/api/result/PrettyPrintable.java > e6152b87cf008b4b4fcb57985c56d1449272b23d > lens-api/src/main/java/org/apache/lens/api/util/PathValidator.java > 92a936a91b7882e4de0b71b6aa9e4f3707770dce > lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java > 096fd7a09303c4da619bdf7cb73a4b25cfa3caaf > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > 4c8b525b118c280fe81e7e8ae3c6e98aab312a32 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > deb857213dc2e113d98f3cf854d0f84813455170 > > lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryDao.java > 9dfde0db7edad0c30528425479af8d4d64e894a7 > > lens-server/src/main/java/org/apache/lens/server/quota/QuotaServiceImpl.java > cc627cfcbcb266cf8586195d56742ab6ec8cbfba > > lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java > 3ea75246cb2b72376395e04eacacca1f88f8e347 > > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java > 22497ca31d710de0dcf3aef2a2a73f814e042f33 > pom.xml 714003835bccc217eb32e7c4ee782e1e6aacc434 > > Diff: https://reviews.apache.org/r/39419/diff/ > > > Testing > --- > > > Thanks, > > Gabor Liptak > >
Re: Review Request 39419: LENS-824 Fix all javadoc warnings/errors
> On Oct. 25, 2015, 3:40 a.m., Amareshwari Sriramadasu wrote: > > I see the issue is still open, but review request is closed. So, reopened. > > > > Gabor, Do you still see errors on generated doc? > > Raju/Gabor, Is that resulting in build failure in java-8? We have fixed all the javadoc errors earlier. We may get new javadoc errors as many patches were in. Right now, build won't be failed as we are not generating the javadocs as part of build. We need to fix all warnings & errors before adding javadoc to build cycle. - Raju --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39419/#review103931 --- On Oct. 19, 2015, 1:33 a.m., Gabor Liptak wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39419/ > --- > > (Updated Oct. 19, 2015, 1:33 a.m.) > > > Review request for lens. > > > Repository: lens > > > Description > --- > > LENS-824 Fix all javadoc warnings/errors > > > Diffs > - > > > lens-api/src/main/java/org/apache/lens/api/query/save/ParameterCollectionType.java > 971e794930e67a25404b4da75d596cfd26a7e17e > lens-api/src/main/java/org/apache/lens/api/result/PrettyPrintable.java > e6152b87cf008b4b4fcb57985c56d1449272b23d > lens-api/src/main/java/org/apache/lens/api/util/PathValidator.java > 92a936a91b7882e4de0b71b6aa9e4f3707770dce > lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java > 096fd7a09303c4da619bdf7cb73a4b25cfa3caaf > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > 4c8b525b118c280fe81e7e8ae3c6e98aab312a32 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > deb857213dc2e113d98f3cf854d0f84813455170 > > lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryDao.java > 9dfde0db7edad0c30528425479af8d4d64e894a7 > > lens-server/src/main/java/org/apache/lens/server/quota/QuotaServiceImpl.java > cc627cfcbcb266cf8586195d56742ab6ec8cbfba > > lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java > 3ea75246cb2b72376395e04eacacca1f88f8e347 > > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java > 22497ca31d710de0dcf3aef2a2a73f814e042f33 > pom.xml 714003835bccc217eb32e7c4ee782e1e6aacc434 > > Diff: https://reviews.apache.org/r/39419/diff/ > > > Testing > --- > > > Thanks, > > Gabor Liptak > >
Re: Review Request 39419: LENS-824 Fix all javadoc warnings/errors
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39419/#review103931 --- I see the issue is still open, but review request is closed. So, reopened. Gabor, Do you still see errors on generated doc? Raju/Gabor, Is that resulting in build failure in java-8? - Amareshwari Sriramadasu On Oct. 19, 2015, 1:33 a.m., Gabor Liptak wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39419/ > --- > > (Updated Oct. 19, 2015, 1:33 a.m.) > > > Review request for lens. > > > Repository: lens > > > Description > --- > > LENS-824 Fix all javadoc warnings/errors > > > Diffs > - > > > lens-api/src/main/java/org/apache/lens/api/query/save/ParameterCollectionType.java > 971e794930e67a25404b4da75d596cfd26a7e17e > lens-api/src/main/java/org/apache/lens/api/result/PrettyPrintable.java > e6152b87cf008b4b4fcb57985c56d1449272b23d > lens-api/src/main/java/org/apache/lens/api/util/PathValidator.java > 92a936a91b7882e4de0b71b6aa9e4f3707770dce > lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java > 096fd7a09303c4da619bdf7cb73a4b25cfa3caaf > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > 4c8b525b118c280fe81e7e8ae3c6e98aab312a32 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > deb857213dc2e113d98f3cf854d0f84813455170 > > lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryDao.java > 9dfde0db7edad0c30528425479af8d4d64e894a7 > > lens-server/src/main/java/org/apache/lens/server/quota/QuotaServiceImpl.java > cc627cfcbcb266cf8586195d56742ab6ec8cbfba > > lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java > 3ea75246cb2b72376395e04eacacca1f88f8e347 > > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java > 22497ca31d710de0dcf3aef2a2a73f814e042f33 > pom.xml 714003835bccc217eb32e7c4ee782e1e6aacc434 > > Diff: https://reviews.apache.org/r/39419/diff/ > > > Testing > --- > > > Thanks, > > Gabor Liptak > >
Re: Review Request 39419: LENS-824 Fix all javadoc warnings/errors
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39419/#review103046 --- Could you please verify javadoc errors/warnigns by running **mvn javadoc:javadoc **? - Raju Bairishetti On Oct. 18, 2015, 1:42 a.m., Gabor Liptak wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39419/ > --- > > (Updated Oct. 18, 2015, 1:42 a.m.) > > > Review request for lens. > > > Repository: lens > > > Description > --- > > LENS-824 Fix all javadoc warnings/errors > > > Diffs > - > > lens-api/src/main/java/org/apache/lens/api/result/PrettyPrintable.java > e6152b87cf008b4b4fcb57985c56d1449272b23d > lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java > 096fd7a09303c4da619bdf7cb73a4b25cfa3caaf > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > deb857213dc2e113d98f3cf854d0f84813455170 > > lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java > 3ea75246cb2b72376395e04eacacca1f88f8e347 > > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java > 22497ca31d710de0dcf3aef2a2a73f814e042f33 > > Diff: https://reviews.apache.org/r/39419/diff/ > > > Testing > --- > > > Thanks, > > Gabor Liptak > >
Re: Review Request 39419: LENS-824 Fix all javadoc warnings/errors
> On Oct. 18, 2015, 1:54 a.m., Raju Bairishetti wrote: > > Could you please verify javadoc errors/warnigns by running **mvn > > javadoc:javadoc **? I'm uploading progress to allow early comments. - Gabor --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39419/#review103046 --- On Oct. 18, 2015, 2:02 a.m., Gabor Liptak wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39419/ > --- > > (Updated Oct. 18, 2015, 2:02 a.m.) > > > Review request for lens. > > > Repository: lens > > > Description > --- > > LENS-824 Fix all javadoc warnings/errors > > > Diffs > - > > > lens-api/src/main/java/org/apache/lens/api/query/save/ParameterCollectionType.java > 971e794930e67a25404b4da75d596cfd26a7e17e > lens-api/src/main/java/org/apache/lens/api/result/PrettyPrintable.java > e6152b87cf008b4b4fcb57985c56d1449272b23d > lens-api/src/main/java/org/apache/lens/api/util/PathValidator.java > 92a936a91b7882e4de0b71b6aa9e4f3707770dce > lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java > 096fd7a09303c4da619bdf7cb73a4b25cfa3caaf > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > 4c8b525b118c280fe81e7e8ae3c6e98aab312a32 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > deb857213dc2e113d98f3cf854d0f84813455170 > > lens-server/src/main/java/org/apache/lens/server/quota/QuotaServiceImpl.java > cc627cfcbcb266cf8586195d56742ab6ec8cbfba > > lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java > 3ea75246cb2b72376395e04eacacca1f88f8e347 > > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java > 22497ca31d710de0dcf3aef2a2a73f814e042f33 > > Diff: https://reviews.apache.org/r/39419/diff/ > > > Testing > --- > > > Thanks, > > Gabor Liptak > >
Re: Review Request 39419: LENS-824 Fix all javadoc warnings/errors
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39419/ --- (Updated Oct. 18, 2015, 2:02 a.m.) Review request for lens. Repository: lens Description --- LENS-824 Fix all javadoc warnings/errors Diffs (updated) - lens-api/src/main/java/org/apache/lens/api/query/save/ParameterCollectionType.java 971e794930e67a25404b4da75d596cfd26a7e17e lens-api/src/main/java/org/apache/lens/api/result/PrettyPrintable.java e6152b87cf008b4b4fcb57985c56d1449272b23d lens-api/src/main/java/org/apache/lens/api/util/PathValidator.java 92a936a91b7882e4de0b71b6aa9e4f3707770dce lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 096fd7a09303c4da619bdf7cb73a4b25cfa3caaf lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 4c8b525b118c280fe81e7e8ae3c6e98aab312a32 lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java deb857213dc2e113d98f3cf854d0f84813455170 lens-server/src/main/java/org/apache/lens/server/quota/QuotaServiceImpl.java cc627cfcbcb266cf8586195d56742ab6ec8cbfba lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java 3ea75246cb2b72376395e04eacacca1f88f8e347 lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 22497ca31d710de0dcf3aef2a2a73f814e042f33 Diff: https://reviews.apache.org/r/39419/diff/ Testing --- Thanks, Gabor Liptak
