subject:"Re\: Review Request 66549\: Lens Server\: SPNEGO authentication"

Re: Review Request 66549: Lens Server: SPNEGO authentication

2018-05-18 Thread Rajitha R


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66549/#review203419
---


Ship it!




Ship It!

- Rajitha R


On May 18, 2018, 8:58 a.m., Barun Kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66549/
> ---
> 
> (Updated May 18, 2018, 8:58 a.m.)
> 
> 
> Review request for lens, Ankit Kailaswar, Puneet Gupta, and Rajitha R.
> 
> 
> Bugs: LENS-1509
> https://issues.apache.org/jira/browse/LENS-1509
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Currently authentication in lens works by taking username/password while 
> opening a session and validating it.
> 
> This change will add support of SPNEGO support in lens server and clinet so 
> that it can negotiate the authentication scheme. Currently only 
> Negotiate(Kerberos) scheme is implemented but others like Basic/Digest etc 
> can be added as well later.
> 
> 
> Diffs
> -
> 
>   contrib/clients/python/lens/client/auth.py PRE-CREATION 
>   contrib/clients/python/lens/client/session.py a1ccc4ba3 
>   contrib/clients/python/setup.py de59d32a9 
>   lens-api/src/main/java/org/apache/lens/api/auth/AuthScheme.java 
> PRE-CREATION 
>   lens-client/src/main/java/org/apache/lens/client/LensClientConfig.java 
> b703e132d 
>   lens-client/src/main/java/org/apache/lens/client/LensConnection.java 
> bb15b23ca 
>   lens-client/src/main/java/org/apache/lens/client/LensConnectionParams.java 
> 3a5dcdb82 
>   lens-client/src/main/java/org/apache/lens/client/SpnegoClientFilter.java 
> PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  f14ae44af 
>   lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 
> b5248f3d5 
>   lens-server/src/main/java/org/apache/lens/server/LensApplication.java 
> c3f99529a 
>   lens-server/src/main/java/org/apache/lens/server/LogResource.java d6d33484f 
>   lens-server/src/main/java/org/apache/lens/server/auth/Authenticate.java 
> PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/auth/LensSecurityContext.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/auth/SpnegoAuthenticationFilter.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/error/NotAuthorizedExceptionMapper.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java
>  8818844d3 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java
>  d53fbbf80 
>   
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java
>  72748cdb1 
>   lens-server/src/main/java/org/apache/lens/server/quota/QuotaResource.java 
> 213019105 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java
>  6c8b8ad7a 
>   
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 
> 08a5cff4f 
>   
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 
> 63eea6313 
> 
> 
> Diff: https://reviews.apache.org/r/66549/diff/6/
> 
> 
> Testing
> ---
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules . SUCCESS [1.458s]
> [INFO] Lens .. SUCCESS [3.567s]
> [INFO] Lens API .. SUCCESS [19.185s]
> [INFO] Lens API for server and extensions  SUCCESS [17.395s]
> [INFO] Lens Cube . SUCCESS [3:00.221s]
> [INFO] Lens DB storage ... SUCCESS [13.920s]
> [INFO] Lens Query Library  SUCCESS [11.039s]
> [INFO] Lens Hive Driver .. SUCCESS [1:06.122s]
> [INFO] Lens Driver for JDBC .. SUCCESS [42.723s]
> [INFO] Lens Elastic Search Driver  SUCCESS [17.640s]
> [INFO] Lens Server ... SUCCESS 
> [10:18.231s]
> [INFO] Lens client ... SUCCESS [1:27.686s]
> [INFO] Lens CLI .. SUCCESS [1:32.599s]
> [INFO] Lens Examples . SUCCESS [8.707s]
> [INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [0.691s]
> [INFO] Lens Distribution . SUCCESS [8.002s]
> [INFO] Lens ML Lib ... SUCCESS [1:06.984s]
> [INFO] Lens ML Ext Distribution .. SUCCESS [2.084s]
> [INFO] Lens Regression ... SUCCESS [12.962s]
> [INFO] Lens UI ... SUCCESS

Re: Review Request 66549: Lens Server: SPNEGO authentication

2018-05-18 Thread Barun Kumar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66549/
---

(Updated May 18, 2018, 8:58 a.m.)


Review request for lens, Ankit Kailaswar, Puneet Gupta, and Rajitha R.


Changes
---

Made some method private.


Bugs: LENS-1509
https://issues.apache.org/jira/browse/LENS-1509


Repository: lens


Description
---

Currently authentication in lens works by taking username/password while 
opening a session and validating it.

This change will add support of SPNEGO support in lens server and clinet so 
that it can negotiate the authentication scheme. Currently only 
Negotiate(Kerberos) scheme is implemented but others like Basic/Digest etc can 
be added as well later.


Diffs (updated)
-

  contrib/clients/python/lens/client/auth.py PRE-CREATION 
  contrib/clients/python/lens/client/session.py a1ccc4ba3 
  contrib/clients/python/setup.py de59d32a9 
  lens-api/src/main/java/org/apache/lens/api/auth/AuthScheme.java PRE-CREATION 
  lens-client/src/main/java/org/apache/lens/client/LensClientConfig.java 
b703e132d 
  lens-client/src/main/java/org/apache/lens/client/LensConnection.java 
bb15b23ca 
  lens-client/src/main/java/org/apache/lens/client/LensConnectionParams.java 
3a5dcdb82 
  lens-client/src/main/java/org/apache/lens/client/SpnegoClientFilter.java 
PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 
f14ae44af 
  lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 
b5248f3d5 
  lens-server/src/main/java/org/apache/lens/server/LensApplication.java 
c3f99529a 
  lens-server/src/main/java/org/apache/lens/server/auth/Authenticate.java 
PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/auth/LensSecurityContext.java 
PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/auth/SpnegoAuthenticationFilter.java
 PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/error/NotAuthorizedExceptionMapper.java
 PRE-CREATION 
  lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 
08a5cff4f 
  lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 
63eea6313 


Diff: https://reviews.apache.org/r/66549/diff/5/

Changes: https://reviews.apache.org/r/66549/diff/4-5/


Testing
---

[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules . SUCCESS [1.458s]
[INFO] Lens .. SUCCESS [3.567s]
[INFO] Lens API .. SUCCESS [19.185s]
[INFO] Lens API for server and extensions  SUCCESS [17.395s]
[INFO] Lens Cube . SUCCESS [3:00.221s]
[INFO] Lens DB storage ... SUCCESS [13.920s]
[INFO] Lens Query Library  SUCCESS [11.039s]
[INFO] Lens Hive Driver .. SUCCESS [1:06.122s]
[INFO] Lens Driver for JDBC .. SUCCESS [42.723s]
[INFO] Lens Elastic Search Driver  SUCCESS [17.640s]
[INFO] Lens Server ... SUCCESS [10:18.231s]
[INFO] Lens client ... SUCCESS [1:27.686s]
[INFO] Lens CLI .. SUCCESS [1:32.599s]
[INFO] Lens Examples . SUCCESS [8.707s]
[INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [0.691s]
[INFO] Lens Distribution . SUCCESS [8.002s]
[INFO] Lens ML Lib ... SUCCESS [1:06.984s]
[INFO] Lens ML Ext Distribution .. SUCCESS [2.084s]
[INFO] Lens Regression ... SUCCESS [12.962s]
[INFO] Lens UI ... SUCCESS [35.012s]
[INFO] Lens Contrib .. SUCCESS [0.263s]
[INFO] Lens Contributed Clients .. SUCCESS [0.266s]
[INFO] Lens Python Client  SUCCESS [0.247s]
[INFO] 


Thanks,

Barun Kumar

Re: Review Request 66549: Lens Server: SPNEGO authentication

2018-05-18 Thread Barun Kumar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66549/
---

(Updated May 18, 2018, 8:08 a.m.)


Review request for lens, Ankit Kailaswar, Puneet Gupta, and Rajitha R.


Changes
---

Fixed krbLoginModule conf. It requires "true" instead of true (string vs 
boolean)


Bugs: LENS-1509
https://issues.apache.org/jira/browse/LENS-1509


Repository: lens


Description
---

Currently authentication in lens works by taking username/password while 
opening a session and validating it.

This change will add support of SPNEGO support in lens server and clinet so 
that it can negotiate the authentication scheme. Currently only 
Negotiate(Kerberos) scheme is implemented but others like Basic/Digest etc can 
be added as well later.


Diffs (updated)
-

  contrib/clients/python/lens/client/auth.py PRE-CREATION 
  contrib/clients/python/lens/client/session.py a1ccc4ba3 
  contrib/clients/python/setup.py de59d32a9 
  lens-api/src/main/java/org/apache/lens/api/auth/AuthScheme.java PRE-CREATION 
  lens-client/src/main/java/org/apache/lens/client/LensClientConfig.java 
b703e132d 
  lens-client/src/main/java/org/apache/lens/client/LensConnection.java 
bb15b23ca 
  lens-client/src/main/java/org/apache/lens/client/LensConnectionParams.java 
3a5dcdb82 
  lens-client/src/main/java/org/apache/lens/client/SpnegoClientFilter.java 
PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 
f14ae44af 
  lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 
b5248f3d5 
  lens-server/src/main/java/org/apache/lens/server/LensApplication.java 
c3f99529a 
  lens-server/src/main/java/org/apache/lens/server/auth/Authenticate.java 
PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/auth/LensSecurityContext.java 
PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/auth/SpnegoAuthenticationFilter.java
 PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/error/NotAuthorizedExceptionMapper.java
 PRE-CREATION 
  lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 
08a5cff4f 
  lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 
63eea6313 


Diff: https://reviews.apache.org/r/66549/diff/4/

Changes: https://reviews.apache.org/r/66549/diff/3-4/


Testing
---

[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules . SUCCESS [1.458s]
[INFO] Lens .. SUCCESS [3.567s]
[INFO] Lens API .. SUCCESS [19.185s]
[INFO] Lens API for server and extensions  SUCCESS [17.395s]
[INFO] Lens Cube . SUCCESS [3:00.221s]
[INFO] Lens DB storage ... SUCCESS [13.920s]
[INFO] Lens Query Library  SUCCESS [11.039s]
[INFO] Lens Hive Driver .. SUCCESS [1:06.122s]
[INFO] Lens Driver for JDBC .. SUCCESS [42.723s]
[INFO] Lens Elastic Search Driver  SUCCESS [17.640s]
[INFO] Lens Server ... SUCCESS [10:18.231s]
[INFO] Lens client ... SUCCESS [1:27.686s]
[INFO] Lens CLI .. SUCCESS [1:32.599s]
[INFO] Lens Examples . SUCCESS [8.707s]
[INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [0.691s]
[INFO] Lens Distribution . SUCCESS [8.002s]
[INFO] Lens ML Lib ... SUCCESS [1:06.984s]
[INFO] Lens ML Ext Distribution .. SUCCESS [2.084s]
[INFO] Lens Regression ... SUCCESS [12.962s]
[INFO] Lens UI ... SUCCESS [35.012s]
[INFO] Lens Contrib .. SUCCESS [0.263s]
[INFO] Lens Contributed Clients .. SUCCESS [0.266s]
[INFO] Lens Python Client  SUCCESS [0.247s]
[INFO] 


Thanks,

Barun Kumar

Re: Review Request 66549: Lens Server: SPNEGO authentication

2018-05-14 Thread Barun Kumar



> On May 7, 2018, 12:10 p.m., Rajitha R wrote:
> > lens-server/src/main/java/org/apache/lens/server/BaseLensService.java
> > Line 164 (original), 169 (patched)
> > 
> >
> > Why are we passing a negate value here? If auth scheme is set, 
> > shouldn't this be sent as true?

the last argument is to do the old auth. if auth scheme is present then we are 
not doing old auth.


> On May 7, 2018, 12:10 p.m., Rajitha R wrote:
> > lens-server/src/main/java/org/apache/lens/server/LensApplication.java
> > Lines 79 (patched)
> > 
> >
> > The purpose of NotAuthorizedExceptionMapper isn't clear. Can existing 
> > GenericeExceptionMapper not serve the purpose?

THe purpose of this class is to handle NotAuthorizedException and return proper 
error to client. Yew we can use GenericeExceptionMapper instead but it does a 
lot of thing which could be avoided by having specific exception mapper for 
exception rather than having one for "Exception" class.


> On May 7, 2018, 12:10 p.m., Rajitha R wrote:
> > lens-server/src/main/java/org/apache/lens/server/auth/SpnegoAuthenticationFilter.java
> > Lines 66 (patched)
> > 
> >
> > Can't see this property defined anywhere in the patch.

This is an existing property. We will have to add this filter in that.


> On May 7, 2018, 12:10 p.m., Rajitha R wrote:
> > lens-server/src/main/java/org/apache/lens/server/auth/SpnegoAuthenticationFilter.java
> > Lines 272 (patched)
> > 
> >
> > I dont still recommend this. Please go through other exceptions in lens 
> > (check lens-error.conf). We should handle this one similar to others to 
> > have some consistency in the code

lens-error.conf contains error code specific to lens-server. I think 
authentication is orthogonal to it and we should deal with standard HTTP level 
error code and JAX-RS API. NotAuthorizedException is standard exception defined 
in JAX-RS API for authentication failure.


> On May 7, 2018, 12:10 p.m., Rajitha R wrote:
> > lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java
> > Lines 128 (patched)
> > 
> >
> > Since this flow is only valid for Negotiate scheme, can we have the 
> > additional check if the scheme is only negotiate?

This can be valid for any auth scheme. The validation for Negotiate is 
happening in SpnegoAuthenticationFilter.


- Barun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66549/#review202544
---


On May 14, 2018, 2 p.m., Barun Kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66549/
> ---
> 
> (Updated May 14, 2018, 2 p.m.)
> 
> 
> Review request for lens, Ankit Kailaswar, Puneet Gupta, and Rajitha R.
> 
> 
> Bugs: LENS-1509
> https://issues.apache.org/jira/browse/LENS-1509
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Currently authentication in lens works by taking username/password while 
> opening a session and validating it.
> 
> This change will add support of SPNEGO support in lens server and clinet so 
> that it can negotiate the authentication scheme. Currently only 
> Negotiate(Kerberos) scheme is implemented but others like Basic/Digest etc 
> can be added as well later.
> 
> 
> Diffs
> -
> 
>   contrib/clients/python/lens/client/auth.py PRE-CREATION 
>   contrib/clients/python/lens/client/session.py a1ccc4ba3 
>   contrib/clients/python/setup.py de59d32a9 
>   lens-api/src/main/java/org/apache/lens/api/auth/AuthScheme.java 
> PRE-CREATION 
>   lens-client/src/main/java/org/apache/lens/client/LensClientConfig.java 
> b703e132d 
>   lens-client/src/main/java/org/apache/lens/client/LensConnectionParams.java 
> 3a5dcdb82 
>   lens-client/src/main/java/org/apache/lens/client/SpnegoClientFilter.java 
> PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  f14ae44af 
>   lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 
> b5248f3d5 
>   lens-server/src/main/java/org/apache/lens/server/LensApplication.java 
> c3f99529a 
>   lens-server/src/main/java/org/apache/lens/server/auth/Authenticate.java 
> PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/auth/LensSecurityContext.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/auth/SpnegoAuthenticationFilter.java
>  PRE-CREATION 
>   
>

Re: Review Request 66549: Lens Server: SPNEGO authentication

2018-05-14 Thread Barun Kumar



> On May 9, 2018, 1:58 p.m., Rajitha R wrote:
> > lens-client/src/main/java/org/apache/lens/client/LensClientConfig.java
> > Lines 95 (patched)
> > 
> >
> > Is this config password required? This might require user to set these 
> > config in lens-client xml file. Shouldn't Kinit suffice here

This is not required. Removed.


> On May 9, 2018, 1:58 p.m., Rajitha R wrote:
> > lens-client/src/main/java/org/apache/lens/client/LensConnectionParams.java
> > Lines 56 (patched)
> > 
> >
> > Can this be made configurable ?

We can and earlier I did make it configurable but every client will have to add 
it in configuration. SO going for a default addition.


- Barun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66549/#review202755
---


On May 14, 2018, 2 p.m., Barun Kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66549/
> ---
> 
> (Updated May 14, 2018, 2 p.m.)
> 
> 
> Review request for lens, Ankit Kailaswar, Puneet Gupta, and Rajitha R.
> 
> 
> Bugs: LENS-1509
> https://issues.apache.org/jira/browse/LENS-1509
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Currently authentication in lens works by taking username/password while 
> opening a session and validating it.
> 
> This change will add support of SPNEGO support in lens server and clinet so 
> that it can negotiate the authentication scheme. Currently only 
> Negotiate(Kerberos) scheme is implemented but others like Basic/Digest etc 
> can be added as well later.
> 
> 
> Diffs
> -
> 
>   contrib/clients/python/lens/client/auth.py PRE-CREATION 
>   contrib/clients/python/lens/client/session.py a1ccc4ba3 
>   contrib/clients/python/setup.py de59d32a9 
>   lens-api/src/main/java/org/apache/lens/api/auth/AuthScheme.java 
> PRE-CREATION 
>   lens-client/src/main/java/org/apache/lens/client/LensClientConfig.java 
> b703e132d 
>   lens-client/src/main/java/org/apache/lens/client/LensConnectionParams.java 
> 3a5dcdb82 
>   lens-client/src/main/java/org/apache/lens/client/SpnegoClientFilter.java 
> PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  f14ae44af 
>   lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 
> b5248f3d5 
>   lens-server/src/main/java/org/apache/lens/server/LensApplication.java 
> c3f99529a 
>   lens-server/src/main/java/org/apache/lens/server/auth/Authenticate.java 
> PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/auth/LensSecurityContext.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/auth/SpnegoAuthenticationFilter.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/error/NotAuthorizedExceptionMapper.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 
> 08a5cff4f 
>   
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 
> 63eea6313 
> 
> 
> Diff: https://reviews.apache.org/r/66549/diff/3/
> 
> 
> Testing
> ---
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules . SUCCESS [1.458s]
> [INFO] Lens .. SUCCESS [3.567s]
> [INFO] Lens API .. SUCCESS [19.185s]
> [INFO] Lens API for server and extensions  SUCCESS [17.395s]
> [INFO] Lens Cube . SUCCESS [3:00.221s]
> [INFO] Lens DB storage ... SUCCESS [13.920s]
> [INFO] Lens Query Library  SUCCESS [11.039s]
> [INFO] Lens Hive Driver .. SUCCESS [1:06.122s]
> [INFO] Lens Driver for JDBC .. SUCCESS [42.723s]
> [INFO] Lens Elastic Search Driver  SUCCESS [17.640s]
> [INFO] Lens Server ... SUCCESS 
> [10:18.231s]
> [INFO] Lens client ... SUCCESS [1:27.686s]
> [INFO] Lens CLI .. SUCCESS [1:32.599s]
> [INFO] Lens Examples . SUCCESS [8.707s]
> [INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [0.691s]
> [INFO] Lens Distribution . SUCCESS [8.002s]
> [INFO] Lens ML Lib ... SUCCESS [1:06.984s]
> [INFO] Lens ML Ext Distribution .. SUCCESS [2.084s]
> [INFO] Lens Regression

Re: Review Request 66549: Lens Server: SPNEGO authentication

2018-05-14 Thread Barun Kumar



> On April 23, 2018, 6:09 a.m., Rajitha R wrote:
> > lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java
> > Lines 71 (patched)
> > 
> >
> > Should we not have the authentication across all resources than just 
> > session?

We have taken call to have it only on session resourece as of now.


- Barun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66549/#review201719
---


On May 14, 2018, 2 p.m., Barun Kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66549/
> ---
> 
> (Updated May 14, 2018, 2 p.m.)
> 
> 
> Review request for lens, Ankit Kailaswar, Puneet Gupta, and Rajitha R.
> 
> 
> Bugs: LENS-1509
> https://issues.apache.org/jira/browse/LENS-1509
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Currently authentication in lens works by taking username/password while 
> opening a session and validating it.
> 
> This change will add support of SPNEGO support in lens server and clinet so 
> that it can negotiate the authentication scheme. Currently only 
> Negotiate(Kerberos) scheme is implemented but others like Basic/Digest etc 
> can be added as well later.
> 
> 
> Diffs
> -
> 
>   contrib/clients/python/lens/client/auth.py PRE-CREATION 
>   contrib/clients/python/lens/client/session.py a1ccc4ba3 
>   contrib/clients/python/setup.py de59d32a9 
>   lens-api/src/main/java/org/apache/lens/api/auth/AuthScheme.java 
> PRE-CREATION 
>   lens-client/src/main/java/org/apache/lens/client/LensClientConfig.java 
> b703e132d 
>   lens-client/src/main/java/org/apache/lens/client/LensConnectionParams.java 
> 3a5dcdb82 
>   lens-client/src/main/java/org/apache/lens/client/SpnegoClientFilter.java 
> PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  f14ae44af 
>   lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 
> b5248f3d5 
>   lens-server/src/main/java/org/apache/lens/server/LensApplication.java 
> c3f99529a 
>   lens-server/src/main/java/org/apache/lens/server/auth/Authenticate.java 
> PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/auth/LensSecurityContext.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/auth/SpnegoAuthenticationFilter.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/error/NotAuthorizedExceptionMapper.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 
> 08a5cff4f 
>   
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 
> 63eea6313 
> 
> 
> Diff: https://reviews.apache.org/r/66549/diff/3/
> 
> 
> Testing
> ---
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules . SUCCESS [1.458s]
> [INFO] Lens .. SUCCESS [3.567s]
> [INFO] Lens API .. SUCCESS [19.185s]
> [INFO] Lens API for server and extensions  SUCCESS [17.395s]
> [INFO] Lens Cube . SUCCESS [3:00.221s]
> [INFO] Lens DB storage ... SUCCESS [13.920s]
> [INFO] Lens Query Library  SUCCESS [11.039s]
> [INFO] Lens Hive Driver .. SUCCESS [1:06.122s]
> [INFO] Lens Driver for JDBC .. SUCCESS [42.723s]
> [INFO] Lens Elastic Search Driver  SUCCESS [17.640s]
> [INFO] Lens Server ... SUCCESS 
> [10:18.231s]
> [INFO] Lens client ... SUCCESS [1:27.686s]
> [INFO] Lens CLI .. SUCCESS [1:32.599s]
> [INFO] Lens Examples . SUCCESS [8.707s]
> [INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [0.691s]
> [INFO] Lens Distribution . SUCCESS [8.002s]
> [INFO] Lens ML Lib ... SUCCESS [1:06.984s]
> [INFO] Lens ML Ext Distribution .. SUCCESS [2.084s]
> [INFO] Lens Regression ... SUCCESS [12.962s]
> [INFO] Lens UI ... SUCCESS [35.012s]
> [INFO] Lens Contrib .. SUCCESS [0.263s]
> [INFO] Lens Contributed Clients .. SUCCESS [0.266s]
> [INFO] Lens Python Client  SUCCESS [0.247s]
> [INFO] 
>

Re: Review Request 66549: Lens Server: SPNEGO authentication

2018-05-14 Thread Barun Kumar



> On May 9, 2018, 1:58 p.m., Puneet Gupta wrote:
> > lens-client/src/main/java/org/apache/lens/client/SpnegoClientFilter.java
> > Lines 80 (patched)
> > 
> >
> > can we also add details on usage or user and password ?

This filter is added by default while building `LensConnection` in 
`LensConnectionParams.setupRequestFilters`.


> On May 9, 2018, 1:58 p.m., Puneet Gupta wrote:
> > lens-client/src/main/java/org/apache/lens/client/SpnegoClientFilter.java
> > Lines 132 (patched)
> > 
> >
> > can be private ?

done


> On May 9, 2018, 1:58 p.m., Puneet Gupta wrote:
> > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java
> > Line 1515 (original), 1515 (patched)
> > 
> >
> > why is this renoved ?

It was duplicate. It's fixed in master now. Added it back.


- Barun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66549/#review202754
---


On May 14, 2018, 2 p.m., Barun Kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66549/
> ---
> 
> (Updated May 14, 2018, 2 p.m.)
> 
> 
> Review request for lens, Ankit Kailaswar, Puneet Gupta, and Rajitha R.
> 
> 
> Bugs: LENS-1509
> https://issues.apache.org/jira/browse/LENS-1509
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Currently authentication in lens works by taking username/password while 
> opening a session and validating it.
> 
> This change will add support of SPNEGO support in lens server and clinet so 
> that it can negotiate the authentication scheme. Currently only 
> Negotiate(Kerberos) scheme is implemented but others like Basic/Digest etc 
> can be added as well later.
> 
> 
> Diffs
> -
> 
>   contrib/clients/python/lens/client/auth.py PRE-CREATION 
>   contrib/clients/python/lens/client/session.py a1ccc4ba3 
>   contrib/clients/python/setup.py de59d32a9 
>   lens-api/src/main/java/org/apache/lens/api/auth/AuthScheme.java 
> PRE-CREATION 
>   lens-client/src/main/java/org/apache/lens/client/LensClientConfig.java 
> b703e132d 
>   lens-client/src/main/java/org/apache/lens/client/LensConnectionParams.java 
> 3a5dcdb82 
>   lens-client/src/main/java/org/apache/lens/client/SpnegoClientFilter.java 
> PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  f14ae44af 
>   lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 
> b5248f3d5 
>   lens-server/src/main/java/org/apache/lens/server/LensApplication.java 
> c3f99529a 
>   lens-server/src/main/java/org/apache/lens/server/auth/Authenticate.java 
> PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/auth/LensSecurityContext.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/auth/SpnegoAuthenticationFilter.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/error/NotAuthorizedExceptionMapper.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 
> 08a5cff4f 
>   
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 
> 63eea6313 
> 
> 
> Diff: https://reviews.apache.org/r/66549/diff/3/
> 
> 
> Testing
> ---
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules . SUCCESS [1.458s]
> [INFO] Lens .. SUCCESS [3.567s]
> [INFO] Lens API .. SUCCESS [19.185s]
> [INFO] Lens API for server and extensions  SUCCESS [17.395s]
> [INFO] Lens Cube . SUCCESS [3:00.221s]
> [INFO] Lens DB storage ... SUCCESS [13.920s]
> [INFO] Lens Query Library  SUCCESS [11.039s]
> [INFO] Lens Hive Driver .. SUCCESS [1:06.122s]
> [INFO] Lens Driver for JDBC .. SUCCESS [42.723s]
> [INFO] Lens Elastic Search Driver  SUCCESS [17.640s]
> [INFO] Lens Server ... SUCCESS 
> [10:18.231s]
> [INFO] Lens client ... SUCCESS [1:27.686s]
> [INFO] Lens CLI .. SUCCESS [1:32.599s]
> [INFO] Lens Examples . SUCCESS [8.707s]
> [INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [0.691s]
> [INFO] Lens Distribution . SUCCESS

Re: Review Request 66549: Lens Server: SPNEGO authentication

2018-05-14 Thread Barun Kumar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66549/
---

(Updated May 14, 2018, 2 p.m.)


Review request for lens, Ankit Kailaswar, Puneet Gupta, and Rajitha R.


Changes
---

Fixed review comments.


Bugs: LENS-1509
https://issues.apache.org/jira/browse/LENS-1509


Repository: lens


Description
---

Currently authentication in lens works by taking username/password while 
opening a session and validating it.

This change will add support of SPNEGO support in lens server and clinet so 
that it can negotiate the authentication scheme. Currently only 
Negotiate(Kerberos) scheme is implemented but others like Basic/Digest etc can 
be added as well later.


Diffs (updated)
-

  contrib/clients/python/lens/client/auth.py PRE-CREATION 
  contrib/clients/python/lens/client/session.py a1ccc4ba3 
  contrib/clients/python/setup.py de59d32a9 
  lens-api/src/main/java/org/apache/lens/api/auth/AuthScheme.java PRE-CREATION 
  lens-client/src/main/java/org/apache/lens/client/LensClientConfig.java 
b703e132d 
  lens-client/src/main/java/org/apache/lens/client/LensConnectionParams.java 
3a5dcdb82 
  lens-client/src/main/java/org/apache/lens/client/SpnegoClientFilter.java 
PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 
f14ae44af 
  lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 
b5248f3d5 
  lens-server/src/main/java/org/apache/lens/server/LensApplication.java 
c3f99529a 
  lens-server/src/main/java/org/apache/lens/server/auth/Authenticate.java 
PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/auth/LensSecurityContext.java 
PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/auth/SpnegoAuthenticationFilter.java
 PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/error/NotAuthorizedExceptionMapper.java
 PRE-CREATION 
  lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 
08a5cff4f 
  lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 
63eea6313 


Diff: https://reviews.apache.org/r/66549/diff/3/

Changes: https://reviews.apache.org/r/66549/diff/2-3/


Testing
---

[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules . SUCCESS [1.458s]
[INFO] Lens .. SUCCESS [3.567s]
[INFO] Lens API .. SUCCESS [19.185s]
[INFO] Lens API for server and extensions  SUCCESS [17.395s]
[INFO] Lens Cube . SUCCESS [3:00.221s]
[INFO] Lens DB storage ... SUCCESS [13.920s]
[INFO] Lens Query Library  SUCCESS [11.039s]
[INFO] Lens Hive Driver .. SUCCESS [1:06.122s]
[INFO] Lens Driver for JDBC .. SUCCESS [42.723s]
[INFO] Lens Elastic Search Driver  SUCCESS [17.640s]
[INFO] Lens Server ... SUCCESS [10:18.231s]
[INFO] Lens client ... SUCCESS [1:27.686s]
[INFO] Lens CLI .. SUCCESS [1:32.599s]
[INFO] Lens Examples . SUCCESS [8.707s]
[INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [0.691s]
[INFO] Lens Distribution . SUCCESS [8.002s]
[INFO] Lens ML Lib ... SUCCESS [1:06.984s]
[INFO] Lens ML Ext Distribution .. SUCCESS [2.084s]
[INFO] Lens Regression ... SUCCESS [12.962s]
[INFO] Lens UI ... SUCCESS [35.012s]
[INFO] Lens Contrib .. SUCCESS [0.263s]
[INFO] Lens Contributed Clients .. SUCCESS [0.266s]
[INFO] Lens Python Client  SUCCESS [0.247s]
[INFO] 


Thanks,

Barun Kumar

Re: Review Request 66549: Lens Server: SPNEGO authentication

2018-05-09 Thread Rajitha R


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66549/#review202755
---




lens-client/src/main/java/org/apache/lens/client/LensClientConfig.java
Lines 95 (patched)


Is this config password required? This might require user to set these 
config in lens-client xml file. Shouldn't Kinit suffice here



lens-client/src/main/java/org/apache/lens/client/LensConnectionParams.java
Lines 56 (patched)


Can this be made configurable ?


- Rajitha R


On May 4, 2018, 12:48 p.m., Barun Kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66549/
> ---
> 
> (Updated May 4, 2018, 12:48 p.m.)
> 
> 
> Review request for lens, Ankit Kailaswar, Puneet Gupta, and Rajitha R.
> 
> 
> Bugs: LENS-1509
> https://issues.apache.org/jira/browse/LENS-1509
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Currently authentication in lens works by taking username/password while 
> opening a session and validating it.
> 
> This change will add support of SPNEGO support in lens server and clinet so 
> that it can negotiate the authentication scheme. Currently only 
> Negotiate(Kerberos) scheme is implemented but others like Basic/Digest etc 
> can be added as well later.
> 
> 
> Diffs
> -
> 
>   contrib/clients/python/lens/client/auth.py PRE-CREATION 
>   contrib/clients/python/lens/client/session.py a1ccc4ba3 
>   contrib/clients/python/setup.py de59d32a9 
>   lens-api/src/main/java/org/apache/lens/api/auth/AuthScheme.java 
> PRE-CREATION 
>   lens-client/src/main/java/org/apache/lens/client/LensClientConfig.java 
> b703e132d 
>   lens-client/src/main/java/org/apache/lens/client/LensConnectionParams.java 
> 3a5dcdb82 
>   lens-client/src/main/java/org/apache/lens/client/SpnegoClientFilter.java 
> PRE-CREATION 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
> e83eacb11 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  f14ae44af 
>   lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 
> b5248f3d5 
>   lens-server/src/main/java/org/apache/lens/server/LensApplication.java 
> c3f99529a 
>   lens-server/src/main/java/org/apache/lens/server/auth/Authenticate.java 
> PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/auth/LensSecurityContext.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/auth/SpnegoAuthenticationFilter.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/error/NotAuthorizedExceptionMapper.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 
> 08a5cff4f 
>   
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 
> 63eea6313 
> 
> 
> Diff: https://reviews.apache.org/r/66549/diff/2/
> 
> 
> Testing
> ---
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules . SUCCESS [1.458s]
> [INFO] Lens .. SUCCESS [3.567s]
> [INFO] Lens API .. SUCCESS [19.185s]
> [INFO] Lens API for server and extensions  SUCCESS [17.395s]
> [INFO] Lens Cube . SUCCESS [3:00.221s]
> [INFO] Lens DB storage ... SUCCESS [13.920s]
> [INFO] Lens Query Library  SUCCESS [11.039s]
> [INFO] Lens Hive Driver .. SUCCESS [1:06.122s]
> [INFO] Lens Driver for JDBC .. SUCCESS [42.723s]
> [INFO] Lens Elastic Search Driver  SUCCESS [17.640s]
> [INFO] Lens Server ... SUCCESS 
> [10:18.231s]
> [INFO] Lens client ... SUCCESS [1:27.686s]
> [INFO] Lens CLI .. SUCCESS [1:32.599s]
> [INFO] Lens Examples . SUCCESS [8.707s]
> [INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [0.691s]
> [INFO] Lens Distribution . SUCCESS [8.002s]
> [INFO] Lens ML Lib ... SUCCESS [1:06.984s]
> [INFO] Lens ML Ext Distribution .. SUCCESS [2.084s]
> [INFO] Lens Regression ... SUCCESS [12.962s]
> [INFO] Lens UI ... SUCCESS [35.012s]
> [INFO] Lens Contrib .. SUCCESS [0.263s]
> [INFO] Lens Contributed Clients

Re: Review Request 66549: Lens Server: SPNEGO authentication

2018-05-09 Thread Puneet Gupta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66549/#review202754
---




lens-client/src/main/java/org/apache/lens/client/SpnegoClientFilter.java
Lines 80 (patched)


can we also add details on usage or user and password ?



lens-client/src/main/java/org/apache/lens/client/SpnegoClientFilter.java
Lines 132 (patched)


can be private ?



lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java
Line 1515 (original), 1515 (patched)


why is this renoved ?



lens-server/src/main/java/org/apache/lens/server/auth/SpnegoAuthenticationFilter.java
Lines 226 (patched)


can be private ?


- Puneet Gupta


On May 4, 2018, 12:48 p.m., Barun Kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66549/
> ---
> 
> (Updated May 4, 2018, 12:48 p.m.)
> 
> 
> Review request for lens, Ankit Kailaswar, Puneet Gupta, and Rajitha R.
> 
> 
> Bugs: LENS-1509
> https://issues.apache.org/jira/browse/LENS-1509
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Currently authentication in lens works by taking username/password while 
> opening a session and validating it.
> 
> This change will add support of SPNEGO support in lens server and clinet so 
> that it can negotiate the authentication scheme. Currently only 
> Negotiate(Kerberos) scheme is implemented but others like Basic/Digest etc 
> can be added as well later.
> 
> 
> Diffs
> -
> 
>   contrib/clients/python/lens/client/auth.py PRE-CREATION 
>   contrib/clients/python/lens/client/session.py a1ccc4ba3 
>   contrib/clients/python/setup.py de59d32a9 
>   lens-api/src/main/java/org/apache/lens/api/auth/AuthScheme.java 
> PRE-CREATION 
>   lens-client/src/main/java/org/apache/lens/client/LensClientConfig.java 
> b703e132d 
>   lens-client/src/main/java/org/apache/lens/client/LensConnectionParams.java 
> 3a5dcdb82 
>   lens-client/src/main/java/org/apache/lens/client/SpnegoClientFilter.java 
> PRE-CREATION 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
> e83eacb11 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  f14ae44af 
>   lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 
> b5248f3d5 
>   lens-server/src/main/java/org/apache/lens/server/LensApplication.java 
> c3f99529a 
>   lens-server/src/main/java/org/apache/lens/server/auth/Authenticate.java 
> PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/auth/LensSecurityContext.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/auth/SpnegoAuthenticationFilter.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/error/NotAuthorizedExceptionMapper.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 
> 08a5cff4f 
>   
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 
> 63eea6313 
> 
> 
> Diff: https://reviews.apache.org/r/66549/diff/2/
> 
> 
> Testing
> ---
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules . SUCCESS [1.458s]
> [INFO] Lens .. SUCCESS [3.567s]
> [INFO] Lens API .. SUCCESS [19.185s]
> [INFO] Lens API for server and extensions  SUCCESS [17.395s]
> [INFO] Lens Cube . SUCCESS [3:00.221s]
> [INFO] Lens DB storage ... SUCCESS [13.920s]
> [INFO] Lens Query Library  SUCCESS [11.039s]
> [INFO] Lens Hive Driver .. SUCCESS [1:06.122s]
> [INFO] Lens Driver for JDBC .. SUCCESS [42.723s]
> [INFO] Lens Elastic Search Driver  SUCCESS [17.640s]
> [INFO] Lens Server ... SUCCESS 
> [10:18.231s]
> [INFO] Lens client ... SUCCESS [1:27.686s]
> [INFO] Lens CLI .. SUCCESS [1:32.599s]
> [INFO] Lens Examples . SUCCESS [8.707s]
> [INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [0.691s]
> [INFO] Lens Distribution . SUCCESS [8.002s]
> [INFO] Lens ML Lib ... SUCCESS [1:06.984s]
> [INFO] Lens ML Ext Distribution .. SUCCESS [2.084s]
>

Re: Review Request 66549: Lens Server: SPNEGO authentication

2018-05-09 Thread Barun Kumar



> On April 12, 2018, 8:22 a.m., Rajitha R wrote:
> > lens-server/src/main/java/org/apache/lens/server/BaseLensService.java
> > Lines 78 (patched)
> > 
> >
> > the service already has conf defined. This shouldn't be required

No this doesn't have it defined.


> On April 12, 2018, 8:22 a.m., Rajitha R wrote:
> > lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java
> > Lines 77 (patched)
> > 
> >
> > we should get conf from session service than initializing again here

No method in SessionService to get conf.


- Barun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66549/#review200978
---


On May 4, 2018, 12:48 p.m., Barun Kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66549/
> ---
> 
> (Updated May 4, 2018, 12:48 p.m.)
> 
> 
> Review request for lens, Ankit Kailaswar, Puneet Gupta, and Rajitha R.
> 
> 
> Bugs: LENS-1509
> https://issues.apache.org/jira/browse/LENS-1509
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Currently authentication in lens works by taking username/password while 
> opening a session and validating it.
> 
> This change will add support of SPNEGO support in lens server and clinet so 
> that it can negotiate the authentication scheme. Currently only 
> Negotiate(Kerberos) scheme is implemented but others like Basic/Digest etc 
> can be added as well later.
> 
> 
> Diffs
> -
> 
>   contrib/clients/python/lens/client/auth.py PRE-CREATION 
>   contrib/clients/python/lens/client/session.py a1ccc4ba3 
>   contrib/clients/python/setup.py de59d32a9 
>   lens-api/src/main/java/org/apache/lens/api/auth/AuthScheme.java 
> PRE-CREATION 
>   lens-client/src/main/java/org/apache/lens/client/LensClientConfig.java 
> b703e132d 
>   lens-client/src/main/java/org/apache/lens/client/LensConnectionParams.java 
> 3a5dcdb82 
>   lens-client/src/main/java/org/apache/lens/client/SpnegoClientFilter.java 
> PRE-CREATION 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
> e83eacb11 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  f14ae44af 
>   lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 
> b5248f3d5 
>   lens-server/src/main/java/org/apache/lens/server/LensApplication.java 
> c3f99529a 
>   lens-server/src/main/java/org/apache/lens/server/auth/Authenticate.java 
> PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/auth/LensSecurityContext.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/auth/SpnegoAuthenticationFilter.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/error/NotAuthorizedExceptionMapper.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 
> 08a5cff4f 
>   
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 
> 63eea6313 
> 
> 
> Diff: https://reviews.apache.org/r/66549/diff/2/
> 
> 
> Testing
> ---
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules . SUCCESS [1.458s]
> [INFO] Lens .. SUCCESS [3.567s]
> [INFO] Lens API .. SUCCESS [19.185s]
> [INFO] Lens API for server and extensions  SUCCESS [17.395s]
> [INFO] Lens Cube . SUCCESS [3:00.221s]
> [INFO] Lens DB storage ... SUCCESS [13.920s]
> [INFO] Lens Query Library  SUCCESS [11.039s]
> [INFO] Lens Hive Driver .. SUCCESS [1:06.122s]
> [INFO] Lens Driver for JDBC .. SUCCESS [42.723s]
> [INFO] Lens Elastic Search Driver  SUCCESS [17.640s]
> [INFO] Lens Server ... SUCCESS 
> [10:18.231s]
> [INFO] Lens client ... SUCCESS [1:27.686s]
> [INFO] Lens CLI .. SUCCESS [1:32.599s]
> [INFO] Lens Examples . SUCCESS [8.707s]
> [INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [0.691s]
> [INFO] Lens Distribution . SUCCESS [8.002s]
> [INFO] Lens ML Lib ... SUCCESS [1:06.984s]
> [INFO] Lens ML Ext Distribution .. SUCCESS [2.084s]
> [INFO] Lens Regression ...

Re: Review Request 66549: Lens Server: SPNEGO authentication

2018-05-07 Thread Rajitha R


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66549/#review202544
---




lens-server/src/main/java/org/apache/lens/server/BaseLensService.java
Line 164 (original), 169 (patched)


Why are we passing a negate value here? If auth scheme is set, shouldn't 
this be sent as true?



lens-server/src/main/java/org/apache/lens/server/LensApplication.java
Lines 79 (patched)


The purpose of NotAuthorizedExceptionMapper isn't clear. Can existing 
GenericeExceptionMapper not serve the purpose?



lens-server/src/main/java/org/apache/lens/server/auth/SpnegoAuthenticationFilter.java
Lines 66 (patched)


Can't see this property defined anywhere in the patch.



lens-server/src/main/java/org/apache/lens/server/auth/SpnegoAuthenticationFilter.java
Lines 272 (patched)


I dont still recommend this. Please go through other exceptions in lens 
(check lens-error.conf). We should handle this one similar to others to have 
some consistency in the code



lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java
Lines 128 (patched)


Since this flow is only valid for Negotiate scheme, can we have the 
additional check if the scheme is only negotiate?


- Rajitha R


On May 4, 2018, 12:48 p.m., Barun Kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66549/
> ---
> 
> (Updated May 4, 2018, 12:48 p.m.)
> 
> 
> Review request for lens, Ankit Kailaswar, Puneet Gupta, and Rajitha R.
> 
> 
> Bugs: LENS-1509
> https://issues.apache.org/jira/browse/LENS-1509
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Currently authentication in lens works by taking username/password while 
> opening a session and validating it.
> 
> This change will add support of SPNEGO support in lens server and clinet so 
> that it can negotiate the authentication scheme. Currently only 
> Negotiate(Kerberos) scheme is implemented but others like Basic/Digest etc 
> can be added as well later.
> 
> 
> Diffs
> -
> 
>   contrib/clients/python/lens/client/auth.py PRE-CREATION 
>   contrib/clients/python/lens/client/session.py a1ccc4ba3 
>   contrib/clients/python/setup.py de59d32a9 
>   lens-api/src/main/java/org/apache/lens/api/auth/AuthScheme.java 
> PRE-CREATION 
>   lens-client/src/main/java/org/apache/lens/client/LensClientConfig.java 
> b703e132d 
>   lens-client/src/main/java/org/apache/lens/client/LensConnectionParams.java 
> 3a5dcdb82 
>   lens-client/src/main/java/org/apache/lens/client/SpnegoClientFilter.java 
> PRE-CREATION 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
> e83eacb11 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  f14ae44af 
>   lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 
> b5248f3d5 
>   lens-server/src/main/java/org/apache/lens/server/LensApplication.java 
> c3f99529a 
>   lens-server/src/main/java/org/apache/lens/server/auth/Authenticate.java 
> PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/auth/LensSecurityContext.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/auth/SpnegoAuthenticationFilter.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/error/NotAuthorizedExceptionMapper.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 
> 08a5cff4f 
>   
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 
> 63eea6313 
> 
> 
> Diff: https://reviews.apache.org/r/66549/diff/2/
> 
> 
> Testing
> ---
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules . SUCCESS [1.458s]
> [INFO] Lens .. SUCCESS [3.567s]
> [INFO] Lens API .. SUCCESS [19.185s]
> [INFO] Lens API for server and extensions  SUCCESS [17.395s]
> [INFO] Lens Cube . SUCCESS [3:00.221s]
> [INFO] Lens DB storage ... SUCCESS [13.920s]
> [INFO] Lens Query Library  SUCCESS [11.039s]
> [INFO] Lens Hive Driver .. SUCCESS [1:06.122s]
> [INFO] Lens Driver for JDBC .. SUCCESS [42.723s]
> [INFO] Lens Elastic Search Driver  SUCCESS [17.640s]
> [INFO] Lens Server

Re: Review Request 66549: Lens Server: SPNEGO authentication

2018-05-04 Thread Barun Kumar



> On April 12, 2018, 8:22 a.m., Rajitha R wrote:
> > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java
> > Line 1516 (original)
> > 
> >
> > revert this

This is a duplicate method.


> On April 12, 2018, 8:22 a.m., Rajitha R wrote:
> > lens-server/src/main/java/org/apache/lens/server/BaseLensService.java
> > Line 164 (original), 169 (patched)
> > 
> >
> > the ! condition here is intentional?

yes.


> On April 12, 2018, 8:22 a.m., Rajitha R wrote:
> > lens-server/src/main/java/org/apache/lens/server/auth/LensSecurityContext.java
> > Lines 63 (patched)
> > 
> >
> > The purpose of this class isn't clear. All the methods return null

fixed.


- Barun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66549/#review200978
---


On May 4, 2018, 12:48 p.m., Barun Kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66549/
> ---
> 
> (Updated May 4, 2018, 12:48 p.m.)
> 
> 
> Review request for lens, Ankit Kailaswar, Puneet Gupta, and Rajitha R.
> 
> 
> Bugs: LENS-1509
> https://issues.apache.org/jira/browse/LENS-1509
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Currently authentication in lens works by taking username/password while 
> opening a session and validating it.
> 
> This change will add support of SPNEGO support in lens server and clinet so 
> that it can negotiate the authentication scheme. Currently only 
> Negotiate(Kerberos) scheme is implemented but others like Basic/Digest etc 
> can be added as well later.
> 
> 
> Diffs
> -
> 
>   contrib/clients/python/lens/client/auth.py PRE-CREATION 
>   contrib/clients/python/lens/client/session.py a1ccc4ba3 
>   contrib/clients/python/setup.py de59d32a9 
>   lens-api/src/main/java/org/apache/lens/api/auth/AuthScheme.java 
> PRE-CREATION 
>   lens-client/src/main/java/org/apache/lens/client/LensClientConfig.java 
> b703e132d 
>   lens-client/src/main/java/org/apache/lens/client/LensConnectionParams.java 
> 3a5dcdb82 
>   lens-client/src/main/java/org/apache/lens/client/SpnegoClientFilter.java 
> PRE-CREATION 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
> e83eacb11 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  f14ae44af 
>   lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 
> b5248f3d5 
>   lens-server/src/main/java/org/apache/lens/server/LensApplication.java 
> c3f99529a 
>   lens-server/src/main/java/org/apache/lens/server/auth/Authenticate.java 
> PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/auth/LensSecurityContext.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/auth/SpnegoAuthenticationFilter.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/error/NotAuthorizedExceptionMapper.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 
> 08a5cff4f 
>   
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 
> 63eea6313 
> 
> 
> Diff: https://reviews.apache.org/r/66549/diff/2/
> 
> 
> Testing
> ---
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules . SUCCESS [1.458s]
> [INFO] Lens .. SUCCESS [3.567s]
> [INFO] Lens API .. SUCCESS [19.185s]
> [INFO] Lens API for server and extensions  SUCCESS [17.395s]
> [INFO] Lens Cube . SUCCESS [3:00.221s]
> [INFO] Lens DB storage ... SUCCESS [13.920s]
> [INFO] Lens Query Library  SUCCESS [11.039s]
> [INFO] Lens Hive Driver .. SUCCESS [1:06.122s]
> [INFO] Lens Driver for JDBC .. SUCCESS [42.723s]
> [INFO] Lens Elastic Search Driver  SUCCESS [17.640s]
> [INFO] Lens Server ... SUCCESS 
> [10:18.231s]
> [INFO] Lens client ... SUCCESS [1:27.686s]
> [INFO] Lens CLI .. SUCCESS [1:32.599s]
> [INFO] Lens Examples . SUCCESS [8.707s]
> [INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [0.691s]
> [INFO] Lens Distribution . SUCCESS [8.002s]
> [INFO]

Re: Review Request 66549: Lens Server: SPNEGO authentication

2018-05-04 Thread Barun Kumar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66549/
---

(Updated May 4, 2018, 12:48 p.m.)


Review request for lens, Ankit Kailaswar, Puneet Gupta, and Rajitha R.


Bugs: LENS-1509
https://issues.apache.org/jira/browse/LENS-1509


Repository: lens


Description
---

Currently authentication in lens works by taking username/password while 
opening a session and validating it.

This change will add support of SPNEGO support in lens server and clinet so 
that it can negotiate the authentication scheme. Currently only 
Negotiate(Kerberos) scheme is implemented but others like Basic/Digest etc can 
be added as well later.


Diffs (updated)
-

  contrib/clients/python/lens/client/auth.py PRE-CREATION 
  contrib/clients/python/lens/client/session.py a1ccc4ba3 
  contrib/clients/python/setup.py de59d32a9 
  lens-api/src/main/java/org/apache/lens/api/auth/AuthScheme.java PRE-CREATION 
  lens-client/src/main/java/org/apache/lens/client/LensClientConfig.java 
b703e132d 
  lens-client/src/main/java/org/apache/lens/client/LensConnectionParams.java 
3a5dcdb82 
  lens-client/src/main/java/org/apache/lens/client/SpnegoClientFilter.java 
PRE-CREATION 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
e83eacb11 
  
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 
f14ae44af 
  lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 
b5248f3d5 
  lens-server/src/main/java/org/apache/lens/server/LensApplication.java 
c3f99529a 
  lens-server/src/main/java/org/apache/lens/server/auth/Authenticate.java 
PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/auth/LensSecurityContext.java 
PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/auth/SpnegoAuthenticationFilter.java
 PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/error/NotAuthorizedExceptionMapper.java
 PRE-CREATION 
  lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 
08a5cff4f 
  lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 
63eea6313 


Diff: https://reviews.apache.org/r/66549/diff/2/

Changes: https://reviews.apache.org/r/66549/diff/1-2/


Testing
---

[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules . SUCCESS [1.458s]
[INFO] Lens .. SUCCESS [3.567s]
[INFO] Lens API .. SUCCESS [19.185s]
[INFO] Lens API for server and extensions  SUCCESS [17.395s]
[INFO] Lens Cube . SUCCESS [3:00.221s]
[INFO] Lens DB storage ... SUCCESS [13.920s]
[INFO] Lens Query Library  SUCCESS [11.039s]
[INFO] Lens Hive Driver .. SUCCESS [1:06.122s]
[INFO] Lens Driver for JDBC .. SUCCESS [42.723s]
[INFO] Lens Elastic Search Driver  SUCCESS [17.640s]
[INFO] Lens Server ... SUCCESS [10:18.231s]
[INFO] Lens client ... SUCCESS [1:27.686s]
[INFO] Lens CLI .. SUCCESS [1:32.599s]
[INFO] Lens Examples . SUCCESS [8.707s]
[INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [0.691s]
[INFO] Lens Distribution . SUCCESS [8.002s]
[INFO] Lens ML Lib ... SUCCESS [1:06.984s]
[INFO] Lens ML Ext Distribution .. SUCCESS [2.084s]
[INFO] Lens Regression ... SUCCESS [12.962s]
[INFO] Lens UI ... SUCCESS [35.012s]
[INFO] Lens Contrib .. SUCCESS [0.263s]
[INFO] Lens Contributed Clients .. SUCCESS [0.266s]
[INFO] Lens Python Client  SUCCESS [0.247s]
[INFO] 


Thanks,

Barun Kumar

Re: Review Request 66549: Lens Server: SPNEGO authentication

2018-05-04 Thread Barun Kumar



> On April 12, 2018, 8:22 a.m., Rajitha R wrote:
> > lens-server/src/main/java/org/apache/lens/server/auth/SpnegoAuthenticationFilter.java
> > Lines 64 (patched)
> > 
> >
> > What exactly is this id? Can this be made configurable than a hardcoded 
> > value ?

This is not a configuration param so hardcoded it.


> On April 12, 2018, 8:22 a.m., Rajitha R wrote:
> > lens-server/src/main/java/org/apache/lens/server/auth/SpnegoAuthenticationFilter.java
> > Lines 65 (patched)
> > 
> >
> > Please move all constant fields to lensconstants class

This constant is private to this class.


> On April 12, 2018, 8:22 a.m., Rajitha R wrote:
> > lens-server/src/main/java/org/apache/lens/server/auth/SpnegoAuthenticationFilter.java
> > Lines 73 (patched)
> > 
> >
> > Does Spnego only support NEGOTIATE scheme? Can we have a default scheme 
> > implemented as well?

There is no default scheme. Others are Plain/Digest etc. We are only doing 
Negotiate as of now.


> On April 12, 2018, 8:22 a.m., Rajitha R wrote:
> > lens-server/src/main/java/org/apache/lens/server/auth/SpnegoAuthenticationFilter.java
> > Lines 106 (patched)
> > 
> >
> > shouldn't we check if all the parameters(uriinfo, resourceinfo etc) are 
> > non null before fetching any data in this method?

This is injected by JAX-RS container so this is not nullable.


> On April 12, 2018, 8:22 a.m., Rajitha R wrote:
> > lens-server/src/main/java/org/apache/lens/server/auth/SpnegoAuthenticationFilter.java
> > Lines 257 (patched)
> > 
> >
> > Can we create a new error code and throw Lens exception for all 
> > authentication failures?

We are using standard JAX-RS exception here for 401 status code. I think this 
is better.


> On April 12, 2018, 8:22 a.m., Rajitha R wrote:
> > lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java
> > Lines 128 (patched)
> > 
> >
> > is this flow valid for all auth schemes?

Yes. This is valid for all schemes. But againg only Negotiate is implemented as 
of now.


- Barun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66549/#review200978
---


On May 4, 2018, 11:04 a.m., Barun Kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66549/
> ---
> 
> (Updated May 4, 2018, 11:04 a.m.)
> 
> 
> Review request for lens, Ankit Kailaswar, Puneet Gupta, and Rajitha R.
> 
> 
> Bugs: LENS-1509
> https://issues.apache.org/jira/browse/LENS-1509
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Currently authentication in lens works by taking username/password while 
> opening a session and validating it.
> 
> This change will add support of SPNEGO support in lens server and clinet so 
> that it can negotiate the authentication scheme. Currently only 
> Negotiate(Kerberos) scheme is implemented but others like Basic/Digest etc 
> can be added as well later.
> 
> 
> Diffs
> -
> 
>   contrib/clients/python/lens/client/auth.py PRE-CREATION 
>   contrib/clients/python/lens/client/session.py a1ccc4b 
>   contrib/clients/python/setup.py de59d32 
>   lens-api/src/main/java/org/apache/lens/api/auth/AuthScheme.java 
> PRE-CREATION 
>   lens-client/src/main/java/org/apache/lens/client/LensClientConfig.java 
> b703e13 
>   lens-client/src/main/java/org/apache/lens/client/SpnegoClientFilter.java 
> PRE-CREATION 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
> e83eacb 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  0e05d28 
>   lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 
> b5248f3 
>   lens-server/src/main/java/org/apache/lens/server/LensApplication.java 
> c3f9952 
>   lens-server/src/main/java/org/apache/lens/server/auth/Authenticate.java 
> PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/auth/LensSecurityContext.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/auth/SpnegoAuthenticationFilter.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/error/NotAuthorizedExceptionMapper.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 
> 08a5cff 
>   
>

Re: Review Request 66549: Lens Server: SPNEGO authentication

2018-04-23 Thread Rajitha R


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66549/#review201719
---



Should we not have the authentication across all resources than just session?


lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java
Lines 71 (patched)


Should we not have the authentication across all resources than just 
session?


- Rajitha R


On April 12, 2018, 8:16 a.m., Barun Kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66549/
> ---
> 
> (Updated April 12, 2018, 8:16 a.m.)
> 
> 
> Review request for lens, Ankit Kailaswar and Rajitha R.
> 
> 
> Bugs: LENS-1509
> https://issues.apache.org/jira/browse/LENS-1509
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Currently authentication in lens works by taking username/password while 
> opening a session and validating it.
> 
> This change will add support of SPNEGO support in lens server and clinet so 
> that it can negotiate the authentication scheme. Currently only 
> Negotiate(Kerberos) scheme is implemented but others like Basic/Digest etc 
> can be added as well later.
> 
> 
> Diffs
> -
> 
>   contrib/clients/python/lens/client/auth.py PRE-CREATION 
>   contrib/clients/python/lens/client/session.py a1ccc4b 
>   contrib/clients/python/setup.py de59d32 
>   lens-api/src/main/java/org/apache/lens/api/auth/AuthScheme.java 
> PRE-CREATION 
>   lens-client/src/main/java/org/apache/lens/client/LensClientConfig.java 
> b703e13 
>   lens-client/src/main/java/org/apache/lens/client/SpnegoClientFilter.java 
> PRE-CREATION 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
> e83eacb 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  0e05d28 
>   lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 
> b5248f3 
>   lens-server/src/main/java/org/apache/lens/server/LensApplication.java 
> c3f9952 
>   lens-server/src/main/java/org/apache/lens/server/auth/Authenticate.java 
> PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/auth/LensSecurityContext.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/auth/SpnegoAuthenticationFilter.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/error/NotAuthorizedExceptionMapper.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 
> 08a5cff 
>   
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 
> 63eea63 
> 
> 
> Diff: https://reviews.apache.org/r/66549/diff/1/
> 
> 
> Testing
> ---
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules . SUCCESS [1.458s]
> [INFO] Lens .. SUCCESS [3.567s]
> [INFO] Lens API .. SUCCESS [19.185s]
> [INFO] Lens API for server and extensions  SUCCESS [17.395s]
> [INFO] Lens Cube . SUCCESS [3:00.221s]
> [INFO] Lens DB storage ... SUCCESS [13.920s]
> [INFO] Lens Query Library  SUCCESS [11.039s]
> [INFO] Lens Hive Driver .. SUCCESS [1:06.122s]
> [INFO] Lens Driver for JDBC .. SUCCESS [42.723s]
> [INFO] Lens Elastic Search Driver  SUCCESS [17.640s]
> [INFO] Lens Server ... SUCCESS 
> [10:18.231s]
> [INFO] Lens client ... SUCCESS [1:27.686s]
> [INFO] Lens CLI .. SUCCESS [1:32.599s]
> [INFO] Lens Examples . SUCCESS [8.707s]
> [INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [0.691s]
> [INFO] Lens Distribution . SUCCESS [8.002s]
> [INFO] Lens ML Lib ... SUCCESS [1:06.984s]
> [INFO] Lens ML Ext Distribution .. SUCCESS [2.084s]
> [INFO] Lens Regression ... SUCCESS [12.962s]
> [INFO] Lens UI ... SUCCESS [35.012s]
> [INFO] Lens Contrib .. SUCCESS [0.263s]
> [INFO] Lens Contributed Clients .. SUCCESS [0.266s]
> [INFO] Lens Python Client  SUCCESS [0.247s]
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Barun Kumar
> 
>

Re: Review Request 66549: Lens Server: SPNEGO authentication

2018-04-12 Thread Barun Kumar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66549/
---

(Updated April 12, 2018, 8:16 a.m.)


Review request for lens, Ankit Kailaswar and Rajitha R.


Repository: lens


Description
---

Currently authentication in lens works by taking username/password while 
opening a session and validating it.

This change will add support of SPNEGO support in lens server and clinet so 
that it can negotiate the authentication scheme. Currently only 
Negotiate(Kerberos) scheme is implemented but others like Basic/Digest etc can 
be added as well later.


Diffs
-

  contrib/clients/python/lens/client/auth.py PRE-CREATION 
  contrib/clients/python/lens/client/session.py a1ccc4b 
  contrib/clients/python/setup.py de59d32 
  lens-api/src/main/java/org/apache/lens/api/auth/AuthScheme.java PRE-CREATION 
  lens-client/src/main/java/org/apache/lens/client/LensClientConfig.java 
b703e13 
  lens-client/src/main/java/org/apache/lens/client/SpnegoClientFilter.java 
PRE-CREATION 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
e83eacb 
  
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 
0e05d28 
  lens-server/src/main/java/org/apache/lens/server/BaseLensService.java b5248f3 
  lens-server/src/main/java/org/apache/lens/server/LensApplication.java c3f9952 
  lens-server/src/main/java/org/apache/lens/server/auth/Authenticate.java 
PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/auth/LensSecurityContext.java 
PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/auth/SpnegoAuthenticationFilter.java
 PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/error/NotAuthorizedExceptionMapper.java
 PRE-CREATION 
  lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 
08a5cff 
  lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 
63eea63 


Diff: https://reviews.apache.org/r/66549/diff/1/


Testing (updated)
---

[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules . SUCCESS [1.458s]
[INFO] Lens .. SUCCESS [3.567s]
[INFO] Lens API .. SUCCESS [19.185s]
[INFO] Lens API for server and extensions  SUCCESS [17.395s]
[INFO] Lens Cube . SUCCESS [3:00.221s]
[INFO] Lens DB storage ... SUCCESS [13.920s]
[INFO] Lens Query Library  SUCCESS [11.039s]
[INFO] Lens Hive Driver .. SUCCESS [1:06.122s]
[INFO] Lens Driver for JDBC .. SUCCESS [42.723s]
[INFO] Lens Elastic Search Driver  SUCCESS [17.640s]
[INFO] Lens Server ... SUCCESS [10:18.231s]
[INFO] Lens client ... SUCCESS [1:27.686s]
[INFO] Lens CLI .. SUCCESS [1:32.599s]
[INFO] Lens Examples . SUCCESS [8.707s]
[INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [0.691s]
[INFO] Lens Distribution . SUCCESS [8.002s]
[INFO] Lens ML Lib ... SUCCESS [1:06.984s]
[INFO] Lens ML Ext Distribution .. SUCCESS [2.084s]
[INFO] Lens Regression ... SUCCESS [12.962s]
[INFO] Lens UI ... SUCCESS [35.012s]
[INFO] Lens Contrib .. SUCCESS [0.263s]
[INFO] Lens Contributed Clients .. SUCCESS [0.266s]
[INFO] Lens Python Client  SUCCESS [0.247s]
[INFO] 


Thanks,

Barun Kumar

Re: Review Request 66549: Lens Server: SPNEGO authentication

Re: Review Request 66549: Lens Server: SPNEGO authentication

Re: Review Request 66549: Lens Server: SPNEGO authentication

Re: Review Request 66549: Lens Server: SPNEGO authentication

Re: Review Request 66549: Lens Server: SPNEGO authentication

Re: Review Request 66549: Lens Server: SPNEGO authentication

Re: Review Request 66549: Lens Server: SPNEGO authentication

Re: Review Request 66549: Lens Server: SPNEGO authentication

Re: Review Request 66549: Lens Server: SPNEGO authentication

Re: Review Request 66549: Lens Server: SPNEGO authentication

Re: Review Request 66549: Lens Server: SPNEGO authentication

Re: Review Request 66549: Lens Server: SPNEGO authentication

Re: Review Request 66549: Lens Server: SPNEGO authentication

Re: Review Request 66549: Lens Server: SPNEGO authentication

Re: Review Request 66549: Lens Server: SPNEGO authentication

Re: Review Request 66549: Lens Server: SPNEGO authentication

Re: Review Request 66549: Lens Server: SPNEGO authentication

17 matches

Site Navigation

Mail list logo

Footer information