Re: Review Request 38920: LENS-797: Improve CLI documentation to mention the helpful role of pressing tab while writing commands

2015-10-08 Thread Rajat Khandelwal 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38920/
---

(Updated Oct. 8, 2015, 1:09 p.m.)


Review request for lens.


Bugs: LENS-797
https://issues.apache.org/jira/browse/LENS-797


Repository: lens


Description
---

https://lens.apache.org/user/cli.html doesn't mention that pressing  can 
be interactive. I've seen users looking up commands every time and even saving 
commands in text files for quicker access. We should mention that commands need 
not be remembered and CLI can help you find the command and its arguments any 
time.


Diffs (updated)
-

  
lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java 
279521113204d614c0807d9ba679ebe36221883d 
  lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 
0afdd61a955d6a0a18c68f678145904722dd0c90 
  lens-cli/src/main/java/org/apache/lens/cli/commands/LensDatabaseCommands.java 
1de24a49bf2242170f229235379bc2cffaae060c 
  
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java 
cd7de556febd4fc2ae684390793298e2f713ff9b 
  
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java
 74efed9159906478d91e75623186a81a7532acb0 
  lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 
6d7d9ebd9937c85c603f9a1bf2822af6763a1ede 
  
lens-cli/src/main/java/org/apache/lens/cli/commands/LensLogResourceCommands.java
 c43a5ffa556c2a8566013fd1258462c9f602c235 
  
lens-cli/src/main/java/org/apache/lens/cli/commands/LensNativeTableCommands.java
 df425810365fc1c328392809c6ff7a72c2c7a8b2 
  lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 
b6e3fcf1d9348b39e8bcc694cd769d4a5faf9971 
  lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 
ca73af76672fb7708bc12ddc503c0877701dbd90 
  lens-cli/src/test/resources/cli-intro.apt 
b5773abe880b7b523f614c6b4da50848e19155f3 
  src/site/apt/user/cli.apt be93b8cfe982fcf60b13dbd3abaa15879537c3fd 

Diff: https://reviews.apache.org/r/38920/diff/


Testing
---


Thanks,

Rajat Khandelwal

Re: Review Request 38920: LENS-797: Improve CLI documentation to mention the helpful role of pressing tab while writing commands

2015-10-05 Thread Amareshwari Sriramadasu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38920/#review101448
---



lens-cli/src/test/resources/cli-intro.apt (line 74)


May be we should add, "for example" in the beginning of this illustration 
here.



lens-cli/src/test/resources/cli-intro.apt (line 84)


This is not a bug. For optional all parametters, mentioining of -- will be 
required.


- Amareshwari Sriramadasu


On Oct. 1, 2015, 9:11 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38920/
> ---
> 
> (Updated Oct. 1, 2015, 9:11 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-797
> https://issues.apache.org/jira/browse/LENS-797
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> https://lens.apache.org/user/cli.html doesn't mention that pressing  can 
> be interactive. I've seen users looking up commands every time and even 
> saving commands in text files for quicker access. We should mention that 
> commands need not be remembered and CLI can help you find the command and its 
> arguments any time.
> 
> 
> Diffs
> -
> 
>   
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java
>  279521113204d614c0807d9ba679ebe36221883d 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 
> 0afdd61a955d6a0a18c68f678145904722dd0c90 
>   
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDatabaseCommands.java 
> 1de24a49bf2242170f229235379bc2cffaae060c 
>   
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java
>  cd7de556febd4fc2ae684390793298e2f713ff9b 
>   
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java
>  74efed9159906478d91e75623186a81a7532acb0 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 
> 6d7d9ebd9937c85c603f9a1bf2822af6763a1ede 
>   
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensLogResourceCommands.java
>  c43a5ffa556c2a8566013fd1258462c9f602c235 
>   
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensNativeTableCommands.java
>  df425810365fc1c328392809c6ff7a72c2c7a8b2 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 
> b6e3fcf1d9348b39e8bcc694cd769d4a5faf9971 
>   
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 
> ca73af76672fb7708bc12ddc503c0877701dbd90 
>   lens-cli/src/test/resources/cli-intro.apt 
> b5773abe880b7b523f614c6b4da50848e19155f3 
>   src/site/apt/user/cli.apt be93b8cfe982fcf60b13dbd3abaa15879537c3fd 
> 
> Diff: https://reviews.apache.org/r/38920/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Review Request 38920: LENS-797: Improve CLI documentation to mention the helpful role of pressing tab while writing commands

2015-10-01 Thread Rajat Khandelwal 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38920/
---

Review request for lens.


Bugs: LENS-797
https://issues.apache.org/jira/browse/LENS-797


Repository: lens


Description
---

https://lens.apache.org/user/cli.html doesn't mention that pressing  can 
be interactive. I've seen users looking up commands every time and even saving 
commands in text files for quicker access. We should mention that commands need 
not be remembered and CLI can help you find the command and its arguments any 
time.


Diffs
-

  
lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java 
279521113204d614c0807d9ba679ebe36221883d 
  lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 
0afdd61a955d6a0a18c68f678145904722dd0c90 
  lens-cli/src/main/java/org/apache/lens/cli/commands/LensDatabaseCommands.java 
1de24a49bf2242170f229235379bc2cffaae060c 
  
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java 
cd7de556febd4fc2ae684390793298e2f713ff9b 
  
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java
 74efed9159906478d91e75623186a81a7532acb0 
  lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 
6d7d9ebd9937c85c603f9a1bf2822af6763a1ede 
  
lens-cli/src/main/java/org/apache/lens/cli/commands/LensLogResourceCommands.java
 c43a5ffa556c2a8566013fd1258462c9f602c235 
  
lens-cli/src/main/java/org/apache/lens/cli/commands/LensNativeTableCommands.java
 df425810365fc1c328392809c6ff7a72c2c7a8b2 
  lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 
b6e3fcf1d9348b39e8bcc694cd769d4a5faf9971 
  lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 
ca73af76672fb7708bc12ddc503c0877701dbd90 
  lens-cli/src/test/resources/cli-intro.apt 
b5773abe880b7b523f614c6b4da50848e19155f3 
  src/site/apt/user/cli.apt be93b8cfe982fcf60b13dbd3abaa15879537c3fd 

Diff: https://reviews.apache.org/r/38920/diff/


Testing
---


Thanks,

Rajat Khandelwal