Re: Review Request 49770: Core scheduler

2016-07-22 Thread Rajat Khandelwal 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49770/#review143228
---


Ship it!




Ship It!

- Rajat Khandelwal


On July 22, 2016, 5:53 p.m., Lavkesh Lahngir wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49770/
> ---
> 
> (Updated July 22, 2016, 5:53 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-128
> https://issues.apache.org/jira/browse/LENS-128
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Implementaion of core scheduler:
> 
> 
> Diffs
> -
> 
>   
> lens-api/src/main/java/org/apache/lens/api/error/InvalidStateTransitionException.java
>  PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobEvent.java 
> PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInfo.java 
> 7d06689 
>   
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceEvent.java
>  PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceInfo.java
>  8158576 
>   
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceRun.java
>  PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceState.java
>  PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceStatus.java
>  85e7e85 
>   lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobState.java 
> PRE-CREATION 
>   
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobStatus.java 
> aaf403c 
>   lens-api/src/main/java/org/apache/lens/api/scheduler/StateTransitioner.java 
> PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 
> 33ec9d9 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/FieldsCannotBeQueriedTogetherTest.java
>  fe2dfb3 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java 
> c8a9ac6 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  bd9b1ab 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/error/InvalidStateTransitionException.java
>  5882151 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/events/SchedulerAlarmEvent.java
>  3ca7eb9 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java
>  d0af876 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/StateMachine.java
>  ba6a0a2 
>   lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 
> 74bc0be 
>   lens-server/src/main/java/org/apache/lens/server/LensServices.java 7618669 
>   
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java
>  1e8d540 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/AlarmService.java 
> PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java
>  39c4d98 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java 
> bf99fde 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerQueryEventListener.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
>  3952671 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/notification/services/AlarmService.java
>  a4cdd83 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/state/SchedulerJobInstanceState.java
>  95057e4 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/state/SchedulerJobState.java
>  d21cd05 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/util/UtilityMethods.java
>  31783ad 
>   
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 
> e77c7fa 
>   lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 
> 63a7874 
>   lens-server/src/main/resources/lensserver-default.xml 3ce8fc1 
>   
> lens-server/src/test/java/org/apache/lens/server/scheduler/AlarmServiceTest.java
>  PRE-CREATION 
>   
> lens-server/src/test/java/org/apache/lens/server/scheduler/SchedulerDAOTest.java
>  d76a586 
>   
> lens-server/src/test/java/org/apache/lens/server/scheduler/TestSchedulerServiceImpl.java
>  PRE-CREATION 
>   
> lens-server/src/test/java/org/apache/lens/server/scheduler/notification/services/AlarmServiceTest.java
>  06883ae 
>   src/site/apt/admin/config.apt 852955b 
> 
> Diff: https://reviews.apache.org/r/49770/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Lavkesh Lahngir
> 
>

Re: Review Request 49770: Core scheduler

2016-07-22 Thread Lavkesh Lahngir 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49770/
---

(Updated July 22, 2016, 12:23 p.m.)


Review request for lens.


Bugs: LENS-128
https://issues.apache.org/jira/browse/LENS-128


Repository: lens


Description
---

Implementaion of core scheduler:


Diffs (updated)
-

  
lens-api/src/main/java/org/apache/lens/api/error/InvalidStateTransitionException.java
 PRE-CREATION 
  lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobEvent.java 
PRE-CREATION 
  lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInfo.java 
7d06689 
  
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceEvent.java
 PRE-CREATION 
  
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceInfo.java
 8158576 
  
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceRun.java
 PRE-CREATION 
  
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceState.java
 PRE-CREATION 
  
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceStatus.java
 85e7e85 
  lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobState.java 
PRE-CREATION 
  lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobStatus.java 
aaf403c 
  lens-api/src/main/java/org/apache/lens/api/scheduler/StateTransitioner.java 
PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 
33ec9d9 
  
lens-cube/src/test/java/org/apache/lens/cube/parse/FieldsCannotBeQueriedTogetherTest.java
 fe2dfb3 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java 
c8a9ac6 
  
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 
bd9b1ab 
  
lens-server-api/src/main/java/org/apache/lens/server/api/error/InvalidStateTransitionException.java
 5882151 
  
lens-server-api/src/main/java/org/apache/lens/server/api/events/SchedulerAlarmEvent.java
 3ca7eb9 
  
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java
 d0af876 
  
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/StateMachine.java
 ba6a0a2 
  lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 74bc0be 
  lens-server/src/main/java/org/apache/lens/server/LensServices.java 7618669 
  
lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java
 1e8d540 
  lens-server/src/main/java/org/apache/lens/server/scheduler/AlarmService.java 
PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java
 39c4d98 
  lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java 
bf99fde 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java
 PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerQueryEventListener.java
 PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
 3952671 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/notification/services/AlarmService.java
 a4cdd83 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/state/SchedulerJobInstanceState.java
 95057e4 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/state/SchedulerJobState.java
 d21cd05 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/util/UtilityMethods.java
 31783ad 
  lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 
e77c7fa 
  lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 
63a7874 
  lens-server/src/main/resources/lensserver-default.xml 3ce8fc1 
  
lens-server/src/test/java/org/apache/lens/server/scheduler/AlarmServiceTest.java
 PRE-CREATION 
  
lens-server/src/test/java/org/apache/lens/server/scheduler/SchedulerDAOTest.java
 d76a586 
  
lens-server/src/test/java/org/apache/lens/server/scheduler/TestSchedulerServiceImpl.java
 PRE-CREATION 
  
lens-server/src/test/java/org/apache/lens/server/scheduler/notification/services/AlarmServiceTest.java
 06883ae 
  src/site/apt/admin/config.apt 852955b 

Diff: https://reviews.apache.org/r/49770/diff/


Testing
---


Thanks,

Lavkesh Lahngir

Re: Review Request 49770: Core scheduler

2016-07-22 Thread Amareshwari Sriramadasu 


> On July 22, 2016, 3:53 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/resources/lensserver-default.xml, line 876
> > 
> >
> > why are we setting default value to 0 ?
> 
> Lavkesh Lahngir wrote:
> There are no specific reasons. If the value is set to zero then take 
> current time as 'now'.

Sure, lets update the doc with the same and upload.


- Amareshwari


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49770/#review143174
---


On July 21, 2016, 10:10 a.m., Lavkesh Lahngir wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49770/
> ---
> 
> (Updated July 21, 2016, 10:10 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-128
> https://issues.apache.org/jira/browse/LENS-128
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Implementaion of core scheduler:
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInfo.java 
> 7d06689 
>   
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceInfo.java
>  8158576 
>   
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceRun.java
>  PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 
> 33ec9d9 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/FieldsCannotBeQueriedTogetherTest.java
>  fe2dfb3 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java 
> c8a9ac6 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  bd9b1ab 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/events/SchedulerAlarmEvent.java
>  3ca7eb9 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceState.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobState.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java
>  d0af876 
>   lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 
> 74bc0be 
>   lens-server/src/main/java/org/apache/lens/server/LensServices.java 7618669 
>   
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java
>  1e8d540 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/AlarmService.java 
> PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java
>  39c4d98 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java 
> bf99fde 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerQueryEventListener.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
>  3952671 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/notification/services/AlarmService.java
>  a4cdd83 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/state/SchedulerJobInstanceState.java
>  95057e4 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/state/SchedulerJobState.java
>  d21cd05 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/util/UtilityMethods.java
>  31783ad 
>   
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 
> e77c7fa 
>   lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 
> 63a7874 
>   lens-server/src/main/resources/lensserver-default.xml 6dc322e 
>   
> lens-server/src/test/java/org/apache/lens/server/scheduler/AlarmServiceTest.java
>  PRE-CREATION 
>   
> lens-server/src/test/java/org/apache/lens/server/scheduler/SchedulerDAOTest.java
>  d76a586 
>   
> lens-server/src/test/java/org/apache/lens/server/scheduler/TestSchedulerServiceImpl.java
>  PRE-CREATION 
>   
> lens-server/src/test/java/org/apache/lens/server/scheduler/notification/services/AlarmServiceTest.java
>  06883ae 
>   src/site/apt/admin/config.apt 5b76069 
> 
> Diff: https://reviews.apache.org/r/49770/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Lavkesh Lahngir
> 
>

Re: Review Request 49770: Core scheduler

2016-07-22 Thread Lavkesh Lahngir 


> On July 22, 2016, 3:53 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/resources/lensserver-default.xml, line 876
> > 
> >
> > why are we setting default value to 0 ?

There are no specific reasons. If the value is set to zero then take current 
time as 'now'.


- Lavkesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49770/#review143174
---


On July 21, 2016, 10:10 a.m., Lavkesh Lahngir wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49770/
> ---
> 
> (Updated July 21, 2016, 10:10 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-128
> https://issues.apache.org/jira/browse/LENS-128
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Implementaion of core scheduler:
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInfo.java 
> 7d06689 
>   
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceInfo.java
>  8158576 
>   
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceRun.java
>  PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 
> 33ec9d9 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/FieldsCannotBeQueriedTogetherTest.java
>  fe2dfb3 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java 
> c8a9ac6 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  bd9b1ab 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/events/SchedulerAlarmEvent.java
>  3ca7eb9 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceState.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobState.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java
>  d0af876 
>   lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 
> 74bc0be 
>   lens-server/src/main/java/org/apache/lens/server/LensServices.java 7618669 
>   
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java
>  1e8d540 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/AlarmService.java 
> PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java
>  39c4d98 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java 
> bf99fde 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerQueryEventListener.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
>  3952671 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/notification/services/AlarmService.java
>  a4cdd83 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/state/SchedulerJobInstanceState.java
>  95057e4 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/state/SchedulerJobState.java
>  d21cd05 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/util/UtilityMethods.java
>  31783ad 
>   
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 
> e77c7fa 
>   lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 
> 63a7874 
>   lens-server/src/main/resources/lensserver-default.xml 6dc322e 
>   
> lens-server/src/test/java/org/apache/lens/server/scheduler/AlarmServiceTest.java
>  PRE-CREATION 
>   
> lens-server/src/test/java/org/apache/lens/server/scheduler/SchedulerDAOTest.java
>  d76a586 
>   
> lens-server/src/test/java/org/apache/lens/server/scheduler/TestSchedulerServiceImpl.java
>  PRE-CREATION 
>   
> lens-server/src/test/java/org/apache/lens/server/scheduler/notification/services/AlarmServiceTest.java
>  06883ae 
>   src/site/apt/admin/config.apt 5b76069 
> 
> Diff: https://reviews.apache.org/r/49770/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Lavkesh Lahngir
> 
>

Re: Review Request 49770: Core scheduler

2016-07-21 Thread Amareshwari Sriramadasu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49770/#review143174
---


Fix it, then Ship it!




Changes look good to me.


lens-server/src/main/resources/lensserver-default.xml (line 876)


why are we setting default value to 0 ?


- Amareshwari Sriramadasu


On July 21, 2016, 10:10 a.m., Lavkesh Lahngir wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49770/
> ---
> 
> (Updated July 21, 2016, 10:10 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-128
> https://issues.apache.org/jira/browse/LENS-128
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Implementaion of core scheduler:
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInfo.java 
> 7d06689 
>   
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceInfo.java
>  8158576 
>   
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceRun.java
>  PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 
> 33ec9d9 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/FieldsCannotBeQueriedTogetherTest.java
>  fe2dfb3 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java 
> c8a9ac6 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  bd9b1ab 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/events/SchedulerAlarmEvent.java
>  3ca7eb9 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceState.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobState.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java
>  d0af876 
>   lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 
> 74bc0be 
>   lens-server/src/main/java/org/apache/lens/server/LensServices.java 7618669 
>   
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java
>  1e8d540 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/AlarmService.java 
> PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java
>  39c4d98 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java 
> bf99fde 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerQueryEventListener.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
>  3952671 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/notification/services/AlarmService.java
>  a4cdd83 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/state/SchedulerJobInstanceState.java
>  95057e4 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/state/SchedulerJobState.java
>  d21cd05 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/util/UtilityMethods.java
>  31783ad 
>   
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 
> e77c7fa 
>   lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 
> 63a7874 
>   lens-server/src/main/resources/lensserver-default.xml 6dc322e 
>   
> lens-server/src/test/java/org/apache/lens/server/scheduler/AlarmServiceTest.java
>  PRE-CREATION 
>   
> lens-server/src/test/java/org/apache/lens/server/scheduler/SchedulerDAOTest.java
>  d76a586 
>   
> lens-server/src/test/java/org/apache/lens/server/scheduler/TestSchedulerServiceImpl.java
>  PRE-CREATION 
>   
> lens-server/src/test/java/org/apache/lens/server/scheduler/notification/services/AlarmServiceTest.java
>  06883ae 
>   src/site/apt/admin/config.apt 5b76069 
> 
> Diff: https://reviews.apache.org/r/49770/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Lavkesh Lahngir
> 
>

Re: Review Request 49770: Core scheduler

2016-07-21 Thread Lavkesh Lahngir 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49770/
---

(Updated July 21, 2016, 10:10 a.m.)


Review request for lens.


Bugs: LENS-128
https://issues.apache.org/jira/browse/LENS-128


Repository: lens


Description
---

Implementaion of core scheduler:


Diffs (updated)
-

  lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInfo.java 
7d06689 
  
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceInfo.java
 8158576 
  
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceRun.java
 PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 
33ec9d9 
  
lens-cube/src/test/java/org/apache/lens/cube/parse/FieldsCannotBeQueriedTogetherTest.java
 fe2dfb3 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java 
c8a9ac6 
  
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 
bd9b1ab 
  
lens-server-api/src/main/java/org/apache/lens/server/api/events/SchedulerAlarmEvent.java
 3ca7eb9 
  
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceState.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobState.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java
 d0af876 
  lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 74bc0be 
  lens-server/src/main/java/org/apache/lens/server/LensServices.java 7618669 
  
lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java
 1e8d540 
  lens-server/src/main/java/org/apache/lens/server/scheduler/AlarmService.java 
PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java
 39c4d98 
  lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java 
bf99fde 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java
 PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerQueryEventListener.java
 PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
 3952671 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/notification/services/AlarmService.java
 a4cdd83 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/state/SchedulerJobInstanceState.java
 95057e4 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/state/SchedulerJobState.java
 d21cd05 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/util/UtilityMethods.java
 31783ad 
  lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 
e77c7fa 
  lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 
63a7874 
  lens-server/src/main/resources/lensserver-default.xml 6dc322e 
  
lens-server/src/test/java/org/apache/lens/server/scheduler/AlarmServiceTest.java
 PRE-CREATION 
  
lens-server/src/test/java/org/apache/lens/server/scheduler/SchedulerDAOTest.java
 d76a586 
  
lens-server/src/test/java/org/apache/lens/server/scheduler/TestSchedulerServiceImpl.java
 PRE-CREATION 
  
lens-server/src/test/java/org/apache/lens/server/scheduler/notification/services/AlarmServiceTest.java
 06883ae 
  src/site/apt/admin/config.apt 5b76069 

Diff: https://reviews.apache.org/r/49770/diff/


Testing
---


Thanks,

Lavkesh Lahngir

Re: Review Request 49770: Core scheduler

2016-07-20 Thread Lavkesh Lahngir 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49770/
---

(Updated July 20, 2016, 3:15 p.m.)


Review request for lens.


Changes
---

Test case fixes.


Bugs: LENS-128
https://issues.apache.org/jira/browse/LENS-128


Repository: lens


Description
---

Implementaion of core scheduler:


Diffs (updated)
-

  lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInfo.java 
7d06689 
  
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceInfo.java
 8158576 
  
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceRun.java
 PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 
33ec9d9 
  
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 
bd9b1ab 
  
lens-server-api/src/main/java/org/apache/lens/server/api/events/SchedulerAlarmEvent.java
 3ca7eb9 
  
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceState.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobState.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java
 d0af876 
  lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 74bc0be 
  lens-server/src/main/java/org/apache/lens/server/LensServices.java 7618669 
  
lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java
 1e8d540 
  lens-server/src/main/java/org/apache/lens/server/scheduler/AlarmService.java 
PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java
 39c4d98 
  lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java 
bf99fde 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java
 PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerQueryEventListener.java
 PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
 3952671 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/notification/services/AlarmService.java
 a4cdd83 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/state/SchedulerJobInstanceState.java
 95057e4 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/state/SchedulerJobState.java
 d21cd05 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/util/UtilityMethods.java
 31783ad 
  lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 
e77c7fa 
  lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 
63a7874 
  
lens-server/src/test/java/org/apache/lens/server/scheduler/AlarmServiceTest.java
 PRE-CREATION 
  
lens-server/src/test/java/org/apache/lens/server/scheduler/SchedulerDAOTest.java
 d76a586 
  
lens-server/src/test/java/org/apache/lens/server/scheduler/TestSchedulerServiceImpl.java
 PRE-CREATION 
  
lens-server/src/test/java/org/apache/lens/server/scheduler/notification/services/AlarmServiceTest.java
 06883ae 

Diff: https://reviews.apache.org/r/49770/diff/


Testing
---


Thanks,

Lavkesh Lahngir

Re: Review Request 49770: Core scheduler

2016-07-18 Thread Rajat Khandelwal 


> On July 11, 2016, 12:24 p.m., Rajat Khandelwal wrote:
> > lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerQueryEventListener.java,
> >  line 55
> > 
> >
> > might need to add one more case for `CLOSED` state.
> 
> Lavkesh Lahngir wrote:
> Do yo think there is a need to check CLOSED status ?

In case CLOSED comes here, we don't want it to mark it as failed. You might 
have to check through test cases whether CLOSED event comes here or not.


- Rajat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49770/#review141641
---


On July 15, 2016, 2:42 p.m., Lavkesh Lahngir wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49770/
> ---
> 
> (Updated July 15, 2016, 2:42 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-128
> https://issues.apache.org/jira/browse/LENS-128
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Implementaion of core scheduler:
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInfo.java 
> 7d06689 
>   
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceInfo.java
>  8158576 
>   
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceRun.java
>  PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 
> 33ec9d9 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  bd9b1ab 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/events/SchedulerAlarmEvent.java
>  3ca7eb9 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java
>  d0af876 
>   
> lens-server-api/src/main/java/org/apache/lens/server/scheduler/SchedulerJobInstanceState.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/scheduler/SchedulerJobState.java
>  PRE-CREATION 
>   lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 
> 74bc0be 
>   lens-server/src/main/java/org/apache/lens/server/LensServices.java 7618669 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java
>  39c4d98 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java 
> bf99fde 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerQueryEventListener.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
>  3952671 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/notification/services/AlarmService.java
>  a4cdd83 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/state/SchedulerJobInstanceState.java
>  95057e4 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/state/SchedulerJobState.java
>  d21cd05 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/util/UtilityMethods.java
>  31783ad 
>   
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 
> e77c7fa 
>   
> lens-server/src/test/java/org/apache/lens/server/scheduler/SchedulerDAOTest.java
>  d76a586 
>   
> lens-server/src/test/java/org/apache/lens/server/scheduler/TestSchedulerServiceImpl.java
>  PRE-CREATION 
>   
> lens-server/src/test/java/org/apache/lens/server/scheduler/notification/services/AlarmServiceTest.java
>  06883ae 
> 
> Diff: https://reviews.apache.org/r/49770/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Lavkesh Lahngir
> 
>

Re: Review Request 49770: Core scheduler

2016-07-18 Thread Rajat Khandelwal 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49770/#review142352
---




lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInfo.java 
(line 55)


Rename variable too to reflect this is status, not state.



lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 
(lines 132 - 136)


Do we have test cases for this?



lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 
(line 1116)


Let's mention unit too in the property name. probably `current.time.millis`



lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java
 (line 55)


`@returns`



lens-server-api/src/main/java/org/apache/lens/server/scheduler/SchedulerJobInstanceState.java
 (line 19)


`server.api.scheduler`



lens-server-api/src/main/java/org/apache/lens/server/scheduler/SchedulerJobInstanceState.java
 (line 54)


Can we call it `State` instead of `STATE`?



lens-server-api/src/main/java/org/apache/lens/server/scheduler/SchedulerJobInstanceState.java
 (line 185)


Same as above: Let's name it `Event` instead of `EVENT`.



lens-server-api/src/main/java/org/apache/lens/server/scheduler/SchedulerJobState.java
 (line 19)


`org.apache.lens.server.api.scheduler`



lens-server-api/src/main/java/org/apache/lens/server/scheduler/SchedulerJobState.java
 (line 54)


`State`. http://stackoverflow.com/a/3069863/459384



lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java
 (line 92)


This might be confusing. In listing queries, there's a form param named 
`state`. Here, we have one named `status`.



lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java
 (line 204)


Can we return some more helpful info for the user? When will the operation 
not be successful?



lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java 
(lines 140 - 144)


Mismatch. One place uses `state`, another uses `status`.



lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java
 (line 35)


Let's take the value from configutation. We might need an option to 
dynamically size the scheduler event listener depending on scale.



lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java
 (line 84)


Let's try to use `QueryExecutionService` instead of `Impl`



lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java
 (line 93)


Same as above



lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java
 (line 116)


Shall we move line 97 to here? There is no use uf `currentTime` between 
there and here.



lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java
 (line 135)


Can we remove this? If not, can you provide some more details in the 
comment itself wrt what handling is required?



lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java
 (line 148)


Shall we move the `nextTransition` method to the enum instead of the 
`State` object? That way, creating such new instances can be avoided.



lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
 (line 58)


+1



lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
 (line 151)


We might want to estimate with fail-on-partial set to false.



lens-server/src/main/java/org/apache/lens/server/scheduler/util/UtilityMethods.java
 (line 19)


we have another utility class `org.apache.lens.server.util.UtilityMethods`. 
Let's merge this class into that.


- Rajat Khandelwal


On July 15, 2016, 2:42 p.m., Lavkesh Lahngir wrote:
> 
>

Re: Review Request 49770: Core scheduler

2016-07-15 Thread Lavkesh Lahngir 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49770/
---

(Updated July 15, 2016, 9:12 a.m.)


Review request for lens.


Changes
---

Fixed all the pending issues.


Bugs: LENS-128
https://issues.apache.org/jira/browse/LENS-128


Repository: lens


Description
---

Implementaion of core scheduler:


Diffs (updated)
-

  lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInfo.java 
7d06689 
  
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceInfo.java
 8158576 
  
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceRun.java
 PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 
33ec9d9 
  
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 
bd9b1ab 
  
lens-server-api/src/main/java/org/apache/lens/server/api/events/SchedulerAlarmEvent.java
 3ca7eb9 
  
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java
 d0af876 
  
lens-server-api/src/main/java/org/apache/lens/server/scheduler/SchedulerJobInstanceState.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/scheduler/SchedulerJobState.java
 PRE-CREATION 
  lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 74bc0be 
  lens-server/src/main/java/org/apache/lens/server/LensServices.java 7618669 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java
 39c4d98 
  lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java 
bf99fde 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java
 PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerQueryEventListener.java
 PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
 3952671 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/notification/services/AlarmService.java
 a4cdd83 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/state/SchedulerJobInstanceState.java
 95057e4 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/state/SchedulerJobState.java
 d21cd05 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/util/UtilityMethods.java
 31783ad 
  lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 
e77c7fa 
  
lens-server/src/test/java/org/apache/lens/server/scheduler/SchedulerDAOTest.java
 d76a586 
  
lens-server/src/test/java/org/apache/lens/server/scheduler/TestSchedulerServiceImpl.java
 PRE-CREATION 
  
lens-server/src/test/java/org/apache/lens/server/scheduler/notification/services/AlarmServiceTest.java
 06883ae 

Diff: https://reviews.apache.org/r/49770/diff/


Testing
---


Thanks,

Lavkesh Lahngir

Re: Review Request 49770: Core scheduler

2016-07-14 Thread Lavkesh Lahngir 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49770/
---

(Updated July 14, 2016, 10:07 p.m.)


Review request for lens.


Changes
---

1. Rerun Fix.
2. Test cases
2. Moved code around. 
3. TODO: Client side API should be fixed.


Bugs: LENS-128
https://issues.apache.org/jira/browse/LENS-128


Repository: lens


Description (updated)
---

Implementaion of core scheduler:


Diffs (updated)
-

  lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInfo.java 
7d06689 
  
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceInfo.java
 8158576 
  lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 
33ec9d9 
  
lens-server-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInfo.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceInfo.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceRun.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 
bd9b1ab 
  
lens-server-api/src/main/java/org/apache/lens/server/api/events/SchedulerAlarmEvent.java
 3ca7eb9 
  
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java
 d0af876 
  
lens-server-api/src/main/java/org/apache/lens/server/scheduler/SchedulerJobInstanceState.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/scheduler/SchedulerJobState.java
 PRE-CREATION 
  lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 74bc0be 
  lens-server/src/main/java/org/apache/lens/server/LensServices.java 7618669 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java
 39c4d98 
  lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java 
bf99fde 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java
 PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerQueryEventListener.java
 PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
 3952671 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/notification/services/AlarmService.java
 a4cdd83 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/state/SchedulerJobInstanceState.java
 95057e4 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/state/SchedulerJobState.java
 d21cd05 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/util/UtilityMethods.java
 31783ad 
  lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 
e77c7fa 
  
lens-server/src/test/java/org/apache/lens/server/scheduler/SchedulerDAOTest.java
 d76a586 
  
lens-server/src/test/java/org/apache/lens/server/scheduler/TestSchedulerServiceImpl.java
 PRE-CREATION 
  
lens-server/src/test/java/org/apache/lens/server/scheduler/notification/services/AlarmServiceTest.java
 06883ae 

Diff: https://reviews.apache.org/r/49770/diff/


Testing
---


Thanks,

Lavkesh Lahngir

Re: Review Request 49770: Core scheduler

2016-07-11 Thread Lavkesh Lahngir 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49770/
---

(Updated July 11, 2016, 3:39 p.m.)


Review request for lens.


Changes
---

Query configuration has a parameter named "lens.query.current.time" which will 
be used to resolve now()


Bugs: LENS-128
https://issues.apache.org/jira/browse/LENS-128


Repository: lens


Description (updated)
---

Implementaion of core scheduler:
TODO: 
1. Test cases.


Diffs (updated)
-

  lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInfo.java 
7d06689 
  
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceInfo.java
 8158576 
  lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 
33ec9d9 
  
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 
bd9b1ab 
  
lens-server-api/src/main/java/org/apache/lens/server/api/events/SchedulerAlarmEvent.java
 3ca7eb9 
  
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java
 d0af876 
  lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 74bc0be 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java
 39c4d98 
  lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java 
bf99fde 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java
 PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerQueryEventListener.java
 PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
 3952671 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/notification/services/AlarmService.java
 a4cdd83 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/util/UtilityMethods.java
 31783ad 
  lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 
e77c7fa 
  
lens-server/src/test/java/org/apache/lens/server/scheduler/SchedulerDAOTest.java
 d76a586 
  
lens-server/src/test/java/org/apache/lens/server/scheduler/SchedulerServiceTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/49770/diff/


Testing
---


Thanks,

Lavkesh Lahngir

Re: Review Request 49770: Core scheduler

2016-07-11 Thread Lavkesh Lahngir 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49770/#review141707
---




lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceInfo.java
 (line 83)


This is a typo.


- Lavkesh Lahngir


On July 11, 2016, 3:39 p.m., Lavkesh Lahngir wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49770/
> ---
> 
> (Updated July 11, 2016, 3:39 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-128
> https://issues.apache.org/jira/browse/LENS-128
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Implementaion of core scheduler:
> TODO: 
> 1. Test cases.
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInfo.java 
> 7d06689 
>   
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceInfo.java
>  8158576 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 
> 33ec9d9 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  bd9b1ab 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/events/SchedulerAlarmEvent.java
>  3ca7eb9 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java
>  d0af876 
>   lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 
> 74bc0be 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java
>  39c4d98 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java 
> bf99fde 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerQueryEventListener.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
>  3952671 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/notification/services/AlarmService.java
>  a4cdd83 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/util/UtilityMethods.java
>  31783ad 
>   
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 
> e77c7fa 
>   
> lens-server/src/test/java/org/apache/lens/server/scheduler/SchedulerDAOTest.java
>  d76a586 
>   
> lens-server/src/test/java/org/apache/lens/server/scheduler/SchedulerServiceTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/49770/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Lavkesh Lahngir
> 
>

Re: Review Request 49770: Core scheduler

2016-07-11 Thread Lavkesh Lahngir 


> On July 11, 2016, 6:54 a.m., Rajat Khandelwal wrote:
> > lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java,
> >  line 34
> > 
> >
> > Can the first and/or the third arguments converted to take `Service` 
> > instead of `ServiceImpl`?

QueryExecutionServiceImpl is neccessary because of opensession method(). 
I changed the schedulerService


> On July 11, 2016, 6:54 a.m., Rajat Khandelwal wrote:
> > lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerQueryEventListener.java,
> >  line 55
> > 
> >
> > might need to add one more case for `CLOSED` state.

Do yo think there is a need to check CLOSED status ?


- Lavkesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49770/#review141641
---


On July 11, 2016, 3:39 p.m., Lavkesh Lahngir wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49770/
> ---
> 
> (Updated July 11, 2016, 3:39 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-128
> https://issues.apache.org/jira/browse/LENS-128
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Implementaion of core scheduler:
> TODO: 
> 1. Test cases.
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInfo.java 
> 7d06689 
>   
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceInfo.java
>  8158576 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 
> 33ec9d9 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  bd9b1ab 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/events/SchedulerAlarmEvent.java
>  3ca7eb9 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java
>  d0af876 
>   lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 
> 74bc0be 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java
>  39c4d98 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java 
> bf99fde 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerQueryEventListener.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
>  3952671 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/notification/services/AlarmService.java
>  a4cdd83 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/util/UtilityMethods.java
>  31783ad 
>   
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 
> e77c7fa 
>   
> lens-server/src/test/java/org/apache/lens/server/scheduler/SchedulerDAOTest.java
>  d76a586 
>   
> lens-server/src/test/java/org/apache/lens/server/scheduler/SchedulerServiceTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/49770/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Lavkesh Lahngir
> 
>

Re: Review Request 49770: Core scheduler

2016-07-11 Thread Rajat Khandelwal 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49770/#review141641
---




lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java
 (line 34)


Can the first and/or the third arguments converted to take `Service` 
instead of `ServiceImpl`?



lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java
 (line 72)


Should be job submitter's login



lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java
 (line 118)


Mark failed here too?



lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerQueryEventListener.java
 (line 55)


might need to add one more case for `CLOSED` state.



lens-server/src/main/java/org/apache/lens/server/scheduler/util/UtilityMethods.java
 (line 57)


`fromString(x.toString)` would be slightly slower than `new 
SchedulerJobHandle(UUID.randomUUID())`.


- Rajat Khandelwal


On July 8, 2016, 1:05 a.m., Lavkesh Lahngir wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49770/
> ---
> 
> (Updated July 8, 2016, 1:05 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-128
> https://issues.apache.org/jira/browse/LENS-128
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Implementaion of core scheduler:
> TODO: 
> 1. Test cases.
> 2. Open session with the user. 
> 3. Saved Query.
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInfo.java 
> 7d06689 
>   
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceInfo.java
>  8158576 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/events/SchedulerAlarmEvent.java
>  3ca7eb9 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java
>  d0af876 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java
>  39c4d98 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java 
> bf99fde 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerQueryEventListener.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
>  3952671 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/notification/services/AlarmService.java
>  a4cdd83 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/util/UtilityMethods.java
>  31783ad 
>   
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 
> e77c7fa 
>   
> lens-server/src/test/java/org/apache/lens/server/scheduler/SchedulerDAOTest.java
>  d76a586 
>   
> lens-server/src/test/java/org/apache/lens/server/scheduler/SchedulerServiceTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/49770/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Lavkesh Lahngir
> 
>

Review Request 49770: Core scheduler

2016-07-07 Thread Lavkesh Lahngir 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49770/
---

Review request for lens.


Bugs: LENS-128
https://issues.apache.org/jira/browse/LENS-128


Repository: lens


Description
---

Implementaion of core scheduler:
TODO: 
1. Test cases.
2. Open session with the user. 
3. Saved Query.


Diffs
-

  lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInfo.java 
7d06689 
  
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceInfo.java
 8158576 
  
lens-server-api/src/main/java/org/apache/lens/server/api/events/SchedulerAlarmEvent.java
 3ca7eb9 
  
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java
 d0af876 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java
 39c4d98 
  lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java 
bf99fde 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java
 PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerQueryEventListener.java
 PRE-CREATION 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
 3952671 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/notification/services/AlarmService.java
 a4cdd83 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/util/UtilityMethods.java
 31783ad 
  lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 
e77c7fa 
  
lens-server/src/test/java/org/apache/lens/server/scheduler/SchedulerDAOTest.java
 d76a586 
  
lens-server/src/test/java/org/apache/lens/server/scheduler/SchedulerServiceTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/49770/diff/


Testing
---


Thanks,

Lavkesh Lahngir