Re: Review Request 51363: LENS-1287: Create command in cli to create schema taking parent directory where schema is stored

2016-10-05 Thread Rajat Khandelwal 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51363/
---

(Updated Oct. 5, 2016, 2:40 p.m.)


Review request for lens.


Bugs: LENS-1287
https://issues.apache.org/jira/browse/LENS-1287


Repository: lens


Description
---


Diffs (updated)
-

  lens-cli/src/main/java/org/apache/lens/cli/commands/LensDatabaseCommands.java 
05108f0158b655653f0665da80a2d10b24f33233 
  
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java
 7df5c7ca1c7f557409ed36a4be7f4b050260f159 
  lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 
6457bceef143ce08e6a57726cb1e54dcf3288b0c 
  lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java 
PRE-CREATION 
  lens-cli/src/test/java/org/apache/lens/cli/LensCLITest.java PRE-CREATION 
  lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 
c20766c26c42918e7ab33c32c0b4218ddfa5ee81 
  lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java 
9687c6089125b4eb9dc2a96fd7d4a140c81eb66c 
  lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java 
a3f01c38d1c94857f0cdfdd7a457b402754c30a6 
  
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 
5d6d7682d75793897cc6d2fee0bb23ce7f467ab9 
  lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java 
b4cbf344c46faa40074bc79fa0227312e027dfb6 
  
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java
 24f9279b24de98ed1e7304ec2e2010c17df9f8d8 
  lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 
e75fc0ef19d9d9b288bdb677bfdf499aa088e6ee 
  lens-cli/src/test/java/org/apache/lens/cli/TestLensSchemaCommands.java 
PRE-CREATION 
  lens-cli/src/test/java/org/apache/lens/cli/TestLensSegmentationCommands.java 
e6d4bc5354bbcae9ea6d1f06ec2be6e2ff885cf6 
  lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 
c4ab6140c573d8bb4d2048969be14786d2371d6d 
  lens-cli/src/test/java/org/apache/lens/cli/doc/TestGenerateCLIUserDoc.java 
95e6b4e205128a19d1099f0a14638a8eb2d19c7c 
  lens-cli/src/test/resources/cube_with_no_weight_facts.xml 
4673ca416758c35bf50616896f084360a1b5bb89 
  lens-cli/src/test/resources/dim_table.xml 
eb4ddfcc49c9cfdc152df35fe863176986016d95 
  lens-cli/src/test/resources/dim_table2.xml 
8440e28b59cdcc567bac00e4c1e2367ef2ebda0c 
  lens-cli/src/test/resources/fact1.xml 
b18a39313bff9850c720cb3f0492bc6b7a650f78 
  lens-cli/src/test/resources/fact_without_weight.xml 
0c124b2aba88a9efcc164b3b4de96479c164cd6a 
  lens-cli/src/test/resources/local-storage.xml 
65513757f5dc2a19fea88cde4f4fa8736f814091 
  lens-cli/src/test/resources/sample-cube.xml 
2d6bc3469466cee6245f8f503af956dcc92cffb5 
  lens-cli/src/test/resources/schema/cubes/base/cube_with_no_weight_facts.xml 
PRE-CREATION 
  lens-cli/src/test/resources/schema/cubes/base/sample-cube.xml PRE-CREATION 
  lens-cli/src/test/resources/schema/dimensions/test-detail.xml PRE-CREATION 
  lens-cli/src/test/resources/schema/dimensions/test-dimension.xml PRE-CREATION 
  lens-cli/src/test/resources/schema/dimtables/dim_table.xml PRE-CREATION 
  lens-cli/src/test/resources/schema/dimtables/dim_table2.xml PRE-CREATION 
  lens-cli/src/test/resources/schema/facts/fact1.xml PRE-CREATION 
  lens-cli/src/test/resources/schema/facts/fact_without_weight.xml PRE-CREATION 
  lens-cli/src/test/resources/schema/segmentations/seg1.xml PRE-CREATION 
  lens-cli/src/test/resources/schema/storages/local-storage.xml PRE-CREATION 
  lens-cli/src/test/resources/seg1.xml 8a3991514633bcb25ded0e305bdd50192149773c 
  lens-cli/src/test/resources/test-detail.xml 
b51c1888d88436302a7e43ef12d3643fe99b0267 
  lens-cli/src/test/resources/test-dimension.xml 
01de8e69bce7536768bd99d765af3d07f70914a4 
  src/site/apt/user/cli.apt 2522e03fc80b12bcd64f6df155cd862e4e53e2c2 

Diff: https://reviews.apache.org/r/51363/diff/


Testing
---


Thanks,

Rajat Khandelwal

Re: Review Request 51363: LENS-1287: Create command in cli to create schema taking parent directory where schema is stored

2016-10-03 Thread Amareshwari Sriramadasu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51363/#review151157
---


Ship it!




Ship It!

- Amareshwari Sriramadasu


On Oct. 3, 2016, 9:12 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51363/
> ---
> 
> (Updated Oct. 3, 2016, 9:12 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1287
> https://issues.apache.org/jira/browse/LENS-1287
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDatabaseCommands.java 
> 05108f0158b655653f0665da80a2d10b24f33233 
>   
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java
>  7df5c7ca1c7f557409ed36a4be7f4b050260f159 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 
> 6457bceef143ce08e6a57726cb1e54dcf3288b0c 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java 
> PRE-CREATION 
>   lens-cli/src/test/java/org/apache/lens/cli/LensCLITest.java PRE-CREATION 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 
> c20766c26c42918e7ab33c32c0b4218ddfa5ee81 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java 
> 9687c6089125b4eb9dc2a96fd7d4a140c81eb66c 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java 
> a3f01c38d1c94857f0cdfdd7a457b402754c30a6 
>   
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java
>  5d6d7682d75793897cc6d2fee0bb23ce7f467ab9 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java 
> b4cbf344c46faa40074bc79fa0227312e027dfb6 
>   
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java
>  24f9279b24de98ed1e7304ec2e2010c17df9f8d8 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 
> e75fc0ef19d9d9b288bdb677bfdf499aa088e6ee 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensSchemaCommands.java 
> PRE-CREATION 
>   
> lens-cli/src/test/java/org/apache/lens/cli/TestLensSegmentationCommands.java 
> e6d4bc5354bbcae9ea6d1f06ec2be6e2ff885cf6 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 
> c4ab6140c573d8bb4d2048969be14786d2371d6d 
>   lens-cli/src/test/java/org/apache/lens/cli/doc/TestGenerateCLIUserDoc.java 
> 95e6b4e205128a19d1099f0a14638a8eb2d19c7c 
>   lens-cli/src/test/resources/cube_with_no_weight_facts.xml 
> 4673ca416758c35bf50616896f084360a1b5bb89 
>   lens-cli/src/test/resources/dim_table.xml 
> eb4ddfcc49c9cfdc152df35fe863176986016d95 
>   lens-cli/src/test/resources/dim_table2.xml 
> 8440e28b59cdcc567bac00e4c1e2367ef2ebda0c 
>   lens-cli/src/test/resources/fact1.xml 
> b18a39313bff9850c720cb3f0492bc6b7a650f78 
>   lens-cli/src/test/resources/fact_without_weight.xml 
> 0c124b2aba88a9efcc164b3b4de96479c164cd6a 
>   lens-cli/src/test/resources/local-storage.xml 
> 65513757f5dc2a19fea88cde4f4fa8736f814091 
>   lens-cli/src/test/resources/sample-cube.xml 
> 2d6bc3469466cee6245f8f503af956dcc92cffb5 
>   lens-cli/src/test/resources/schema/cubes/base/cube_with_no_weight_facts.xml 
> PRE-CREATION 
>   lens-cli/src/test/resources/schema/cubes/base/sample-cube.xml PRE-CREATION 
>   lens-cli/src/test/resources/schema/dimensions/test-detail.xml PRE-CREATION 
>   lens-cli/src/test/resources/schema/dimensions/test-dimension.xml 
> PRE-CREATION 
>   lens-cli/src/test/resources/schema/dimtables/dim_table.xml PRE-CREATION 
>   lens-cli/src/test/resources/schema/dimtables/dim_table2.xml PRE-CREATION 
>   lens-cli/src/test/resources/schema/facts/fact1.xml PRE-CREATION 
>   lens-cli/src/test/resources/schema/facts/fact_without_weight.xml 
> PRE-CREATION 
>   lens-cli/src/test/resources/schema/segmentations/seg1.xml PRE-CREATION 
>   lens-cli/src/test/resources/schema/storages/local-storage.xml PRE-CREATION 
>   lens-cli/src/test/resources/seg1.xml 
> 8a3991514633bcb25ded0e305bdd50192149773c 
>   lens-cli/src/test/resources/test-detail.xml 
> b51c1888d88436302a7e43ef12d3643fe99b0267 
>   lens-cli/src/test/resources/test-dimension.xml 
> 01de8e69bce7536768bd99d765af3d07f70914a4 
>   src/site/apt/user/cli.apt 2522e03fc80b12bcd64f6df155cd862e4e53e2c2 
> 
> Diff: https://reviews.apache.org/r/51363/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 51363: LENS-1287: Create command in cli to create schema taking parent directory where schema is stored

2016-09-30 Thread Rajat Khandelwal 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51363/
---

(Updated Sept. 30, 2016, 5:50 p.m.)


Review request for lens.


Bugs: LENS-1287
https://issues.apache.org/jira/browse/LENS-1287


Repository: lens


Description
---


Diffs (updated)
-

  lens-cli/src/main/java/org/apache/lens/cli/commands/LensDatabaseCommands.java 
05108f0158b655653f0665da80a2d10b24f33233 
  
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java
 7df5c7ca1c7f557409ed36a4be7f4b050260f159 
  lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 
6457bceef143ce08e6a57726cb1e54dcf3288b0c 
  lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java 
PRE-CREATION 
  lens-cli/src/test/java/org/apache/lens/cli/LensCLITest.java PRE-CREATION 
  lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 
c20766c26c42918e7ab33c32c0b4218ddfa5ee81 
  lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java 
9687c6089125b4eb9dc2a96fd7d4a140c81eb66c 
  lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java 
a3f01c38d1c94857f0cdfdd7a457b402754c30a6 
  
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 
5d6d7682d75793897cc6d2fee0bb23ce7f467ab9 
  lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java 
b4cbf344c46faa40074bc79fa0227312e027dfb6 
  
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java
 24f9279b24de98ed1e7304ec2e2010c17df9f8d8 
  lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 
e75fc0ef19d9d9b288bdb677bfdf499aa088e6ee 
  lens-cli/src/test/java/org/apache/lens/cli/TestLensSchemaCommands.java 
PRE-CREATION 
  lens-cli/src/test/java/org/apache/lens/cli/TestLensSegmentationCommands.java 
e6d4bc5354bbcae9ea6d1f06ec2be6e2ff885cf6 
  lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 
c4ab6140c573d8bb4d2048969be14786d2371d6d 
  lens-cli/src/test/java/org/apache/lens/cli/doc/TestGenerateCLIUserDoc.java 
95e6b4e205128a19d1099f0a14638a8eb2d19c7c 
  lens-cli/src/test/resources/cube_with_no_weight_facts.xml 
4673ca416758c35bf50616896f084360a1b5bb89 
  lens-cli/src/test/resources/dim_table.xml 
eb4ddfcc49c9cfdc152df35fe863176986016d95 
  lens-cli/src/test/resources/dim_table2.xml 
8440e28b59cdcc567bac00e4c1e2367ef2ebda0c 
  lens-cli/src/test/resources/fact1.xml 
b18a39313bff9850c720cb3f0492bc6b7a650f78 
  lens-cli/src/test/resources/fact_without_weight.xml 
0c124b2aba88a9efcc164b3b4de96479c164cd6a 
  lens-cli/src/test/resources/local-storage.xml 
65513757f5dc2a19fea88cde4f4fa8736f814091 
  lens-cli/src/test/resources/sample-cube.xml 
2d6bc3469466cee6245f8f503af956dcc92cffb5 
  lens-cli/src/test/resources/schema/cubes/base/cube_with_no_weight_facts.xml 
PRE-CREATION 
  lens-cli/src/test/resources/schema/cubes/base/sample-cube.xml PRE-CREATION 
  lens-cli/src/test/resources/schema/dimensions/test-detail.xml PRE-CREATION 
  lens-cli/src/test/resources/schema/dimensions/test-dimension.xml PRE-CREATION 
  lens-cli/src/test/resources/schema/dimtables/dim_table.xml PRE-CREATION 
  lens-cli/src/test/resources/schema/dimtables/dim_table2.xml PRE-CREATION 
  lens-cli/src/test/resources/schema/facts/fact1.xml PRE-CREATION 
  lens-cli/src/test/resources/schema/facts/fact_without_weight.xml PRE-CREATION 
  lens-cli/src/test/resources/schema/segmentations/seg1.xml PRE-CREATION 
  lens-cli/src/test/resources/schema/storages/local-storage.xml PRE-CREATION 
  lens-cli/src/test/resources/seg1.xml 8a3991514633bcb25ded0e305bdd50192149773c 
  lens-cli/src/test/resources/test-detail.xml 
b51c1888d88436302a7e43ef12d3643fe99b0267 
  lens-cli/src/test/resources/test-dimension.xml 
01de8e69bce7536768bd99d765af3d07f70914a4 
  src/site/apt/user/cli.apt 2522e03fc80b12bcd64f6df155cd862e4e53e2c2 

Diff: https://reviews.apache.org/r/51363/diff/


Testing
---


Thanks,

Rajat Khandelwal

Re: Review Request 51363: LENS-1287: Create command in cli to create schema taking parent directory where schema is stored

2016-09-21 Thread Amareshwari Sriramadasu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51363/#review149949
---




lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java 
(line 20)


Can we include unit tests?



lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java 
(line 41)


Can you add more details on directory structure accepted here ?



lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java 
(line 94)


Can we this message come on cli console as well ?


- Amareshwari Sriramadasu


On Sept. 21, 2016, 9:49 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51363/
> ---
> 
> (Updated Sept. 21, 2016, 9:49 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1287
> https://issues.apache.org/jira/browse/LENS-1287
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/51363/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 51363: LENS-1287: Create command in cli to create schema taking parent directory where schema is stored

2016-09-21 Thread Rajat Khandelwal 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51363/
---

(Updated Sept. 21, 2016, 3:19 p.m.)


Review request for lens.


Bugs: LENS-1287
https://issues.apache.org/jira/browse/LENS-1287


Repository: lens


Description
---


Diffs (updated)
-

  lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java 
PRE-CREATION 

Diff: https://reviews.apache.org/r/51363/diff/


Testing
---


Thanks,

Rajat Khandelwal

Re: Review Request 51363: LENS-1287: Create command in cli to create schema taking parent directory where schema is stored

2016-09-06 Thread Rajat Khandelwal 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51363/
---

(Updated Sept. 6, 2016, 3:01 p.m.)


Review request for lens.


Bugs: LENS-1287
https://issues.apache.org/jira/browse/LENS-1287


Repository: lens


Description
---


Diffs (updated)
-

  lens-api/src/main/java/org/apache/lens/api/APIResult.java 
26e99265f8437fedfcb093ad61ba1f810c026516 
  lens-api/src/main/java/org/apache/lens/api/ToYAMLString.java 
65a0c44813569848d35127b0a58b0831bd8e67f7 
  lens-api/src/test/java/org/apache/lens/api/jaxb/YAMLToStringStrategyTest.java 
3a784f8e52311ed5875c1e2471bb3bd2e46931f6 
  
lens-api/src/test/resources/toString/org.apache.lens.api.query.QueryHandleWithResultSet.yaml
 dfa33d22976bd3a98c17c190d4c99f2d4d22b4c0 
  lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java 
PRE-CREATION 
  lens-cli/src/test/java/org/apache/lens/cli/LensCliApplicationTest.java 
c536ed649b6a54d008c20040aba6f98ee009b7b9 
  lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java 
41672ac5a1091a14831dd5e8ecb24a62e1a908e5 
  lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java 
a1a78c50b8cd83fcf7e5c76022566889a246a2b3 
  
lens-client/src/main/java/org/apache/lens/client/exceptions/LensBriefErrorException.java
 ddfd777a77247ece953d11208086ea7f473179e1 
  
lens-client/src/main/java/org/apache/lens/client/model/IdBriefErrorTemplate.java
 8a485b521b6aa2544c65035ef4edcde272c04e43 
  
lens-client/src/test/java/org/apache/lens/client/model/IdBriefErrorTemplateTest.java
 9d9ec0ea49d4f6e6b27fc2895f1b2d2dcaabc7f1 
  
lens-examples/src/test/java/org/apache/lens/examples/ExampleSchemaToStringTest.java
 4a3c07b501064238bd9fa068cfbbaccadc045f46 

Diff: https://reviews.apache.org/r/51363/diff/


Testing
---


Thanks,

Rajat Khandelwal

Re: Review Request 51363: LENS-1287: Create command in cli to create schema taking parent directory where schema is stored

2016-09-06 Thread Rajat Khandelwal 


> On Sept. 2, 2016, 12:05 p.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/java/org/apache/lens/api/APIResult.java, line 130
> > 
> >
> > We can use LensUtil.getCauseMessage() instead of the above code.

LensUtil is in lens-server-api. This code is in lens-api. Didn't want to make a 
large change.


- Rajat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51363/#review147630
---


On Aug. 30, 2016, 5:12 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51363/
> ---
> 
> (Updated Aug. 30, 2016, 5:12 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1287
> https://issues.apache.org/jira/browse/LENS-1287
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/APIResult.java 
> 26e99265f8437fedfcb093ad61ba1f810c026516 
>   lens-api/src/main/java/org/apache/lens/api/ToYAMLString.java 
> 65a0c44813569848d35127b0a58b0831bd8e67f7 
>   
> lens-api/src/test/java/org/apache/lens/api/jaxb/YAMLToStringStrategyTest.java 
> 3a784f8e52311ed5875c1e2471bb3bd2e46931f6 
>   
> lens-api/src/test/resources/toString/org.apache.lens.api.query.QueryHandleWithResultSet.yaml
>  dfa33d22976bd3a98c17c190d4c99f2d4d22b4c0 
>   lens-cli/src/test/java/org/apache/lens/cli/LensCliApplicationTest.java 
> c536ed649b6a54d008c20040aba6f98ee009b7b9 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java 
> 41672ac5a1091a14831dd5e8ecb24a62e1a908e5 
>   lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java 
> a1a78c50b8cd83fcf7e5c76022566889a246a2b3 
>   
> lens-client/src/main/java/org/apache/lens/client/exceptions/LensBriefErrorException.java
>  ddfd777a77247ece953d11208086ea7f473179e1 
>   
> lens-client/src/main/java/org/apache/lens/client/model/IdBriefErrorTemplate.java
>  8a485b521b6aa2544c65035ef4edcde272c04e43 
>   
> lens-client/src/test/java/org/apache/lens/client/model/IdBriefErrorTemplateTest.java
>  9d9ec0ea49d4f6e6b27fc2895f1b2d2dcaabc7f1 
>   
> lens-examples/src/test/java/org/apache/lens/examples/ExampleSchemaToStringTest.java
>  4a3c07b501064238bd9fa068cfbbaccadc045f46 
> 
> Diff: https://reviews.apache.org/r/51363/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 51363: LENS-1287: Create command in cli to create schema taking parent directory where schema is stored

2016-09-02 Thread Amareshwari Sriramadasu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51363/#review147630
---




lens-api/src/main/java/org/apache/lens/api/APIResult.java (line 130)


We can use LensUtil.getCauseMessage() instead of the above code.



lens-client/src/test/java/org/apache/lens/client/model/IdBriefErrorTemplateTest.java
 (line 63)


Why are we disabling this?


- Amareshwari Sriramadasu


On Aug. 30, 2016, 11:42 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51363/
> ---
> 
> (Updated Aug. 30, 2016, 11:42 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1287
> https://issues.apache.org/jira/browse/LENS-1287
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/APIResult.java 
> 26e99265f8437fedfcb093ad61ba1f810c026516 
>   lens-api/src/main/java/org/apache/lens/api/ToYAMLString.java 
> 65a0c44813569848d35127b0a58b0831bd8e67f7 
>   
> lens-api/src/test/java/org/apache/lens/api/jaxb/YAMLToStringStrategyTest.java 
> 3a784f8e52311ed5875c1e2471bb3bd2e46931f6 
>   
> lens-api/src/test/resources/toString/org.apache.lens.api.query.QueryHandleWithResultSet.yaml
>  dfa33d22976bd3a98c17c190d4c99f2d4d22b4c0 
>   lens-cli/src/test/java/org/apache/lens/cli/LensCliApplicationTest.java 
> c536ed649b6a54d008c20040aba6f98ee009b7b9 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java 
> 41672ac5a1091a14831dd5e8ecb24a62e1a908e5 
>   lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java 
> a1a78c50b8cd83fcf7e5c76022566889a246a2b3 
>   
> lens-client/src/main/java/org/apache/lens/client/exceptions/LensBriefErrorException.java
>  ddfd777a77247ece953d11208086ea7f473179e1 
>   
> lens-client/src/main/java/org/apache/lens/client/model/IdBriefErrorTemplate.java
>  8a485b521b6aa2544c65035ef4edcde272c04e43 
>   
> lens-client/src/test/java/org/apache/lens/client/model/IdBriefErrorTemplateTest.java
>  9d9ec0ea49d4f6e6b27fc2895f1b2d2dcaabc7f1 
>   
> lens-examples/src/test/java/org/apache/lens/examples/ExampleSchemaToStringTest.java
>  4a3c07b501064238bd9fa068cfbbaccadc045f46 
> 
> Diff: https://reviews.apache.org/r/51363/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 51363: LENS-1287: Create command in cli to create schema taking parent directory where schema is stored

2016-08-30 Thread Rajat Khandelwal 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51363/
---

(Updated Aug. 30, 2016, 5:12 p.m.)


Review request for lens.


Bugs: LENS-1287
https://issues.apache.org/jira/browse/LENS-1287


Repository: lens


Description
---


Diffs (updated)
-

  lens-api/src/main/java/org/apache/lens/api/APIResult.java 
26e99265f8437fedfcb093ad61ba1f810c026516 
  lens-api/src/main/java/org/apache/lens/api/ToYAMLString.java 
65a0c44813569848d35127b0a58b0831bd8e67f7 
  lens-api/src/test/java/org/apache/lens/api/jaxb/YAMLToStringStrategyTest.java 
3a784f8e52311ed5875c1e2471bb3bd2e46931f6 
  
lens-api/src/test/resources/toString/org.apache.lens.api.query.QueryHandleWithResultSet.yaml
 dfa33d22976bd3a98c17c190d4c99f2d4d22b4c0 
  lens-cli/src/test/java/org/apache/lens/cli/LensCliApplicationTest.java 
c536ed649b6a54d008c20040aba6f98ee009b7b9 
  lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java 
41672ac5a1091a14831dd5e8ecb24a62e1a908e5 
  lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java 
a1a78c50b8cd83fcf7e5c76022566889a246a2b3 
  
lens-client/src/main/java/org/apache/lens/client/exceptions/LensBriefErrorException.java
 ddfd777a77247ece953d11208086ea7f473179e1 
  
lens-client/src/main/java/org/apache/lens/client/model/IdBriefErrorTemplate.java
 8a485b521b6aa2544c65035ef4edcde272c04e43 
  
lens-client/src/test/java/org/apache/lens/client/model/IdBriefErrorTemplateTest.java
 9d9ec0ea49d4f6e6b27fc2895f1b2d2dcaabc7f1 
  
lens-examples/src/test/java/org/apache/lens/examples/ExampleSchemaToStringTest.java
 4a3c07b501064238bd9fa068cfbbaccadc045f46 

Diff: https://reviews.apache.org/r/51363/diff/


Testing
---


Thanks,

Rajat Khandelwal

Review Request 51363: LENS-1287: Create command in cli to create schema taking parent directory where schema is stored

2016-08-24 Thread Rajat Khandelwal 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51363/
---

Review request for lens.


Bugs: LENS-1287
https://issues.apache.org/jira/browse/LENS-1287


Repository: lens


Description
---


Diffs
-

  lens-api/src/main/java/org/apache/lens/api/APIResult.java 
26e99265f8437fedfcb093ad61ba1f810c026516 
  lens-api/src/main/java/org/apache/lens/api/ToYAMLString.java 
65a0c44813569848d35127b0a58b0831bd8e67f7 
  lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 
6ce8209eec3a8a92c14462f82e7c3ec5921d855a 
  lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java 
PRE-CREATION 
  
lens-cli/src/main/java/org/apache/lens/cli/commands/LensSegmentationCommands.java
 PRE-CREATION 
  
lens-cli/src/main/java/org/apache/lens/cli/commands/annotations/LensSegmentationCommands.java
 e53442d2e169c003326eff0d83a826bb22aa7c37 
  lens-cli/src/main/resources/META-INF/spring/spring-shell-plugin.xml 
bfcf16b997fc101e7d2904b9e5ebed5d1bdd480c 
  lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java 
41672ac5a1091a14831dd5e8ecb24a62e1a908e5 
  
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java
 24f9279b24de98ed1e7304ec2e2010c17df9f8d8 
  lens-cli/src/test/java/org/apache/lens/cli/TestLensSegmentationCommands.java 
e6d4bc5354bbcae9ea6d1f06ec2be6e2ff885cf6 
  lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java 
a1a78c50b8cd83fcf7e5c76022566889a246a2b3 
  
lens-client/src/main/java/org/apache/lens/client/exceptions/LensBriefErrorException.java
 ddfd777a77247ece953d11208086ea7f473179e1 
  
lens-client/src/main/java/org/apache/lens/client/model/IdBriefErrorTemplate.java
 8a485b521b6aa2544c65035ef4edcde272c04e43 
  lens-server/src/test/resources/hive-site.xml 
94c5012821330e1a78aad2a7fdfca0cc1d0fade2 

Diff: https://reviews.apache.org/r/51363/diff/


Testing
---


Thanks,

Rajat Khandelwal