date:20170628

Re: logging-log4net git commit: (doc) Fix name of class LogicalThreadContext

2017-06-28 Thread Stefan Bodewig

Argh, I pushed this to the wrong branch (master instead of develop) by
habit.

Sorry

Stefan

[GitHub] logging-log4net pull request #11: (doc) Fix name of class LogicalThreadConte...

2017-06-28 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/logging-log4net/pull/11


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] logging-log4net issue #11: (doc) Fix name of class LogicalThreadContext

2017-06-28 Thread bodewig

Github user bodewig commented on the issue:

https://github.com/apache/logging-log4net/pull/11
  
merged, many thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] logging-log4net pull request #11: (doc) Fix name of class LogicalThreadConte...

2017-06-28 Thread MarcelGosselin

GitHub user MarcelGosselin opened a pull request:

https://github.com/apache/logging-log4net/pull/11

(doc) Fix name of class LogicalThreadContext

Fix name of class LogicalThreadContext in Scopes section, words were 
reversed.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MarcelGosselin/logging-log4net patch-2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/logging-log4net/pull/11.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #11


commit 1ed20b6f5946688a765a061693d1292b2dc3a83e
Author: Marcel Gosselin 
Date:   2017-06-29T03:07:18Z

(doc) Fix name of class LogicalThreadContext

Fix name of class LogicalThreadContext in Scopes section, words were 
reversed.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: logging-log4j2 git commit: [LOG4J2-1699] Log File Permissions with PosixFilePermission feedback from jira. Closes #89. - item 2: Better log at configuration step if file attribute view are defined

2017-06-28 Thread Gary Gregory

You are correct. I was going to add it later but it got mixed up in this
commit. I just disabled it.

Thank you for noticing!

Gary

On Wed, Jun 28, 2017 at 9:47 AM, Matt Sicker  wrote:

> That JMS stuff doesn't look like it belongs here?
>
> On 27 June 2017 at 13:12,  wrote:
>
> > Repository: logging-log4j2
> > Updated Branches:
> >   refs/heads/master 93afa566c -> a5a95886b
> >
> >
> > [LOG4J2-1699] Log File Permissions with PosixFilePermission feedback
> > from jira. Closes #89.
> > - item 2: Better log at configuration step if file attribute view are
> > defined but underlying files system doesnt support it
> > - item 3: Exception catch and logged if OperationNotSupported or
> > Operation not permitted are thrown while changing file attribute
> > permissions, user or group
> > - item 4: No need to apply file posix attribute if file is just rolled
> > not compressed, both in DirectWriteRolloverStrategy and
> > DefaultRolloverStrategy.
> > - Changed next release version in documentation and javadoc.
> >
> > Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
> > Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/
> > commit/a5a95886
> > Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/
> a5a95886
> > Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/
> a5a95886
> >
> > Branch: refs/heads/master
> > Commit: a5a95886b6912b31009a7c61f18396280e083cd6
> > Parents: 93afa56
> > Author: Pierrick HYMBERT 
> > Authored: Tue Jun 27 11:12:27 2017 -0700
> > Committer: Gary Gregory 
> > Committed: Tue Jun 27 11:12:27 2017 -0700
> >
> > --
> >  .../mom/activemq/JmsAppenderConnectLaterIT.java | 108
> +++
> >  .../log4j/core/appender/FileManager.java|  65 +++
> >  .../rolling/DefaultRolloverStrategy.java|  10 +-
> >  .../rolling/DirectWriteRolloverStrategy.java|  10 +-
> >  .../appender/rolling/RollingFileManager.java|   6 +-
> >  .../rolling/RollingRandomAccessFileManager.java |   4 +-
> >  .../action/PosixViewAttributeAction.java|   6 +-
> >  src/site/xdoc/manual/appenders.xml  |   4 +-
> >  8 files changed, 167 insertions(+), 46 deletions(-)
> > --
> >
> >
> > http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/
> > a5a95886/log4j-core-its/src/test/java/org/apache/logging/
> > log4j/core/appender/mom/activemq/JmsAppenderConnectLaterIT.java
> > --
> > diff --git a/log4j-core-its/src/test/java/org/apache/logging/log4j/
> > core/appender/mom/activemq/JmsAppenderConnectLaterIT.java
> > b/log4j-core-its/src/test/java/org/apache/logging/log4j/
> > core/appender/mom/activemq/JmsAppenderConnectLaterIT.java
> > new file mode 100644
> > index 000..8f548d2
> > --- /dev/null
> > +++ b/log4j-core-its/src/test/java/org/apache/logging/log4j/
> > core/appender/mom/activemq/JmsAppenderConnectLaterIT.java
> > @@ -0,0 +1,108 @@
> > +/*
> > + * Licensed to the Apache Software Foundation (ASF) under one or more
> > + * contributor license agreements. See the NOTICE file distributed with
> > + * this work for additional information regarding copyright ownership.
> > + * The ASF licenses this file to You under the Apache license, Version
> 2.0
> > + * (the "License"); you may not use this file except in compliance with
> > + * the License. You may obtain a copy of the License at
> > + *
> > + *  http://www.apache.org/licenses/LICENSE-2.0
> > + *
> > + * Unless required by applicable law or agreed to in writing, software
> > + * distributed under the License is distributed on an "AS IS" BASIS,
> > + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
> > implied.
> > + * See the license for the specific language governing permissions and
> > + * limitations under the license.
> > + */
> > +package org.apache.logging.log4j.core.appender.mom.activemq;
> > +
> > +import java.util.HashMap;
> > +import java.util.Map;
> > +
> > +import org.apache.activemq.broker.BrokerService;
> > +import org.apache.activemq.jndi.ActiveMQInitialContextFactory;
> > +import org.apache.logging.log4j.Level;
> > +import org.apache.logging.log4j.categories.Appenders;
> > +import org.apache.logging.log4j.core.Layout;
> > +import org.apache.logging.log4j.core.LogEvent;
> > +import org.apache.logging.log4j.core.appender.mom.JmsAppender;
> > +import org.apache.logging.log4j.core.impl.Log4jLogEvent;
> > +import org.apache.logging.log4j.core.layout.MessageLayout;
> > +import org.apache.logging.log4j.message.StringMapMessage;
> > +import org.apache.logging.log4j.test.AvailablePortFinder;
> > +import org.junit.Ignore;
> > +import org.junit.Test;
> > +import org.junit.experimental.categories.Category;
> > +
> > +/**
> > + * Tests that a

[jira] [Commented] (LOG4J2-1934) JMS Appender does not know how to recover from a broken connection

2017-06-28 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/LOG4J2-1934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16067595#comment-16067595
 ] 

ASF subversion and git services commented on LOG4J2-1934:
-

Commit 5d1b605d922d37c02afdd656ccdb4afae2864cd0 in logging-log4j2's branch 
refs/heads/master from [~garydgregory]
[ https://git-wip-us.apache.org/repos/asf?p=logging-log4j2.git;h=5d1b605 ]

[LOG4J2-1934] JMS Appender does not know how to recover from a broken
connection.

> JMS Appender does not know how to recover from a broken connection
> --
>
> Key: LOG4J2-1934
> URL: https://issues.apache.org/jira/browse/LOG4J2-1934
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Appenders
>Affects Versions: 2.8.2
>Reporter: Gary Gregory
>Assignee: Gary Gregory
>Priority: Critical
> Fix For: 2.9
>
>
> If a broker, like ActiveMQ goes up, down, and up. Log4j gives me:
> {noformat}
> 2017-06-06 18:26:58,396 HPM-ListeningIoReactor 4 ERROR An exception occurred 
> processing Appender ActiveMQ 
> org.apache.logging.log4j.core.appender.AppenderLoggingException: 
> javax.jms.IllegalStateException: The Session is closed
>   at 
> org.apache.logging.log4j.core.appender.mom.JmsAppender.append(JmsAppender.java:69)
>   at 
> org.apache.logging.log4j.core.config.AppenderControl.tryCallAppender(AppenderControl.java:156)
>   at 
> org.apache.logging.log4j.core.config.AppenderControl.callAppender0(AppenderControl.java:129)
>   at 
> org.apache.logging.log4j.core.config.AppenderControl.callAppenderPreventRecursion(AppenderControl.java:120)
>   at 
> org.apache.logging.log4j.core.config.AppenderControl.callAppender(AppenderControl.java:84)
>   at 
> org.apache.logging.log4j.core.config.LoggerConfig.callAppenders(LoggerConfig.java:448)
>   at 
> org.apache.logging.log4j.core.config.LoggerConfig.processLogEvent(LoggerConfig.java:433)
>   at 
> org.apache.logging.log4j.core.config.LoggerConfig.log(LoggerConfig.java:417)
>   at 
> org.apache.logging.log4j.core.config.LoggerConfig.log(LoggerConfig.java:403)
>   at 
> org.apache.logging.log4j.core.config.AwaitCompletionReliabilityStrategy.log(AwaitCompletionReliabilityStrategy.java:63)
>   at org.apache.logging.log4j.core.Logger.logMessage(Logger.java:146)
>   at 
> org.apache.logging.log4j.spi.AbstractLogger.logMessageSafely(AbstractLogger.java:2091)
>   at 
> org.apache.logging.log4j.spi.AbstractLogger.logIfEnabled(AbstractLogger.java:1813)
>   at 
> org.apache.logging.log4j.spi.AbstractLogger.info(AbstractLogger.java:1267)
>   >SNIP<
>   at 
> org.apache.http.nio.protocol.HttpAsyncService.requestReceived(HttpAsyncService.java:338)
>   at 
> org.apache.http.impl.nio.DefaultNHttpServerConnection.consumeInput(DefaultNHttpServerConnection.java:273)
>   at 
> org.apache.http.impl.nio.DefaultHttpServerIODispatch.onInputReady(DefaultHttpServerIODispatch.java:158)
>   at 
> org.apache.http.impl.nio.DefaultHttpServerIODispatch.onInputReady(DefaultHttpServerIODispatch.java:52)
>   at 
> org.apache.http.impl.nio.reactor.AbstractIODispatch.inputReady(AbstractIODispatch.java:114)
>   at 
> org.apache.http.impl.nio.reactor.BaseIOReactor.readable(BaseIOReactor.java:162)
>   at 
> org.apache.http.impl.nio.reactor.AbstractIOReactor.processEvent(AbstractIOReactor.java:337)
>   at 
> org.apache.http.impl.nio.reactor.AbstractIOReactor.processEvents(AbstractIOReactor.java:315)
>   at 
> org.apache.http.impl.nio.reactor.AbstractIOReactor.execute(AbstractIOReactor.java:276)
>   at 
> org.apache.http.impl.nio.reactor.BaseIOReactor.execute(BaseIOReactor.java:104)
>   at 
> org.apache.http.impl.nio.reactor.AbstractMultiworkerIOReactor$Worker.run(AbstractMultiworkerIOReactor.java:588)
>   at java.lang.Thread.run(Unknown Source)
> Caused by: javax.jms.IllegalStateException: The Session is closed
>   at 
> org.apache.activemq.ActiveMQSession.checkClosed(ActiveMQSession.java:771)
>   at 
> org.apache.activemq.ActiveMQSession.configureMessage(ActiveMQSession.java:759)
>   at 
> org.apache.activemq.ActiveMQSession.createMapMessage(ActiveMQSession.java:338)
>   at 
> org.apache.logging.log4j.core.appender.mom.JmsManager.createMessage(JmsManager.java:136)
>   at 
> org.apache.logging.log4j.core.appender.mom.JmsAppender.append(JmsAppender.java:65)
>   ... 28 more
> {noformat}
> I plan on fixing that ASAP.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: logging-log4j2 git commit: LOG4J2-1958 Specify version when SerializedLayout is deprecated

2017-06-28 Thread Gary Gregory

Brilliant! :-)

Gary

On Wed, Jun 28, 2017 at 10:09 AM, Matt Sicker  wrote:

> Oh, I missed the context line. It's part of the tag already.
>
> On 28 June 2017 at 12:02, Mikael Ståldal  wrote:
>
> > I just did that, didn't I?
> >
> >
> >
> > On 2017-06-28 18:57, Gary Gregory wrote:
> >
> >> On Jun 28, 2017 08:54, "Matt Sicker"  wrote:
> >>
> >> You can add a @deprecated javadoc tag to specify that which makes it
> more
> >> prominent in the javadocs.
> >>
> >>
> >> +1
> >>
> >> Gary
> >>
> >>
> >> On 28 June 2017 at 08:50,  wrote:
> >>
> >> Repository: logging-log4j2
> >>> Updated Branches:
> >>>refs/heads/LOG4J2-1958 041f42dad -> 61db8afdd
> >>>
> >>>
> >>> LOG4J2-1958 Specify version when SerializedLayout is deprecated
> >>>
> >>>
> >>> Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
> >>> Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/
> >>> commit/61db8afd
> >>> Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/6
> >>> 1db8afd
> >>> Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/6
> >>> 1db8afd
> >>>
> >>> Branch: refs/heads/LOG4J2-1958
> >>> Commit: 61db8afdd2761e83541095a5a964f4bddd6ac943
> >>> Parents: 041f42d
> >>> Author: Mikael Ståldal 
> >>> Authored: Wed Jun 28 15:50:28 2017 +0200
> >>> Committer: Mikael Ståldal 
> >>> Committed: Wed Jun 28 15:50:28 2017 +0200
> >>>
> >>> --
> >>>   .../org/apache/logging/log4j/core/layout/SerializedLayout.java | 1 +
> >>>   src/site/xdoc/manual/appenders.xml | 4
> >>> +++-
> >>>   src/site/xdoc/manual/layouts.xml.vm| 6
> >>> +++---
> >>>   3 files changed, 7 insertions(+), 4 deletions(-)
> >>> --
> >>>
> >>>
> >>> http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/
> >>> 61db8afd/log4j-core/src/main/java/org/apache/logging/log4j/
> >>> core/layout/SerializedLayout.java
> >>> --
> >>> diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/
> >>>
> >> layout/SerializedLayout.java
> >>
> >>> b/log4j-core/src/main/java/org/apache/logging/log4j/core/
> >>> layout/SerializedLayout.java
> >>> index 43700e0..091e31e 100644
> >>> --- a/log4j-core/src/main/java/org/apache/logging/log4j/core/
> >>> layout/SerializedLayout.java
> >>> +++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/
> >>> layout/SerializedLayout.java
> >>> @@ -32,6 +32,7 @@ import org.apache.logging.log4j.core.
> >>> config.plugins.PluginFactory;
> >>>*
> >>>* @deprecated Java Serialization has inherent security weaknesses,
> >>> using
> >>> this layout is no longer recommended.
> >>>* An alternative layout containing the same information is {@link
> >>> JsonLayout} when configured with properties="true".
> >>> + * Deprecated since 2.9.
> >>>*/
> >>>   @Deprecated
> >>>   @Plugin(name = "SerializedLayout", category = Node.CATEGORY,
> >>> elementType
> >>> = Layout.ELEMENT_TYPE, printObject = true)
> >>>
> >>> http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/
> >>> 61db8afd/src/site/xdoc/manual/appenders.xml
> >>> --
> >>> diff --git a/src/site/xdoc/manual/appenders.xml
> b/src/site/xdoc/manual/
> >>> appenders.xml
> >>> index 7d9dfc4..528dabe 100644
> >>> --- a/src/site/xdoc/manual/appenders.xml
> >>> +++ b/src/site/xdoc/manual/appenders.xml
> >>> @@ -1296,6 +1296,7 @@ public class ConnectionFactory {
> >>> Layout
> >>> 
> >>>   The Layout to use to format the LogEvent. Required,
> >>> there
> >>> is no default.
> >>> +New since 2.9, in previous versions
> SerializedLayout
> >>> was default.
> >>> 
> >>>   
> >>>   
> >>> @@ -4380,7 +4381,8 @@ public class JpaLogEntity extends
> >>> AbstractLogEventWrapperEntity {
> >>>   
> >>> layout
> >>> Layout
> >>> -  The Layout to use to format the LogEvent. Required,
> >>> there is no default.
> >>> +  The Layout to use to format the LogEvent. Required,
> >>> there is no default.
> >>> +  New since 2.9, in previous versions
> >>> SerializedLayout was default.
> >>>   
> >>>   
> >>> reconnectionDelayMillis
> >>>
> >>> http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/
> >>> 61db8afd/src/site/xdoc/manual/layouts.xml.vm
> >>> --
> >>> diff --git a/src/site/xdoc/manual/layouts.xml.vm
> b/src/site/xdoc/manual/
> >>> layouts.xml.vm
> >>> index 7d17fd1..a8353bd 100644
> >>> ---

Re: logging-log4j2 git commit: LOG4J2-1958 Specify version when SerializedLayout is deprecated

2017-06-28 Thread Matt Sicker

Oh, I missed the context line. It's part of the tag already.

On 28 June 2017 at 12:02, Mikael Ståldal  wrote:

> I just did that, didn't I?
>
>
>
> On 2017-06-28 18:57, Gary Gregory wrote:
>
>> On Jun 28, 2017 08:54, "Matt Sicker"  wrote:
>>
>> You can add a @deprecated javadoc tag to specify that which makes it more
>> prominent in the javadocs.
>>
>>
>> +1
>>
>> Gary
>>
>>
>> On 28 June 2017 at 08:50,  wrote:
>>
>> Repository: logging-log4j2
>>> Updated Branches:
>>>refs/heads/LOG4J2-1958 041f42dad -> 61db8afdd
>>>
>>>
>>> LOG4J2-1958 Specify version when SerializedLayout is deprecated
>>>
>>>
>>> Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
>>> Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/
>>> commit/61db8afd
>>> Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/6
>>> 1db8afd
>>> Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/6
>>> 1db8afd
>>>
>>> Branch: refs/heads/LOG4J2-1958
>>> Commit: 61db8afdd2761e83541095a5a964f4bddd6ac943
>>> Parents: 041f42d
>>> Author: Mikael Ståldal 
>>> Authored: Wed Jun 28 15:50:28 2017 +0200
>>> Committer: Mikael Ståldal 
>>> Committed: Wed Jun 28 15:50:28 2017 +0200
>>>
>>> --
>>>   .../org/apache/logging/log4j/core/layout/SerializedLayout.java | 1 +
>>>   src/site/xdoc/manual/appenders.xml | 4
>>> +++-
>>>   src/site/xdoc/manual/layouts.xml.vm| 6
>>> +++---
>>>   3 files changed, 7 insertions(+), 4 deletions(-)
>>> --
>>>
>>>
>>> http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/
>>> 61db8afd/log4j-core/src/main/java/org/apache/logging/log4j/
>>> core/layout/SerializedLayout.java
>>> --
>>> diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/
>>>
>> layout/SerializedLayout.java
>>
>>> b/log4j-core/src/main/java/org/apache/logging/log4j/core/
>>> layout/SerializedLayout.java
>>> index 43700e0..091e31e 100644
>>> --- a/log4j-core/src/main/java/org/apache/logging/log4j/core/
>>> layout/SerializedLayout.java
>>> +++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/
>>> layout/SerializedLayout.java
>>> @@ -32,6 +32,7 @@ import org.apache.logging.log4j.core.
>>> config.plugins.PluginFactory;
>>>*
>>>* @deprecated Java Serialization has inherent security weaknesses,
>>> using
>>> this layout is no longer recommended.
>>>* An alternative layout containing the same information is {@link
>>> JsonLayout} when configured with properties="true".
>>> + * Deprecated since 2.9.
>>>*/
>>>   @Deprecated
>>>   @Plugin(name = "SerializedLayout", category = Node.CATEGORY,
>>> elementType
>>> = Layout.ELEMENT_TYPE, printObject = true)
>>>
>>> http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/
>>> 61db8afd/src/site/xdoc/manual/appenders.xml
>>> --
>>> diff --git a/src/site/xdoc/manual/appenders.xml b/src/site/xdoc/manual/
>>> appenders.xml
>>> index 7d9dfc4..528dabe 100644
>>> --- a/src/site/xdoc/manual/appenders.xml
>>> +++ b/src/site/xdoc/manual/appenders.xml
>>> @@ -1296,6 +1296,7 @@ public class ConnectionFactory {
>>> Layout
>>> 
>>>   The Layout to use to format the LogEvent. Required,
>>> there
>>> is no default.
>>> +New since 2.9, in previous versions SerializedLayout
>>> was default.
>>> 
>>>   
>>>   
>>> @@ -4380,7 +4381,8 @@ public class JpaLogEntity extends
>>> AbstractLogEventWrapperEntity {
>>>   
>>> layout
>>> Layout
>>> -  The Layout to use to format the LogEvent. Required,
>>> there is no default.
>>> +  The Layout to use to format the LogEvent. Required,
>>> there is no default.
>>> +  New since 2.9, in previous versions
>>> SerializedLayout was default.
>>>   
>>>   
>>> reconnectionDelayMillis
>>>
>>> http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/
>>> 61db8afd/src/site/xdoc/manual/layouts.xml.vm
>>> --
>>> diff --git a/src/site/xdoc/manual/layouts.xml.vm b/src/site/xdoc/manual/
>>> layouts.xml.vm
>>> index 7d17fd1..a8353bd 100644
>>> --- a/src/site/xdoc/manual/layouts.xml.vm
>>> +++ b/src/site/xdoc/manual/layouts.xml.vm
>>> @@ -1978,9 +1978,9 @@ at org.apache.logging.log4j.core.
>>> pattern.ExtendedThrowableTest.testException(Ext
>>> The SerializedLayout accepts no parameters.
>>> 
>>> 
>>> -  Java Serialization has inherent security weaknesses, using
>>> this
>>> layout is no

Re: logging-log4j2 git commit: LOG4J2-1958 Specify version when SerializedLayout is deprecated

2017-06-28 Thread Gary Gregory

On Jun 28, 2017 08:54, "Matt Sicker"  wrote:

You can add a @deprecated javadoc tag to specify that which makes it more
prominent in the javadocs.


+1

Gary


On 28 June 2017 at 08:50,  wrote:

> Repository: logging-log4j2
> Updated Branches:
>   refs/heads/LOG4J2-1958 041f42dad -> 61db8afdd
>
>
> LOG4J2-1958 Specify version when SerializedLayout is deprecated
>
>
> Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
> Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/
> commit/61db8afd
> Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/61db8afd
> Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/61db8afd
>
> Branch: refs/heads/LOG4J2-1958
> Commit: 61db8afdd2761e83541095a5a964f4bddd6ac943
> Parents: 041f42d
> Author: Mikael Ståldal 
> Authored: Wed Jun 28 15:50:28 2017 +0200
> Committer: Mikael Ståldal 
> Committed: Wed Jun 28 15:50:28 2017 +0200
>
> --
>  .../org/apache/logging/log4j/core/layout/SerializedLayout.java | 1 +
>  src/site/xdoc/manual/appenders.xml | 4 +++-
>  src/site/xdoc/manual/layouts.xml.vm| 6 +++---
>  3 files changed, 7 insertions(+), 4 deletions(-)
> --
>
>
> http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/
> 61db8afd/log4j-core/src/main/java/org/apache/logging/log4j/
> core/layout/SerializedLayout.java
> --
> diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/
layout/SerializedLayout.java
> b/log4j-core/src/main/java/org/apache/logging/log4j/core/
> layout/SerializedLayout.java
> index 43700e0..091e31e 100644
> --- a/log4j-core/src/main/java/org/apache/logging/log4j/core/
> layout/SerializedLayout.java
> +++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/
> layout/SerializedLayout.java
> @@ -32,6 +32,7 @@ import org.apache.logging.log4j.core.
> config.plugins.PluginFactory;
>   *
>   * @deprecated Java Serialization has inherent security weaknesses, using
> this layout is no longer recommended.
>   * An alternative layout containing the same information is {@link
> JsonLayout} when configured with properties="true".
> + * Deprecated since 2.9.
>   */
>  @Deprecated
>  @Plugin(name = "SerializedLayout", category = Node.CATEGORY, elementType
> = Layout.ELEMENT_TYPE, printObject = true)
>
> http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/
> 61db8afd/src/site/xdoc/manual/appenders.xml
> --
> diff --git a/src/site/xdoc/manual/appenders.xml b/src/site/xdoc/manual/
> appenders.xml
> index 7d9dfc4..528dabe 100644
> --- a/src/site/xdoc/manual/appenders.xml
> +++ b/src/site/xdoc/manual/appenders.xml
> @@ -1296,6 +1296,7 @@ public class ConnectionFactory {
>Layout
>
>  The Layout to use to format the LogEvent. Required, there
> is no default.
> +New since 2.9, in previous versions SerializedLayout
> was default.
>
>  
>  
> @@ -4380,7 +4381,8 @@ public class JpaLogEntity extends
> AbstractLogEventWrapperEntity {
>  
>layout
>Layout
> -  The Layout to use to format the LogEvent. Required,
> there is no default.
> +  The Layout to use to format the LogEvent. Required,
> there is no default.
> +  New since 2.9, in previous versions
> SerializedLayout was default.
>  
>  
>reconnectionDelayMillis
>
> http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/
> 61db8afd/src/site/xdoc/manual/layouts.xml.vm
> --
> diff --git a/src/site/xdoc/manual/layouts.xml.vm b/src/site/xdoc/manual/
> layouts.xml.vm
> index 7d17fd1..a8353bd 100644
> --- a/src/site/xdoc/manual/layouts.xml.vm
> +++ b/src/site/xdoc/manual/layouts.xml.vm
> @@ -1978,9 +1978,9 @@ at org.apache.logging.log4j.core.
> pattern.ExtendedThrowableTest.testException(Ext
>The SerializedLayout accepts no parameters.
>
>
> -  Java Serialization has inherent security weaknesses, using this
> layout is no longer recommended.
> -  An alternative layout containing the same information is  href="#JSONLayout">JsonLayout,
> -  when configured with properties="true".
> +  This layout is deprecated since version 2.9. Java Serialization
> has inherent security weaknesses,
> +  using this layout is no longer recommended. An alternative
> layout containing the same information
> +  is JsonLayout, configured with
> properties="true".
>
>  
>  
>
>


--
Matt

[jira] [Commented] (LOG4J2-1958) Deprecate SerializedLayout and remove it as default

2017-06-28 Thread Matt Sicker (JIRA)


[ 
https://issues.apache.org/jira/browse/LOG4J2-1958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16066847#comment-16066847
 ] 

Matt Sicker commented on LOG4J2-1958:
-

Said status logger message might want to include a link to more information 
about the general object deserialization exploits in Java besides linking our 
CVE.

> Deprecate SerializedLayout and remove it as default
> ---
>
> Key: LOG4J2-1958
> URL: https://issues.apache.org/jira/browse/LOG4J2-1958
> Project: Log4j 2
>  Issue Type: Task
>  Components: Appenders, Layouts
>Affects Versions: 2.8.2
>Reporter: Mikael Ståldal
>Assignee: Mikael Ståldal
> Fix For: 2.9
>
>
> Due to inherent security weakness of Java object serialization, see 
> CVE-2017-5645, we should deprecate SerializedLayout and discourage its use. 
> We should also remove it as default from the appenders which currently has it:
> * SocketAppender
> * JmsAppender
> For the time being, we can recommend using JsonLayout as a replacement.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: logging-log4j2 git commit: LOG4J2-1958 Specify version when SerializedLayout is deprecated

2017-06-28 Thread Matt Sicker

You can add a @deprecated javadoc tag to specify that which makes it more
prominent in the javadocs.

On 28 June 2017 at 08:50,  wrote:

> Repository: logging-log4j2
> Updated Branches:
>   refs/heads/LOG4J2-1958 041f42dad -> 61db8afdd
>
>
> LOG4J2-1958 Specify version when SerializedLayout is deprecated
>
>
> Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
> Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/
> commit/61db8afd
> Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/61db8afd
> Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/61db8afd
>
> Branch: refs/heads/LOG4J2-1958
> Commit: 61db8afdd2761e83541095a5a964f4bddd6ac943
> Parents: 041f42d
> Author: Mikael Ståldal 
> Authored: Wed Jun 28 15:50:28 2017 +0200
> Committer: Mikael Ståldal 
> Committed: Wed Jun 28 15:50:28 2017 +0200
>
> --
>  .../org/apache/logging/log4j/core/layout/SerializedLayout.java | 1 +
>  src/site/xdoc/manual/appenders.xml | 4 +++-
>  src/site/xdoc/manual/layouts.xml.vm| 6 +++---
>  3 files changed, 7 insertions(+), 4 deletions(-)
> --
>
>
> http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/
> 61db8afd/log4j-core/src/main/java/org/apache/logging/log4j/
> core/layout/SerializedLayout.java
> --
> diff --git 
> a/log4j-core/src/main/java/org/apache/logging/log4j/core/layout/SerializedLayout.java
> b/log4j-core/src/main/java/org/apache/logging/log4j/core/
> layout/SerializedLayout.java
> index 43700e0..091e31e 100644
> --- a/log4j-core/src/main/java/org/apache/logging/log4j/core/
> layout/SerializedLayout.java
> +++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/
> layout/SerializedLayout.java
> @@ -32,6 +32,7 @@ import org.apache.logging.log4j.core.
> config.plugins.PluginFactory;
>   *
>   * @deprecated Java Serialization has inherent security weaknesses, using
> this layout is no longer recommended.
>   * An alternative layout containing the same information is {@link
> JsonLayout} when configured with properties="true".
> + * Deprecated since 2.9.
>   */
>  @Deprecated
>  @Plugin(name = "SerializedLayout", category = Node.CATEGORY, elementType
> = Layout.ELEMENT_TYPE, printObject = true)
>
> http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/
> 61db8afd/src/site/xdoc/manual/appenders.xml
> --
> diff --git a/src/site/xdoc/manual/appenders.xml b/src/site/xdoc/manual/
> appenders.xml
> index 7d9dfc4..528dabe 100644
> --- a/src/site/xdoc/manual/appenders.xml
> +++ b/src/site/xdoc/manual/appenders.xml
> @@ -1296,6 +1296,7 @@ public class ConnectionFactory {
>Layout
>
>  The Layout to use to format the LogEvent. Required, there
> is no default.
> +New since 2.9, in previous versions SerializedLayout
> was default.
>
>  
>  
> @@ -4380,7 +4381,8 @@ public class JpaLogEntity extends
> AbstractLogEventWrapperEntity {
>  
>layout
>Layout
> -  The Layout to use to format the LogEvent. Required,
> there is no default.
> +  The Layout to use to format the LogEvent. Required,
> there is no default.
> +  New since 2.9, in previous versions
> SerializedLayout was default.
>  
>  
>reconnectionDelayMillis
>
> http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/
> 61db8afd/src/site/xdoc/manual/layouts.xml.vm
> --
> diff --git a/src/site/xdoc/manual/layouts.xml.vm b/src/site/xdoc/manual/
> layouts.xml.vm
> index 7d17fd1..a8353bd 100644
> --- a/src/site/xdoc/manual/layouts.xml.vm
> +++ b/src/site/xdoc/manual/layouts.xml.vm
> @@ -1978,9 +1978,9 @@ at org.apache.logging.log4j.core.
> pattern.ExtendedThrowableTest.testException(Ext
>The SerializedLayout accepts no parameters.
>
>
> -  Java Serialization has inherent security weaknesses, using this
> layout is no longer recommended.
> -  An alternative layout containing the same information is  href="#JSONLayout">JsonLayout,
> -  when configured with properties="true".
> +  This layout is deprecated since version 2.9. Java Serialization
> has inherent security weaknesses,
> +  using this layout is no longer recommended. An alternative
> layout containing the same information
> +  is JsonLayout, configured with
> properties="true".
>
>  
>  
>
>


-- 
Matt Sicker

Re: [1/2] logging-log4j2 git commit: LOG4J2-1958 Deprecate SerializedLayout and remove it as default

2017-06-28 Thread Remko Popma

In the manual pages, can we mention that in previous versions the default
was SerializedLayout, but as of log4j-2.9 users need to explicitly specify
a layout since there is no default? I think it is important to document the
log4j version when this change took place.

On Wed, Jun 28, 2017 at 9:52 PM,  wrote:

> Repository: logging-log4j2
> Updated Branches:
>   refs/heads/LOG4J2-1958 [created] c1b90f961
>
>
> LOG4J2-1958 Deprecate SerializedLayout and remove it as default
>
>
> Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
> Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/
> commit/330a16f9
> Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/330a16f9
> Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/330a16f9
>
> Branch: refs/heads/LOG4J2-1958
> Commit: 330a16f923a8eb34b983cc3fb255927dd9699323
> Parents: 3f45368
> Author: Mikael Ståldal 
> Authored: Wed Jun 28 14:50:52 2017 +0200
> Committer: Mikael Ståldal 
> Committed: Wed Jun 28 14:50:52 2017 +0200
>
> --
>  .../log4j/core/appender/SocketAppender.java |  8 +++---
>  .../log4j/core/appender/mom/JmsAppender.java|  7 +++--
>  .../log4j/core/layout/SerializedLayout.java |  6 +
>  .../log4j/core/appender/SocketAppenderTest.java | 28 ++--
>  src/changes/changes.xml |  3 +++
>  src/site/xdoc/manual/appenders.xml  | 15 ++-
>  src/site/xdoc/manual/layouts.xml.vm |  9 +--
>  src/site/xdoc/manual/migration.xml  |  2 +-
>  8 files changed, 54 insertions(+), 24 deletions(-)
> --
>
>
> http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/
> 330a16f9/log4j-core/src/main/java/org/apache/logging/log4j/
> core/appender/SocketAppender.java
> --
> diff --git 
> a/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/SocketAppender.java
> b/log4j-core/src/main/java/org/apache/logging/log4j/core/
> appender/SocketAppender.java
> index 8c2b83d..b433403 100644
> --- a/log4j-core/src/main/java/org/apache/logging/log4j/core/
> appender/SocketAppender.java
> +++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/
> appender/SocketAppender.java
> @@ -36,7 +36,6 @@ import org.apache.logging.log4j.core.
> config.plugins.PluginElement;
>  import org.apache.logging.log4j.core.config.plugins.PluginFactory;
>  import org.apache.logging.log4j.core.config.plugins.validation.
> constraints.ValidHost;
>  import org.apache.logging.log4j.core.config.plugins.validation.
> constraints.ValidPort;
> -import org.apache.logging.log4j.core.layout.SerializedLayout;
>  import org.apache.logging.log4j.core.net.AbstractSocketManager;
>  import org.apache.logging.log4j.core.net.Advertiser;
>  import org.apache.logging.log4j.core.net.DatagramSocketManager;
> @@ -197,7 +196,8 @@ public class SocketAppender extends
> AbstractOutputStreamAppender  final boolean bufferedIo = isBufferedIo();
>  Layout layout = getLayout();
>  if (layout == null) {
> -layout = SerializedLayout.createLayout();
> +AbstractLifeCycle.LOGGER.error("No layout provided for
> SocketAppender");
> +return null;
>  }
>
>  final String name = getName();
> @@ -280,7 +280,7 @@ public class SocketAppender extends
> AbstractOutputStreamAppender   *If {@code "true"} (default) exceptions encountered when
> appending events are logged; otherwise they
>   *are propagated to the caller.
>   * @param layout
> - *The layout to use (defaults to SerializedLayout).
> + *The layout to use. Required, there is no default.
>   * @param filter
>   *The Filter or null.
>   * @param advertise
> @@ -354,7 +354,7 @@ public class SocketAppender extends
> AbstractOutputStreamAppender   *If {@code "true"} (default) exceptions encountered when
> appending events are logged; otherwise they
>   *are propagated to the caller.
>   * @param layout
> - *The layout to use (defaults to {@link
> SerializedLayout}).
> + *The layout to use. Required, there is no default.
>   * @param filter
>   *The Filter or null.
>   * @param advertise
>
> http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/
> 330a16f9/log4j-core/src/main/java/org/apache/logging/log4j/
> core/appender/mom/JmsAppender.java
> --
> diff --git 
> a/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/mom/JmsAppender.java
> b/log4j-core/src/main/java/org/apache/logging/log4j/core/
>

[jira] [Commented] (LOG4J2-1950) Docker build broken with log4j-api-java9

2017-06-28 Thread Pierrick HYMBERT (JIRA)


[ 
https://issues.apache.org/jira/browse/LOG4J2-1950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16066485#comment-16066485
 ] 

Pierrick HYMBERT commented on LOG4J2-1950:
--

The docker VM is configured {{FROM openjdk:7-jdk}}, only log4j-api-java9 module 
use the toolchain jdk9.

Confirmed with the following run just after the build:
{code}
RUN java -version && /opt/apache-maven-3.5.0/bin/mvn -version
{code}

That output:
{code}
Step 5/6 : RUN java -version && /opt/apache-maven-3.5.0/bin/mvn -version
 ---> Running in ec253c24e421
java version "1.7.0_131"
OpenJDK Runtime Environment (IcedTea 2.6.9) (7u131-2.6.9-2~deb8u1)
OpenJDK 64-Bit Server VM (build 24.131-b00, mixed mode)
Apache Maven 3.5.0 (ff8f5e7444045639af65f6095c62210b5713f426; 
2017-04-03T19:39:06Z)
Maven home: /opt/apache-maven-3.5.0
Java version: 1.7.0_131, vendor: Oracle Corporation
Java home: /usr/lib/jvm/java-7-openjdk-amd64/jre
Default locale: en, platform encoding: UTF-8
OS name: "linux", version: "4.4.52-boot2docker", arch: "amd64", family: "unix"
 ---> 14c3a4c8a028
{code}

> Docker build broken with log4j-api-java9
> 
>
> Key: LOG4J2-1950
> URL: https://issues.apache.org/jira/browse/LOG4J2-1950
> Project: Log4j 2
>  Issue Type: Bug
> Environment: Docker
>Reporter: Pierrick HYMBERT
>Priority: Trivial
> Fix For: 2.9
>
>
> Since introduction of jdk9 requirement in the build, docker image cannot be 
> built.
> It fails with:
> {code}
> [INFO] --- maven-toolchains-plugin:1.1:toolchain (default) @ log4j-api-java9 
> ---
> [INFO] Required toolchain: jdk [ version='9' ]
> [ERROR] No toolchain found for type jdk
> [ERROR] Cannot find matching toolchain definitions for the following 
> toolchain types:
> jdk [ version='9' ]
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Apache Log4j 2 . SUCCESS [05:27 
> min]
> [INFO] Apache Log4j API Java 9 support  FAILURE [ 25.103 
> s]
> [INFO] Apache Log4j API ... SKIPPED
> [INFO] Apache Log4j Core .. SKIPPED
> [INFO] Apache Log4j Core Integration Tests  SKIPPED
> [INFO] Apache Log4j 1.x Compatibility API . SKIPPED
> [INFO] Apache Log4j SLF4J Binding . SKIPPED
> [INFO] Apache Log4j to SLF4J Adapter .. SKIPPED
> [INFO] Apache Log4j Commons Logging Bridge  SKIPPED
> [INFO] Apache Log4j Flume Bridge .. SKIPPED
> [INFO] Apache Log4j Web ... SKIPPED
> [INFO] Apache Log4j Tag Library ... SKIPPED
> [INFO] Apache Log4j JMX GUI ... SKIPPED
> [INFO] Apache Log4j Samples ... SKIPPED
> [INFO] Apache Log4j Samples: Flume - Common ... SKIPPED
> [INFO] Apache Log4j Samples: Flume - Remote ... SKIPPED
> [INFO] Apache Log4j Samples: Flume - Embedded . SKIPPED
> [INFO] Apache Log4j Samples: Configuration  SKIPPED
> [INFO] Apache Log4j Samples: LoggerProperties . SKIPPED
> [INFO] Apache Log4j Scala 2.11 wrapper for Log4j API .. SKIPPED
> [INFO] Apache Log4j Samples: Scala API  SKIPPED
> [INFO] Apache Log4j OSGi .. SKIPPED
> [INFO] Apache Log4j BOM ... SKIPPED
> [INFO] Apache Log4j NoSQL . SKIPPED
> [INFO] Apache Log4J Performance Tests . SKIPPED
> [INFO] Apache Log4j Streaming Interface ... SKIPPED
> [INFO] Apache Log4j JUL Adapter ... SKIPPED
> [INFO] Apache Log4j Liquibase Binding . SKIPPED
> [INFO] Apache Log4j Scala 2.10 wrapper for Log4j API .. SKIPPED
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time: 08:47 min
> [INFO] Finished at: 2017-06-22T15:27:35+00:00
> [INFO] Final Memory: 33M/81M
> [INFO] 
> 
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-toolchains-plugin:1.1:toolchain (default) on 
> project log4j-api-java9: Cannot find matching toolchain definitions for the 
> following toolchain types:
> [ERROR] jdk [ version='9' ]
> [ERROR] Please make sure you define the required toolchains in your 
> ~/.m2/toolchains.xml file.
> [ERROR] -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X

[jira] [Commented] (LOG4J2-1950) Docker build broken with log4j-api-java9

2017-06-28 Thread JIRA


[ 
https://issues.apache.org/jira/browse/LOG4J2-1950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16066445#comment-16066445
 ] 

Mikael Ståldal commented on LOG4J2-1950:


{quote}SecureSocketAppenderSocketOptionsTest.testSocketTrafficClass:127 
expected:<2> but was:<0>
SocketAppenderSocketOptionsTest.testSocketTrafficClass:107 expected:<2> but 
was:<0>{quote}

Those are the tests that only works on Java 7 (not on Java 8 or 9).

> Docker build broken with log4j-api-java9
> 
>
> Key: LOG4J2-1950
> URL: https://issues.apache.org/jira/browse/LOG4J2-1950
> Project: Log4j 2
>  Issue Type: Bug
> Environment: Docker
>Reporter: Pierrick HYMBERT
>Priority: Trivial
> Fix For: 2.9
>
>
> Since introduction of jdk9 requirement in the build, docker image cannot be 
> built.
> It fails with:
> {code}
> [INFO] --- maven-toolchains-plugin:1.1:toolchain (default) @ log4j-api-java9 
> ---
> [INFO] Required toolchain: jdk [ version='9' ]
> [ERROR] No toolchain found for type jdk
> [ERROR] Cannot find matching toolchain definitions for the following 
> toolchain types:
> jdk [ version='9' ]
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Apache Log4j 2 . SUCCESS [05:27 
> min]
> [INFO] Apache Log4j API Java 9 support  FAILURE [ 25.103 
> s]
> [INFO] Apache Log4j API ... SKIPPED
> [INFO] Apache Log4j Core .. SKIPPED
> [INFO] Apache Log4j Core Integration Tests  SKIPPED
> [INFO] Apache Log4j 1.x Compatibility API . SKIPPED
> [INFO] Apache Log4j SLF4J Binding . SKIPPED
> [INFO] Apache Log4j to SLF4J Adapter .. SKIPPED
> [INFO] Apache Log4j Commons Logging Bridge  SKIPPED
> [INFO] Apache Log4j Flume Bridge .. SKIPPED
> [INFO] Apache Log4j Web ... SKIPPED
> [INFO] Apache Log4j Tag Library ... SKIPPED
> [INFO] Apache Log4j JMX GUI ... SKIPPED
> [INFO] Apache Log4j Samples ... SKIPPED
> [INFO] Apache Log4j Samples: Flume - Common ... SKIPPED
> [INFO] Apache Log4j Samples: Flume - Remote ... SKIPPED
> [INFO] Apache Log4j Samples: Flume - Embedded . SKIPPED
> [INFO] Apache Log4j Samples: Configuration  SKIPPED
> [INFO] Apache Log4j Samples: LoggerProperties . SKIPPED
> [INFO] Apache Log4j Scala 2.11 wrapper for Log4j API .. SKIPPED
> [INFO] Apache Log4j Samples: Scala API  SKIPPED
> [INFO] Apache Log4j OSGi .. SKIPPED
> [INFO] Apache Log4j BOM ... SKIPPED
> [INFO] Apache Log4j NoSQL . SKIPPED
> [INFO] Apache Log4J Performance Tests . SKIPPED
> [INFO] Apache Log4j Streaming Interface ... SKIPPED
> [INFO] Apache Log4j JUL Adapter ... SKIPPED
> [INFO] Apache Log4j Liquibase Binding . SKIPPED
> [INFO] Apache Log4j Scala 2.10 wrapper for Log4j API .. SKIPPED
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time: 08:47 min
> [INFO] Finished at: 2017-06-22T15:27:35+00:00
> [INFO] Final Memory: 33M/81M
> [INFO] 
> 
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-toolchains-plugin:1.1:toolchain (default) on 
> project log4j-api-java9: Cannot find matching toolchain definitions for the 
> following toolchain types:
> [ERROR] jdk [ version='9' ]
> [ERROR] Please make sure you define the required toolchains in your 
> ~/.m2/toolchains.xml file.
> [ERROR] -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
> [ERROR]
> [ERROR] After correcting the problems, you can resume the build with the 
> command
> [ERROR]   mvn  -rf :log4j-api-java9
> The command '/bin/sh -c set -ex && cd /src && 
> /opt/apache-maven-3.3.9/bin/mvn verify' returned a non-zero code: 1
> {code}
> I have tried to make it working back, but alpine doesnt support openjdk9 till 
> now, so I suggest to revert

[jira] [Commented] (LOG4J2-1958) Deprecate SerializedLayout and remove it as default

2017-06-28 Thread JIRA


[ 
https://issues.apache.org/jira/browse/LOG4J2-1958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16066437#comment-16066437
 ] 

Mikael Ståldal commented on LOG4J2-1958:


See Git branch LOG4J2-1958.

> Deprecate SerializedLayout and remove it as default
> ---
>
> Key: LOG4J2-1958
> URL: https://issues.apache.org/jira/browse/LOG4J2-1958
> Project: Log4j 2
>  Issue Type: Task
>  Components: Appenders, Layouts
>Affects Versions: 2.8.2
>Reporter: Mikael Ståldal
>Assignee: Mikael Ståldal
> Fix For: 2.9
>
>
> Due to inherent security weakness of Java object serialization, see 
> CVE-2017-5645, we should deprecate SerializedLayout and discourage its use. 
> We should also remove it as default from the appenders which currently has it:
> * SocketAppender
> * JmsAppender
> For the time being, we can recommend using JsonLayout as a replacement.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LOG4J2-1958) Deprecate SerializedLayout and remove it as default

2017-06-28 Thread JIRA


[ 
https://issues.apache.org/jira/browse/LOG4J2-1958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16066411#comment-16066411
 ] 

Mikael Ståldal commented on LOG4J2-1958:


Yes, that could be a good idea.

> Deprecate SerializedLayout and remove it as default
> ---
>
> Key: LOG4J2-1958
> URL: https://issues.apache.org/jira/browse/LOG4J2-1958
> Project: Log4j 2
>  Issue Type: Task
>  Components: Appenders, Layouts
>Affects Versions: 2.8.2
>Reporter: Mikael Ståldal
>Assignee: Mikael Ståldal
> Fix For: 2.9
>
>
> Due to inherent security weakness of Java object serialization, see 
> CVE-2017-5645, we should deprecate SerializedLayout and discourage its use. 
> We should also remove it as default from the appenders which currently has it:
> * SocketAppender
> * JmsAppender
> For the time being, we can recommend using JsonLayout as a replacement.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (LOG4J2-1086) SizeBasedTriggeringPolicy is not working properly

2017-06-28 Thread Pierrick HYMBERT (JIRA)


 [ 
https://issues.apache.org/jira/browse/LOG4J2-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierrick HYMBERT updated LOG4J2-1086:
-
Attachment: LOG4J2-1086.Test.patch

Hello [~ralph.go...@dslextreme.com] and team,

I am not sure this is the correct way to reproduce and what is the acceptable 
size overload in log files: one log event ?

With this unit test, more thread you add, bigger files you got at the end, with 
32 threads on Windows I got 5248 bytes log instead of 2048.

I have also disabled {{log4j2.enable.direct.encoders}}, because it looks it 
didnt call {{RollingFileAppender.append}} method directly but the problem 
persist.

I didnt find correct place to fix or move {{RollingFileAppender.checkRollover}} 
method, it seems to be called to early.

> SizeBasedTriggeringPolicy is not working properly
> -
>
> Key: LOG4J2-1086
> URL: https://issues.apache.org/jira/browse/LOG4J2-1086
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Appenders
>Affects Versions: 2.3, 2.4.1
> Environment: Windows 7 OS Websphere 8.5.5.6
>Reporter: Sharat
>Assignee: Ralph Goers
>Priority: Minor
>  Labels: features
> Attachments: LOG4J2-1086.Test.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> {code}
> 
> 
>  
>  filePattern="/logs/test-%i.log"> 
>
>   %d %-5p %class{36} (%M:%L) 
> -%msg%xEx%n 
>
>
>   
>   
>
>
>
>
>
>
>   
>   
>  
> 
>   
>   
> 
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LOG4J2-1699) Configurable Log File Permissions with PosixFilePermission

2017-06-28 Thread Pierrick HYMBERT (JIRA)


[ 
https://issues.apache.org/jira/browse/LOG4J2-1699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16066120#comment-16066120
 ] 

Pierrick HYMBERT commented on LOG4J2-1699:
--

OK for me, thank you all! Dear [~ddimatos], please confirm it is ok for you

> Configurable Log File Permissions with PosixFilePermission
> --
>
> Key: LOG4J2-1699
> URL: https://issues.apache.org/jira/browse/LOG4J2-1699
> Project: Log4j 2
>  Issue Type: Question
>  Components: Appenders
> Environment: Linux
>Reporter: Demetrios Dimatos
>  Labels: features
> Fix For: 2.9
>
> Attachments: LOG4J2-1699-2.patch, LOG4J2-1699.patch
>
>   Original Estimate: 336h
>  Remaining Estimate: 336h
>
> We would like to hear the communities thoughts on being able to configure the 
> permissions log files are created with. We don't want to rely on UMASK 
> because we have managed services who's process should generate logs with a 
> 644 yet deployed applications by users should default to a 640 because the 
> logs may contain sensitive information.
> We will make the modification and set this in the properties file. Now we are 
> looking to see what the community position would be on accepting such a 
> patch, we don't want to be patching our own distribution indefinitely. 
> I searched all the JIRAs and was not able to find any matching requirements 
> recently. All I could find was something dated in 2006: 
> https://bz.apache.org/bugzilla/show_bug.cgi?id=40407



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: logging-log4net git commit: (doc) Fix name of class LogicalThreadContext

[GitHub] logging-log4net pull request #11: (doc) Fix name of class LogicalThreadConte...

[GitHub] logging-log4net issue #11: (doc) Fix name of class LogicalThreadContext

[GitHub] logging-log4net pull request #11: (doc) Fix name of class LogicalThreadConte...

Re: logging-log4j2 git commit: [LOG4J2-1699] Log File Permissions with PosixFilePermission feedback from jira. Closes #89. - item 2: Better log at configuration step if file attribute view are defined

[jira] [Commented] (LOG4J2-1934) JMS Appender does not know how to recover from a broken connection

Re: logging-log4j2 git commit: LOG4J2-1958 Specify version when SerializedLayout is deprecated

Re: logging-log4j2 git commit: LOG4J2-1958 Specify version when SerializedLayout is deprecated

Re: logging-log4j2 git commit: LOG4J2-1958 Specify version when SerializedLayout is deprecated

[jira] [Commented] (LOG4J2-1958) Deprecate SerializedLayout and remove it as default

Re: logging-log4j2 git commit: LOG4J2-1958 Specify version when SerializedLayout is deprecated

Re: [1/2] logging-log4j2 git commit: LOG4J2-1958 Deprecate SerializedLayout and remove it as default

[jira] [Commented] (LOG4J2-1950) Docker build broken with log4j-api-java9

[jira] [Commented] (LOG4J2-1950) Docker build broken with log4j-api-java9

[jira] [Commented] (LOG4J2-1958) Deprecate SerializedLayout and remove it as default

[jira] [Commented] (LOG4J2-1958) Deprecate SerializedLayout and remove it as default

[jira] [Updated] (LOG4J2-1086) SizeBasedTriggeringPolicy is not working properly

[jira] [Commented] (LOG4J2-1699) Configurable Log File Permissions with PosixFilePermission

18 matches

Site Navigation

Mail list logo

Footer information