[jira] [Updated] (SOLR-9912) SimpleFacets - support facet.excludeTerms parameter
[ https://issues.apache.org/jira/browse/SOLR-9912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonny Marks updated SOLR-9912: -- Attachment: SOLR-9912.patch Moved ExcludeBytesRefFilter to anonymous inner class > SimpleFacets - support facet.excludeTerms parameter > --- > > Key: SOLR-9912 > URL: https://issues.apache.org/jira/browse/SOLR-9912 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Jonny Marks >Assignee: Christine Poerschke >Priority: Minor > Attachments: SOLR-9912.patch, SOLR-9912.patch, SOLR-9912.patch, > SOLR-9912.patch > > > This ticket is for supporting a new facet.excludeTerms parameter for removing > specific terms from the facet counts, without having to exclude the terms > from the index itself. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-9800) FacetComponent - move construction of SimpleFacets to a protected method
[
https://issues.apache.org/jira/browse/SOLR-9800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jonny Marks updated SOLR-9800:
--
Description:
This patch moves the construction of SimpleFacets from inside process() to a
new protected method, allowing contrib modules to reuse FacetComponent with a
different SimpleFacets implementation.
For example:
{code}
class MyFacetComponent extends FacetComponent {
@Override
protected SimpleFacets newSimpleFacets(SolrQueryRequest req, DocSet docSet,
SolrParams params, ResponseBuilder rb) {
return new SimpleFacets(req, docSet, params, rb) {
@Override
protected Predicate newBytesRefFilter(String field, SolrParams
params) {
...
return new MyBytesRefFilter (...);
}
};
}
}
{code}
was:
This patch moves the construction of SimpleFacets from inside process() to a
new protected method, allowing contrib modules to reuse FacetComponent with a
different SimpleFacets implementation.
For example:
{code}
class MyFacetComponent extends FacetComponent {
@Override
protected SimpleFacets newSimpleFacets(SolrQueryRequest req, DocSet docSet,
SolrParams params, ResponseBuilder rb) {
return new SimpleFacets(req, docSet, params, rb) {
@Override
protected BytesRefFilter newBytesRefFilter(String field, SolrParams
params) {
...
return new MyBytesRefFilter (...);
}
};
}
}
{code}
> FacetComponent - move construction of SimpleFacets to a protected method
>
>
> Key: SOLR-9800
> URL: https://issues.apache.org/jira/browse/SOLR-9800
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Jonny Marks
>Assignee: Christine Poerschke
>Priority: Minor
> Attachments: SOLR-9800.patch
>
>
> This patch moves the construction of SimpleFacets from inside process() to a
> new protected method, allowing contrib modules to reuse FacetComponent with a
> different SimpleFacets implementation.
> For example:
> {code}
> class MyFacetComponent extends FacetComponent {
> @Override
> protected SimpleFacets newSimpleFacets(SolrQueryRequest req, DocSet docSet,
> SolrParams params, ResponseBuilder rb) {
> return new SimpleFacets(req, docSet, params, rb) {
> @Override
> protected Predicate newBytesRefFilter(String field,
> SolrParams params) {
> ...
> return new MyBytesRefFilter (...);
> }
> };
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-9914) SimpleFacets: refactor "contains" check into "SubstringBytesRefMatcher" class
[ https://issues.apache.org/jira/browse/SOLR-9914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonny Marks updated SOLR-9914: -- Description: This patch refactors the "contains" logic for only including constraints which contain a given substring, into a "Predicate" interface and "SubstringBytesRefFilter" implementation. This allows users to have custom logic for including terms in the filter counts, not only based on substring matches. was: This patch refactors the "contains" logic for only including constraints which contain a given substring, into a "BytesRefMatcher" interface and "SubstringBytesRefMatcher" implementation. This allows users to have custom logic for including terms in the filter counts, not only based on substring matches. > SimpleFacets: refactor "contains" check into "SubstringBytesRefMatcher" class > - > > Key: SOLR-9914 > URL: https://issues.apache.org/jira/browse/SOLR-9914 > Project: Solr > Issue Type: Sub-task > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Jonny Marks >Assignee: Christine Poerschke >Priority: Minor > Attachments: SOLR-9914.patch, SOLR-9914.patch, SOLR-9914.patch > > > This patch refactors the "contains" logic for only including constraints > which contain a given substring, into a "Predicate" interface and > "SubstringBytesRefFilter" implementation. > This allows users to have custom logic for including terms in the filter > counts, not only based on substring matches. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-9912) SimpleFacets - support facet.excludeTerms parameter
[ https://issues.apache.org/jira/browse/SOLR-9912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonny Marks updated SOLR-9912: -- Attachment: SOLR-9912.patch Updating patch after SimpleFacets.contains removed in subtask > SimpleFacets - support facet.excludeTerms parameter > --- > > Key: SOLR-9912 > URL: https://issues.apache.org/jira/browse/SOLR-9912 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Jonny Marks >Assignee: Christine Poerschke >Priority: Minor > Attachments: SOLR-9912.patch, SOLR-9912.patch, SOLR-9912.patch > > > This ticket is for supporting a new facet.excludeTerms parameter for removing > specific terms from the facet counts, without having to exclude the terms > from the index itself. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-9914) SimpleFacets: refactor "contains" check into "SubstringBytesRefMatcher" class
[ https://issues.apache.org/jira/browse/SOLR-9914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonny Marks updated SOLR-9914: -- Attachment: SOLR-9914.patch Removed SimpleFacets.contains > SimpleFacets: refactor "contains" check into "SubstringBytesRefMatcher" class > - > > Key: SOLR-9914 > URL: https://issues.apache.org/jira/browse/SOLR-9914 > Project: Solr > Issue Type: Sub-task > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Jonny Marks >Assignee: Christine Poerschke >Priority: Minor > Attachments: SOLR-9914.patch, SOLR-9914.patch, SOLR-9914.patch > > > This patch refactors the "contains" logic for only including constraints > which contain a given substring, into a "BytesRefMatcher" interface and > "SubstringBytesRefMatcher" implementation. > This allows users to have custom logic for including terms in the filter > counts, not only based on substring matches. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-9912) SimpleFacets - support facet.excludeTerms parameter
[ https://issues.apache.org/jira/browse/SOLR-9912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonny Marks updated SOLR-9912: -- Attachment: SOLR-9912.patch Updated patch to use Predicate instead of BytesRefFilter > SimpleFacets - support facet.excludeTerms parameter > --- > > Key: SOLR-9912 > URL: https://issues.apache.org/jira/browse/SOLR-9912 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Jonny Marks >Assignee: Christine Poerschke >Priority: Minor > Attachments: SOLR-9912.patch, SOLR-9912.patch > > > This ticket is for supporting a new facet.excludeTerms parameter for removing > specific terms from the facet counts, without having to exclude the terms > from the index itself. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-9914) SimpleFacets: refactor "contains" check into "SubstringBytesRefMatcher" class
[ https://issues.apache.org/jira/browse/SOLR-9914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonny Marks updated SOLR-9914: -- Attachment: SOLR-9914.patch Thanks for the suggestion [~dsmiley], I've updated the patch to use Predicate. > SimpleFacets: refactor "contains" check into "SubstringBytesRefMatcher" class > - > > Key: SOLR-9914 > URL: https://issues.apache.org/jira/browse/SOLR-9914 > Project: Solr > Issue Type: Sub-task > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Jonny Marks >Assignee: Christine Poerschke >Priority: Minor > Attachments: SOLR-9914.patch, SOLR-9914.patch > > > This patch refactors the "contains" logic for only including constraints > which contain a given substring, into a "BytesRefMatcher" interface and > "SubstringBytesRefMatcher" implementation. > This allows users to have custom logic for including terms in the filter > counts, not only based on substring matches. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-9800) FacetComponent - move construction of SimpleFacets to a protected method
[
https://issues.apache.org/jira/browse/SOLR-9800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jonny Marks updated SOLR-9800:
--
Description:
This patch moves the construction of SimpleFacets from inside process() to a
new protected method, allowing contrib modules to reuse FacetComponent with a
different SimpleFacets implementation.
For example:
{code}
class MyFacetComponent extends FacetComponent {
@Override
protected SimpleFacets newSimpleFacets(SolrQueryRequest req, DocSet docSet,
SolrParams params, ResponseBuilder rb) {
return new SimpleFacets(req, docSet, params, rb) {
@Override
protected BytesRefFilter newBytesRefFilter(String field, SolrParams
params) {
...
return new MyBytesRefFilter (...);
}
};
}
}
{code}
was:This patch moves the construction of SimpleFacets from inside process()
to a new protected method, allowing contrib modules to reuse FacetComponent
with a different SimpleFacets implementation.
> FacetComponent - move construction of SimpleFacets to a protected method
>
>
> Key: SOLR-9800
> URL: https://issues.apache.org/jira/browse/SOLR-9800
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Jonny Marks
>Priority: Minor
> Attachments: SOLR-9800.patch
>
>
> This patch moves the construction of SimpleFacets from inside process() to a
> new protected method, allowing contrib modules to reuse FacetComponent with a
> different SimpleFacets implementation.
> For example:
> {code}
> class MyFacetComponent extends FacetComponent {
> @Override
> protected SimpleFacets newSimpleFacets(SolrQueryRequest req, DocSet docSet,
> SolrParams params, ResponseBuilder rb) {
> return new SimpleFacets(req, docSet, params, rb) {
> @Override
> protected BytesRefFilter newBytesRefFilter(String field, SolrParams
> params) {
> ...
> return new MyBytesRefFilter (...);
> }
> };
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-9912) SimpleFacets - support facet.excludeTerms parameter
[ https://issues.apache.org/jira/browse/SOLR-9912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonny Marks updated SOLR-9912: -- Summary: SimpleFacets - support facet.excludeTerms parameter (was: FacetComponent - support facet.excludeTerms parameter) > SimpleFacets - support facet.excludeTerms parameter > --- > > Key: SOLR-9912 > URL: https://issues.apache.org/jira/browse/SOLR-9912 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Jonny Marks >Priority: Minor > Attachments: SOLR-9912.patch > > > This ticket is for supporting a new facet.excludeTerms parameter for removing > specific terms from the facet counts, without having to exclude the terms > from the index itself. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-9912) FacetComponent - support facet.excludeTerms parameter
[ https://issues.apache.org/jira/browse/SOLR-9912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonny Marks updated SOLR-9912: -- Attachment: SOLR-9912.patch > FacetComponent - support facet.excludeTerms parameter > - > > Key: SOLR-9912 > URL: https://issues.apache.org/jira/browse/SOLR-9912 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Jonny Marks >Priority: Minor > Attachments: SOLR-9912.patch > > > This ticket is for supporting a new facet.excludeTerms parameter for removing > specific terms from the facet counts, without having to exclude the terms > from the index itself. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-9912) FacetComponent - support facet.exclude parameter
[ https://issues.apache.org/jira/browse/SOLR-9912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonny Marks updated SOLR-9912: -- Description: This ticket is for supporting a new facet.excludeTerms parameter for removing specific terms from the facet counts, without having to exclude the terms from the index itself. (was: This ticket is for supporting a new facet.exclude parameter for removing specific terms from the facet counts, without having to exclude the terms from the index itself.) > FacetComponent - support facet.exclude parameter > > > Key: SOLR-9912 > URL: https://issues.apache.org/jira/browse/SOLR-9912 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Jonny Marks >Priority: Minor > > This ticket is for supporting a new facet.excludeTerms parameter for removing > specific terms from the facet counts, without having to exclude the terms > from the index itself. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-9912) FacetComponent - support facet.excludeTerms parameter
[ https://issues.apache.org/jira/browse/SOLR-9912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonny Marks updated SOLR-9912: -- Summary: FacetComponent - support facet.excludeTerms parameter (was: FacetComponent - support facet.exclude parameter) > FacetComponent - support facet.excludeTerms parameter > - > > Key: SOLR-9912 > URL: https://issues.apache.org/jira/browse/SOLR-9912 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Jonny Marks >Priority: Minor > > This ticket is for supporting a new facet.excludeTerms parameter for removing > specific terms from the facet counts, without having to exclude the terms > from the index itself. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-9914) SimpleFacets: refactor "contains" check into "SubstringBytesRefMatcher" class
[ https://issues.apache.org/jira/browse/SOLR-9914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonny Marks updated SOLR-9914: -- Attachment: SOLR-9914.patch > SimpleFacets: refactor "contains" check into "SubstringBytesRefMatcher" class > - > > Key: SOLR-9914 > URL: https://issues.apache.org/jira/browse/SOLR-9914 > Project: Solr > Issue Type: Sub-task > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Jonny Marks >Priority: Minor > Attachments: SOLR-9914.patch > > > This patch refactors the "contains" logic for only including constraints > which contain a given substring, into a "BytesRefMatcher" interface and > "SubstringBytesRefMatcher" implementation. > This allows users to have custom logic for including terms in the filter > counts, not only based on substring matches. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Created] (SOLR-9914) SimpleFacets: refactor "contains" check into "SubstringBytesRefMatcher" class
Jonny Marks created SOLR-9914: - Summary: SimpleFacets: refactor "contains" check into "SubstringBytesRefMatcher" class Key: SOLR-9914 URL: https://issues.apache.org/jira/browse/SOLR-9914 Project: Solr Issue Type: Sub-task Security Level: Public (Default Security Level. Issues are Public) Reporter: Jonny Marks Priority: Minor This patch refactors the "contains" logic for only including constraints which contain a given substring, into a "BytesRefMatcher" interface and "SubstringBytesRefMatcher" implementation. This allows users to have custom logic for including terms in the filter counts, not only based on substring matches. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-9820) PerSegmentSingleValuedFaceting - mark "contains" and "ignoreCase" fields private
[ https://issues.apache.org/jira/browse/SOLR-9820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonny Marks updated SOLR-9820: -- Issue Type: Sub-task (was: Task) Parent: SOLR-9912 > PerSegmentSingleValuedFaceting - mark "contains" and "ignoreCase" fields > private > > > Key: SOLR-9820 > URL: https://issues.apache.org/jira/browse/SOLR-9820 > Project: Solr > Issue Type: Sub-task > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Jonny Marks >Priority: Minor > Attachments: SOLR-9820.patch > > > This patch marks the "contains" and "ignoreCase" fields in > PerSegmentSingleValuedFaceting private (they are currently public). > A separate patch will follow where I propose to replace them with a > customizable variant. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Created] (SOLR-9912) FacetComponent - support facet.exclude parameter
Jonny Marks created SOLR-9912: - Summary: FacetComponent - support facet.exclude parameter Key: SOLR-9912 URL: https://issues.apache.org/jira/browse/SOLR-9912 Project: Solr Issue Type: Task Security Level: Public (Default Security Level. Issues are Public) Reporter: Jonny Marks Priority: Minor This ticket is for supporting a new facet.exclude parameter for removing specific terms from the facet counts, without having to exclude the terms from the index itself. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-9787) Replace json.nl=arrnvp with json.nl=arrntv (array of Name Type Value) style in JSONResponseWriter
[
https://issues.apache.org/jira/browse/SOLR-9787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jonny Marks updated SOLR-9787:
--
Attachment: SOLR-9787.patch
arrntv patch attached
> Replace json.nl=arrnvp with json.nl=arrntv (array of Name Type Value) style
> in JSONResponseWriter
> -
>
> Key: SOLR-9787
> URL: https://issues.apache.org/jira/browse/SOLR-9787
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Christine Poerschke
>Assignee: Christine Poerschke
>Priority: Minor
> Attachments: SOLR-9787.patch, SOLR-9787.patch
>
>
> This follows on from and builds upon SOLR-9442's addition of json.nl=arrnvp
> style. See
> https://issues.apache.org/jira/browse/SOLR-9442?focusedCommentId=15664719=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15664719
> onwards for background info.
> Example:
> {code}
> NamedList("a"=1,"bar”=“foo",null=3.4f,null=null)
> =>
> [
> { "name":"a", "type":"int", "value":1 },
> { "name":"bar", "type":"str", "value":"foo" },
> { "name":null, "type":"float", "value":3.4 },
> { "name":null, "type":"null", "value":null }
> ]
> {code}
> This style maintains the type information of the values, similar to the xml
> format:
> {code}
>
> 1
> foo
> 3.4
>
>
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-9820) PerSegmentSingleValuedFaceting - mark "contains" and "ignoreCase" fields private
[ https://issues.apache.org/jira/browse/SOLR-9820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonny Marks updated SOLR-9820: -- Attachment: SOLR-9820.patch > PerSegmentSingleValuedFaceting - mark "contains" and "ignoreCase" fields > private > > > Key: SOLR-9820 > URL: https://issues.apache.org/jira/browse/SOLR-9820 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Jonny Marks >Priority: Minor > Attachments: SOLR-9820.patch > > > This patch marks the "contains" and "ignoreCase" fields in > PerSegmentSingleValuedFaceting private (they are currently public). > A separate patch will follow where I propose to replace them with a > customizable variant. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Created] (SOLR-9820) PerSegmentSingleValuedFaceting - mark "contains" and "ignoreCase" fields private
Jonny Marks created SOLR-9820: - Summary: PerSegmentSingleValuedFaceting - mark "contains" and "ignoreCase" fields private Key: SOLR-9820 URL: https://issues.apache.org/jira/browse/SOLR-9820 Project: Solr Issue Type: Task Security Level: Public (Default Security Level. Issues are Public) Reporter: Jonny Marks Priority: Minor This patch marks the "contains" and "ignoreCase" fields in PerSegmentSingleValuedFaceting private (they are currently public). A separate patch will follow where I propose to replace them with a customizable variant. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-9800) FacetComponent - move construction of SimpleFacets to a protected method
[ https://issues.apache.org/jira/browse/SOLR-9800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonny Marks updated SOLR-9800: -- Attachment: SOLR-9800.patch Attaching patch > FacetComponent - move construction of SimpleFacets to a protected method > > > Key: SOLR-9800 > URL: https://issues.apache.org/jira/browse/SOLR-9800 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Jonny Marks >Priority: Minor > Attachments: SOLR-9800.patch > > > This patch moves the construction of SimpleFacets from inside process() to a > new protected method, allowing contrib modules to reuse FacetComponent with a > different SimpleFacets implementation. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Created] (SOLR-9800) FacetComponent - move construction of SimpleFacets to a protected method
Jonny Marks created SOLR-9800: - Summary: FacetComponent - move construction of SimpleFacets to a protected method Key: SOLR-9800 URL: https://issues.apache.org/jira/browse/SOLR-9800 Project: Solr Issue Type: Bug Security Level: Public (Default Security Level. Issues are Public) Reporter: Jonny Marks Priority: Minor This patch moves the construction of SimpleFacets from inside process() to a new protected method, allowing contrib modules to reuse FacetComponent with a different SimpleFacets implementation. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9787) Replace json.nl=arrnvp with json.nl=arrntv (array of Name Type Value) style in JSONResponseWriter
[
https://issues.apache.org/jira/browse/SOLR-9787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15690715#comment-15690715
]
Jonny Marks commented on SOLR-9787:
---
I plan to work on this in the first half of December
> Replace json.nl=arrnvp with json.nl=arrntv (array of Name Type Value) style
> in JSONResponseWriter
> -
>
> Key: SOLR-9787
> URL: https://issues.apache.org/jira/browse/SOLR-9787
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Christine Poerschke
>Assignee: Christine Poerschke
>Priority: Minor
> Attachments: SOLR-9787.patch
>
>
> This follows on from and builds upon SOLR-9442's addition of json.nl=arrnvp
> style. See
> https://issues.apache.org/jira/browse/SOLR-9442?focusedCommentId=15664719=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15664719
> onwards for background info.
> Example:
> {code}
> NamedList("a"=1,"bar”=“foo",null=3.4f,null=null)
> =>
> [
> { "name":"a", "type":"int", "value":1 },
> { "name":"bar", "type":"str", "value":"foo" },
> { "name":null, "type":"float", "value":3.4 },
> { "name":null, "type":"null", "value":null }
> ]
> {code}
> This style maintains the type information of the values, similar to the xml
> format:
> {code}
>
> 1
> foo
> 3.4
>
>
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-9726) DocValuesFacets: move 'contains' check after 'min' check
[ https://issues.apache.org/jira/browse/SOLR-9726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonny Marks updated SOLR-9726: -- Attachment: SOLR-9726.patch > DocValuesFacets: move 'contains' check after 'min' check > > > Key: SOLR-9726 > URL: https://issues.apache.org/jira/browse/SOLR-9726 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Jonny Marks >Priority: Minor > Attachments: SOLR-9726.patch > > > If a query requests facets with a 'contains' check, DocValuesFacets converts > each term's ordinal to a BytesRef, does the string match and then checks > whether it has a high enough count to go in the priority queue. > This patch moves the lookup after the min check so that we don't do it for > all terms. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Created] (SOLR-9726) DocValuesFacets: move 'contains' check after 'min' check
Jonny Marks created SOLR-9726: - Summary: DocValuesFacets: move 'contains' check after 'min' check Key: SOLR-9726 URL: https://issues.apache.org/jira/browse/SOLR-9726 Project: Solr Issue Type: Task Security Level: Public (Default Security Level. Issues are Public) Reporter: Jonny Marks Priority: Minor If a query requests facets with a 'contains' check, DocValuesFacets converts each term's ordinal to a BytesRef, does the string match and then checks whether it has a high enough count to go in the priority queue. This patch moves the lookup after the min check so that we don't do it for all terms. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9442) Add json.nl=arrnvp (array of NamedValuePair) style in JSONResponseWriter
[
https://issues.apache.org/jira/browse/SOLR-9442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15621874#comment-15621874
]
Jonny Marks commented on SOLR-9442:
---
Thanks Christine, the changes are fine.
> Add json.nl=arrnvp (array of NamedValuePair) style in JSONResponseWriter
>
>
> Key: SOLR-9442
> URL: https://issues.apache.org/jira/browse/SOLR-9442
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Response Writers
>Reporter: Jonny Marks
>Assignee: Christine Poerschke
>Priority: Minor
> Attachments: SOLR-9442.patch, SOLR-9442.patch, SOLR-9442.patch
>
>
> The JSONResponseWriter class currently supports several styles of NamedList
> output format, documented on the wiki at http://wiki.apache.org/solr/SolJSON
> and in the code at
> https://github.com/apache/lucene-solr/blob/master/solr/core/src/java/org/apache/solr/response/JSONResponseWriter.java#L71-L76.
> For example the 'arrmap' style:
> {code}NamedList("a"=1,"b"=2,null=3) => [{"a":1},{"b":2},3]
> NamedList("a"=1,"bar”=“foo",null=3.4f) => [{"a":1},{"bar”:”foo"},{3.4}]{code}
> This patch creates a new style ‘arrnvp’ which is an array of named value
> pairs. For example:
> {code}NamedList("a"=1,"b"=2,null=3) =>
> [{"name":"a","int":1},{"name":"b","int":2},{"int":3}]
> NamedList("a"=1,"bar”=“foo",null=3.4f) =>
> [{"name":"a","int":1},{"name":"b","str":"foo"},{"float":3.4}]{code}
> This style maintains the type information of the values, similar to the xml
> format:
> {code:xml}
> 1
> foo
> 3.4
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-9442) Add json.nl=arrnvp (array of NamedValuePair) style in JSONResponseWriter
[
https://issues.apache.org/jira/browse/SOLR-9442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jonny Marks updated SOLR-9442:
--
Attachment: SOLR-9442.patch
Attaching full patch
> Add json.nl=arrnvp (array of NamedValuePair) style in JSONResponseWriter
>
>
> Key: SOLR-9442
> URL: https://issues.apache.org/jira/browse/SOLR-9442
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Response Writers
>Reporter: Jonny Marks
>Priority: Minor
> Attachments: SOLR-9442.patch, SOLR-9442.patch
>
>
> The JSONResponseWriter class currently supports several styles of NamedList
> output format, documented on the wiki at http://wiki.apache.org/solr/SolJSON
> and in the code at
> https://github.com/apache/lucene-solr/blob/master/solr/core/src/java/org/apache/solr/response/JSONResponseWriter.java#L71-L76.
> For example the 'arrmap' style:
> {code}NamedList("a"=1,"b"=2,null=3) => [{"a":1},{"b":2},3]
> NamedList("a"=1,"bar”=“foo",null=3.4f) => [{"a":1},{"bar”:”foo"},{3.4}]{code}
> This patch creates a new style ‘arrnvp’ which is an array of named value
> pairs. For example:
> {code}NamedList("a"=1,"b"=2,null=3) =>
> [{"name":"a","int":1},{"name":"b","int":2},{"int":3}]
> NamedList("a"=1,"bar”=“foo",null=3.4f) =>
> [{"name":"a","int":1},{"name":"b","str":"foo"},{"float":3.4}]{code}
> This style maintains the type information of the values, similar to the xml
> format:
> {code:xml}
> 1
> foo
> 3.4
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-9551) Add constructor to JSONWriter which takes wrapperFunction and namedListStyle
[ https://issues.apache.org/jira/browse/SOLR-9551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonny Marks updated SOLR-9551: -- Attachment: SOLR-9551.patch Attaching patch > Add constructor to JSONWriter which takes wrapperFunction and namedListStyle > > > Key: SOLR-9551 > URL: https://issues.apache.org/jira/browse/SOLR-9551 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Jonny Marks >Priority: Minor > Attachments: SOLR-9551.patch > > > Currently JSONWriter's constructor extracts the wrapperFunction and > namedListStyle from the request. > This patch adds a new constructor where these are passed in from > JSONResponseWriter. This will allow us to decide in JSONResponseWriter which > writer to construct based on the named list style. > There is precedent here - GeoJSONResponseWriter extracts geofield from the > request and passes it to GeoJSONWriter. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Created] (SOLR-9551) Add constructor to JSONWriter which takes wrapperFunction and namedListStyle
Jonny Marks created SOLR-9551: - Summary: Add constructor to JSONWriter which takes wrapperFunction and namedListStyle Key: SOLR-9551 URL: https://issues.apache.org/jira/browse/SOLR-9551 Project: Solr Issue Type: Improvement Security Level: Public (Default Security Level. Issues are Public) Reporter: Jonny Marks Priority: Minor Currently JSONWriter's constructor extracts the wrapperFunction and namedListStyle from the request. This patch adds a new constructor where these are passed in from JSONResponseWriter. This will allow us to decide in JSONResponseWriter which writer to construct based on the named list style. There is precedent here - GeoJSONResponseWriter extracts geofield from the request and passes it to GeoJSONWriter. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-9538) Relocate {JSON,Smile}WriterTest and TestBinaryResponseWriter to org.apache.solr.response
[
https://issues.apache.org/jira/browse/SOLR-9538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jonny Marks updated SOLR-9538:
--
Attachment: SOLR-9538.patch
Attaching patch
> Relocate {JSON,Smile}WriterTest and TestBinaryResponseWriter to
> org.apache.solr.response
>
>
> Key: SOLR-9538
> URL: https://issues.apache.org/jira/browse/SOLR-9538
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Jonny Marks
>Priority: Minor
> Attachments: SOLR-9538.patch
>
>
> JSONWriterTest, SmileWriterTest and TestBinaryResponseWriter are currently in
> the org.apache.solr.request package but the classes they test
> (JSONResponseWriter, SmileWriter, BinaryResponseWriter) are in the
> org.apache.solr.response package.
> This patch moves the tests to the response package.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Created] (SOLR-9538) Relocate {JSON,Smile}WriterTest and TestBinaryResponseWriter to org.apache.solr.response
Jonny Marks created SOLR-9538:
-
Summary: Relocate {JSON,Smile}WriterTest and
TestBinaryResponseWriter to org.apache.solr.response
Key: SOLR-9538
URL: https://issues.apache.org/jira/browse/SOLR-9538
Project: Solr
Issue Type: Improvement
Security Level: Public (Default Security Level. Issues are Public)
Reporter: Jonny Marks
Priority: Minor
JSONWriterTest, SmileWriterTest and TestBinaryResponseWriter are currently in
the org.apache.solr.request package but the classes they test
(JSONResponseWriter, SmileWriter, BinaryResponseWriter) are in the
org.apache.solr.response package.
This patch moves the tests to the response package.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Issue Comment Deleted] (SOLR-9442) Add json.nl=arrnvp (array of NamedValuePair) style in JSONResponseWriter
[
https://issues.apache.org/jira/browse/SOLR-9442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jonny Marks updated SOLR-9442:
--
Comment: was deleted
(was: Patch)
> Add json.nl=arrnvp (array of NamedValuePair) style in JSONResponseWriter
>
>
> Key: SOLR-9442
> URL: https://issues.apache.org/jira/browse/SOLR-9442
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Response Writers
>Reporter: Jonny Marks
>Priority: Minor
> Attachments: SOLR-9442.patch
>
>
> The JSONResponseWriter class currently supports several styles of NamedList
> output format, documented on the wiki at http://wiki.apache.org/solr/SolJSON
> and in the code at
> https://github.com/apache/lucene-solr/blob/master/solr/core/src/java/org/apache/solr/response/JSONResponseWriter.java#L71-L76.
> For example the 'arrmap' style:
> {code}NamedList("a"=1,"b"=2,null=3) => [{"a":1},{"b":2},3]
> NamedList("a"=1,"bar”=“foo",null=3.4f) => [{"a":1},{"bar”:”foo"},{3.4}]{code}
> This patch creates a new style ‘arrnvp’ which is an array of named value
> pairs. For example:
> {code}NamedList("a"=1,"b"=2,null=3) =>
> [{"name":"a","int":1},{"name":"b","int":2},{"int":3}]
> NamedList("a"=1,"bar”=“foo",null=3.4f) =>
> [{"name":"a","int":1},{"name":"b","str":"foo"},{"float":3.4}]{code}
> This style maintains the type information of the values, similar to the xml
> format:
> {code:xml}
> 1
> foo
> 3.4
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-9442) Add json.nl=arrnvp (array of NamedValuePair) style in JSONResponseWriter
[
https://issues.apache.org/jira/browse/SOLR-9442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jonny Marks updated SOLR-9442:
--
Attachment: SOLR-9442.patch
Patch
> Add json.nl=arrnvp (array of NamedValuePair) style in JSONResponseWriter
>
>
> Key: SOLR-9442
> URL: https://issues.apache.org/jira/browse/SOLR-9442
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Response Writers
>Reporter: Jonny Marks
>Priority: Minor
> Attachments: SOLR-9442.patch
>
>
> The JSONResponseWriter class currently supports several styles of NamedList
> output format, documented on the wiki at http://wiki.apache.org/solr/SolJSON
> and in the code at
> https://github.com/apache/lucene-solr/blob/master/solr/core/src/java/org/apache/solr/response/JSONResponseWriter.java#L71-L76.
> For example the 'arrmap' style:
> {code}NamedList("a"=1,"b"=2,null=3) => [{"a":1},{"b":2},3]
> NamedList("a"=1,"bar”=“foo",null=3.4f) => [{"a":1},{"bar”:”foo"},{3.4}]{code}
> This patch creates a new style ‘arrnvp’ which is an array of named value
> pairs. For example:
> {code}NamedList("a"=1,"b"=2,null=3) =>
> [{"name":"a","int":1},{"name":"b","int":2},{"int":3}]
> NamedList("a"=1,"bar”=“foo",null=3.4f) =>
> [{"name":"a","int":1},{"name":"b","str":"foo"},{"float":3.4}]{code}
> This style maintains the type information of the values, similar to the xml
> format:
> {code:xml}
> 1
> foo
> 3.4
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Created] (SOLR-9442) Add json.nl=arrnvp (array of NamedValuePair) style in JSONResponseWriter
Jonny Marks created SOLR-9442:
-
Summary: Add json.nl=arrnvp (array of NamedValuePair) style in
JSONResponseWriter
Key: SOLR-9442
URL: https://issues.apache.org/jira/browse/SOLR-9442
Project: Solr
Issue Type: Improvement
Security Level: Public (Default Security Level. Issues are Public)
Components: Response Writers
Reporter: Jonny Marks
Priority: Minor
The JSONResponseWriter class currently supports several styles of NamedList
output format, documented on the wiki at http://wiki.apache.org/solr/SolJSON
and in the code at
https://github.com/apache/lucene-solr/blob/master/solr/core/src/java/org/apache/solr/response/JSONResponseWriter.java#L71-L76.
For example the 'arrmap' style:
{code}NamedList("a"=1,"b"=2,null=3) => [{"a":1},{"b":2},3]
NamedList("a"=1,"bar”=“foo",null=3.4f) => [{"a":1},{"bar”:”foo"},{3.4}]{code}
This patch creates a new style ‘arrnvp’ which is an array of named value pairs.
For example:
{code}NamedList("a"=1,"b"=2,null=3) =>
[{"name":"a","int":1},{"name":"b","int":2},{"int":3}]
NamedList("a"=1,"bar”=“foo",null=3.4f) =>
[{"name":"a","int":1},{"name":"b","str":"foo"},{"float":3.4}]{code}
This style maintains the type information of the values, similar to the xml
format:
{code:xml}
1
foo
3.4
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
