[jira] [Commented] (LUCENE-7933) LongBistSet can't have Long size

2017-09-01 Thread Won Jonghoon (JIRA) 

[ 
https://issues.apache.org/jira/browse/LUCENE-7933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1615#comment-1615
 ] 

Won Jonghoon commented on LUCENE-7933:
--

Thanks apache LongBitset people ^^






- 원본 메일 -


보낸사람: Michael McCandless (JIRA) 
받는사람: 
날짜: 17.09.01 22:17 GMT +0900
제목: [jira] [Resolved] (LUCENE-7933) LongBistSet can't have Long size


 [ 
[1]https://issues.apache.org/jira/browse/LUCENE-7933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael McCandless resolved LUCENE-7933.

   Resolution: Fixed
Fix Version/s: 7.1
   master (8.0)

Thanks [~dreampk00]!




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)





[1] 
https://issues.apache.org/jira/browse/LUCENE-7933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
[2] https://issues.apache.org/jira/browse/LUCENE-7933

[1] 
https://issues.apache.org/jira/browse/LUCENE-7933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
[2] https://issues.apache.org/jira/browse/LUCENE-7933


> LongBistSet can't have Long size
> 
>
> Key: LUCENE-7933
> URL: https://issues.apache.org/jira/browse/LUCENE-7933
> Project: Lucene - Core
>  Issue Type: Bug
>Affects Versions: 6.6
>Reporter: Won Jonghoon
>Priority: Trivial
> Fix For: master (8.0), 7.1
>
> Attachments: LUCENE-7933.patch
>
>
> private final long[] bits; // Array of longs holding the bits 
> ===> bits.length is small for bit number having Long.MAX
> so you can not call "LongBitSet.set(Long.MAX-1)"



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (LUCENE-7933) LongBistSet can't have Long size

2017-08-20 Thread Won Jonghoon (JIRA) 

[ 
https://issues.apache.org/jira/browse/LUCENE-7933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16134402#comment-16134402
 ] 

Won Jonghoon commented on LUCENE-7933:
--

I agree it.


It just seems to add size checking logic.








- 원본 메일 -


보낸사람: Michael McCandless (JIRA) 
받는사람: 
날짜: 17.08.20 18:46 GMT +0900
제목: [jira] [Commented] (LUCENE-7933) LongBistSet can't have Long size


[ 
[1]https://issues.apache.org/jira/browse/LUCENE-7933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16134359#comment-16134359
 ] 

Michael McCandless commented on LUCENE-7933:


Let's just add a check in the ctor and throw {{IllegalArgumentException}} if 
the request {{numBits}} is too large?




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)





[1] 
https://issues.apache.org/jira/browse/LUCENE-7933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16134359#comment-16134359
[2] https://issues.apache.org/jira/browse/LUCENE-7933

[1] 
https://issues.apache.org/jira/browse/LUCENE-7933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16134359#comment-16134359
[2] https://issues.apache.org/jira/browse/LUCENE-7933


> LongBistSet can't have Long size
> 
>
> Key: LUCENE-7933
> URL: https://issues.apache.org/jira/browse/LUCENE-7933
> Project: Lucene - Core
>  Issue Type: Bug
>Affects Versions: 6.6
>Reporter: Won Jonghoon
>Priority: Trivial
>
> private final long[] bits; // Array of longs holding the bits 
> ===> bits.length is small for bit number having Long.MAX
> so you can not call "LongBitSet.set(Long.MAX-1)"



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (LUCENE-7933) LongBistSet can't have Long size

2017-08-19 Thread Won Jonghoon (JIRA) 

[ 
https://issues.apache.org/jira/browse/LUCENE-7933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16134306#comment-16134306
 ] 

Won Jonghoon commented on LUCENE-7933:
--

  You say "This class is for supporting a contiguous (simple) bitset up to 
64*2^31 bits in size."

but it doesn't check max size.




LongBistSet maxLongSizeLongBistSet = new LongBistSet(Long.MAX); ===> no error 
because no size check, numBits can have the value that is greater than 64*2^31. 
example  (2^63 - 1)





I think LongBitSet class is for supporting a contiguous (simple) bitset up to 
Long.MAX bits in size.

Well I will make new class using BitSet class  that is a java stand API.





- 원본 메일 -


보낸사람: Yonik Seeley (JIRA) 
받는사람: 
날짜: 17.08.20 12:59 GMT +0900
제목: [jira] [Commented] (LUCENE-7933) LongBistSet can't have Long size


[ 
[1]https://issues.apache.org/jira/browse/LUCENE-7933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16134299#comment-16134299
 ] 

Yonik Seeley commented on LUCENE-7933:
--

This class is for supporting a contiguous (simple) bitset up to 64*2^31 bits in 
size.
It's not clear to me where you think the bug is, but perhaps you could provide 
a patch that would clear it up?




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)





[1] 
https://issues.apache.org/jira/browse/LUCENE-7933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16134299#comment-16134299
[2] https://issues.apache.org/jira/browse/LUCENE-7933

[1] 
https://issues.apache.org/jira/browse/LUCENE-7933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16134299#comment-16134299
[2] https://issues.apache.org/jira/browse/LUCENE-7933


> LongBistSet can't have Long size
> 
>
> Key: LUCENE-7933
> URL: https://issues.apache.org/jira/browse/LUCENE-7933
> Project: Lucene - Core
>  Issue Type: Bug
>Affects Versions: 6.6
>Reporter: Won Jonghoon
>Priority: Trivial
>
> private final long[] bits; // Array of longs holding the bits 
> ===> bits.length is small for bit number having Long.MAX
> so you can not call "LongBitSet.set(Long.MAX-1)"



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Created] (LUCENE-7933) LongBistSet can't have Long size

2017-08-19 Thread Won Jonghoon (JIRA) 
Won Jonghoon created LUCENE-7933:


 Summary: LongBistSet can't have Long size
 Key: LUCENE-7933
 URL: https://issues.apache.org/jira/browse/LUCENE-7933
 Project: Lucene - Core
  Issue Type: Bug
Affects Versions: 6.6
Reporter: Won Jonghoon
Priority: Trivial


private final long[] bits; // Array of longs holding the bits 
===> bits.length is small for bit number having Long.MAX
so you can not call "LongBitSet.set(Long.MAX-1)"



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org