[GitHub] lucene-solr pull request #:

[arjenm]

Github user arjenm commented on the pull request:


https://github.com/apache/lucene-solr/commit/962313b83ba9c69379e1f84dffc881a361713ce9#commitcomment-26095567
  
In solr/core/src/java/org/apache/solr/util/SolrPluginUtils.java:
In solr/core/src/java/org/apache/solr/util/SolrPluginUtils.java on line 731:
Unfortunately, since I don't have the lucene-solr project checked out/set 
up, submitting a proper patch is a bit too large of an effort. Luckily the 
change I made was really small, so hopefully you can do it? :)

I can live with missing the chance of the honor of submitting a patch to 
Lucene ;)

In my first comment, I've mentioned the fix, but here it is in a bit more 
detail:
Replace this line in 
SolrPluginUtils#flattenBooleanQuery(BooleanQuery.Builder, BooleanQuery, float)

https://github.com/apache/lucene-solr/blob/187849f9b67ba6b7e6c2d06cc25359bf53b2ce9f/solr/core/src/java/org/apache/solr/util/SolrPluginUtils.java#L747

With the properly formatted version of this:
`if (boost != 1f) {
   to.add(new BoostQuery(cq, boost), clause.getOccur());
} else {
  to.add(clause);
}`



---

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[GitHub] lucene-solr pull request #:

[arjenm]

Github user arjenm commented on the pull request:


https://github.com/apache/lucene-solr/commit/962313b83ba9c69379e1f84dffc881a361713ce9#commitcomment-26093062
  
In solr/core/src/java/org/apache/solr/util/SolrPluginUtils.java:
In solr/core/src/java/org/apache/solr/util/SolrPluginUtils.java on line 731:
@jpountz What I tried to tell, but appearantly failed, is: the boost-float 
is collected and adjusted via the recursion, but its value is not used.

So what was a "increase boost with parent's boost" now is a "collect parent 
boost, ignore it". Or in other terms, the result of this method is exactly the 
same when the boost-float is removed from it.

I'd expect this method should re-introduce that boost-value somewhere in 
the new flattened query.


---

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[GitHub] lucene-solr pull request #:

[arjenm]

Github user arjenm commented on the pull request:


https://github.com/apache/lucene-solr/commit/962313b83ba9c69379e1f84dffc881a361713ce9#commitcomment-25899672
  
In solr/core/src/java/org/apache/solr/util/SolrPluginUtils.java:
In solr/core/src/java/org/apache/solr/util/SolrPluginUtils.java on line 731:
Its a bit late, but I had a old copy of this method and was curious how I'd 
to change this... But shouldn't it do _something_ with that boost-parameter 
other than adjusting it recursively?

In my copy I have this (although in multi-line):
`if (boost != 1.0f) {
   to.add(new BoostQuery(cq, boost), clause.getOccur());
} else {
  to.add(clause);
}`


---

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org