ErickErickson commented on issue #665: Fixes SOLR-11841, SOLR-13331, SOLR-13347
URL: https://github.com/apache/lucene-solr/pull/665#issuecomment-492758246
There are two things that might help with the arbitrary change issue:
1> On the reviewing side, In InteliJ, I can choose an option “ignore all
whitespace”, I’m sure other tools have similar. Doesn’t help with final and the
like of course.
2> Again in IntelliJ and (presumably) other tools I can set the autoformat
to only reformat changed lines rather than entire files.
FWIW,
Erick
> On May 15, 2019, at 6:49 AM, David Smiley wrote:
>
> It'd help to review your changes if you made fewer arbitrary changes, like
adding 'final' and changing indentation of javadocs that were fine as they were.
> Also, it'd help to summarize why 3 different issues are being fixed in one
PR. Might be just fine but please add info/context to make reviewer's job
either or you may not get a review at all.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub, or mute the thread.
>
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
