[GitHub] [lucene-solr] atris commented on issue #796: LUCENE-8927: Set.copyOf and Set.of instead of Collections.unmodifiabl…
atris commented on issue #796: LUCENE-8927: Set.copyOf and Set.of instead of Collections.unmodifiabl… URL: https://github.com/apache/lucene-solr/pull/796#issuecomment-513296065 Solr changes are coming in a separate PR since I did not want to overlap and amplify things in a single PR. We can explore further changes in subsequent PRs. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] [lucene-solr] atris commented on issue #796: LUCENE-8927: Set.copyOf and Set.of instead of Collections.unmodifiabl…
atris commented on issue #796: LUCENE-8927: Set.copyOf and Set.of instead of Collections.unmodifiabl… URL: https://github.com/apache/lucene-solr/pull/796#issuecomment-513171204 > I think you forgot to remove `createElementNameSet`? Oops, sorry. Updated This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] [lucene-solr] atris commented on issue #796: LUCENE-8927: Set.copyOf and Set.of instead of Collections.unmodifiabl…
atris commented on issue #796: LUCENE-8927: Set.copyOf and Set.of instead of Collections.unmodifiabl… URL: https://github.com/apache/lucene-solr/pull/796#issuecomment-513165474 @jpountz Thanks, updated the PR This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] [lucene-solr] atris commented on issue #796: LUCENE-8927: Set.copyOf and Set.of instead of Collections.unmodifiabl…
atris commented on issue #796: LUCENE-8927: Set.copyOf and Set.of instead of Collections.unmodifiabl… URL: https://github.com/apache/lucene-solr/pull/796#issuecomment-513139699 cc @jpountz This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
