[GitHub] [lucene-solr] dweiss commented on issue #657: LUCENE-8781: FST direct arc addressing

[GitBox]

dweiss commented on issue #657: LUCENE-8781: FST direct arc addressing
URL: https://github.com/apache/lucene-solr/pull/657#issuecomment-489558774
 
 
   Committed to master, thanks Mike!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[GitHub] [lucene-solr] dweiss commented on issue #657: LUCENE-8781: FST direct arc addressing

[GitBox]

dweiss commented on issue #657: LUCENE-8781: FST direct arc addressing
URL: https://github.com/apache/lucene-solr/pull/657#issuecomment-489445325
 
 
   It all looks good, Mike. There is one remaining thing -- to add a 
changes.txt entry in Lucene (under "improvements" section, I think). Add 
yourself as author of the patch, please. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[GitHub] [lucene-solr] dweiss commented on issue #657: LUCENE-8781: FST direct arc addressing

[GitBox]

dweiss commented on issue #657: LUCENE-8781: FST direct arc addressing
URL: https://github.com/apache/lucene-solr/pull/657#issuecomment-489203649
 
 
   Thanks Mike. I'll take a look and will get back to you.
   
   On Fri, May 3, 2019 at 8:46 PM Michael Sokolov 
   wrote:
   
   > *@msokolov* commented on this pull request.
   > --
   >
   > In
   > 
lucene/codecs/src/java/org/apache/lucene/codecs/blocktreeords/OrdsSegmentTermsEnum.java
   > :
   >
   > > @@ -1082,12 +1082,14 @@ private InputOutput getByOutput(long targetOrd) 
throws IOException {
   >if (FST.targetHasArcs(arc)) {
   >  // System.out.println("  targetHasArcs");
   >  result.grow(1+upto);
   > -
   > +if (arc.target < 0 || arc.target > Integer.MAX_VALUE) {
   >
   > @dweiss  I think I addressed your comments and
   > this is ready to be committed. If you agree, would you be able to help with
   > that (I'm not a committer, so I need help!)?
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > ,
   > or mute the thread
   > 

   > .
   >
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org