[GitHub] [lucene-solr] mocobeta commented on issue #782: LUCENE-8911: Backport LUCENE-8778 (improved analysis SPI name handling) to 8.x
mocobeta commented on issue #782: LUCENE-8911: Backport LUCENE-8778 (improved analysis SPI name handling) to 8.x URL: https://github.com/apache/lucene-solr/pull/782#issuecomment-511179210 Hi @uschindler, the branch is ready to merge, I think. Could you please review the changes in `AnalysisSPILoader` and its tests? All other parts are identical to the master branch. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] [lucene-solr] mocobeta commented on issue #782: LUCENE-8911: Backport LUCENE-8778 (improved analysis SPI name handling) to 8.x
mocobeta commented on issue #782: LUCENE-8911: Backport LUCENE-8778 (improved analysis SPI name handling) to 8.x URL: https://github.com/apache/lucene-solr/pull/782#issuecomment-511109268 In addition to backporting LUCENE-8778 and succeeding commits, I slightly changed `AnalysisSPILoader` to emulate legacy look-up algorithm. I also added test cases for custom factories which does not have the NAME constants, or have the NAME constants but they are not same as legacy names. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
