[GitHub] [lucene-solr] msokolov commented on a change in pull request #809: LUCENE-8933: Validate JapaneseTokenizer user dictionary entry
msokolov commented on a change in pull request #809: LUCENE-8933: Validate
JapaneseTokenizer user dictionary entry
URL: https://github.com/apache/lucene-solr/pull/809#discussion_r307976589
##
File path:
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/dict/UserDictionary.java
##
@@ -104,6 +104,8 @@ public int compare(String[] left, String[] right) {
long ord = 0;
for (String[] values : featureEntries) {
+ String surface = values[0].replaceAll(" ", "");
Review comment:
ah never mind my question, I see from the email discussion that is the case:
we shouldn't allow this kind of entry
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] [lucene-solr] msokolov commented on a change in pull request #809: LUCENE-8933: Validate JapaneseTokenizer user dictionary entry
msokolov commented on a change in pull request #809: LUCENE-8933: Validate
JapaneseTokenizer user dictionary entry
URL: https://github.com/apache/lucene-solr/pull/809#discussion_r307976466
##
File path:
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/dict/UserDictionary.java
##
@@ -104,6 +104,8 @@ public int compare(String[] left, String[] right) {
long ord = 0;
for (String[] values : featureEntries) {
+ String surface = values[0].replaceAll(" ", "");
Review comment:
maybe replace all white space here (ie including tabs) by using \s?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
