[GitHub] [lucene-solr] msokolov edited a comment on issue #753: LUCENE-8895: switch all FST usage to enable array-with-gaps encoding

2019-07-01 Thread GitBox
msokolov edited a comment on issue #753: LUCENE-8895: switch all FST usage to 
enable array-with-gaps encoding
URL: https://github.com/apache/lucene-solr/pull/753#issuecomment-507295712
 
 
   Based on feedback so far, this looks like a reasonable step. Also note 
latest commit removes unused `Util.getByOutput()` and related tests.
   
   By the way, in addition to test and precommit, I also ran `ant test  
-Dtests.postingsformat=FST50` since that uncovered some issues previously.
   
   I'll push in a couple of days if there are no further comments. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[GitHub] [lucene-solr] msokolov edited a comment on issue #753: LUCENE-8895: switch all FST usage to enable array-with-gaps encoding

2019-07-01 Thread GitBox
msokolov edited a comment on issue #753: LUCENE-8895: switch all FST usage to 
enable array-with-gaps encoding
URL: https://github.com/apache/lucene-solr/pull/753#issuecomment-507295712
 
 
   Based on feedback so far, this looks like a reasonable step. Also note 
latest commit removes unused `Util.getByOutput()` and related tests.
   
   By the way, in addition to test and precommit, I also ran {{ant test  
-Dtests.postingsformat=FST50}} since that uncovered some issues previously.
   
   I'll push in a couple of days if there are no further comments. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org