[GitHub] [lucene-solr] noblepaul commented on a change in pull request #666: SOLR-13437: fork noggit code into Solr
noblepaul commented on a change in pull request #666: SOLR-13437: fork noggit code into Solr URL: https://github.com/apache/lucene-solr/pull/666#discussion_r284491919 ## File path: solr/solrj/src/java/org/apache/solr/common/json/ObjectBuilder.java ## @@ -0,0 +1,166 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more Review comment: done This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] [lucene-solr] noblepaul commented on a change in pull request #666: SOLR-13437: fork noggit code into Solr
noblepaul commented on a change in pull request #666: SOLR-13437: fork noggit code into Solr URL: https://github.com/apache/lucene-solr/pull/666#discussion_r283984130 ## File path: solr/solrj/src/java/org/apache/solr/common/json/ObjectBuilder.java ## @@ -0,0 +1,166 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more Review comment: I'm not clear what else needs to be done This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] [lucene-solr] noblepaul commented on a change in pull request #666: SOLR-13437: fork noggit code into Solr
noblepaul commented on a change in pull request #666: SOLR-13437: fork noggit code into Solr URL: https://github.com/apache/lucene-solr/pull/666#discussion_r283630028 ## File path: solr/solrj/src/java/org/apache/solr/common/json/ObjectBuilder.java ## @@ -0,0 +1,166 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more Review comment: ASL let's you modify content , yeah, we can add a credit in the NOTICE.txt This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] [lucene-solr] noblepaul commented on a change in pull request #666: SOLR-13437: fork noggit code into Solr
noblepaul commented on a change in pull request #666: SOLR-13437: fork noggit code into Solr URL: https://github.com/apache/lucene-solr/pull/666#discussion_r281940354 ## File path: lucene/tools/forbiddenApis/solr.txt ## @@ -55,3 +55,8 @@ com.google.common.base.Preconditions#checkNotNull(java.lang.Object,java.lang.Obj @defaultMessage Use methods in java.util.Comparator instead com.google.common.collect.Ordering +@defaultMessage Use corresponding classes in package org.apache.solr.common.json instead Review comment: sure. thanks . I didn't know it was possible This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
