[GitHub] lucene-solr pull request: solr: add buildAndRunCollectorChain meth...
Github user cpoerschke closed the pull request at: https://github.com/apache/lucene-solr/pull/48 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] lucene-solr pull request: solr: add buildAndRunCollectorChain meth...
Github user cpoerschke commented on the pull request: https://github.com/apache/lucene-solr/pull/48#issuecomment-43537862 Commit above adds similar buildAndRunCollectorChain method to Grouping.java to reduce code duplication there too a little. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] lucene-solr pull request: solr: add buildAndRunCollectorChain meth...
Github user cpoerschke commented on the pull request: https://github.com/apache/lucene-solr/pull/48#issuecomment-43208284 Extra commit above relates to [comments] on SOLR-6067 ticket. [comments]: https://issues.apache.org/jira/browse/SOLR-6067?focusedCommentId=13998594page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13998594 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] lucene-solr pull request: solr: add buildAndRunCollectorChain meth...
GitHub user cpoerschke opened a pull request: https://github.com/apache/lucene-solr/pull/48 solr: add buildAndRunCollectorChain method to reduce code duplication Adds buildAndRunCollectorChain method to reduce code duplication in SolrIndexSearcher class. No SOLR JIRA ticket opened as yet. You can merge this pull request into a Git repository by running: $ git pull https://github.com/bloomberg/lucene-solr branch_4x-SolrIndexSearcher-buildAndRunCollectorChain Alternatively you can review and apply these changes as the patch at: https://github.com/apache/lucene-solr/pull/48.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #48 commit f2bd4b835a3da3e0a3c8bd88cf4fab44ce403c0f Author: Christine Poerschke cpoersc...@bloomberg.net Date: 2014-05-08T13:23:32Z solr: add buildAndRunCollectorChain method to reduce code duplication in SolrIndexSearcher --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] lucene-solr pull request: solr: add buildAndRunCollectorChain meth...
Github user cpoerschke commented on the pull request: https://github.com/apache/lucene-solr/pull/48#issuecomment-42980446 https://issues.apache.org/jira/i#browse/SOLR-6067 now opened for this change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org