[GitHub] lucene-solr pull request #292: Removed extra whitespace

2018-10-02 Thread leggiero
Github user leggiero commented on a diff in the pull request:

https://github.com/apache/lucene-solr/pull/292#discussion_r222080579
  
--- Diff: solr/example/example-DIH/solr/solr/conf/solr-data-config.xml ---
@@ -18,7 +18,7 @@
 
   
 http://127.0.0.1:8983/solr/db "
+url="http://127.0.0.1:8983/solr/db";
--- End diff --

Thanks for the feedback. Can this merged to be included in the next release?


---

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[GitHub] lucene-solr pull request #292: Removed extra whitespace

2018-02-11 Thread diegoceccarelli
Github user diegoceccarelli commented on a diff in the pull request:

https://github.com/apache/lucene-solr/pull/292#discussion_r167441568
  
--- Diff: solr/example/example-DIH/solr/solr/conf/solr-data-config.xml ---
@@ -18,7 +18,7 @@
 
   
 http://127.0.0.1:8983/solr/db "
+url="http://127.0.0.1:8983/solr/db";
--- End diff --

This looks good and makes sense to me. 


---

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[GitHub] lucene-solr pull request #292: Removed extra whitespace

2017-12-17 Thread leggiero
GitHub user leggiero opened a pull request:

https://github.com/apache/lucene-solr/pull/292

Removed extra whitespace



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/leggiero/lucene-solr patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/lucene-solr/pull/292.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #292


commit ae7025358e7fa5f448105de5e453e2644143e04e
Author: Eduardo Leggiero 
Date:   2017-12-17T16:49:51Z

Removed extra whitespace




---

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org