[GitHub] risdenk commented on a change in pull request #558: SOLR-11763: Upgrade Guava to 25.1-jre

2019-02-19 Thread GitBox 
risdenk commented on a change in pull request #558: SOLR-11763: Upgrade Guava 
to 25.1-jre
URL: https://github.com/apache/lucene-solr/pull/558#discussion_r258254757
 
 

 ##
 File path: solr/core/ivy.xml
 ##
 @@ -133,6 +133,7 @@
 
 
 
+
 
 Review comment:
   Addressed the license/notice.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[GitHub] risdenk commented on a change in pull request #558: SOLR-11763: Upgrade Guava to 25.1-jre

2019-02-02 Thread GitBox 
risdenk commented on a change in pull request #558: SOLR-11763: Upgrade Guava 
to 25.1-jre
URL: https://github.com/apache/lucene-solr/pull/558#discussion_r253282735
 
 

 ##
 File path: lucene/ivy-versions.properties
 ##
 @@ -116,7 +117,7 @@ org.apache.calcite.version = 1.13.0
 /org.apache.commons/commons-math3 = 3.6.1
 /org.apache.commons/commons-text = 1.4
 
-org.apache.curator.version = 2.8.0
+org.apache.curator.version = 2.13.0
 
 Review comment:
   This version shades guava - don't end up with Guava issues down the line and 
matches the Hadoop 3.2.0 curator version.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[GitHub] risdenk commented on a change in pull request #558: SOLR-11763: Upgrade Guava to 25.1-jre

2019-02-02 Thread GitBox 
risdenk commented on a change in pull request #558: SOLR-11763: Upgrade Guava 
to 25.1-jre
URL: https://github.com/apache/lucene-solr/pull/558#discussion_r253282727
 
 

 ##
 File path: lucene/ivy-versions.properties
 ##
 @@ -24,14 +24,15 @@ com.fasterxml.jackson.core.version = 2.9.6
 /com.github.ben-manes.caffeine/caffeine = 2.4.0
 /com.github.virtuald/curvesapi = 1.04
 
-/com.google.guava/guava = 14.0.1
+/com.google.guava/guava = 25.1-jre
 /com.google.protobuf/protobuf-java = 3.6.1
 /com.google.re2j/re2j = 1.2
 /com.googlecode.juniversalchardet/juniversalchardet = 1.0.3
 /com.googlecode.mp4parser/isoparser = 1.1.22
 /com.healthmarketscience.jackcess/jackcess = 2.1.12
 /com.healthmarketscience.jackcess/jackcess-encrypt = 2.1.4
 /com.ibm.icu/icu4j = 62.1
+/com.jayway.jsonpath/json-path = 2.4.0
 
 Review comment:
   Needed by calcite


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[GitHub] risdenk commented on a change in pull request #558: SOLR-11763: Upgrade Guava to 25.1-jre

2019-02-02 Thread GitBox 
risdenk commented on a change in pull request #558: SOLR-11763: Upgrade Guava 
to 25.1-jre
URL: https://github.com/apache/lucene-solr/pull/558#discussion_r253282730
 
 

 ##
 File path: lucene/ivy-versions.properties
 ##
 @@ -222,7 +223,7 @@ org.carrot2.morfologik.version = 2.1.5
 
 /org.ccil.cowan.tagsoup/tagsoup = 1.2.1
 
-org.codehaus.janino.version = 2.7.6
+org.codehaus.janino.version = 3.0.9
 
 Review comment:
   needed by calcite


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[GitHub] risdenk commented on a change in pull request #558: SOLR-11763: Upgrade Guava to 25.1-jre

2019-02-02 Thread GitBox 
risdenk commented on a change in pull request #558: SOLR-11763: Upgrade Guava 
to 25.1-jre
URL: https://github.com/apache/lucene-solr/pull/558#discussion_r253279691
 
 

 ##
 File path: solr/core/ivy.xml
 ##
 @@ -133,6 +133,7 @@
 
 
 
+
 
 Review comment:
   Need to address precommit failures from this. Check license/notice. Fixed 
initial test failures about class not found though. Will get to later tonight.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[GitHub] risdenk commented on a change in pull request #558: SOLR-11763: Upgrade Guava to 25.1-jre

2019-02-02 Thread GitBox 
risdenk commented on a change in pull request #558: SOLR-11763: Upgrade Guava 
to 25.1-jre
URL: https://github.com/apache/lucene-solr/pull/558#discussion_r253279561
 
 

 ##
 File path: solr/core/ivy.xml
 ##
 @@ -133,6 +133,7 @@
 
 
 
+
 
 Review comment:
   Needed for Calcite upgrade


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[GitHub] risdenk commented on a change in pull request #558: SOLR-11763: Upgrade Guava to 25.1-jre

2019-02-02 Thread GitBox 
risdenk commented on a change in pull request #558: SOLR-11763: Upgrade Guava 
to 25.1-jre
URL: https://github.com/apache/lucene-solr/pull/558#discussion_r253279179
 
 

 ##
 File path: lucene/ivy-versions.properties
 ##
 @@ -24,7 +24,7 @@ com.fasterxml.jackson.core.version = 2.9.6
 /com.github.ben-manes.caffeine/caffeine = 2.4.0
 /com.github.virtuald/curvesapi = 1.04
 
-/com.google.guava/guava = 14.0.1
+/com.google.guava/guava = 25.1-jre
 
 Review comment:
   Based on experience in KNOX-1611 found that 26.0-jre+ broke backwards 
compatibility for things Hadoop in integration tests required.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[GitHub] risdenk commented on a change in pull request #558: SOLR-11763: Upgrade Guava to 25.1-jre

2019-02-02 Thread GitBox 
risdenk commented on a change in pull request #558: SOLR-11763: Upgrade Guava 
to 25.1-jre
URL: https://github.com/apache/lucene-solr/pull/558#discussion_r253279211
 
 

 ##
 File path: 
solr/core/src/java/org/apache/solr/cloud/api/collections/TimeRoutedAlias.java
 ##
 @@ -36,7 +36,7 @@
 import java.util.function.Predicate;
 import java.util.function.Supplier;
 
-import com.google.common.base.Objects;
+import com.google.common.base.MoreObjects;
 
 Review comment:
   Guava changed `Objects` -> `MoreObjects`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[GitHub] risdenk commented on a change in pull request #558: SOLR-11763: Upgrade Guava to 25.1-jre

2019-02-02 Thread GitBox 
risdenk commented on a change in pull request #558: SOLR-11763: Upgrade Guava 
to 25.1-jre
URL: https://github.com/apache/lucene-solr/pull/558#discussion_r253279205
 
 

 ##
 File path: lucene/ivy-versions.properties
 ##
 @@ -101,10 +101,10 @@ net.thisptr.version = 0.0.8
 
 /org.apache.ant/ant = 1.8.2
 
-org.apache.calcite.avatica.version = 1.10.0
+org.apache.calcite.avatica.version = 1.13.0
 /org.apache.calcite.avatica/avatica-core = 
${org.apache.calcite.avatica.version}
 
-org.apache.calcite.version = 1.13.0
+org.apache.calcite.version = 1.18.0
 
 Review comment:
   Calcite uses Guava and gives ability to use latest version here. Calcite 
1.16.0 requires later than Guava 19. `calcite.avatica.version` and 
`janino.version` are upgraded accordingly.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org