[Lucene.Net] [jira] [Issue Comment Edited] (LUCENENET-437) Port Contrib.Shingle from Java

2011-07-18 Thread Digy (JIRA)

[ 
https://issues.apache.org/jira/browse/LUCENENET-437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13067389#comment-13067389
 ] 

Digy edited comment on LUCENENET-437 at 7/18/11 11:28 PM:
--

bq. It ensures equality, but does not ensure inequality.
Sorry but I must object again.
It ensures inequality, but doesn't ensure equality.(if hashcodes are not equal 
objects are not also, but having the same hashcode doesn't say anything about 
equality)



  was (Author: digydigy):
bq. It ensures equality, but does not ensure inequality.
Sorry but I must object again.
It ensures inequality, but doesn't ensure equality.


  
 Port Contrib.Shingle from Java
 --

 Key: LUCENENET-437
 URL: https://issues.apache.org/jira/browse/LUCENENET-437
 Project: Lucene.Net
  Issue Type: Task
  Components: Lucene.Net Contrib, Lucene.Net Test
Affects Versions: Lucene.Net 2.9.4, Lucene.Net 2.9.4g
Reporter: Troy Howard
Assignee: Troy Howard
Priority: Minor
 Fix For: Lucene.Net 2.9.4, Lucene.Net 2.9.4g


 Port Contrib.Shingle from Java

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[Lucene.Net] [jira] [Issue Comment Edited] (LUCENENET-437) Port Contrib.Shingle from Java

2011-07-18 Thread Troy Howard (JIRA)

[ 
https://issues.apache.org/jira/browse/LUCENENET-437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13067328#comment-13067328
 ] 

Troy Howard edited comment on LUCENENET-437 at 7/18/11 9:56 PM:


I assume you're referring to the issue found here: 

http://blogs.msdn.com/b/ericlippert/archive/2011/07/12/what-curious-property-does-this-string-have.aspx

I am aware of that issue.. however the implementation in ListComparer is 
exactly the behaviour of Java. I copied the implementation straight from the 
Java docs.

http://download.oracle.com/javase/1.4.2/docs/api/java/util/List.html#hashCode()

The issue you're describing is more of a problem with the .NET implementation 
of GetHashcode() rather than the correctness of using hashcode for comparison. 

See (for implementation): http://www.dotnetperls.com/gethashcode

Anyhow, I'll update this to use SupportClass.EquatableList since it allows the 
code to pass unit tests, and also not have that particular problem.

  was (Author: thoward37):
I assume you're referring to the issue found here: 

http://blogs.msdn.com/b/ericlippert/archive/2011/07/12/what-curious-property-does-this-string-have.aspx
  
 Port Contrib.Shingle from Java
 --

 Key: LUCENENET-437
 URL: https://issues.apache.org/jira/browse/LUCENENET-437
 Project: Lucene.Net
  Issue Type: Task
  Components: Lucene.Net Contrib, Lucene.Net Test
Affects Versions: Lucene.Net 2.9.4, Lucene.Net 2.9.4g
Reporter: Troy Howard
Assignee: Troy Howard
Priority: Minor
 Fix For: Lucene.Net 2.9.4, Lucene.Net 2.9.4g


 Port Contrib.Shingle from Java

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira