[ https://issues.apache.org/jira/browse/LUCENE-5673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13999807#comment-13999807 ]
Uwe Schindler edited comment on LUCENE-5673 at 5/16/14 1:55 PM: ---------------------------------------------------------------- Should I backport to 4.8.1? This does not brea logic, it just cleans up the exception, so no risk to break something. was (Author: thetaphi): Should I backport to 4.8.1? > MMapDirectory shouldn't pass along OOM wrapped as IOException > ------------------------------------------------------------- > > Key: LUCENE-5673 > URL: https://issues.apache.org/jira/browse/LUCENE-5673 > Project: Lucene - Core > Issue Type: Bug > Components: core/store > Affects Versions: 4.8 > Reporter: Robert Muir > Assignee: Uwe Schindler > Fix For: 4.9, 5.0 > > Attachments: LUCENE-5673.patch, LUCENE-5673.patch, LUCENE-5673.patch, > LUCENE-5673.patch > > > The bug here is in java (not MMapDir), but i think we shoudl do something. > Users get confused when they configure their JVM to trigger something on OOM, > and then see "OutOfMemoryError: Map Failed": but their trigger doesnt fire. > Thats because in the jdk, when it maps files it catches OutOfMemoryError, > asks for a garbage collection, sleeps for 100 milliseconds, then tries to map > again. if it fails a second time it wraps the OOM in a generic IOException. > I think we should add a try/catch to our filechannel.map -- This message was sent by Atlassian JIRA (v6.2#6252) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org