[ 
https://issues.apache.org/jira/browse/LUCENE-6301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14953084#comment-14953084
 ] 

Jack Krupansky edited comment on LUCENE-6301 at 10/12/15 12:58 PM:
-------------------------------------------------------------------

I know this change has been in progress for awhile, but it just kind of sunk 
for me finally and now I'm wondering what the impact on Solr will be. I mean, 
wasn't Filter supposed to be a big performance win over a Query since it 
eliminates the performance impact of scoring? If that was the case, is Lucene 
proving some alternate method of achieving a similar performance improvement? I 
think it is, but... not stated quite so explicitly. An example of the expected 
migration would help a lot. I think the example should be in the Lucene Javadoc 
- "To filter documents without the performance overhead of scoring, use the 
following technique..." If I understand properly, one would simply wrap the 
query in a BooleanQuery with a single clause that uses 
BooleanQuery.Clause.FILTER and that would have exactly the same effect (and 
performance gain) as the old Filter class. Is that statement 100% accurate? If 
so, it would be good to make it explicit here in Jira, in the deprecation 
comment in the the Filter class, and in BooleanQuery as well. Thanks!


was (Author: jkrupan):
I know this change has been in progress for awhile, but it just kind of sunk 
for me finally in and now I'm wondering what the impact on Solr will be. I 
mean, wasn't Filter supposed to be a big performance win over a Query since it 
eliminates the performance impact of scoring? If that was the case, is Lucene 
proving some alternate method of achieving a similar performance improvement? I 
think it is, but... not stated quite so explicitly. An example of the expected 
migration would help a lot. I think the example should be in the Lucene Javadoc 
- "To filter documents without the performance overhead of scoring, use the 
following technique..." If I understand properly, one would simply wrap the 
query in a BooleanQuery with a single clause that uses 
BooleanQuery.Clause.FILTER and that would have exactly the same effect (and 
performance gain) as the old Filter class. Is that statement 100% accurate? If 
so, it would be good to make it explicit here in Jira, in the deprecation 
comment in the the Filter class, and in BooleanQuery as well. Thanks!

> Deprecate Filter
> ----------------
>
>                 Key: LUCENE-6301
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6301
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Adrien Grand
>            Assignee: Adrien Grand
>             Fix For: 5.2, Trunk
>
>         Attachments: LUCENE-6301.patch, LUCENE-6301.patch
>
>
> It will still take time to completely remove Filter, but I think we should 
> start deprecating it now to state our intention and encourage users to move 
> to queries as soon as possible?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to