[ 
https://issues.apache.org/jira/browse/LUCENE-7578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15709795#comment-15709795
 ] 

Timothy M. Rodriguez edited comment on LUCENE-7578 at 11/30/16 9:15 PM:
------------------------------------------------------------------------

Some care would have to be taken with spans, especially with significant slop.  
It's arguably worse to have a single highlight across it.  But otherwise, this 
definitely is a desired improvement.


was (Author: timothy055):
Some care would have to be taken with spans, especially with significant slop.  
It's arguably worse to have a single highlight across it.

> UnifiedHighlighter: Convert PhraseHelper to use SpanCollector API
> -----------------------------------------------------------------
>
>                 Key: LUCENE-7578
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7578
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/highlighter
>            Reporter: David Smiley
>
> The PhraseHelper of the UnifiedHighlighter currently collects position-spans 
> per SpanQuery (and it knows which terms are in which SpanQuery), and then it 
> filters PostingsEnum based on that.  It's similar to how the original 
> Highlighter WSTE works.  The main problem with this approach is that it can 
> be inaccurate for some nested span queries -- LUCENE-2287, LUCENE-5455 (has 
> the clearest example), LUCENE-6796.  Non-nested SpanQueries (e.g. that which 
> is converted from a PhraseQuery or MultiPhraseQuery) are _not_ a problem.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to