[jira] [Comment Edited] (LUCENE-8874) Show SPI names only instead of class names in Luke Analysis tab
[
https://issues.apache.org/jira/browse/LUCENE-8874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16875643#comment-16875643
]
Tomoko Uchida edited comment on LUCENE-8874 at 6/30/19 4:25 AM:
Here is the patch: [^LUCENE-8874.patch]
was (Author: tomoko uchida):
Here is the patch: [^LUCENE-8874]
> Show SPI names only instead of class names in Luke Analysis tab
> ---
>
> Key: LUCENE-8874
> URL: https://issues.apache.org/jira/browse/LUCENE-8874
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/analysis, modules/luke
>Reporter: Tomoko Uchida
>Assignee: Tomoko Uchida
>Priority: Minor
> Attachments: LUCENE-8874.patch, Screenshot from 2019-06-30
> 13-15-40.png, Screenshot from 2019-06-30 13-15-57.png
>
>
> Each analyzer component factory now has an explicitly documented "NAME"
> static field (LUCENE-8778) to promote the proper use of (symbolic) SPI names.
> It would be better to get rid of all concrete factory class names from the
> Analysis tab UI, but instead show SPI names.
> From implementation perspective, reflection tricks are needed to obtain the
> {{NAME}} field value without knowing the concrete classes (frameworks like
> Luke Analysis tab often don't know them). APIs to obtain the SPI name from a
> factory object might be needed for convenience and unified access to the
> names.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Comment Edited] (LUCENE-8874) Show SPI names only instead of class names in Luke Analysis tab
[
https://issues.apache.org/jira/browse/LUCENE-8874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16875643#comment-16875643
]
Tomoko Uchida edited comment on LUCENE-8874 at 6/30/19 4:10 AM:
Here is the patch: [^LUCENE-8874]
was (Author: tomoko uchida):
Here is the patch:
> Show SPI names only instead of class names in Luke Analysis tab
> ---
>
> Key: LUCENE-8874
> URL: https://issues.apache.org/jira/browse/LUCENE-8874
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/analysis, modules/luke
>Reporter: Tomoko Uchida
>Assignee: Tomoko Uchida
>Priority: Minor
> Attachments: LUCENE-8874
>
>
> Each analyzer component factory now has an explicitly documented "NAME"
> static field (LUCENE-8778) to promote the proper use of (symbolic) SPI names.
> It would be better to get rid of all concrete factory class names from the
> Analysis tab UI, but instead show SPI names.
> From implementation perspective, reflection tricks are needed to obtain the
> {{NAME}} field value without knowing the concrete classes (frameworks like
> Luke Analysis tab often don't know them). APIs to obtain the SPI name from a
> factory object might be needed for convenience and unified access to the
> names.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
