[jira] [Comment Edited] (SOLR-12330) JSON Facet syntax errors are responded as runtime exceptions with 500 code

2019-02-07 Thread Mikhail Khludnev (JIRA)


[ 
https://issues.apache.org/jira/browse/SOLR-12330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16763376#comment-16763376
 ] 

Mikhail Khludnev edited comment on SOLR-12330 at 2/8/19 7:39 AM:
-

 I decided to drop unrelated changes regarding preventing ambiguous references 
{{q=\{!v=$pair}=foo=bar}} and spawn a dedicated issue for it 
SOLR-13232. Once this one pass, I commit. 


was (Author: mkhludnev):
 I decided to drop unrelated changes regarding preventing ambiguous references 
{{q=\{!v=$pair}=foo=bar}} and spawn a dedicated issue for it. Once 
this one pass, I commit. 

> JSON Facet syntax errors are responded as runtime exceptions with 500 code
> --
>
> Key: SOLR-12330
> URL: https://issues.apache.org/jira/browse/SOLR-12330
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: Facet Module
>Affects Versions: 7.3
>Reporter: Mikhail Khludnev
>Assignee: Mikhail Khludnev
>Priority: Major
> Attachments: SOLR-12330-combined.patch, SOLR-12330.patch, 
> SOLR-12330.patch, SOLR-12330.patch, SOLR-12330.patch, SOLR-12330.patch, 
> SOLR-12330.patch, SOLR-12330.patch, SOLR-12330.patch, SOLR-12330.patch
>
>
> Just encounter such weird behaviour, will recheck and followup. 
>  \{{"filter":["\{!v=$bogus}"]}} responds back with just NPE which makes 
> impossible to guess the reason.
>  -It might be even worse, since- \{{"filter":[\{"param":"bogus"}]}} seems 
> like just silently ignored. Turns out it's ok see SOLR-9682



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Comment Edited] (SOLR-12330) JSON Facet syntax errors are responded as runtime exceptions with 500 code

2019-02-07 Thread Mikhail Khludnev (JIRA)


[ 
https://issues.apache.org/jira/browse/SOLR-12330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16763376#comment-16763376
 ] 

Mikhail Khludnev edited comment on SOLR-12330 at 2/8/19 7:32 AM:
-

 I decided to drop unrelated changes regarding preventing ambiguous references 
{{q=\{!v=$pair}=foo=bar}} and spawn a dedicated issue for it. Once 
this one pass, I commit. 


was (Author: mkhludnev):
 I decided to drop unrelated changes regarding preventing unambiguous 
references {{q=\{!v=$pair}=foo=bar}} and spawn a dedicated issue for 
it. Once this one pass, I commit. 

> JSON Facet syntax errors are responded as runtime exceptions with 500 code
> --
>
> Key: SOLR-12330
> URL: https://issues.apache.org/jira/browse/SOLR-12330
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: Facet Module
>Affects Versions: 7.3
>Reporter: Mikhail Khludnev
>Assignee: Mikhail Khludnev
>Priority: Major
> Attachments: SOLR-12330-combined.patch, SOLR-12330.patch, 
> SOLR-12330.patch, SOLR-12330.patch, SOLR-12330.patch, SOLR-12330.patch, 
> SOLR-12330.patch, SOLR-12330.patch, SOLR-12330.patch, SOLR-12330.patch
>
>
> Just encounter such weird behaviour, will recheck and followup. 
>  \{{"filter":["\{!v=$bogus}"]}} responds back with just NPE which makes 
> impossible to guess the reason.
>  -It might be even worse, since- \{{"filter":[\{"param":"bogus"}]}} seems 
> like just silently ignored. Turns out it's ok see SOLR-9682



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Comment Edited] (SOLR-12330) JSON Facet syntax errors are responded as runtime exceptions with 500 code

2019-02-06 Thread Jason Gerlowski (JIRA)


[ 
https://issues.apache.org/jira/browse/SOLR-12330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762313#comment-16762313
 ] 

Jason Gerlowski edited comment on SOLR-12330 at 2/7/19 2:37 AM:


LGTM.  I _think_ you should be able to drop the {{json-facet-api.adoc}} changes 
from the patch, as I have that information covered already in some recent 
tweaks I made to the JSON faceting docs over on SOLR-13042.  But worth double 
checking me on that, as there might be a detail I missed.


was (Author: gerlowskija):
LGTM.  I _think_ you should be able to drop the {{json-facet-api.adoc}} changes 
from the patch, as I have that information covered already in some recent 
tweaks I made the the JSON faceting docs over on SOLR-13042.  But worth double 
checking me on that, as there might be a detail I missed.

> JSON Facet syntax errors are responded as runtime exceptions with 500 code
> --
>
> Key: SOLR-12330
> URL: https://issues.apache.org/jira/browse/SOLR-12330
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: Facet Module
>Affects Versions: 7.3
>Reporter: Mikhail Khludnev
>Assignee: Mikhail Khludnev
>Priority: Major
> Attachments: SOLR-12330-combined.patch, SOLR-12330.patch, 
> SOLR-12330.patch, SOLR-12330.patch, SOLR-12330.patch, SOLR-12330.patch, 
> SOLR-12330.patch, SOLR-12330.patch
>
>
> Just encounter such weird behaviour, will recheck and followup. 
>  \{{"filter":["\{!v=$bogus}"]}} responds back with just NPE which makes 
> impossible to guess the reason.
>  -It might be even worse, since- \{{"filter":[\{"param":"bogus"}]}} seems 
> like just silently ignored. Turns out it's ok see SOLR-9682



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org