[jira] [Comment Edited] (SOLR-12361) Change _childDocuments to Map
[
https://issues.apache.org/jira/browse/SOLR-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507255#comment-16507255
]
mosh edited comment on SOLR-12361 at 6/10/18 5:36 AM:
--
{quote}What do you think mosh? How should I refer to you in CHANGES.txt?
{quote}
I like it, this patch looks ready.
You can simply refer to me as Moshe Bla.
was (Author: moshebla):
{quote}What do you think mosh? How should I refer to you in CHANGES.txt?
{quote}
I like it, this patch looks ready.
You can simply refer to me as MosheBla.
> Change _childDocuments to Map
> -
>
> Key: SOLR-12361
> URL: https://issues.apache.org/jira/browse/SOLR-12361
> Project: Solr
> Issue Type: Sub-task
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: mosh
>Priority: Major
> Attachments: SOLR-12361.patch, SOLR-12361.patch, SOLR-12361.patch,
> SOLR-12361.patch
>
> Time Spent: 10h
> Remaining Estimate: 0h
>
> During the discussion on SOLR-12298, there was a proposal to change
> _childDocuments in SolrDocumentBase to a Map, to incorporate the relationship
> between the parent and its child documents.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Comment Edited] (SOLR-12361) Change _childDocuments to Map
[
https://issues.apache.org/jira/browse/SOLR-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488429#comment-16488429
]
mosh edited comment on SOLR-12361 at 5/24/18 5:48 AM:
--
{quote}Lets say that docs can have semantic child relations (named child
relations), *OR* (XOR?) they can have anonymous ones – what we have today.
{quote}
Just to make sure we're on the same page [~dsmiley].
Do you propose we deprecate _childDocuments for the time being, leave it as is,
while implementing child docs as values?
Later on(Solr 8.0) the _childDocuments will be removed?
Plus, would we have to enforce that no childDocument is inserted inside the
_childDocuments_ key annonymous childDocuments were inserted to the current doc?
was (Author: moshebla):
{quote}Lets say that docs can have semantic child relations (named child
relations), *OR* (XOR?) they can have anonymous ones – what we have today.
{quote}
Just to make sure we're on the same page [~dsmiley].
Do you propose we deprecate _childDocuments for the time being, leave it as is,
while implementing child docs as values?
Later on(Solr 8.0) the _childDocuments will be removed?
> Change _childDocuments to Map
> -
>
> Key: SOLR-12361
> URL: https://issues.apache.org/jira/browse/SOLR-12361
> Project: Solr
> Issue Type: Sub-task
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: mosh
>Priority: Major
> Attachments: SOLR-12361.patch, SOLR-12361.patch
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> During the discussion on SOLR-12298, there was a proposal to change
> _childDocuments in SolrDocumentBase to a Map, to incorporate the relationship
> between the parent and its child documents.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Comment Edited] (SOLR-12361) Change _childDocuments to Map
[
https://issues.apache.org/jira/browse/SOLR-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476952#comment-16476952
]
mosh edited comment on SOLR-12361 at 5/16/18 7:15 AM:
--
quoting [~dsmiley]
{quote}One other variation on an approach is to keep the _childDocuments member
of SolrInputDocument but have it be a Map to
capture the relationship name.
{quote}
This would make all children as multiValued fields.
How do you propose we store whether the fields was an array or a single value
document when it was entered?
Perhaps we should have the _childDocuments be a Map, having the
values either be a SolrInputDocument or a Collection.
Perhaps have the values be SolrInputDocument, or some variation of it be a
better fit, since it has the ability to abstract the value as a collection even
if it is originally an object?
was (Author: moshebla):
quoting [~dsmiley]
{quote}One other variation on an approach is to keep the _childDocuments member
of SolrInputDocument but have it be a Map to
capture the relationship name.
{quote}
This would make all children as multiValued fields.
How do you propose we store whether the fields was an array or a single value
document when it was entered?
Perhaps we should have the _childDocuments be a Map, having the
values either be a SolrInputDocument or a Collection.
> Change _childDocuments to Map
> -
>
> Key: SOLR-12361
> URL: https://issues.apache.org/jira/browse/SOLR-12361
> Project: Solr
> Issue Type: Sub-task
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: mosh
>Priority: Major
>
> During the discussion on SOLR-12298, there was a proposal to change
> _childDocuments in SolrDocumentBase to a Map, to incorporate the relationship
> between the parent and its child documents.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
