[jira] [Comment Edited] (SOLR-9083) Remove all and from schemas
[ https://issues.apache.org/jira/browse/SOLR-9083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15275329#comment-15275329 ] Erick Erickson edited comment on SOLR-9083 at 5/7/16 6:21 PM: -- Hmmm, what about and ? They've been deprecated since 3.6 so I'd guess the same argument applies. So I guess I'll remove them from most of the schema files but leave them in a couple. Hmm, not sure about this, let me look a bit more. Unlike removing the and tags, if the code still looks at these it'd change _behavior_ to no good purpose. Nope, not going here. The code still looks at these and uses them, albeit with a warning in managed_schema that it's overridden by 'df' in solrconfig.xml. So taking these out would be A Bad Thing. was (Author: erickerickson): Hmmm, what about and ? They've been deprecated since 3.6 so I'd guess the same argument applies. So I guess I'll remove them from most of the schema files but leave them in a couple. Hmm, not sure about this, let me look a bit more. Unlike removing the and tags, if the code still looks at these it'd change _behavior_ to no good purpose. Nope, not going here. The code still looks at these and uses them, albeit with a warning in managed_schema that it's overridden by 'df' in solrconfig.xml. So taking these out would be A Bad Thing. > Remove all and from schemas > > > Key: SOLR-9083 > URL: https://issues.apache.org/jira/browse/SOLR-9083 > Project: Solr > Issue Type: Improvement >Reporter: Erick Erickson >Assignee: Erick Erickson >Priority: Minor > > We've deprecated these for quite some time, they should be removed from our > files. I noticed that we still have them hanging around. And it's > cloudy/foggy/rainy this morning so... > Getting the proper indentation will mean reformatting these, but there will > be _no_ functional changes. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Comment Edited] (SOLR-9083) Remove all and from schemas
[ https://issues.apache.org/jira/browse/SOLR-9083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15275329#comment-15275329 ] Erick Erickson edited comment on SOLR-9083 at 5/7/16 6:21 PM: -- Hmmm, what about and ? They've been deprecated since 3.6 so I'd guess the same argument applies. So I guess I'll remove them from most of the schema files but leave them in a couple. Hmm, not sure about this, let me look a bit more. Unlike removing the and tags, if the code still looks at these it'd change _behavior_ to no good purpose. Nope, not going here. The code still looks at these and uses them, albeit with a warning in managed_schema that it's overridden by 'df' in solrconfig.xml. So taking these out would be A Bad Thing. was (Author: erickerickson): Hmmm, what about and ? They've been deprecated since 3.6 so I'd guess the same argument applies. So I guess I'll remove them from most of the schema files but leave them in a couple. Hmm, not sure about this, let me look a bit more. Unlike removing the and tags, if the code still looks at these it'd change _behavior_ to no good purpose. > Remove all and from schemas > > > Key: SOLR-9083 > URL: https://issues.apache.org/jira/browse/SOLR-9083 > Project: Solr > Issue Type: Improvement >Reporter: Erick Erickson >Assignee: Erick Erickson >Priority: Minor > > We've deprecated these for quite some time, they should be removed from our > files. I noticed that we still have them hanging around. And it's > cloudy/foggy/rainy this morning so... > Getting the proper indentation will mean reformatting these, but there will > be _no_ functional changes. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Comment Edited] (SOLR-9083) Remove all and from schemas
[ https://issues.apache.org/jira/browse/SOLR-9083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15275329#comment-15275329 ] Erick Erickson edited comment on SOLR-9083 at 5/7/16 6:10 PM: -- Hmmm, what about and ? They've been deprecated since 3.6 so I'd guess the same argument applies. So I guess I'll remove them from most of the schema files but leave them in a couple. Hmm, not sure about this, let me look a bit more. Unlike removing the and tags, if the code still looks at these it'd change _behavior_ to no good purpose. was (Author: erickerickson): Hmmm, what about and ? They've been deprecated since 3.6 so I'd guess the same argument applies. So I guess I'll remove them from most of the schema files but leave them in a couple. > Remove all and from schemas > > > Key: SOLR-9083 > URL: https://issues.apache.org/jira/browse/SOLR-9083 > Project: Solr > Issue Type: Improvement >Reporter: Erick Erickson >Assignee: Erick Erickson >Priority: Minor > > We've deprecated these for quite some time, they should be removed from our > files. I noticed that we still have them hanging around. And it's > cloudy/foggy/rainy this morning so... > Getting the proper indentation will mean reformatting these, but there will > be _no_ functional changes. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
