[jira] [Commented] (LUCENE-3232) Move MutableValues to Queries Module
[
https://issues.apache.org/jira/browse/LUCENE-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13053593#comment-13053593
]
Chris Male commented on LUCENE-3232:
Code to execute before patch:
{code}
svn mkdir --parents modules/queries/src/java/org/apache/lucene/queries/function
svn move solr/src/java/org/apache/solr/search/MutableValue.java
modules/queries/src/java/org/apache/lucene/queries/function/MutableValue.java
svn move solr/src/java/org/apache/solr/search/MutableValueFloat.java
modules/queries/src/java/org/apache/lucene/queries/function/MutableValueFloat.java
svn move solr/src/java/org/apache/solr/search/MutableValueBool.java
modules/queries/src/java/org/apache/lucene/queries/function/MutableValueBool.java
svn move solr/src/java/org/apache/solr/search/MutableValueDate.java
modules/queries/src/java/org/apache/lucene/queries/function/MutableValueDate.java
svn move solr/src/java/org/apache/solr/search/MutableValueDouble.java
modules/queries/src/java/org/apache/lucene/queries/function/MutableValueDouble.java
svn move solr/src/java/org/apache/solr/search/MutableValueInt.java
modules/queries/src/java/org/apache/lucene/queries/function/MutableValueInt.java
svn move solr/src/java/org/apache/solr/search/MutableValueLong.java
modules/queries/src/java/org/apache/lucene/queries/function/MutableValueLong.java
svn move solr/src/java/org/apache/solr/search/MutableValueStr.java
modules/queries/src/java/org/apache/lucene/queries/function/MutableValueStr.java
{code}
Move MutableValues to Queries Module
Key: LUCENE-3232
URL: https://issues.apache.org/jira/browse/LUCENE-3232
Project: Lucene - Java
Issue Type: Sub-task
Components: core/search
Reporter: Chris Male
Fix For: 4.0
Solr makes use of the MutableValue* series of classes to improve performance
of grouping by FunctionQuery (I think). As such they are used in ValueSource
implementations. Consequently we need to move these classes in order to move
the ValueSources.
I'll also use this issue to establish the Queries module where the
FunctionQueries will lie.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-3232) Move MutableValues to Queries Module
[ https://issues.apache.org/jira/browse/LUCENE-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13053599#comment-13053599 ] Yonik Seeley commented on LUCENE-3232: -- These are useful beyond function queries... perhaps they should not be in the function module? Move MutableValues to Queries Module Key: LUCENE-3232 URL: https://issues.apache.org/jira/browse/LUCENE-3232 Project: Lucene - Java Issue Type: Sub-task Components: core/search Reporter: Chris Male Fix For: 4.0 Attachments: LUCENE-3232.patch Solr makes use of the MutableValue* series of classes to improve performance of grouping by FunctionQuery (I think). As such they are used in ValueSource implementations. Consequently we need to move these classes in order to move the ValueSources. I'll also use this issue to establish the Queries module where the FunctionQueries will lie. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-3232) Move MutableValues to Queries Module
[ https://issues.apache.org/jira/browse/LUCENE-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13053600#comment-13053600 ] Chris Male commented on LUCENE-3232: I've debated this backwards and forwards. Do they have a use case out of function queries at the moment? If so then yeah I'll happily put them somewhere else. Otherwise I'll cross that bridge at the time. Move MutableValues to Queries Module Key: LUCENE-3232 URL: https://issues.apache.org/jira/browse/LUCENE-3232 Project: Lucene - Java Issue Type: Sub-task Components: core/search Reporter: Chris Male Fix For: 4.0 Attachments: LUCENE-3232.patch Solr makes use of the MutableValue* series of classes to improve performance of grouping by FunctionQuery (I think). As such they are used in ValueSource implementations. Consequently we need to move these classes in order to move the ValueSources. I'll also use this issue to establish the Queries module where the FunctionQueries will lie. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-3232) Move MutableValues to Queries Module
[ https://issues.apache.org/jira/browse/LUCENE-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13053601#comment-13053601 ] Chris Male commented on LUCENE-3232: Actually scrap that question, I'll put them somewhere else immediately. Move MutableValues to Queries Module Key: LUCENE-3232 URL: https://issues.apache.org/jira/browse/LUCENE-3232 Project: Lucene - Java Issue Type: Sub-task Components: core/search Reporter: Chris Male Fix For: 4.0 Attachments: LUCENE-3232.patch Solr makes use of the MutableValue* series of classes to improve performance of grouping by FunctionQuery (I think). As such they are used in ValueSource implementations. Consequently we need to move these classes in order to move the ValueSources. I'll also use this issue to establish the Queries module where the FunctionQueries will lie. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
