[jira] [Commented] (LUCENE-4077) ToParentBlockJoinCollector provides no way to access computed scores and the maxScore
[ https://issues.apache.org/jira/browse/LUCENE-4077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13286389#comment-13286389 ] Christoph Kaser commented on LUCENE-4077: - Thank you, now it works perfectly! ToParentBlockJoinCollector provides no way to access computed scores and the maxScore - Key: LUCENE-4077 URL: https://issues.apache.org/jira/browse/LUCENE-4077 Project: Lucene - Java Issue Type: Bug Components: modules/join Affects Versions: 3.4, 3.5, 3.6 Reporter: Christoph Kaser Assignee: Michael McCandless Attachments: LUCENE-4077.patch, LUCENE-4077.patch, LUCENE-4077.patch, LUCENE-4077.patch The constructor of ToParentBlockJoinCollector allows to turn on the tracking of parent scores and the maximum parent score, however there is no way to access those scores because: * maxScore is a private field, and there is no getter * TopGroups / GroupDocs does not provide access to the scores for the parent documents, only the children -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4077) ToParentBlockJoinCollector provides no way to access computed scores and the maxScore
[ https://issues.apache.org/jira/browse/LUCENE-4077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13286770#comment-13286770 ] Michael McCandless commented on LUCENE-4077: Super, thanks Christoph, I'll commit shortly... ToParentBlockJoinCollector provides no way to access computed scores and the maxScore - Key: LUCENE-4077 URL: https://issues.apache.org/jira/browse/LUCENE-4077 Project: Lucene - Java Issue Type: Bug Components: modules/join Affects Versions: 3.4, 3.5, 3.6 Reporter: Christoph Kaser Assignee: Michael McCandless Attachments: LUCENE-4077.patch, LUCENE-4077.patch, LUCENE-4077.patch, LUCENE-4077.patch The constructor of ToParentBlockJoinCollector allows to turn on the tracking of parent scores and the maximum parent score, however there is no way to access those scores because: * maxScore is a private field, and there is no getter * TopGroups / GroupDocs does not provide access to the scores for the parent documents, only the children -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4077) ToParentBlockJoinCollector provides no way to access computed scores and the maxScore
[
https://issues.apache.org/jira/browse/LUCENE-4077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13285702#comment-13285702
]
Christoph Kaser commented on LUCENE-4077:
-
Hi Mike,
shouldn't TopGroups.maxScore contain the maximum parent score? If I am not
mistaken, the way it is built now, it contains the maximum child score over all
children.
This is due to this line in ToParentBlockJoinCollector.getTopGroups():
{code}
maxScore = Math.max(maxScore, topDocs.getMaxScore());
{code}
I think it should read:
{code}
totalMaxScore = Math.max(totalMaxScore, og.score);
{code}
Otherwise, topGroups.maxScore is different to
ToParentBlockJoinCollector.getMaxScore()
ToParentBlockJoinCollector provides no way to access computed scores and the
maxScore
-
Key: LUCENE-4077
URL: https://issues.apache.org/jira/browse/LUCENE-4077
Project: Lucene - Java
Issue Type: Bug
Components: modules/join
Affects Versions: 3.4, 3.5, 3.6
Reporter: Christoph Kaser
Assignee: Michael McCandless
Attachments: LUCENE-4077.patch, LUCENE-4077.patch, LUCENE-4077.patch
The constructor of ToParentBlockJoinCollector allows to turn on the tracking
of parent scores and the maximum parent score, however there is no way to
access those scores because:
* maxScore is a private field, and there is no getter
* TopGroups / GroupDocs does not provide access to the scores for the parent
documents, only the children
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4077) ToParentBlockJoinCollector provides no way to access computed scores and the maxScore
[ https://issues.apache.org/jira/browse/LUCENE-4077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13285797#comment-13285797 ] Michael McCandless commented on LUCENE-4077: bq. Otherwise, topGroups.maxScore is different to ToParentBlockJoinCollector.getMaxScore() Woops, you're right, thanks. In fact I should be passing the maxScore that the collector already computed, not recomputing it in ToParentBJC.getTopGroups... ToParentBlockJoinCollector provides no way to access computed scores and the maxScore - Key: LUCENE-4077 URL: https://issues.apache.org/jira/browse/LUCENE-4077 Project: Lucene - Java Issue Type: Bug Components: modules/join Affects Versions: 3.4, 3.5, 3.6 Reporter: Christoph Kaser Assignee: Michael McCandless Attachments: LUCENE-4077.patch, LUCENE-4077.patch, LUCENE-4077.patch The constructor of ToParentBlockJoinCollector allows to turn on the tracking of parent scores and the maximum parent score, however there is no way to access those scores because: * maxScore is a private field, and there is no getter * TopGroups / GroupDocs does not provide access to the scores for the parent documents, only the children -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4077) ToParentBlockJoinCollector provides no way to access computed scores and the maxScore
[
https://issues.apache.org/jira/browse/LUCENE-4077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13284660#comment-13284660
]
Christoph Kaser commented on LUCENE-4077:
-
Hello Mike,
thank you for the patch. There is one small problem:
ToParentBlockJoinCollector.getMaxScore() always returns _NaN_. This happens
because maxScore is initialized as
{code}
private float maxScore = Float.NaN;
{code}
and then updated as
{code}
maxScore = Math.max(score, maxScore);
{code}
which is always _NaN_.
I hope I applied the patch to the correct revision and this is not caused by a
version conflict.
ToParentBlockJoinCollector provides no way to access computed scores and the
maxScore
-
Key: LUCENE-4077
URL: https://issues.apache.org/jira/browse/LUCENE-4077
Project: Lucene - Java
Issue Type: Bug
Components: modules/join
Affects Versions: 3.4, 3.5, 3.6
Reporter: Christoph Kaser
Assignee: Michael McCandless
Attachments: LUCENE-4077.patch
The constructor of ToParentBlockJoinCollector allows to turn on the tracking
of parent scores and the maximum parent score, however there is no way to
access those scores because:
* maxScore is a private field, and there is no getter
* TopGroups / GroupDocs does not provide access to the scores for the parent
documents, only the children
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4077) ToParentBlockJoinCollector provides no way to access computed scores and the maxScore
[ https://issues.apache.org/jira/browse/LUCENE-4077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13284780#comment-13284780 ] Christoph Kaser commented on LUCENE-4077: - This patch works perfectly for my application. Thank you! ToParentBlockJoinCollector provides no way to access computed scores and the maxScore - Key: LUCENE-4077 URL: https://issues.apache.org/jira/browse/LUCENE-4077 Project: Lucene - Java Issue Type: Bug Components: modules/join Affects Versions: 3.4, 3.5, 3.6 Reporter: Christoph Kaser Assignee: Michael McCandless Attachments: LUCENE-4077.patch, LUCENE-4077.patch The constructor of ToParentBlockJoinCollector allows to turn on the tracking of parent scores and the maximum parent score, however there is no way to access those scores because: * maxScore is a private field, and there is no getter * TopGroups / GroupDocs does not provide access to the scores for the parent documents, only the children -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4077) ToParentBlockJoinCollector provides no way to access computed scores and the maxScore
[ https://issues.apache.org/jira/browse/LUCENE-4077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13284917#comment-13284917 ] Michael McCandless commented on LUCENE-4077: Super, thanks for testing Christoph. I'll commit shortly... ToParentBlockJoinCollector provides no way to access computed scores and the maxScore - Key: LUCENE-4077 URL: https://issues.apache.org/jira/browse/LUCENE-4077 Project: Lucene - Java Issue Type: Bug Components: modules/join Affects Versions: 3.4, 3.5, 3.6 Reporter: Christoph Kaser Assignee: Michael McCandless Attachments: LUCENE-4077.patch, LUCENE-4077.patch The constructor of ToParentBlockJoinCollector allows to turn on the tracking of parent scores and the maximum parent score, however there is no way to access those scores because: * maxScore is a private field, and there is no getter * TopGroups / GroupDocs does not provide access to the scores for the parent documents, only the children -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
