[jira] [Commented] (LUCENE-4090) PerFieldPostingsFormat cannot use name as suffix

2012-05-31 Thread Mark Harwood (JIRA)

[ 
https://issues.apache.org/jira/browse/LUCENE-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13286411#comment-13286411
 ] 

Mark Harwood commented on LUCENE-4090:
--

Thanks for the quick fix, Rob :)
Working fine for me here now.

 PerFieldPostingsFormat cannot use name as suffix
 

 Key: LUCENE-4090
 URL: https://issues.apache.org/jira/browse/LUCENE-4090
 Project: Lucene - Java
  Issue Type: Bug
  Components: core/index
Affects Versions: 4.0
Reporter: Robert Muir
Assignee: Robert Muir
 Fix For: 4.0, 5.0

 Attachments: LUCENE-4090.patch, LUCENE-4090.patch


 Currently PFPF just records the name in the metadata, which matches up to the 
 segment suffix. But this isnt enough, e.g. someone can use Pulsing(1) on one 
 field and Pulsing(2) on another field.
 See Mark Harwood's examples struggling with this on LUCENE-4069.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (LUCENE-4090) PerFieldPostingsFormat cannot use name as suffix

2012-05-30 Thread Michael McCandless (JIRA)

[ 
https://issues.apache.org/jira/browse/LUCENE-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13285832#comment-13285832
 ] 

Michael McCandless commented on LUCENE-4090:


Patch looks good!  Nice having the per-field metadata...

I think it's fine to impl .equals() separately ... really 
getPostingsFormatPerField could work around that by holding a single instance 
of a given format and sharing that instance across fields.

 PerFieldPostingsFormat cannot use name as suffix
 

 Key: LUCENE-4090
 URL: https://issues.apache.org/jira/browse/LUCENE-4090
 Project: Lucene - Java
  Issue Type: Bug
  Components: core/index
Affects Versions: 4.0
Reporter: Robert Muir
Assignee: Robert Muir
 Attachments: LUCENE-4090.patch


 Currently PFPF just records the name in the metadata, which matches up to the 
 segment suffix. But this isnt enough, e.g. someone can use Pulsing(1) on one 
 field and Pulsing(2) on another field.
 See Mark Harwood's examples struggling with this on LUCENE-4069.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (LUCENE-4090) PerFieldPostingsFormat cannot use name as suffix

2012-05-30 Thread Robert Muir (JIRA)

[ 
https://issues.apache.org/jira/browse/LUCENE-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13285913#comment-13285913
 ] 

Robert Muir commented on LUCENE-4090:
-

Patch is still buggy, new one coming. My test was garbage basically and didnt 
detect the bug (since it inlines all terms).
At read time we have to key off the combined suffix too...

 PerFieldPostingsFormat cannot use name as suffix
 

 Key: LUCENE-4090
 URL: https://issues.apache.org/jira/browse/LUCENE-4090
 Project: Lucene - Java
  Issue Type: Bug
  Components: core/index
Affects Versions: 4.0
Reporter: Robert Muir
Assignee: Robert Muir
 Attachments: LUCENE-4090.patch


 Currently PFPF just records the name in the metadata, which matches up to the 
 segment suffix. But this isnt enough, e.g. someone can use Pulsing(1) on one 
 field and Pulsing(2) on another field.
 See Mark Harwood's examples struggling with this on LUCENE-4069.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org