[jira] [Commented] (LUCENE-4852) BaseStoredFieldsFormatTestCase
[ https://issues.apache.org/jira/browse/LUCENE-4852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13605466#comment-13605466 ] Adrien Grand commented on LUCENE-4852: -- Patch looks good! BaseStoredFieldsFormatTestCase -- Key: LUCENE-4852 URL: https://issues.apache.org/jira/browse/LUCENE-4852 Project: Lucene - Core Issue Type: Task Components: general/test Reporter: Robert Muir Attachments: LUCENE-4852.patch, LUCENE-4852_prototype.patch The idea is similar to Base[Postings/DocValues/TermVectors]TestCase. We ensure each codec has certain checks and its easier to maintain and also easier to ensure new impls are correct. For example hunting around today, a lot of the best tests are actually tucked away in TestCompressingStoredFieldsFormat. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4852) BaseStoredFieldsFormatTestCase
[ https://issues.apache.org/jira/browse/LUCENE-4852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13605482#comment-13605482 ] Michael McCandless commented on LUCENE-4852: +1 BaseStoredFieldsFormatTestCase -- Key: LUCENE-4852 URL: https://issues.apache.org/jira/browse/LUCENE-4852 Project: Lucene - Core Issue Type: Task Components: general/test Reporter: Robert Muir Attachments: LUCENE-4852.patch, LUCENE-4852_prototype.patch The idea is similar to Base[Postings/DocValues/TermVectors]TestCase. We ensure each codec has certain checks and its easier to maintain and also easier to ensure new impls are correct. For example hunting around today, a lot of the best tests are actually tucked away in TestCompressingStoredFieldsFormat. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4852) BaseStoredFieldsFormatTestCase
[ https://issues.apache.org/jira/browse/LUCENE-4852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13605501#comment-13605501 ] Commit Tag Bot commented on LUCENE-4852: [trunk commit] Robert Muir http://svn.apache.org/viewvc?view=revisionrevision=1457926 LUCENE-4852: BaseStoredFieldsFormatTestCase BaseStoredFieldsFormatTestCase -- Key: LUCENE-4852 URL: https://issues.apache.org/jira/browse/LUCENE-4852 Project: Lucene - Core Issue Type: Task Components: general/test Reporter: Robert Muir Attachments: LUCENE-4852.patch, LUCENE-4852_prototype.patch The idea is similar to Base[Postings/DocValues/TermVectors]TestCase. We ensure each codec has certain checks and its easier to maintain and also easier to ensure new impls are correct. For example hunting around today, a lot of the best tests are actually tucked away in TestCompressingStoredFieldsFormat. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4852) BaseStoredFieldsFormatTestCase
[ https://issues.apache.org/jira/browse/LUCENE-4852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13605539#comment-13605539 ] Commit Tag Bot commented on LUCENE-4852: [branch_4x commit] Robert Muir http://svn.apache.org/viewvc?view=revisionrevision=1457931 LUCENE-4852: BaseStoredFieldsFormatTestCase BaseStoredFieldsFormatTestCase -- Key: LUCENE-4852 URL: https://issues.apache.org/jira/browse/LUCENE-4852 Project: Lucene - Core Issue Type: Task Components: general/test Reporter: Robert Muir Fix For: 5.0, 4.3 Attachments: LUCENE-4852.patch, LUCENE-4852_prototype.patch The idea is similar to Base[Postings/DocValues/TermVectors]TestCase. We ensure each codec has certain checks and its easier to maintain and also easier to ensure new impls are correct. For example hunting around today, a lot of the best tests are actually tucked away in TestCompressingStoredFieldsFormat. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
