[jira] [Commented] (LUCENE-4894) Facet User Guide for lucene 4.2 has deleted classes/methods and needs more explanations.
[ https://issues.apache.org/jira/browse/LUCENE-4894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13714004#comment-13714004 ] Michael McCandless commented on LUCENE-4894: +1 Facet User Guide for lucene 4.2 has deleted classes/methods and needs more explanations. Key: LUCENE-4894 URL: https://issues.apache.org/jira/browse/LUCENE-4894 Project: Lucene - Core Issue Type: Bug Components: general/website, modules/facet Affects Versions: 4.2 Reporter: crocket Priority: Minor Attachments: LUCENE-4894.patch * Concurrent Indexing and Search There is no clear explanation regarding those points below. 1. TaxonomyReader should be reopened after IndexReader. 2. TaxonomyWriter should be committed before IndexWriter. TaxonomyWriter should be closed before IndexWriter. The rationale is that it's ok to see categories to which no document belongs but not ok the other way around. Beginners may not be able to see this until after they think through it for a long time, which most of them including me wouldn't do. However, facet user guide doesn't explain the rationale clearly. * DocumentBuilder FacetSearchParams.addFacetRequest They no longer exist in lucene 4.2, but they are used in code examples. * FacetResultNode.getLabel(TaxonomyReader) It doesn't eixst in 4.2, but it is mentioned in Multiple Facet Requests * ETC I don't know if there are other points to be made. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4894) Facet User Guide for lucene 4.2 has deleted classes/methods and needs more explanations.
[ https://issues.apache.org/jira/browse/LUCENE-4894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13714129#comment-13714129 ] ASF subversion and git services commented on LUCENE-4894: - Commit 1505041 from [~shaie] in branch 'dev/trunk' [ https://svn.apache.org/r1505041 ] LUCENE-4894: remove facet userguide Facet User Guide for lucene 4.2 has deleted classes/methods and needs more explanations. Key: LUCENE-4894 URL: https://issues.apache.org/jira/browse/LUCENE-4894 Project: Lucene - Core Issue Type: Bug Components: general/website, modules/facet Affects Versions: 4.2 Reporter: crocket Priority: Minor Attachments: LUCENE-4894.patch * Concurrent Indexing and Search There is no clear explanation regarding those points below. 1. TaxonomyReader should be reopened after IndexReader. 2. TaxonomyWriter should be committed before IndexWriter. TaxonomyWriter should be closed before IndexWriter. The rationale is that it's ok to see categories to which no document belongs but not ok the other way around. Beginners may not be able to see this until after they think through it for a long time, which most of them including me wouldn't do. However, facet user guide doesn't explain the rationale clearly. * DocumentBuilder FacetSearchParams.addFacetRequest They no longer exist in lucene 4.2, but they are used in code examples. * FacetResultNode.getLabel(TaxonomyReader) It doesn't eixst in 4.2, but it is mentioned in Multiple Facet Requests * ETC I don't know if there are other points to be made. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4894) Facet User Guide for lucene 4.2 has deleted classes/methods and needs more explanations.
[ https://issues.apache.org/jira/browse/LUCENE-4894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13714133#comment-13714133 ] ASF subversion and git services commented on LUCENE-4894: - Commit 1505047 from [~shaie] in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1505047 ] LUCENE-4894: remove facet userguide Facet User Guide for lucene 4.2 has deleted classes/methods and needs more explanations. Key: LUCENE-4894 URL: https://issues.apache.org/jira/browse/LUCENE-4894 Project: Lucene - Core Issue Type: Bug Components: general/website, modules/facet Affects Versions: 4.2 Reporter: crocket Priority: Minor Attachments: LUCENE-4894.patch * Concurrent Indexing and Search There is no clear explanation regarding those points below. 1. TaxonomyReader should be reopened after IndexReader. 2. TaxonomyWriter should be committed before IndexWriter. TaxonomyWriter should be closed before IndexWriter. The rationale is that it's ok to see categories to which no document belongs but not ok the other way around. Beginners may not be able to see this until after they think through it for a long time, which most of them including me wouldn't do. However, facet user guide doesn't explain the rationale clearly. * DocumentBuilder FacetSearchParams.addFacetRequest They no longer exist in lucene 4.2, but they are used in code examples. * FacetResultNode.getLabel(TaxonomyReader) It doesn't eixst in 4.2, but it is mentioned in Multiple Facet Requests * ETC I don't know if there are other points to be made. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4894) Facet User Guide for lucene 4.2 has deleted classes/methods and needs more explanations.
[ https://issues.apache.org/jira/browse/LUCENE-4894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13714287#comment-13714287 ] ASF subversion and git services commented on LUCENE-4894: - Commit 1505076 from [~rcmuir] in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1505076 ] LUCENE-4894: remove dead link to user guide Facet User Guide for lucene 4.2 has deleted classes/methods and needs more explanations. Key: LUCENE-4894 URL: https://issues.apache.org/jira/browse/LUCENE-4894 Project: Lucene - Core Issue Type: Bug Components: general/website, modules/facet Affects Versions: 4.2 Reporter: crocket Assignee: Shai Erera Priority: Minor Fix For: 5.0, 4.5 Attachments: LUCENE-4894.patch * Concurrent Indexing and Search There is no clear explanation regarding those points below. 1. TaxonomyReader should be reopened after IndexReader. 2. TaxonomyWriter should be committed before IndexWriter. TaxonomyWriter should be closed before IndexWriter. The rationale is that it's ok to see categories to which no document belongs but not ok the other way around. Beginners may not be able to see this until after they think through it for a long time, which most of them including me wouldn't do. However, facet user guide doesn't explain the rationale clearly. * DocumentBuilder FacetSearchParams.addFacetRequest They no longer exist in lucene 4.2, but they are used in code examples. * FacetResultNode.getLabel(TaxonomyReader) It doesn't eixst in 4.2, but it is mentioned in Multiple Facet Requests * ETC I don't know if there are other points to be made. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4894) Facet User Guide for lucene 4.2 has deleted classes/methods and needs more explanations.
[ https://issues.apache.org/jira/browse/LUCENE-4894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13714286#comment-13714286 ] ASF subversion and git services commented on LUCENE-4894: - Commit 1505075 from [~rcmuir] in branch 'dev/trunk' [ https://svn.apache.org/r1505075 ] LUCENE-4894: remove dead link to user guide Facet User Guide for lucene 4.2 has deleted classes/methods and needs more explanations. Key: LUCENE-4894 URL: https://issues.apache.org/jira/browse/LUCENE-4894 Project: Lucene - Core Issue Type: Bug Components: general/website, modules/facet Affects Versions: 4.2 Reporter: crocket Assignee: Shai Erera Priority: Minor Fix For: 5.0, 4.5 Attachments: LUCENE-4894.patch * Concurrent Indexing and Search There is no clear explanation regarding those points below. 1. TaxonomyReader should be reopened after IndexReader. 2. TaxonomyWriter should be committed before IndexWriter. TaxonomyWriter should be closed before IndexWriter. The rationale is that it's ok to see categories to which no document belongs but not ok the other way around. Beginners may not be able to see this until after they think through it for a long time, which most of them including me wouldn't do. However, facet user guide doesn't explain the rationale clearly. * DocumentBuilder FacetSearchParams.addFacetRequest They no longer exist in lucene 4.2, but they are used in code examples. * FacetResultNode.getLabel(TaxonomyReader) It doesn't eixst in 4.2, but it is mentioned in Multiple Facet Requests * ETC I don't know if there are other points to be made. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4894) Facet User Guide for lucene 4.2 has deleted classes/methods and needs more explanations.
[ https://issues.apache.org/jira/browse/LUCENE-4894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13620245#comment-13620245 ] crocket commented on LUCENE-4894: - However, without facet user guide, I wouldn't have known that it ever existed. You may still need to advertise the facet module in http://lucene.apache.org/core/4_x_x/index.html Facet User Guide for lucene 4.2 has deleted classes/methods and needs more explanations. Key: LUCENE-4894 URL: https://issues.apache.org/jira/browse/LUCENE-4894 Project: Lucene - Core Issue Type: Bug Components: general/website, modules/facet Affects Versions: 4.2 Reporter: crocket Priority: Minor * Concurrent Indexing and Search There is no clear explanation regarding those points below. 1. TaxonomyReader should be reopened after IndexReader. 2. TaxonomyWriter should be committed before IndexWriter. TaxonomyWriter should be closed before IndexWriter. The rationale is that it's ok to see categories to which no document belongs but not ok the other way around. Beginners may not be able to see this until after they think through it for a long time, which most of them including me wouldn't do. However, facet user guide doesn't explain the rationale clearly. * DocumentBuilder FacetSearchParams.addFacetRequest They no longer exist in lucene 4.2, but they are used in code examples. * FacetResultNode.getLabel(TaxonomyReader) It doesn't eixst in 4.2, but it is mentioned in Multiple Facet Requests * ETC I don't know if there are other points to be made. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4894) Facet User Guide for lucene 4.2 has deleted classes/methods and needs more explanations.
[ https://issues.apache.org/jira/browse/LUCENE-4894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13619583#comment-13619583 ] Shai Erera commented on LUCENE-4894: The userguide is seriously outdated after all the recent refactoring. I was wondering if we should keep it at all, or rather include a high-level documentation under o.a.l.facet.package.html which covers the basic points, and then focus on maintaining good javadocs at the classes / packages level. It gets harder to maintain these documents ... Nevertheless, if you want to take a crack at improving / fixing it, I will help you get it in. Facet User Guide for lucene 4.2 has deleted classes/methods and needs more explanations. Key: LUCENE-4894 URL: https://issues.apache.org/jira/browse/LUCENE-4894 Project: Lucene - Core Issue Type: Bug Components: general/website, modules/facet Affects Versions: 4.2 Reporter: crocket Priority: Minor * Concurrent Indexing and Search There is no clear explanation regarding those points below. 1. TaxonomyReader should be reopened after IndexReader. 2. TaxonomyWriter should be committed before IndexWriter. TaxonomyWriter should be closed before IndexWriter. The rationale is that it's ok to see categories to which no document belongs but not ok the other way around. Beginners may not be able to see this until after they think through it for a long time, which most of them including me wouldn't do. However, facet user guide doesn't explain the rationale clearly. * DocumentBuilder FacetSearchParams.addFacetRequest They no longer exist in lucene 4.2, but they are used in code examples. * FacetResultNode.getLabel(TaxonomyReader) It doesn't eixst in 4.2, but it is mentioned in Multiple Facet Requests * ETC I don't know if there are other points to be made. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4894) Facet User Guide for lucene 4.2 has deleted classes/methods and needs more explanations.
[ https://issues.apache.org/jira/browse/LUCENE-4894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13619601#comment-13619601 ] crocket commented on LUCENE-4894: - Including documentations in javadocs might do the job. Facet User Guide for lucene 4.2 has deleted classes/methods and needs more explanations. Key: LUCENE-4894 URL: https://issues.apache.org/jira/browse/LUCENE-4894 Project: Lucene - Core Issue Type: Bug Components: general/website, modules/facet Affects Versions: 4.2 Reporter: crocket Priority: Minor * Concurrent Indexing and Search There is no clear explanation regarding those points below. 1. TaxonomyReader should be reopened after IndexReader. 2. TaxonomyWriter should be committed before IndexWriter. TaxonomyWriter should be closed before IndexWriter. The rationale is that it's ok to see categories to which no document belongs but not ok the other way around. Beginners may not be able to see this until after they think through it for a long time, which most of them including me wouldn't do. However, facet user guide doesn't explain the rationale clearly. * DocumentBuilder FacetSearchParams.addFacetRequest They no longer exist in lucene 4.2, but they are used in code examples. * FacetResultNode.getLabel(TaxonomyReader) It doesn't eixst in 4.2, but it is mentioned in Multiple Facet Requests * ETC I don't know if there are other points to be made. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-4894) Facet User Guide for lucene 4.2 has deleted classes/methods and needs more explanations.
[ https://issues.apache.org/jira/browse/LUCENE-4894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13619729#comment-13619729 ] Michael McCandless commented on LUCENE-4894: +1 to remove the userGuide and absorb it into javadocs. Facet User Guide for lucene 4.2 has deleted classes/methods and needs more explanations. Key: LUCENE-4894 URL: https://issues.apache.org/jira/browse/LUCENE-4894 Project: Lucene - Core Issue Type: Bug Components: general/website, modules/facet Affects Versions: 4.2 Reporter: crocket Priority: Minor * Concurrent Indexing and Search There is no clear explanation regarding those points below. 1. TaxonomyReader should be reopened after IndexReader. 2. TaxonomyWriter should be committed before IndexWriter. TaxonomyWriter should be closed before IndexWriter. The rationale is that it's ok to see categories to which no document belongs but not ok the other way around. Beginners may not be able to see this until after they think through it for a long time, which most of them including me wouldn't do. However, facet user guide doesn't explain the rationale clearly. * DocumentBuilder FacetSearchParams.addFacetRequest They no longer exist in lucene 4.2, but they are used in code examples. * FacetResultNode.getLabel(TaxonomyReader) It doesn't eixst in 4.2, but it is mentioned in Multiple Facet Requests * ETC I don't know if there are other points to be made. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
